11979 2006-12-26 07:48:16 -0800 SVG text does not respect font-size scaling in bbox calculation 2007-01-08 16:41:10 -0800 1 1 1 Unclassified WebKit SVG 420+ Mac OS X 10.4 RESOLVED DUPLICATE 11984 SVGHitList P2 Normal --- 1 eric webkit-unassigned zimmermann oldest_to_newest 39674 0 eric 2006-12-26 07:48:16 -0800 SVG text does not respect font-size scaling in bbox calculation See attached testcase. After fixing bug 11973 our behavior is slightly better than before, but GREEN is still not entirely green. 39675 1 12028 eric 2006-12-26 07:48:51 -0800 Created attachment 12028 test demonstrating the incorrect behavior 39681 2 12032 eric 2006-12-26 08:40:03 -0800 Created attachment 12032 Another test showing how bad our current behavior is 39693 3 eric 2006-12-26 11:17:04 -0800 Ok, so this is going to be harder to fix than I originally thought. This should be split into two bugs. One to cover the text gradient painting issue, and another to cover text having broken bounding box code. The problem with gradients is not related to how text calculates bounding boxes, but rather due to the SVG text painting system. SVG Text makes manual calls into SVGPaintServer::setup() and SVGPaintServer::teardown() instead of calling paint(). SVGPaintServerGradientCG isn't exactly designed for this code path. The whole SVG text/paintserver interaction looks to be kinda a hack (certainly I am not w/o blame here :), and likely needs to be redesigned. One example would be passing some sort of "painting text" bool to setup/teardown instead of setting a bool on the paintserver. Another would be fixing the whole fill/stroke at once problem which we've talked about for so long. 39696 4 12032 eric 2006-12-26 11:23:54 -0800 Comment on attachment 12032 Another test showing how bad our current behavior is obsoleting this test as it does not apply to this bug. I've filed http://bugs.webkit.org/show_bug.cgi?id=11984 to track fixing this test case. 36595 5 eric 2007-01-07 01:54:51 -0800 Wildfox has done some investigation here. 36184 6 eric 2007-01-08 16:41:10 -0800 Fixed by bug 11984. *** This bug has been marked as a duplicate of 11984 *** 12028 2006-12-26 07:48:51 -0800 2006-12-26 07:48:51 -0800 test demonstrating the incorrect behavior font-size-text-bbox.svg image/svg+xml 372 eric PHN2ZyB4bWxucz0iaHR0cDovL3d3dy53My5vcmcvMjAwMC9zdmciIHhtbG5zOnhsaW5rPSJodHRw Oi8vd3d3LnczLm9yZy8xOTk5L3hsaW5rIj4KICAgIDxkZWZzPgogICAgICAgIDxsaW5lYXJHcmFk aWVudCBpZD0nbXlncmFkaWVudCcgeDE9JzAnIHgyPSc0Jz4KICAgICAgICAgICAgPHN0b3Agc3Rv cC1jb2xvcj0nZ3JlZW4nIG9mZnNldD0nMCcgLz4KICAgICAgICAgICAgPHN0b3Agc3RvcC1jb2xv cj0ncmVkJyBvZmZzZXQ9JzEnIC8+CiAgICAgICAgPC9saW5lYXJHcmFkaWVudD4KICAgIDwvZGVm cz4KICAgIDx0ZXh0IGZvbnQtc2l6ZT0nNjgnIGZpbGw9InVybCgjbXlncmFkaWVudCkiICB4PSIy MCIgeT0iNzAiPkdSRUVOPC90ZXh0Pgo8L3N2Zz4K 12032 2006-12-26 08:40:03 -0800 2006-12-26 11:23:54 -0800 Another test showing how bad our current behavior is textbounce.svg image/svg+xml 1434 eric PD94bWwgdmVyc2lvbj0iMS4wIiBzdGFuZGFsb25lPSJubyI/Pgo8IURPQ1RZUEUgc3ZnIFBVQkxJ QyAiLS8vVzNDLy9EVEQgU1ZHIDIwMDEwOTA0Ly9FTiIgImh0dHA6Ly93d3cudzMub3JnL1RSLzIw MDEvUkVDLVNWRy0yMDAxMDkwNC9EVEQvc3ZnMTAuZHRkIj4KPHN2ZyB3aWR0aD0iODAwIiBoZWln aHQ9IjYwMCIgb25sb2FkPSJzdGFydEFuaW1hdGlvbihldnQpIiB4bWxucz0iaHR0cDovL3d3dy53 My5vcmcvMjAwMC9zdmciPgoJPHNjcmlwdCB0eXBlPSJ0ZXh0L2VjbWFzY3JpcHQiPjwhW0NEQVRB WwoJdmFyIHN0ZXAgPSAxLCBvcGFjaXR5U3RlcCA9ICgxLzUwKTsKCXZhciB4ID0gMzAsIHkgPSAz MCwgb3BhY2l0eSA9IDA7Cgl2YXIgZGFuY2VUaW1lID0gMTsJCgkKCXZhciB4ZGlyID0gMDsgLy8g MCA9IEFkZCwgMSA9IFN1YgoJdmFyIHlkaXIgPSAwOyAvLyAwID0gQWRkLCAxID0gU3ViCgl2YXIg b2RpciA9IDA7IC8vIDAgPSBBZGQsIDEgPSBTdWIKCiAgICB2YXIgYm91bmNlOwoJZnVuY3Rpb24g c3RhcnRBbmltYXRpb24oZXZ0KSB7CgkJYm91bmNlID0gZXZ0LnRhcmdldC5vd25lckRvY3VtZW50 LmdldEVsZW1lbnRCeUlkKCJib3VuY2UiKTsKCQlkYW5jZUFyb3VuZCgpOwogICAgfQoJCglmdW5j dGlvbiBkYW5jZUFyb3VuZCgpIHsKCQlpZih4ZGlyID09IDApIHsKCQkJeCA9IHggKyBzdGVwOwoJ CX0gZWxzZSB7CgkJCXggPSB4IC0gc3RlcDsKCQl9CgoJCWlmKHlkaXIgPT0gMCkgewkKCQkJeSA9 IHkgKyBzdGVwOwoJCX0gZWxzZSB7CgkJCXkgPSB5IC0gc3RlcDsKCQl9CgoJCWlmKHggPiAoODAw IC0gNjUpKSB7CgkJCXhkaXIgPSAxOwoJCX0gZWxzZSBpZih4IDwgMTApIHsKCQkJeGRpciA9IDA7 CgkJfQoKCQlpZih5ID4gKDYwMCAtIDY1KSkgewoJCQl5ZGlyID0gMTsKCQl9IGVsc2UgaWYoeSA8 IDEwKSB7CgkJCXlkaXIgPSAwOwoJCX0KCQkKCQlpZihvZGlyID09IDApIHsKCQkJb3BhY2l0eSA9 IG9wYWNpdHkgKyBvcGFjaXR5U3RlcDsKCQl9IGVsc2UgewoJCQlvcGFjaXR5ID0gb3BhY2l0eSAt IG9wYWNpdHlTdGVwOwoJCX0KCQkKCQlpZihvcGFjaXR5ID4gMSkgewoJCQlvZGlyID0gMTsKCQl9 IGVsc2UgaWYob3BhY2l0eSA8IDApIHsKCQkJb2RpciA9IDA7CgkJfQoJCgkJYm91bmNlLnNldEF0 dHJpYnV0ZSgidHJhbnNmb3JtIiwgInRyYW5zbGF0ZSgiICsgeCArICIsIiArIHkgKyAiKSIpOwkK CQlib3VuY2Uuc2V0QXR0cmlidXRlKCJmb250LXNpemUiLCBvcGFjaXR5ICogNjggKyAzMCk7CgoJ CXNldFRpbWVvdXQoImRhbmNlQXJvdW5kKCkiLCBkYW5jZVRpbWUpOwogICAgfQoJXV0+PC9zY3Jp cHQ+CgkKCTx0ZXh0IGlkPSJib3VuY2UiIHg9IjM1IiB5PSIzNSIgZm9udC1zaXplPSc2OCcgc3R5 bGU9ImZpbGw6Z3JlZW47c3Ryb2tlOmJsYWNrO3N0cm9rZS13aWR0aDo1cHg7Ij5URVNUPC90ZXh0 Pgo8L3N2Zz4K