119778 2013-08-13 17:16:58 -0700 Add Canvas protocol observer 2019-12-17 09:27:39 -0800 1 1 1 Unclassified WebKit Web Inspector 528+ (Nightly build) Unspecified Unspecified RESOLVED FIXED InRadar P2 Normal --- 1 dino dino anonymous graouts joepeck timothy webkit-bug-importer oldest_to_newest 916957 0 dino 2013-08-13 17:16:58 -0700 Now that we're enabling Canvas profiling, we need a canvas observer to receive the events sent from the backend. 916958 1 webkit-bug-importer 2013-08-13 17:17:13 -0700 <rdar://problem/14730691> 916959 2 208693 dino 2013-08-13 17:25:21 -0700 Created attachment 208693 Patch 916964 3 208693 joepeck 2013-08-13 17:36:02 -0700 Comment on attachment 208693 Patch View in context: https://bugs.webkit.org/attachment.cgi?id=208693&action=review r=me, with 1 comment > Source/WebInspectorUI/UserInterface/Main.js:41 > + InspectorBackend.registerCanvasDispatcher(new WebInspector.CanvasObserver); InspectorBackend.registerCanvasDispatcher did not exist in iOS 6. iOS 6 devices load the UserInterface/Legacy/6.0/InspectorBackendCommands.js file instead of the UserInterface/InspectorBackendCommands.js in LoadInspectorBackendCommands.js. So the lack of that function existing will mean that this would be an uncaught exception. You should do this at the bottom like the LayerTreeDispatcher. if (InspectorBackend.registerCanvasDispatcher) InspectorBackend.registerCanvasDispatcher(new WebInspector.CanvasObserver); 916970 4 dino 2013-08-13 18:03:34 -0700 Committed r154034: <http://trac.webkit.org/changeset/154034> 208693 2013-08-13 17:25:21 -0700 2013-08-13 17:36:02 -0700 Patch bug-119778-20130814102520.patch text/plain 4849 dino U3VidmVyc2lvbiBSZXZpc2lvbjogMTU0MDI0CmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViSW5zcGVj dG9yVUkvQ2hhbmdlTG9nIGIvU291cmNlL1dlYkluc3BlY3RvclVJL0NoYW5nZUxvZwppbmRleCBh YWE0MTJkYTJiZjgyZjRiNjAyYmQwYmVkMTQ4M2NkZTkxYTg4YjVmLi41ZmM4ZjcyODQ5YzIwODc4 ZDk3OTFhM2M2YWM4MTIxYTYzOTdiMWU1IDEwMDY0NAotLS0gYS9Tb3VyY2UvV2ViSW5zcGVjdG9y VUkvQ2hhbmdlTG9nCisrKyBiL1NvdXJjZS9XZWJJbnNwZWN0b3JVSS9DaGFuZ2VMb2cKQEAgLTEs MyArMSwyMCBAQAorMjAxMy0wOC0xMyAgRGVhbiBKYWNrc29uICA8ZGlub0BhcHBsZS5jb20+CisK KyAgICAgICAgPGh0dHBzOi8vd2Via2l0Lm9yZy9iLzExOTc3OD4gQWRkIENhbnZhcyBwcm90b2Nv bCBvYnNlcnZlcgorCisgICAgICAgIFJldmlld2VkIGJ5IE5PQk9EWSAoT09QUyEpLgorCisgICAg ICAgIEluIHByZXBhcmF0aW9uIGZvciBsaXN0ZW5pbmcgdG8gYmFja2VuZCBldmVudHMgYWJvdXQg Y2FudmFzIHByb2ZpbGluZywKKyAgICAgICAgYWRkIGEgY2FudmFzIG9ic2VydmVyLgorCisgICAg ICAgICogVXNlckludGVyZmFjZS9DYW52YXNPYnNlcnZlci5qczogTmV3IGVtcHR5IENhbnZhc09i c2VydmVyIG9iamVjdC4KKyAgICAgICAgKFdlYkluc3BlY3Rvci5DYW52YXNPYnNlcnZlcik6Cisg ICAgICAgIChXZWJJbnNwZWN0b3IuQ2FudmFzT2JzZXJ2ZXIucHJvdG90eXBlLmNvbnRleHRDcmVh dGVkKToKKyAgICAgICAgKFdlYkluc3BlY3Rvci5DYW52YXNPYnNlcnZlci5wcm90b3R5cGUudHJh Y2VMb2dzUmVtb3ZlZCk6CisgICAgICAgICogVXNlckludGVyZmFjZS9NYWluLmh0bWw6CisgICAg ICAgICogVXNlckludGVyZmFjZS9NYWluLmpzOgorICAgICAgICAoV2ViSW5zcGVjdG9yLmxvYWRl ZCk6CisKIDIwMTMtMDgtMTEgIERlYW4gSmFja3NvbiAgPGRpbm9AYXBwbGUuY29tPgogCiAgICAg ICAgIFVwZGF0ZSBsb2NhbGl6ZWRTdHJpbmdzIC0gSSB0aGluayBJIGNoZWNrZWQgaW4gYW4gdW5t ZXJnZWQgdmVyc2lvbgpkaWZmIC0tZ2l0IGEvU291cmNlL1dlYkluc3BlY3RvclVJL1VzZXJJbnRl cmZhY2UvQ2FudmFzT2JzZXJ2ZXIuanMgYi9Tb3VyY2UvV2ViSW5zcGVjdG9yVUkvVXNlckludGVy ZmFjZS9DYW52YXNPYnNlcnZlci5qcwpuZXcgZmlsZSBtb2RlIDEwMDY0NAppbmRleCAwMDAwMDAw MDAwMDAwMDAwMDAwMDAwMDAwMDAwMDAwMDAwMDAwMDAwLi5iMzlkNDg3MWU2MjVjNjk0YWEwYTZk ZmRiZTlkYmNmNWFkZmVjZjE5Ci0tLSAvZGV2L251bGwKKysrIGIvU291cmNlL1dlYkluc3BlY3Rv clVJL1VzZXJJbnRlcmZhY2UvQ2FudmFzT2JzZXJ2ZXIuanMKQEAgLTAsMCArMSw0NyBAQAorLyoK KyAqIENvcHlyaWdodCAoQykgMjAxMyBBcHBsZSBJbmMuIEFsbCByaWdodHMgcmVzZXJ2ZWQuCisg KgorICogUmVkaXN0cmlidXRpb24gYW5kIHVzZSBpbiBzb3VyY2UgYW5kIGJpbmFyeSBmb3Jtcywg d2l0aCBvciB3aXRob3V0CisgKiBtb2RpZmljYXRpb24sIGFyZSBwZXJtaXR0ZWQgcHJvdmlkZWQg dGhhdCB0aGUgZm9sbG93aW5nIGNvbmRpdGlvbnMKKyAqIGFyZSBtZXQ6CisgKiAxLiBSZWRpc3Ry aWJ1dGlvbnMgb2Ygc291cmNlIGNvZGUgbXVzdCByZXRhaW4gdGhlIGFib3ZlIGNvcHlyaWdodAor ICogICAgbm90aWNlLCB0aGlzIGxpc3Qgb2YgY29uZGl0aW9ucyBhbmQgdGhlIGZvbGxvd2luZyBk aXNjbGFpbWVyLgorICogMi4gUmVkaXN0cmlidXRpb25zIGluIGJpbmFyeSBmb3JtIG11c3QgcmVw cm9kdWNlIHRoZSBhYm92ZSBjb3B5cmlnaHQKKyAqICAgIG5vdGljZSwgdGhpcyBsaXN0IG9mIGNv bmRpdGlvbnMgYW5kIHRoZSBmb2xsb3dpbmcgZGlzY2xhaW1lciBpbiB0aGUKKyAqICAgIGRvY3Vt ZW50YXRpb24gYW5kL29yIG90aGVyIG1hdGVyaWFscyBwcm92aWRlZCB3aXRoIHRoZSBkaXN0cmli dXRpb24uCisgKgorICogVEhJUyBTT0ZUV0FSRSBJUyBQUk9WSURFRCBCWSBBUFBMRSBJTkMuIEFO RCBJVFMgQ09OVFJJQlVUT1JTIGBgQVMgSVMnJworICogQU5EIEFOWSBFWFBSRVNTIE9SIElNUExJ RUQgV0FSUkFOVElFUywgSU5DTFVESU5HLCBCVVQgTk9UIExJTUlURUQgVE8sCisgKiBUSEUgSU1Q TElFRCBXQVJSQU5USUVTIE9GIE1FUkNIQU5UQUJJTElUWSBBTkQgRklUTkVTUyBGT1IgQSBQQVJU SUNVTEFSCisgKiBQVVJQT1NFIEFSRSBESVNDTEFJTUVELiBJTiBOTyBFVkVOVCBTSEFMTCBBUFBM RSBJTkMuIE9SIElUUyBDT05UUklCVVRPUlMKKyAqIEJFIExJQUJMRSBGT1IgQU5ZIERJUkVDVCwg SU5ESVJFQ1QsIElOQ0lERU5UQUwsIFNQRUNJQUwsIEVYRU1QTEFSWSwgT1IKKyAqIENPTlNFUVVF TlRJQUwgREFNQUdFUyAoSU5DTFVESU5HLCBCVVQgTk9UIExJTUlURUQgVE8sIFBST0NVUkVNRU5U IE9GCisgKiBTVUJTVElUVVRFIEdPT0RTIE9SIFNFUlZJQ0VTOyBMT1NTIE9GIFVTRSwgREFUQSwg T1IgUFJPRklUUzsgT1IgQlVTSU5FU1MKKyAqIElOVEVSUlVQVElPTikgSE9XRVZFUiBDQVVTRUQg QU5EIE9OIEFOWSBUSEVPUlkgT0YgTElBQklMSVRZLCBXSEVUSEVSIElOCisgKiBDT05UUkFDVCwg U1RSSUNUIExJQUJJTElUWSwgT1IgVE9SVCAoSU5DTFVESU5HIE5FR0xJR0VOQ0UgT1IgT1RIRVJX SVNFKQorICogQVJJU0lORyBJTiBBTlkgV0FZIE9VVCBPRiBUSEUgVVNFIE9GIFRISVMgU09GVFdB UkUsIEVWRU4gSUYgQURWSVNFRCBPRgorICogVEhFIFBPU1NJQklMSVRZIE9GIFNVQ0ggREFNQUdF LgorICovCisKK1dlYkluc3BlY3Rvci5DYW52YXNPYnNlcnZlciA9IGZ1bmN0aW9uKCkKK3sKKyAg ICBXZWJJbnNwZWN0b3IuT2JqZWN0LmNhbGwodGhpcyk7Cit9OworCitXZWJJbnNwZWN0b3IuQ2Fu dmFzT2JzZXJ2ZXIucHJvdG90eXBlID0geworICAgIGNvbnN0cnVjdG9yOiBXZWJJbnNwZWN0b3Iu Q2FudmFzT2JzZXJ2ZXIsCisKKyAgICAvLyBFdmVudHMgZGVmaW5lZCBieSB0aGUgIkNhbnZhcyIg ZG9tYWluIChzZWUgV2ViQ29yZS9pbnNwZWN0b3IvSW5zcGVjdG9yLmpzb24pLgorCisgICAgY29u dGV4dENyZWF0ZWQ6IGZ1bmN0aW9uKGZyYW1lSWQpCisgICAgeworICAgICAgICAvLyBGSVhNRTog SW1wbGVtZW50IHRoaXMuCisgICAgfSwKKworICAgIHRyYWNlTG9nc1JlbW92ZWQ6IGZ1bmN0aW9u KGZyYW1lSWQsIHRyYWNlTG9nSWQpCisgICAgeworICAgICAgICAvLyBGSVhNRTogSW1wbGVtZW50 IHRoaXMuCisgICAgfQorfTsKKworV2ViSW5zcGVjdG9yLkNhbnZhc09ic2VydmVyLnByb3RvdHlw ZS5fX3Byb3RvX18gPSBXZWJJbnNwZWN0b3IuT2JqZWN0LnByb3RvdHlwZTsKZGlmZiAtLWdpdCBh L1NvdXJjZS9XZWJJbnNwZWN0b3JVSS9Vc2VySW50ZXJmYWNlL01haW4uaHRtbCBiL1NvdXJjZS9X ZWJJbnNwZWN0b3JVSS9Vc2VySW50ZXJmYWNlL01haW4uaHRtbAppbmRleCBiMDg1NGRlMzY3NjZj YmUyZTI5MGE2MDllZTBiNDQ5MTFiZTY5ZTI3Li5hYTZlYWUzZWYxNjBmNGI3OTQ4NTFkMTNmZjVl ZTg2NmM5ZmQ0ODA4IDEwMDY0NAotLS0gYS9Tb3VyY2UvV2ViSW5zcGVjdG9yVUkvVXNlckludGVy ZmFjZS9NYWluLmh0bWwKKysrIGIvU291cmNlL1dlYkluc3BlY3RvclVJL1VzZXJJbnRlcmZhY2Uv TWFpbi5odG1sCkBAIC0xNTEsNiArMTUxLDcgQEAKICAgICA8c2NyaXB0IHNyYz0iUmVtb3RlT2Jq ZWN0LmpzIj48L3NjcmlwdD4KICAgICA8c2NyaXB0IHNyYz0iSW5zcGVjdG9yT2JzZXJ2ZXIuanMi Pjwvc2NyaXB0PgogICAgIDxzY3JpcHQgc3JjPSJQYWdlT2JzZXJ2ZXIuanMiPjwvc2NyaXB0Pgor ICAgIDxzY3JpcHQgc3JjPSJDYW52YXNPYnNlcnZlci5qcyI+PC9zY3JpcHQ+CiAgICAgPHNjcmlw dCBzcmM9IkNvbnNvbGVPYnNlcnZlci5qcyI+PC9zY3JpcHQ+CiAgICAgPHNjcmlwdCBzcmM9Ik5l dHdvcmtPYnNlcnZlci5qcyI+PC9zY3JpcHQ+CiAgICAgPHNjcmlwdCBzcmM9IkNTU09ic2VydmVy LmpzIj48L3NjcmlwdD4KZGlmZiAtLWdpdCBhL1NvdXJjZS9XZWJJbnNwZWN0b3JVSS9Vc2VySW50 ZXJmYWNlL01haW4uanMgYi9Tb3VyY2UvV2ViSW5zcGVjdG9yVUkvVXNlckludGVyZmFjZS9NYWlu LmpzCmluZGV4IGYzODRkZDMwNTE0Y2RmMjFlODY2YzhiZDMxM2UwMTBiMTdhYTViYmIuLjg5ZThi OWM2ZjQwZDM2YzJiZmU0NzM0YTFkYzg1M2UwM2I0NjgwNTcgMTAwNjQ0Ci0tLSBhL1NvdXJjZS9X ZWJJbnNwZWN0b3JVSS9Vc2VySW50ZXJmYWNlL01haW4uanMKKysrIGIvU291cmNlL1dlYkluc3Bl Y3RvclVJL1VzZXJJbnRlcmZhY2UvTWFpbi5qcwpAQCAtMzgsNiArMzgsNyBAQCBXZWJJbnNwZWN0 b3IubG9hZGVkID0gZnVuY3Rpb24oKQogICAgIC8vIFJlZ2lzdGVyIG9ic2VydmVycyBmb3IgZXZl bnRzIGZyb20gdGhlIEluc3BlY3RvckJhY2tlbmQuCiAgICAgSW5zcGVjdG9yQmFja2VuZC5yZWdp c3Rlckluc3BlY3RvckRpc3BhdGNoZXIobmV3IFdlYkluc3BlY3Rvci5JbnNwZWN0b3JPYnNlcnZl cik7CiAgICAgSW5zcGVjdG9yQmFja2VuZC5yZWdpc3RlclBhZ2VEaXNwYXRjaGVyKG5ldyBXZWJJ bnNwZWN0b3IuUGFnZU9ic2VydmVyKTsKKyAgICBJbnNwZWN0b3JCYWNrZW5kLnJlZ2lzdGVyQ2Fu dmFzRGlzcGF0Y2hlcihuZXcgV2ViSW5zcGVjdG9yLkNhbnZhc09ic2VydmVyKTsKICAgICBJbnNw ZWN0b3JCYWNrZW5kLnJlZ2lzdGVyQ29uc29sZURpc3BhdGNoZXIobmV3IFdlYkluc3BlY3Rvci5D b25zb2xlT2JzZXJ2ZXIpOwogICAgIEluc3BlY3RvckJhY2tlbmQucmVnaXN0ZXJOZXR3b3JrRGlz cGF0Y2hlcihuZXcgV2ViSW5zcGVjdG9yLk5ldHdvcmtPYnNlcnZlcik7CiAgICAgSW5zcGVjdG9y QmFja2VuZC5yZWdpc3RlckRPTURpc3BhdGNoZXIobmV3IFdlYkluc3BlY3Rvci5ET01PYnNlcnZl cik7Cg==