119763 2013-08-13 11:19:20 -0700 [Mac] fast/dom/attr-style-too-lazy.html is flaky 2013-08-13 15:47:37 -0700 1 1 1 Unclassified WebKit Tools / Tests 528+ (Nightly build) Unspecified Unspecified RESOLVED FIXED P2 Normal --- 1 ap ap commit-queue oldest_to_newest 916817 0 ap 2013-08-13 11:19:20 -0700 I'm sometimes seeing a failure. Looks like status change leaks from a previous test. @@ -1,3 +1,5 @@ +UI DELEGATE STATUS CALLBACK: setStatusText: +UI DELEGATE STATUS CALLBACK: setStatusText: This test verifies that acquiring the 'style' attribute via a DOM Attr node still works correctly after the inline style has been modified through the CSSOM API. On success, you will see a series of "PASS" messages, followed by "TEST COMPLETE". 916821 1 208660 ap 2013-08-13 11:24:48 -0700 Created attachment 208660 proposed fix 916824 2 commit-queue 2013-08-13 11:27:38 -0700 Attachment 208660 did not pass style-queue: Failed to run "['Tools/Scripts/check-webkit-style', '--diff-files', u'Tools/ChangeLog', u'Tools/DumpRenderTree/mac/UIDelegate.mm']" exit_code: 1 Tools/ChangeLog:1: ChangeLog entry has no bug number [changelog/bugnumber] [5] Total errors found: 1 in 2 files If any of these errors are false positives, please file a bug against check-webkit-style. 916825 3 208661 ap 2013-08-13 11:35:02 -0700 Created attachment 208661 With a better ChangeLog 916920 4 208661 commit-queue 2013-08-13 15:47:35 -0700 Comment on attachment 208661 With a better ChangeLog Clearing flags on attachment: 208661 Committed r154027: <http://trac.webkit.org/changeset/154027> 916921 5 commit-queue 2013-08-13 15:47:37 -0700 All reviewed patches have been landed. Closing bug. 208660 2013-08-13 11:24:48 -0700 2013-08-13 11:35:02 -0700 proposed fix StatusText.txt text/plain 1639 ap SW5kZXg6IFRvb2xzL0NoYW5nZUxvZwo9PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09Ci0tLSBUb29scy9DaGFuZ2VMb2cJKHJl dmlzaW9uIDE1NDAxMykKKysrIFRvb2xzL0NoYW5nZUxvZwkod29ya2luZyBjb3B5KQpAQCAtMSwz ICsxLDE2IEBACisyMDEzLTA4LTEzICBBbGV4ZXkgUHJvc2t1cnlha292ICA8YXBAYXBwbGUuY29t PgorCisgICAgICAgIE5lZWQgYSBzaG9ydCBkZXNjcmlwdGlvbiAoT09QUyEpLgorICAgICAgICBO ZWVkIHRoZSBidWcgVVJMIChPT1BTISkuCisKKyAgICAgICAgUmV2aWV3ZWQgYnkgTk9CT0RZIChP T1BTISkuCisKKyAgICAgICAgKiBEdW1wUmVuZGVyVHJlZS9tYWMvVUlEZWxlZ2F0ZS5tbToKKyAg ICAgICAgKC1bVUlEZWxlZ2F0ZSB3ZWJWaWV3OnNldFN0YXR1c1RleHQ6XSk6IERvbid0IGR1bXAg YW55dGhpbmcgd2hlbiBub3QgcnVubmluZworICAgICAgICBhIHRlc3QsIGl0IHdvdWxkIGp1c3Qg c2VtaS1yYW5kb21seSBsZWFrIHRvIHRoZSBuZXh0IG9uZS4KKyAgICAgICAgKC1bVUlEZWxlZ2F0 ZSB3ZWJWaWV3OmRpZFByZXNzTWlzc2luZ1BsdWdpbkJ1dHRvbjpdKTogQWRkZWQgc2FtZSBjaGVj ayBoZXJlLCBqdXN0CisgICAgICAgIGZvciBnb29kIG1lYXN1cmUuCisKIDIwMTMtMDgtMTMgIFJh cGhhZWwgS3VibyBkYSBDb3N0YSAgPHJhcGhhZWwua3Viby5kYS5jb3N0YUBpbnRlbC5jb20+CiAK ICAgICAgICAgW0VGTF1bRFJUXSBTaW1wbGlmeSBjYWxsIHRvIHJldmVyc2VGaW5kKCkKSW5kZXg6 IFRvb2xzL0R1bXBSZW5kZXJUcmVlL21hYy9VSURlbGVnYXRlLm1tCj09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT0KLS0tIFRv b2xzL0R1bXBSZW5kZXJUcmVlL21hYy9VSURlbGVnYXRlLm1tCShyZXZpc2lvbiAxNTQwMDYpCisr KyBUb29scy9EdW1wUmVuZGVyVHJlZS9tYWMvVUlEZWxlZ2F0ZS5tbQkod29ya2luZyBjb3B5KQpA QCAtMTk3LDcgKzE5Nyw3IEBAIC0gKHZvaWQpd2ViVmlldzooV2ViVmlldyAqKXNlbmRlciBleGNl ZWQKIAogLSAodm9pZCl3ZWJWaWV3OihXZWJWaWV3ICopc2VuZGVyIHNldFN0YXR1c1RleHQ6KE5T U3RyaW5nICopdGV4dAogewotICAgIGlmIChnVGVzdFJ1bm5lci0+ZHVtcFN0YXR1c0NhbGxiYWNr cygpKQorICAgIGlmICghZG9uZSAmJiBnVGVzdFJ1bm5lci0+ZHVtcFN0YXR1c0NhbGxiYWNrcygp KQogICAgICAgICBwcmludGYoIlVJIERFTEVHQVRFIFNUQVRVUyBDQUxMQkFDSzogc2V0U3RhdHVz VGV4dDolc1xuIiwgW3RleHQgVVRGOFN0cmluZ10pOwogfQogCkBAIC0yOTAsNyArMjkwLDggQEAg LSAodm9pZCl3ZWJWaWV3OihXZWJWaWV3ICopc2VuZGVyIGNsb3NlRgogCiAtIChCT09MKXdlYlZp ZXc6KFdlYlZpZXcgKil3ZWJWaWV3IGRpZFByZXNzTWlzc2luZ1BsdWdpbkJ1dHRvbjooRE9NRWxl bWVudCAqKWVsZW1lbnQKIHsKLSAgICBwcmludGYoIk1JU1NJTkcgUExVR0lOIEJVVFRPTiBQUkVT U0VEXG4iKTsKKyAgICBpZiAoIWRvbmUpCisgICAgICAgIHByaW50ZigiTUlTU0lORyBQTFVHSU4g QlVUVE9OIFBSRVNTRURcbiIpOwogICAgIHJldHVybiBUUlVFOwogfQogCg== 208661 2013-08-13 11:35:02 -0700 2013-08-13 15:47:35 -0700 With a better ChangeLog StatusText.txt text/plain 1675 ap SW5kZXg6IFRvb2xzL0NoYW5nZUxvZwo9PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09Ci0tLSBUb29scy9DaGFuZ2VMb2cJKHJl dmlzaW9uIDE1NDAxMykKKysrIFRvb2xzL0NoYW5nZUxvZwkod29ya2luZyBjb3B5KQpAQCAtMSwz ICsxLDE2IEBACisyMDEzLTA4LTEzICBBbGV4ZXkgUHJvc2t1cnlha292ICA8YXBAYXBwbGUuY29t PgorCisgICAgICAgIFtNYWNdIGZhc3QvZG9tL2F0dHItc3R5bGUtdG9vLWxhenkuaHRtbCBpcyBm bGFreQorICAgICAgICBodHRwczovL2J1Z3Mud2Via2l0Lm9yZy9zaG93X2J1Zy5jZ2k/aWQ9MTE5 NzYzCisKKyAgICAgICAgUmV2aWV3ZWQgYnkgTk9CT0RZIChPT1BTISkuCisKKyAgICAgICAgKiBE dW1wUmVuZGVyVHJlZS9tYWMvVUlEZWxlZ2F0ZS5tbToKKyAgICAgICAgKC1bVUlEZWxlZ2F0ZSB3 ZWJWaWV3OnNldFN0YXR1c1RleHQ6XSk6IERvbid0IGR1bXAgYW55dGhpbmcgd2hlbiBub3QgcnVu bmluZworICAgICAgICBhIHRlc3QsIGl0IHdvdWxkIGp1c3Qgc2VtaS1yYW5kb21seSBsZWFrIHRv IHRoZSBuZXh0IG9uZS4KKyAgICAgICAgKC1bVUlEZWxlZ2F0ZSB3ZWJWaWV3OmRpZFByZXNzTWlz c2luZ1BsdWdpbkJ1dHRvbjpdKTogQWRkZWQgc2FtZSBjaGVjayBoZXJlLCBqdXN0CisgICAgICAg IGZvciBnb29kIG1lYXN1cmUuCisKIDIwMTMtMDgtMTMgIFJhcGhhZWwgS3VibyBkYSBDb3N0YSAg PHJhcGhhZWwua3Viby5kYS5jb3N0YUBpbnRlbC5jb20+CiAKICAgICAgICAgW0VGTF1bRFJUXSBT aW1wbGlmeSBjYWxsIHRvIHJldmVyc2VGaW5kKCkKSW5kZXg6IFRvb2xzL0R1bXBSZW5kZXJUcmVl L21hYy9VSURlbGVnYXRlLm1tCj09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT0KLS0tIFRvb2xzL0R1bXBSZW5kZXJUcmVlL21h Yy9VSURlbGVnYXRlLm1tCShyZXZpc2lvbiAxNTQwMDYpCisrKyBUb29scy9EdW1wUmVuZGVyVHJl ZS9tYWMvVUlEZWxlZ2F0ZS5tbQkod29ya2luZyBjb3B5KQpAQCAtMTk3LDcgKzE5Nyw3IEBAIC0g KHZvaWQpd2ViVmlldzooV2ViVmlldyAqKXNlbmRlciBleGNlZWQKIAogLSAodm9pZCl3ZWJWaWV3 OihXZWJWaWV3ICopc2VuZGVyIHNldFN0YXR1c1RleHQ6KE5TU3RyaW5nICopdGV4dAogewotICAg IGlmIChnVGVzdFJ1bm5lci0+ZHVtcFN0YXR1c0NhbGxiYWNrcygpKQorICAgIGlmICghZG9uZSAm JiBnVGVzdFJ1bm5lci0+ZHVtcFN0YXR1c0NhbGxiYWNrcygpKQogICAgICAgICBwcmludGYoIlVJ IERFTEVHQVRFIFNUQVRVUyBDQUxMQkFDSzogc2V0U3RhdHVzVGV4dDolc1xuIiwgW3RleHQgVVRG OFN0cmluZ10pOwogfQogCkBAIC0yOTAsNyArMjkwLDggQEAgLSAodm9pZCl3ZWJWaWV3OihXZWJW aWV3ICopc2VuZGVyIGNsb3NlRgogCiAtIChCT09MKXdlYlZpZXc6KFdlYlZpZXcgKil3ZWJWaWV3 IGRpZFByZXNzTWlzc2luZ1BsdWdpbkJ1dHRvbjooRE9NRWxlbWVudCAqKWVsZW1lbnQKIHsKLSAg ICBwcmludGYoIk1JU1NJTkcgUExVR0lOIEJVVFRPTiBQUkVTU0VEXG4iKTsKKyAgICBpZiAoIWRv bmUpCisgICAgICAgIHByaW50ZigiTUlTU0lORyBQTFVHSU4gQlVUVE9OIFBSRVNTRURcbiIpOwog ICAgIHJldHVybiBUUlVFOwogfQogCg==