119762 2013-08-13 11:16:14 -0700 Replace currentTime() with monotonicallyIncreasingTime() in WTF and JavaScriptCore 2013-08-15 10:06:20 -0700 1 1 1 Unclassified WebKit Web Template Framework 528+ (Nightly build) Unspecified Unspecified RESOLVED FIXED P2 Normal --- 119761 0 arurajku webkit-unassigned ararunprasad benjamin cmarcelo commit-queue darin ggaren kling rniwa simon.fraser oldest_to_newest 916815 0 arurajku 2013-08-13 11:16:14 -0700 Replace currentTime() with monotonicallyIncreasingTime() in WTF and JavaScriptCore [at appropriate places] 916818 1 208657 arurajku 2013-08-13 11:19:38 -0700 Created attachment 208657 Patch 916822 2 ggaren 2013-08-13 11:26:33 -0700 Why? 916837 3 arurajku 2013-08-13 12:12:16 -0700 (In reply to comment #2) > Why? Actually some platforms(mostly embedded systems like TV/STB) doesn't have battery powered reliable clock source. Wall Clock time is obtained via time sources like NTP(it may have some latency). So I feel use currentTime() only on the places which really needs wall clock time(like jsDateTime()), remaining places monotonicallyIncreasingTime() is good. 916918 4 ggaren 2013-08-13 15:44:56 -0700 Are you saying that monotonicallyIncreasingTime() is faster than currentTime()? If so, how did you measure that? 916940 5 darin 2013-08-13 16:40:44 -0700 (In reply to comment #4) > Are you saying that monotonicallyIncreasingTime() is faster than currentTime()? If so, how did you measure that? No he’s not saying that. He’s saying that on his platform, monotonicallyIncreasingTime has higher resolution than currentTime. 916961 6 208657 ggaren 2013-08-13 17:27:03 -0700 Comment on attachment 208657 Patch r=me 916963 7 ggaren 2013-08-13 17:27:18 -0700 Thanks. 916967 8 208657 commit-queue 2013-08-13 17:50:19 -0700 Comment on attachment 208657 Patch Clearing flags on attachment: 208657 Committed r154032: <http://trac.webkit.org/changeset/154032> 916968 9 commit-queue 2013-08-13 17:50:21 -0700 All reviewed patches have been landed. Closing bug. 916971 10 simon.fraser 2013-08-13 18:19:03 -0700 The changelog and commit message should have explained the "why". 917001 11 arurajku 2013-08-13 22:59:25 -0700 (In reply to comment #10) > The changelog and commit message should have explained the "why". Simon, sorry for not including details. I will add more details while doing the change for WebCore.(Or is it possible to change the commit message?) 917167 12 darin 2013-08-14 10:20:11 -0700 I think comments in the header with monotonicallyIncreasingTime and currentTime should explain the guidelines for when to use each. That’s where the “why” would go. 208657 2013-08-13 11:19:38 -0700 2013-08-13 17:50:19 -0700 Patch bug-119762-20130813234915.patch text/plain 6520 arurajku U3VidmVyc2lvbiBSZXZpc2lvbjogMTUzODg0CmRpZmYgLS1naXQgYS9Tb3VyY2UvSmF2YVNjcmlw dENvcmUvQ2hhbmdlTG9nIGIvU291cmNlL0phdmFTY3JpcHRDb3JlL0NoYW5nZUxvZwppbmRleCAw MTc2NmYzMmVhODQ0ZjlhZDcyMWJiZTQ4M2VjYjA0YTJlYjYzNTUyLi45ZWY5ZDE4MWUzMTBjZGEz NmUzZjRkM2EyNzZmMjQ4ZTVhNTEyYjQxIDEwMDY0NAotLS0gYS9Tb3VyY2UvSmF2YVNjcmlwdENv cmUvQ2hhbmdlTG9nCisrKyBiL1NvdXJjZS9KYXZhU2NyaXB0Q29yZS9DaGFuZ2VMb2cKQEAgLTEs MyArMSwyMSBAQAorMjAxMy0wOC0xMyAgQXJ1bnByYXNhZCBSYWprdW1hciAgPGFydXJhamt1QGNp c2NvLmNvbT4KKworICAgICAgICBbV1RGXSBbSlNDXSBSZXBsYWNlIGN1cnJlbnRUaW1lKCkgd2l0 aCBtb25vdG9uaWNhbGx5SW5jcmVhc2luZ1RpbWUoKSBpbiBhbGwgcG9zc2libGUgcGxhY2VzCisg ICAgICAgIGh0dHBzOi8vYnVncy53ZWJraXQub3JnL3Nob3dfYnVnLmNnaT9pZD0xMTk3NjIKKwor ICAgICAgICBSZXZpZXdlZCBieSBOT0JPRFkgKE9PUFMhKS4KKworICAgICAgICAqIGhlYXAvSGVh cC5jcHA6CisgICAgICAgIChKU0M6OkhlYXA6OkhlYXApOgorICAgICAgICAoSlNDOjpIZWFwOjpt YXJrUm9vdHMpOgorICAgICAgICAoSlNDOjpIZWFwOjpjb2xsZWN0KToKKyAgICAgICAgKiBqc2Mu Y3BwOgorICAgICAgICAoU3RvcFdhdGNoOjpzdGFydCk6CisgICAgICAgIChTdG9wV2F0Y2g6OnN0 b3ApOgorICAgICAgICAqIHRlc3RSZWdFeHAuY3BwOgorICAgICAgICAoU3RvcFdhdGNoOjpzdGFy dCk6CisgICAgICAgIChTdG9wV2F0Y2g6OnN0b3ApOgorCiAyMDEzLTA4LTA4ICBNYXJrIExhbSAg PG1hcmsubGFtQGFwcGxlLmNvbT4KIAogICAgICAgICBSZXN0b3JpbmcgdXNlIG9mIFN0YWNrSXRl cmF0b3IgaW5zdGVhZCBvZiBJbnRlcnByZXRlcjo6Z2V0U3RhY2t0cmFjZSgpLgpkaWZmIC0tZ2l0 IGEvU291cmNlL1dURi9DaGFuZ2VMb2cgYi9Tb3VyY2UvV1RGL0NoYW5nZUxvZwppbmRleCAxNjg4 NDYxYzM0MGJiNDVkNjVjNTcwNDdkZDRkMWFmYTZjYmU0OWYzLi41NmIwOWY1Y2RlMGRlNTdkNDY4 M2UxNTRhYWI4MmI4NzhlZDdiNGZlIDEwMDY0NAotLS0gYS9Tb3VyY2UvV1RGL0NoYW5nZUxvZwor KysgYi9Tb3VyY2UvV1RGL0NoYW5nZUxvZwpAQCAtMSwzICsxLDEzIEBACisyMDEzLTA4LTEzICBB cnVucHJhc2FkIFJhamt1bWFyICA8YXJ1cmFqa3VAY2lzY28uY29tPgorCisgICAgICAgIFtXVEZd IFtKU0NdIFJlcGxhY2UgY3VycmVudFRpbWUoKSB3aXRoIG1vbm90b25pY2FsbHlJbmNyZWFzaW5n VGltZSgpIGluIGFsbCBwb3NzaWJsZSBwbGFjZXMKKyAgICAgICAgaHR0cHM6Ly9idWdzLndlYmtp dC5vcmcvc2hvd19idWcuY2dpP2lkPTExOTc2MgorCisgICAgICAgIFJldmlld2VkIGJ5IE5PQk9E WSAoT09QUyEpLgorCisgICAgICAgICogd3RmL01haW5UaHJlYWQuY3BwOgorICAgICAgICAoV1RG OjpkaXNwYXRjaEZ1bmN0aW9uc0Zyb21NYWluVGhyZWFkKToKKwogMjAxMy0wOC0wNyAgQWxleCBD aHJpc3RlbnNlbiAgPGFjaHJpc3RlbnNlbkBhcHBsZS5jb20+CiAKICAgICAgICAgRml4ZWQgd3Jv bmcgZGVmaW5pdGlvbiBmb3IgQXBwbGVXaW4gcG9ydCdzIFdlYkdMIGFmdGVyIHIxNTM3NjguCmRp ZmYgLS1naXQgYS9Tb3VyY2UvSmF2YVNjcmlwdENvcmUvaGVhcC9IZWFwLmNwcCBiL1NvdXJjZS9K YXZhU2NyaXB0Q29yZS9oZWFwL0hlYXAuY3BwCmluZGV4IDVhODlmZGI4MWEzMWY2ZDZlMjhkNzIy ODk0MjRiZWM3OWJmODQ3ZGUuLjYwNGU3ODg0ZjFlNTdlMGZiMmJlNjRlNGM2MjI3YjM1MGU3YjA4 NzYgMTAwNjQ0Ci0tLSBhL1NvdXJjZS9KYXZhU2NyaXB0Q29yZS9oZWFwL0hlYXAuY3BwCisrKyBi L1NvdXJjZS9KYXZhU2NyaXB0Q29yZS9oZWFwL0hlYXAuY3BwCkBAIC05MCwxMiArOTAsMTIgQEAg c3RydWN0IEdDVGltZXIgewogc3RydWN0IEdDVGltZXJTY29wZSB7CiAgICAgR0NUaW1lclNjb3Bl KEdDVGltZXIqIHRpbWVyKQogICAgICAgICA6IG1fdGltZXIodGltZXIpCi0gICAgICAgICwgbV9z dGFydChXVEY6OmN1cnJlbnRUaW1lKCkpCisgICAgICAgICwgbV9zdGFydChXVEY6Om1vbm90b25p Y2FsbHlJbmNyZWFzaW5nVGltZSgpKQogICAgIHsKICAgICB9CiAgICAgfkdDVGltZXJTY29wZSgp CiAgICAgewotICAgICAgICBkb3VibGUgZGVsdGEgPSBXVEY6OmN1cnJlbnRUaW1lKCkgLSBtX3N0 YXJ0OworICAgICAgICBkb3VibGUgZGVsdGEgPSBXVEY6Om1vbm90b25pY2FsbHlJbmNyZWFzaW5n VGltZSgpIC0gbV9zdGFydDsKICAgICAgICAgaWYgKGRlbHRhIDwgbV90aW1lci0+bV9taW4pCiAg ICAgICAgICAgICBtX3RpbWVyLT5tX21pbiA9IGRlbHRhOwogICAgICAgICBpZiAoZGVsdGEgPiBt X3RpbWVyLT5tX21heCkKQEAgLTI2Myw3ICsyNjMsNyBAQCBIZWFwOjpIZWFwKFZNKiB2bSwgSGVh cFR5cGUgaGVhcFR5cGUpCiAgICAgLCBtX2lzU2FmZVRvQ29sbGVjdChmYWxzZSkKICAgICAsIG1f dm0odm0pCiAgICAgLCBtX2xhc3RHQ0xlbmd0aCgwKQotICAgICwgbV9sYXN0Q29kZURpc2NhcmRU aW1lKFdURjo6Y3VycmVudFRpbWUoKSkKKyAgICAsIG1fbGFzdENvZGVEaXNjYXJkVGltZShXVEY6 Om1vbm90b25pY2FsbHlJbmNyZWFzaW5nVGltZSgpKQogICAgICwgbV9hY3Rpdml0eUNhbGxiYWNr KERlZmF1bHRHQ0FjdGl2aXR5Q2FsbGJhY2s6OmNyZWF0ZSh0aGlzKSkKICAgICAsIG1fc3dlZXBl cihJbmNyZW1lbnRhbFN3ZWVwZXI6OmNyZWF0ZSh0aGlzKSkKICAgICAsIG1fZGVmZXJyYWxEZXB0 aCgwKQpAQCAtNDMzLDcgKzQzMyw3IEBAIHZvaWQgSGVhcDo6bWFya1Jvb3RzKCkKICAgICBBU1NF UlQoaXNWYWxpZFRocmVhZFN0YXRlKG1fdm0pKTsKIAogI2lmIEVOQUJMRShPQkpFQ1RfTUFSS19M T0dHSU5HKQotICAgIGRvdWJsZSBnY1N0YXJ0VGltZSA9IFdURjo6Y3VycmVudFRpbWUoKTsKKyAg ICBkb3VibGUgZ2NTdGFydFRpbWUgPSBXVEY6Om1vbm90b25pY2FsbHlJbmNyZWFzaW5nVGltZSgp OwogI2VuZGlmCiAKICAgICB2b2lkKiBkdW1teTsKQEAgLTU5MCw3ICs1OTAsNyBAQCB2b2lkIEhl YXA6Om1hcmtSb290cygpCiAjaWYgRU5BQkxFKFBBUkFMTEVMX0dDKQogICAgIHZpc2l0Q291bnQg Kz0gbV9zaGFyZWREYXRhLmNoaWxkVmlzaXRDb3VudCgpOwogI2VuZGlmCi0gICAgTUFSS19MT0df TUVTU0FHRTIoIlxuTnVtYmVyIG9mIGxpdmUgT2JqZWN0cyBhZnRlciBmdWxsIEdDICVsdSwgdG9v ayAlLjZmIHNlY3NcbiIsIHZpc2l0Q291bnQsIFdURjo6Y3VycmVudFRpbWUoKSAtIGdjU3RhcnRU aW1lKTsKKyAgICBNQVJLX0xPR19NRVNTQUdFMigiXG5OdW1iZXIgb2YgbGl2ZSBPYmplY3RzIGFm dGVyIGZ1bGwgR0MgJWx1LCB0b29rICUuNmYgc2Vjc1xuIiwgdmlzaXRDb3VudCwgV1RGOjptb25v dG9uaWNhbGx5SW5jcmVhc2luZ1RpbWUoKSAtIGdjU3RhcnRUaW1lKTsKICNlbmRpZgogCiAgICAg dmlzaXRvci5yZXNldCgpOwpAQCAtNzI2LDEwICs3MjYsMTAgQEAgdm9pZCBIZWFwOjpjb2xsZWN0 KFN3ZWVwVG9nZ2xlIHN3ZWVwVG9nZ2xlKQogCiAgICAgbV9hY3Rpdml0eUNhbGxiYWNrLT53aWxs Q29sbGVjdCgpOwogCi0gICAgZG91YmxlIGxhc3RHQ1N0YXJ0VGltZSA9IFdURjo6Y3VycmVudFRp bWUoKTsKKyAgICBkb3VibGUgbGFzdEdDU3RhcnRUaW1lID0gV1RGOjptb25vdG9uaWNhbGx5SW5j cmVhc2luZ1RpbWUoKTsKICAgICBpZiAobGFzdEdDU3RhcnRUaW1lIC0gbV9sYXN0Q29kZURpc2Nh cmRUaW1lID4gbWludXRlKSB7CiAgICAgICAgIGRlbGV0ZUFsbENvbXBpbGVkQ29kZSgpOwotICAg ICAgICBtX2xhc3RDb2RlRGlzY2FyZFRpbWUgPSBXVEY6OmN1cnJlbnRUaW1lKCk7CisgICAgICAg IG1fbGFzdENvZGVEaXNjYXJkVGltZSA9IFdURjo6bW9ub3RvbmljYWxseUluY3JlYXNpbmdUaW1l KCk7CiAgICAgfQogCiAgICAgewpAQCAtNzk3LDcgKzc5Nyw3IEBAIHZvaWQgSGVhcDo6Y29sbGVj dChTd2VlcFRvZ2dsZSBzd2VlcFRvZ2dsZSkKICAgICBtX2J5dGVzQWxsb2NhdGVkTGltaXQgPSBt YXhIZWFwU2l6ZSAtIGN1cnJlbnRIZWFwU2l6ZTsKIAogICAgIG1fYnl0ZXNBbGxvY2F0ZWQgPSAw OwotICAgIGRvdWJsZSBsYXN0R0NFbmRUaW1lID0gV1RGOjpjdXJyZW50VGltZSgpOworICAgIGRv dWJsZSBsYXN0R0NFbmRUaW1lID0gV1RGOjptb25vdG9uaWNhbGx5SW5jcmVhc2luZ1RpbWUoKTsK ICAgICBtX2xhc3RHQ0xlbmd0aCA9IGxhc3RHQ0VuZFRpbWUgLSBsYXN0R0NTdGFydFRpbWU7CiAK ICAgICBpZiAoT3B0aW9uczo6cmVjb3JkR0NQYXVzZVRpbWVzKCkpCmRpZmYgLS1naXQgYS9Tb3Vy Y2UvSmF2YVNjcmlwdENvcmUvanNjLmNwcCBiL1NvdXJjZS9KYXZhU2NyaXB0Q29yZS9qc2MuY3Bw CmluZGV4IDNlNmQ0YWJhOTY5YmUwNzY5ZjY0MDc3ZjllMGMxZGJhMGQ5NzgxNDUuLmFlMjk5NTQ2 N2U1ODJkMjQ2ZjYzOWI1ZDAwNWE5M2YyNjJjNTMxMzEgMTAwNjQ0Ci0tLSBhL1NvdXJjZS9KYXZh U2NyaXB0Q29yZS9qc2MuY3BwCisrKyBiL1NvdXJjZS9KYXZhU2NyaXB0Q29yZS9qc2MuY3BwCkBA IC0xNzEsMTIgKzE3MSwxMiBAQCBwcml2YXRlOgogCiB2b2lkIFN0b3BXYXRjaDo6c3RhcnQoKQog ewotICAgIG1fc3RhcnRUaW1lID0gY3VycmVudFRpbWUoKTsKKyAgICBtX3N0YXJ0VGltZSA9IG1v bm90b25pY2FsbHlJbmNyZWFzaW5nVGltZSgpOwogfQogCiB2b2lkIFN0b3BXYXRjaDo6c3RvcCgp CiB7Ci0gICAgbV9zdG9wVGltZSA9IGN1cnJlbnRUaW1lKCk7CisgICAgbV9zdG9wVGltZSA9IG1v bm90b25pY2FsbHlJbmNyZWFzaW5nVGltZSgpOwogfQogCiBsb25nIFN0b3BXYXRjaDo6Z2V0RWxh cHNlZE1TKCkKZGlmZiAtLWdpdCBhL1NvdXJjZS9KYXZhU2NyaXB0Q29yZS90ZXN0UmVnRXhwLmNw cCBiL1NvdXJjZS9KYXZhU2NyaXB0Q29yZS90ZXN0UmVnRXhwLmNwcAppbmRleCA5MTg1ZDcyODEw ZjMxMWMyYTAwMzFkMTAyMGJhMDZmNjQ0ZGI0YWJhLi42ZjY4ZDMyYTM3YjcyOWQzZjhjNDkwOTNl MDU5ZjVlZTE2ZWI3MGU0IDEwMDY0NAotLS0gYS9Tb3VyY2UvSmF2YVNjcmlwdENvcmUvdGVzdFJl Z0V4cC5jcHAKKysrIGIvU291cmNlL0phdmFTY3JpcHRDb3JlL3Rlc3RSZWdFeHAuY3BwCkBAIC04 MiwxMiArODIsMTIgQEAgcHJpdmF0ZToKIAogdm9pZCBTdG9wV2F0Y2g6OnN0YXJ0KCkKIHsKLSAg ICBtX3N0YXJ0VGltZSA9IGN1cnJlbnRUaW1lKCk7CisgICAgbV9zdGFydFRpbWUgPSBtb25vdG9u aWNhbGx5SW5jcmVhc2luZ1RpbWUoKTsKIH0KIAogdm9pZCBTdG9wV2F0Y2g6OnN0b3AoKQogewot ICAgIG1fc3RvcFRpbWUgPSBjdXJyZW50VGltZSgpOworICAgIG1fc3RvcFRpbWUgPSBtb25vdG9u aWNhbGx5SW5jcmVhc2luZ1RpbWUoKTsKIH0KIAogbG9uZyBTdG9wV2F0Y2g6OmdldEVsYXBzZWRN UygpCmRpZmYgLS1naXQgYS9Tb3VyY2UvV1RGL3d0Zi9NYWluVGhyZWFkLmNwcCBiL1NvdXJjZS9X VEYvd3RmL01haW5UaHJlYWQuY3BwCmluZGV4IGFlYThjMzY2ZTMxYTM2ZWMyNmI2OWRmMTM0YzNi NDllZDkyZjQ0NGEuLmU3N2IxNWY4NzM0NzJiMGU4ZjdhMDQ3YTY0ODJiNDQxZWExMzg2YWYgMTAw NjQ0Ci0tLSBhL1NvdXJjZS9XVEYvd3RmL01haW5UaHJlYWQuY3BwCisrKyBiL1NvdXJjZS9XVEYv d3RmL01haW5UaHJlYWQuY3BwCkBAIC0xNDEsNyArMTQxLDcgQEAgdm9pZCBkaXNwYXRjaEZ1bmN0 aW9uc0Zyb21NYWluVGhyZWFkKCkKICAgICBpZiAoY2FsbGJhY2tzUGF1c2VkKQogICAgICAgICBy ZXR1cm47CiAKLSAgICBkb3VibGUgc3RhcnRUaW1lID0gY3VycmVudFRpbWUoKTsKKyAgICBkb3Vi bGUgc3RhcnRUaW1lID0gbW9ub3RvbmljYWxseUluY3JlYXNpbmdUaW1lKCk7CiAKICAgICBGdW5j dGlvbldpdGhDb250ZXh0IGludm9jYXRpb247CiAgICAgd2hpbGUgKHRydWUpIHsKQEAgLTE2Miw3 ICsxNjIsNyBAQCB2b2lkIGRpc3BhdGNoRnVuY3Rpb25zRnJvbU1haW5UaHJlYWQoKQogICAgICAg ICAvLyB5aWVsZCBzbyB0aGUgdXNlciBpbnB1dCBjYW4gYmUgcHJvY2Vzc2VkLiBPdGhlcndpc2Ug dXNlciBtYXkgbm90IGJlIGFibGUgdG8gZXZlbiBjbG9zZSB0aGUgd2luZG93LgogICAgICAgICAv LyBUaGlzIGNvZGUgaGFzIGVmZmVjdCBvbmx5IGluIGNhc2UgdGhlIHNjaGVkdWxlRGlzcGF0Y2hG dW5jdGlvbnNPbk1haW5UaHJlYWQoKSBpcyBpbXBsZW1lbnRlZCBpbiBhIHdheSB0aGF0CiAgICAg ICAgIC8vIGFsbG93cyBpbnB1dCBldmVudHMgdG8gYmUgcHJvY2Vzc2VkIGJlZm9yZSB3ZSBhcmUg YmFjayBoZXJlLgotICAgICAgICBpZiAoY3VycmVudFRpbWUoKSAtIHN0YXJ0VGltZSA+IG1heFJ1 bkxvb3BTdXNwZW5zaW9uVGltZSkgeworICAgICAgICBpZiAobW9ub3RvbmljYWxseUluY3JlYXNp bmdUaW1lKCkgLSBzdGFydFRpbWUgPiBtYXhSdW5Mb29wU3VzcGVuc2lvblRpbWUpIHsKICAgICAg ICAgICAgIHNjaGVkdWxlRGlzcGF0Y2hGdW5jdGlvbnNPbk1haW5UaHJlYWQoKTsKICAgICAgICAg ICAgIGJyZWFrOwogICAgICAgICB9Cg==