119744 2013-08-13 06:51:14 -0700 [Curl] Possible infinite loop while downloading. 2013-08-13 09:18:22 -0700 1 1 1 Unclassified WebKit WebCore Misc. 528+ (Nightly build) Unspecified Unspecified RESOLVED FIXED P2 Normal --- 0 peavo webkit-unassigned bfulgham commit-queue galpeter oldest_to_newest 916685 0 peavo 2013-08-13 06:51:14 -0700 If the methods addToCurl() or removeFromCurl() in the curl download manager fails (WebCore/platform/network/curl/CurlDownload.cpp), the download thread might get stuck in an endless loop, while trying to update the curl handle list (in the method updateHandleList()). 916687 1 208625 peavo 2013-08-13 06:59:38 -0700 Created attachment 208625 Patch 916746 2 208625 commit-queue 2013-08-13 09:18:21 -0700 Comment on attachment 208625 Patch Clearing flags on attachment: 208625 Committed r154006: <http://trac.webkit.org/changeset/154006> 916747 3 commit-queue 2013-08-13 09:18:22 -0700 All reviewed patches have been landed. Closing bug. 208625 2013-08-13 06:59:38 -0700 2013-08-13 09:18:20 -0700 Patch bug-119744-20130813155911.patch text/plain 1863 peavo SW5kZXg6IFNvdXJjZS9XZWJDb3JlL0NoYW5nZUxvZwo9PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09Ci0tLSBTb3VyY2UvV2Vi Q29yZS9DaGFuZ2VMb2cJKHJldmlzaW9uIDE1NDAwMCkKKysrIFNvdXJjZS9XZWJDb3JlL0NoYW5n ZUxvZwkod29ya2luZyBjb3B5KQpAQCAtMSwzICsxLDE2IEBACisyMDEzLTA4LTEzICBwZWF2b0Bv dXRsb29rLmNvbSAgPHBlYXZvQG91dGxvb2suY29tPgorCisgICAgICAgIFtDdXJsXSBQb3NzaWJs ZSBpbmZpbml0ZSBsb29wIHdoaWxlIGRvd25sb2FkaW5nLgorICAgICAgICBodHRwczovL2J1Z3Mu d2Via2l0Lm9yZy9zaG93X2J1Zy5jZ2k/aWQ9MTE5NzQ0CisKKyAgICAgICAgUmV2aWV3ZWQgYnkg Tk9CT0RZIChPT1BTISkuCisKKyAgICAgICAgSWYgYWRkaW5nL3JlbW92aW5nIGN1cmwgaGFuZGxl cyBmYWlscywgdGhlIGRvd25sb2FkIHRocmVhZAorICAgICAgICBjYW4gZW5kIHVwIGluIGFuIGVu ZGxlc3MgbG9vcCB0cnlpbmcgdG8gdXBkYXRlIHRoZSBjdXJsIGhhbmRsZSBsaXN0LgorCisgICAg ICAgICogcGxhdGZvcm0vbmV0d29yay9jdXJsL0N1cmxEb3dubG9hZC5jcHA6CisgICAgICAgIChX ZWJDb3JlOjpDdXJsRG93bmxvYWRNYW5hZ2VyOjp1cGRhdGVIYW5kbGVMaXN0KTogQXZvaWQgaW5m aW5pdGUgbG9vcCBieSBpZ25vcmluZyByZXR1cm4gdmFsdWUuCisKIDIwMTMtMDgtMTMgIERhbmls byBDZXNhciBMZW1lcyBkZSBQYXVsYSAgPGRhbmlsby5jZXNhckBjb2xsYWJvcmEuY28udWs+CiAK ICAgICAgICAgW0dUS10gY2xvc2UgdGhlIHZvbHVtZSBzbGlkZXIgd2hlbiB0aGUgbWVkaWEgY29u dHJvbCBwYW5lbCBpcyBoaWRkZW4KSW5kZXg6IFNvdXJjZS9XZWJDb3JlL3BsYXRmb3JtL25ldHdv cmsvY3VybC9DdXJsRG93bmxvYWQuY3BwCj09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT0KLS0tIFNvdXJjZS9XZWJDb3JlL3Bs YXRmb3JtL25ldHdvcmsvY3VybC9DdXJsRG93bmxvYWQuY3BwCShyZXZpc2lvbiAxNTM5ODIpCisr KyBTb3VyY2UvV2ViQ29yZS9wbGF0Zm9ybS9uZXR3b3JrL2N1cmwvQ3VybERvd25sb2FkLmNwcAko d29ya2luZyBjb3B5KQpAQCAtMTIzLDE1ICsxMjMsMTUgQEAgdm9pZCBDdXJsRG93bmxvYWRNYW5h Z2VyOjp1cGRhdGVIYW5kbGVMaQogICAgIC8vIFJlbW92ZSBjdXJsIGVhc3kgaGFuZGxlcyBmcm9t IG11bHRpIGxpc3QgCiAgICAgaW50IHNpemUgPSBtX3JlbW92ZWRIYW5kbGVMaXN0LnNpemUoKTsK ICAgICBmb3IgKGludCBpID0gMDsgaSA8IHNpemU7IGkrKykgewotICAgICAgICBpZiAocmVtb3Zl RnJvbUN1cmwobV9yZW1vdmVkSGFuZGxlTGlzdFswXSkpCi0gICAgICAgICAgICBtX3JlbW92ZWRI YW5kbGVMaXN0LnJlbW92ZSgwKTsKKyAgICAgICAgcmVtb3ZlRnJvbUN1cmwobV9yZW1vdmVkSGFu ZGxlTGlzdFswXSk7CisgICAgICAgIG1fcmVtb3ZlZEhhbmRsZUxpc3QucmVtb3ZlKDApOwogICAg IH0KIAogICAgIC8vIEFkZCBwZW5kaW5nIGN1cmwgZWFzeSBoYW5kbGVzIHRvIG11bHRpIGxpc3Qg CiAgICAgc2l6ZSA9IG1fcGVuZGluZ0hhbmRsZUxpc3Quc2l6ZSgpOwogICAgIGZvciAoaW50IGkg PSAwOyBpIDwgc2l6ZTsgaSsrKSB7Ci0gICAgICAgIGlmIChhZGRUb0N1cmwobV9wZW5kaW5nSGFu ZGxlTGlzdFswXSkpCi0gICAgICAgICAgICBtX3BlbmRpbmdIYW5kbGVMaXN0LnJlbW92ZSgwKTsK KyAgICAgICAgYWRkVG9DdXJsKG1fcGVuZGluZ0hhbmRsZUxpc3RbMF0pOworICAgICAgICBtX3Bl bmRpbmdIYW5kbGVMaXN0LnJlbW92ZSgwKTsKICAgICB9CiB9CiAK