119715 2013-08-12 19:35:51 -0700 Fix variable name |end| -> |size| in EventTarget::fireEventListeners 2013-08-12 20:33:10 -0700 1 1 1 Unclassified WebKit UI Events 528+ (Nightly build) Unspecified Unspecified RESOLVED FIXED BlinkMergeCandidate P2 Normal --- 1 rniwa rniwa benjamin commit-queue darin esprehn+autocc ggaren kangil.han kling sam oldest_to_newest 916499 0 rniwa 2013-08-12 19:35:51 -0700 Merge https://chromium.googlesource.com/chromium/blink/+/f58b017539c48059bb2b88d18ee0ee3d14decb01 |end| variables are used for iterators, so fix the variable name to |size| because it refers to an index. 916502 1 208587 rniwa 2013-08-12 20:00:59 -0700 Created attachment 208587 Cleanup 916511 2 rniwa 2013-08-12 20:33:10 -0700 Committed r153972: <http://trac.webkit.org/changeset/153972> 208587 2013-08-12 20:00:59 -0700 2013-08-12 20:32:08 -0700 Cleanup bug-119715-20130812200058.patch text/plain 4307 rniwa SW5kZXg6IFNvdXJjZS9XZWJDb3JlL0NoYW5nZUxvZwo9PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09Ci0tLSBTb3VyY2UvV2Vi Q29yZS9DaGFuZ2VMb2cJKHJldmlzaW9uIDE1Mzk3MSkKKysrIFNvdXJjZS9XZWJDb3JlL0NoYW5n ZUxvZwkod29ya2luZyBjb3B5KQpAQCAtMSwzICsxLDIwIEBACisyMDEzLTA4LTEyICBSeW9zdWtl IE5pd2EgIDxybml3YUB3ZWJraXQub3JnPgorCisgICAgICAgIEZpeCB2YXJpYWJsZSBuYW1lIHxl bmR8IC0+IHxzaXplfCBpbiBFdmVudFRhcmdldDo6ZmlyZUV2ZW50TGlzdGVuZXJzCisgICAgICAg IGh0dHBzOi8vYnVncy53ZWJraXQub3JnL3Nob3dfYnVnLmNnaT9pZD0xMTk3MTUKKworICAgICAg ICBSZXZpZXdlZCBieSBOT0JPRFkgKE9PUFMhKS4KKworICAgICAgICBNZXJnZSBodHRwczovL2No cm9taXVtLmdvb2dsZXNvdXJjZS5jb20vY2hyb21pdW0vYmxpbmsvKy9mNThiMDE3NTM5YzQ4MDU5 YmIyYjg4ZDE4ZWUwZWUzZDE0ZGVjYjAxCisgICAgICAgIGFuZCBhbHNvIGZpeCB2YXJpYWJsZSBu YW1lcyBpbiBGaXJpbmdFdmVudEl0ZXJhdG9yLgorCisgICAgICAgICogZG9tL0V2ZW50VGFyZ2V0 LmNwcDoKKyAgICAgICAgKFdlYkNvcmU6OkV2ZW50VGFyZ2V0OjpyZW1vdmVFdmVudExpc3RlbmVy KToKKyAgICAgICAgKFdlYkNvcmU6OkV2ZW50VGFyZ2V0OjpmaXJlRXZlbnRMaXN0ZW5lcnMpOgor ICAgICAgICAoV2ViQ29yZTo6RXZlbnRUYXJnZXQ6OnJlbW92ZUFsbEV2ZW50TGlzdGVuZXJzKToK KyAgICAgICAgKiBkb20vRXZlbnRUYXJnZXQuaDoKKyAgICAgICAgKFdlYkNvcmU6OkZpcmluZ0V2 ZW50SXRlcmF0b3I6OkZpcmluZ0V2ZW50SXRlcmF0b3IpOgorCiAyMDEzLTA4LTEyICBSeW9zdWtl IE5pd2EgIDxybml3YUB3ZWJraXQub3JnPgogCiAgICAgICAgIEVuY2Fwc3VsYXRlIGFjY2VzcyB0 byBkb2N1bWVudE5hbWVkSXRlbU1hcCBhbmQgd2luZG93TmFtZWRJdGVtTWFwCkluZGV4OiBTb3Vy Y2UvV2ViQ29yZS9kb20vRXZlbnRUYXJnZXQuY3BwCj09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT0KLS0tIFNvdXJjZS9XZWJD b3JlL2RvbS9FdmVudFRhcmdldC5jcHAJKHJldmlzaW9uIDE1Mzk2OCkKKysrIFNvdXJjZS9XZWJD b3JlL2RvbS9FdmVudFRhcmdldC5jcHAJKHdvcmtpbmcgY29weSkKQEAgLTkyLDEwICs5MiwxMCBA QCBib29sIEV2ZW50VGFyZ2V0OjpyZW1vdmVFdmVudExpc3RlbmVyKGNvCiAgICAgICAgIGlmIChl dmVudFR5cGUgIT0gZmlyaW5nSXRlcmF0b3IuZXZlbnRUeXBlKQogICAgICAgICAgICAgY29udGlu dWU7CiAKLSAgICAgICAgaWYgKGluZGV4T2ZSZW1vdmVkTGlzdGVuZXIgPj0gZmlyaW5nSXRlcmF0 b3IuZW5kKQorICAgICAgICBpZiAoaW5kZXhPZlJlbW92ZWRMaXN0ZW5lciA+PSBmaXJpbmdJdGVy YXRvci5zaXplKQogICAgICAgICAgICAgY29udGludWU7CiAKLSAgICAgICAgLS1maXJpbmdJdGVy YXRvci5lbmQ7CisgICAgICAgIC0tZmlyaW5nSXRlcmF0b3Iuc2l6ZTsKICAgICAgICAgaWYgKGlu ZGV4T2ZSZW1vdmVkTGlzdGVuZXIgPD0gZmlyaW5nSXRlcmF0b3IuaXRlcmF0b3IpCiAgICAgICAg ICAgICAtLWZpcmluZ0l0ZXJhdG9yLml0ZXJhdG9yOwogICAgIH0KQEAgLTIxNywxOCArMjE3LDE3 IEBAIHZvaWQgRXZlbnRUYXJnZXQ6OmZpcmVFdmVudExpc3RlbmVycyhFdmUKIHsKICAgICBSZWZQ dHI8RXZlbnRUYXJnZXQ+IHByb3RlY3QgPSB0aGlzOwogCi0gICAgLy8gRmlyZSBhbGwgbGlzdGVu ZXJzIHJlZ2lzdGVyZWQgZm9yIHRoaXMgZXZlbnQuIERvbid0IGZpcmUgbGlzdGVuZXJzIHJlbW92 ZWQKLSAgICAvLyBkdXJpbmcgZXZlbnQgZGlzcGF0Y2guIEFsc28sIGRvbid0IGZpcmUgZXZlbnQg bGlzdGVuZXJzIGFkZGVkIGR1cmluZyBldmVudAotICAgIC8vIGRpc3BhdGNoLiBDb252ZW5pZW50 bHksIGFsbCBuZXcgZXZlbnQgbGlzdGVuZXJzIHdpbGwgYmUgYWRkZWQgYWZ0ZXIgJ2VuZCcsCi0g ICAgLy8gc28gaXRlcmF0aW5nIHRvICdlbmQnIG5hdHVyYWxseSBleGNsdWRlcyBuZXcgZXZlbnQg bGlzdGVuZXJzLgorICAgIC8vIEZpcmUgYWxsIGxpc3RlbmVycyByZWdpc3RlcmVkIGZvciB0aGlz IGV2ZW50LiBEb24ndCBmaXJlIGxpc3RlbmVycyByZW1vdmVkIGR1cmluZyBldmVudCBkaXNwYXRj aC4KKyAgICAvLyBBbHNvLCBkb24ndCBmaXJlIGV2ZW50IGxpc3RlbmVycyBhZGRlZCBkdXJpbmcg ZXZlbnQgZGlzcGF0Y2guIENvbnZlbmllbnRseSwgYWxsIG5ldyBldmVudCBsaXN0ZW5lcnMgd2ls bCBiZSBhZGRlZAorICAgIC8vIGFmdGVyIG9yIGF0IGluZGV4IHxzaXplfCwgc28gaXRlcmF0aW5n IHVwIHRvIChidXQgbm90IGluY2x1ZGluZykgfHNpemV8IG5hdHVyYWxseSBleGNsdWRlcyBuZXcg ZXZlbnQgbGlzdGVuZXJzLgogCiAgICAgYm9vbCB1c2VyRXZlbnRXYXNIYW5kbGVkID0gZmFsc2U7 CiAgICAgc2l6ZV90IGkgPSAwOwotICAgIHNpemVfdCBlbmQgPSBlbnRyeS5zaXplKCk7CisgICAg c2l6ZV90IHNpemUgPSBlbnRyeS5zaXplKCk7CiAgICAgaWYgKCFkLT5maXJpbmdFdmVudEl0ZXJh dG9ycykKICAgICAgICAgZC0+ZmlyaW5nRXZlbnRJdGVyYXRvcnMgPSBhZG9wdFB0cihuZXcgRmly aW5nRXZlbnRJdGVyYXRvclZlY3Rvcik7Ci0gICAgZC0+ZmlyaW5nRXZlbnRJdGVyYXRvcnMtPmFw cGVuZChGaXJpbmdFdmVudEl0ZXJhdG9yKGV2ZW50LT50eXBlKCksIGksIGVuZCkpOwotICAgIGZv ciAoIDsgaSA8IGVuZDsgKytpKSB7CisgICAgZC0+ZmlyaW5nRXZlbnRJdGVyYXRvcnMtPmFwcGVu ZChGaXJpbmdFdmVudEl0ZXJhdG9yKGV2ZW50LT50eXBlKCksIGksIHNpemUpKTsKKyAgICBmb3Ig KDsgaSA8IHNpemU7ICsraSkgewogICAgICAgICBSZWdpc3RlcmVkRXZlbnRMaXN0ZW5lciYgcmVn aXN0ZXJlZExpc3RlbmVyID0gZW50cnlbaV07CiAgICAgICAgIGlmIChldmVudC0+ZXZlbnRQaGFz ZSgpID09IEV2ZW50OjpDQVBUVVJJTkdfUEhBU0UgJiYgIXJlZ2lzdGVyZWRMaXN0ZW5lci51c2VD YXB0dXJlKQogICAgICAgICAgICAgY29udGludWU7CkBAIC0yODYsNyArMjg1LDcgQEAgdm9pZCBF dmVudFRhcmdldDo6cmVtb3ZlQWxsRXZlbnRMaXN0ZW5lcgogICAgIGlmIChkLT5maXJpbmdFdmVu dEl0ZXJhdG9ycykgewogICAgICAgICBmb3IgKHNpemVfdCBpID0gMDsgaSA8IGQtPmZpcmluZ0V2 ZW50SXRlcmF0b3JzLT5zaXplKCk7ICsraSkgewogICAgICAgICAgICAgZC0+ZmlyaW5nRXZlbnRJ dGVyYXRvcnMtPmF0KGkpLml0ZXJhdG9yID0gMDsKLSAgICAgICAgICAgIGQtPmZpcmluZ0V2ZW50 SXRlcmF0b3JzLT5hdChpKS5lbmQgPSAwOworICAgICAgICAgICAgZC0+ZmlyaW5nRXZlbnRJdGVy YXRvcnMtPmF0KGkpLnNpemUgPSAwOwogICAgICAgICB9CiAgICAgfQogfQpJbmRleDogU291cmNl L1dlYkNvcmUvZG9tL0V2ZW50VGFyZ2V0LmgKPT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PQotLS0gU291cmNlL1dlYkNvcmUv ZG9tL0V2ZW50VGFyZ2V0LmgJKHJldmlzaW9uIDE1Mzk2OCkKKysrIFNvdXJjZS9XZWJDb3JlL2Rv bS9FdmVudFRhcmdldC5oCSh3b3JraW5nIGNvcHkpCkBAIC03OSwxNiArNzksMTYgQEAgbmFtZXNw YWNlIFdlYkNvcmUgewogICAgIHR5cGVkZWYgaW50IEV4Y2VwdGlvbkNvZGU7CiAKICAgICBzdHJ1 Y3QgRmlyaW5nRXZlbnRJdGVyYXRvciB7Ci0gICAgICAgIEZpcmluZ0V2ZW50SXRlcmF0b3IoY29u c3QgQXRvbWljU3RyaW5nJiBldmVudFR5cGUsIHNpemVfdCYgaXRlcmF0b3IsIHNpemVfdCYgZW5k KQorICAgICAgICBGaXJpbmdFdmVudEl0ZXJhdG9yKGNvbnN0IEF0b21pY1N0cmluZyYgZXZlbnRU eXBlLCBzaXplX3QmIGl0ZXJhdG9yLCBzaXplX3QmIHNpemUpCiAgICAgICAgICAgICA6IGV2ZW50 VHlwZShldmVudFR5cGUpCiAgICAgICAgICAgICAsIGl0ZXJhdG9yKGl0ZXJhdG9yKQotICAgICAg ICAgICAgLCBlbmQoZW5kKQorICAgICAgICAgICAgLCBzaXplKHNpemUpCiAgICAgICAgIHsKICAg ICAgICAgfQogCiAgICAgICAgIGNvbnN0IEF0b21pY1N0cmluZyYgZXZlbnRUeXBlOwogICAgICAg ICBzaXplX3QmIGl0ZXJhdG9yOwotICAgICAgICBzaXplX3QmIGVuZDsKKyAgICAgICAgc2l6ZV90 JiBzaXplOwogICAgIH07CiAgICAgdHlwZWRlZiBWZWN0b3I8RmlyaW5nRXZlbnRJdGVyYXRvciwg MT4gRmlyaW5nRXZlbnRJdGVyYXRvclZlY3RvcjsKIAo=