119710 2013-08-12 17:53:40 -0700 Use the correct preprocessor in shouldRepaintFixedBackgroundsOnScroll() 2013-08-12 22:46:22 -0700 1 1 1 Unclassified WebKit WebCore Misc. 528+ (Nightly build) Unspecified Unspecified RESOLVED FIXED P2 Normal --- 0 seokju webkit-unassigned commit-queue esprehn+autocc glenn kondapallykalyan oldest_to_newest 916470 0 seokju 2013-08-12 17:53:40 -0700 Remove unused parameter warning. WebKit/Source/WebCore/rendering/RenderObject.cpp:127:13: warning: unused parameter ‘frameView’ [-Wunused-parameter] 916473 1 208579 seokju 2013-08-12 18:05:38 -0700 Created attachment 208579 Patch 916476 2 208579 darin 2013-08-12 18:09:16 -0700 Comment on attachment 208579 Patch View in context: https://bugs.webkit.org/attachment.cgi?id=208579&action=review > Source/WebCore/rendering/RenderObject.cpp:129 > -#if !ENABLE(FAST_MOBILE_SCROLLING) && !PLATFORM(QT) > +#if !ENABLE(FAST_MOBILE_SCROLLING) || (ENABLE(FAST_MOBILE_SCROLLING) && !PLATFORM(QT)) That’s the same as just change && to ||, why make it so complicated? 916477 3 208579 darin 2013-08-12 18:10:32 -0700 Comment on attachment 208579 Patch View in context: https://bugs.webkit.org/attachment.cgi?id=208579&action=review >> Source/WebCore/rendering/RenderObject.cpp:129 >> +#if !ENABLE(FAST_MOBILE_SCROLLING) || (ENABLE(FAST_MOBILE_SCROLLING) && !PLATFORM(QT)) > > That’s the same as just change && to ||, why make it so complicated? In other words, this is: #if !A || (A && !B) Which is the same as: #if !A || !B 916480 4 seokju 2013-08-12 18:16:29 -0700 (In reply to comment #3) > (From update of attachment 208579 [details]) > View in context: https://bugs.webkit.org/attachment.cgi?id=208579&action=review > > >> Source/WebCore/rendering/RenderObject.cpp:129 > >> +#if !ENABLE(FAST_MOBILE_SCROLLING) || (ENABLE(FAST_MOBILE_SCROLLING) && !PLATFORM(QT)) > > > > That’s the same as just change && to ||, why make it so complicated? > > In other words, this is: > > #if !A || (A && !B) > > Which is the same as: > > #if !A || !B Just check it explicitly. You're right. It could be so complicated. Thanks. 916481 5 208580 seokju 2013-08-12 18:16:41 -0700 Created attachment 208580 Patch 916485 6 seokju 2013-08-12 18:49:26 -0700 (In reply to comment #4) > (In reply to comment #3) > > (From update of attachment 208579 [details] [details]) > > View in context: https://bugs.webkit.org/attachment.cgi?id=208579&action=review > > > > >> Source/WebCore/rendering/RenderObject.cpp:129 > > >> +#if !ENABLE(FAST_MOBILE_SCROLLING) || (ENABLE(FAST_MOBILE_SCROLLING) && !PLATFORM(QT)) > > > > > > That’s the same as just change && to ||, why make it so complicated? > > > > In other words, this is: > > > > #if !A || (A && !B) > > > > Which is the same as: > > > > #if !A || !B > > Just check it explicitly. You're right. > It could be so complicated. Thanks. Fixed it. 916544 7 208580 commit-queue 2013-08-12 22:46:20 -0700 Comment on attachment 208580 Patch Clearing flags on attachment: 208580 Committed r153974: <http://trac.webkit.org/changeset/153974> 916545 8 commit-queue 2013-08-12 22:46:22 -0700 All reviewed patches have been landed. Closing bug. 208579 2013-08-12 18:05:38 -0700 2013-08-12 18:16:34 -0700 Patch bug-119710-20130813100536.patch text/plain 1522 seokju U3VidmVyc2lvbiBSZXZpc2lvbjogMTUzOTY1CmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViQ29yZS9D aGFuZ2VMb2cgYi9Tb3VyY2UvV2ViQ29yZS9DaGFuZ2VMb2cKaW5kZXggZGM1ZGVjYmZjOTNlOGRh OTNmMWExZDY1NDJjZDJiMDE0ODc5Y2IxMy4uY2I2MWMzNWFmZjQ4OTUwZTM2NDliY2Y1YzM1ZmFk YTMwNDlkMTllYSAxMDA2NDQKLS0tIGEvU291cmNlL1dlYkNvcmUvQ2hhbmdlTG9nCisrKyBiL1Nv dXJjZS9XZWJDb3JlL0NoYW5nZUxvZwpAQCAtMSwzICsxLDE1IEBACisyMDEzLTA4LTEyICBTZW9r anUgS3dvbiAgPHNlb2tqdUB3ZWJraXQub3JnPgorCisgICAgICAgIFVzZSB0aGUgY29ycmVjdCBw cmVwcm9jZXNzb3IgaW4gc2hvdWxkUmVwYWludEZpeGVkQmFja2dyb3VuZHNPblNjcm9sbCgpCisg ICAgICAgIGh0dHBzOi8vYnVncy53ZWJraXQub3JnL3Nob3dfYnVnLmNnaT9pZD0xMTk3MTAKKwor ICAgICAgICBSZXZpZXdlZCBieSBOT0JPRFkgKE9PUFMhKS4KKworICAgICAgICBObyBiZWhhdmlv ciBjaGFuZ2UsIG5vIG5ldyB0ZXN0cyBuZWVkZWQuCisKKyAgICAgICAgKiByZW5kZXJpbmcvUmVu ZGVyT2JqZWN0LmNwcDogUmVtb3ZlIHVudXNlZCBwYXJhbWV0ZXIgd2FybmluZy4KKyAgICAgICAg KFdlYkNvcmU6OnNob3VsZFJlcGFpbnRGaXhlZEJhY2tncm91bmRzT25TY3JvbGwpOgorCiAyMDEz LTA4LTEyICBBcm5hdWQgUmVuZXZpZXIgIDxhLnJlbmV2aWVyQHNhbXN1bmcuY29tPgogCiAgICAg ICAgIFtjYWlyb10gbWVtb3J5IGNvcnJ1cHRpb24gd2l0aCBwdXRJbWFnZURhdGEgYW5kIGFjY2Vs ZXJhdGVkIGNhbnZhcy4KZGlmZiAtLWdpdCBhL1NvdXJjZS9XZWJDb3JlL3JlbmRlcmluZy9SZW5k ZXJPYmplY3QuY3BwIGIvU291cmNlL1dlYkNvcmUvcmVuZGVyaW5nL1JlbmRlck9iamVjdC5jcHAK aW5kZXggOTc0OTI4NDJmMzk3ZjcxYjRhMzU1ZWNjOTEwMzk1NzE4NTIyNGQzNy4uYTc3YTg4YjNm YjFiN2U3N2I5ZTQ2NTliYzIyZDY2MzBlMjNlNDQwOCAxMDA2NDQKLS0tIGEvU291cmNlL1dlYkNv cmUvcmVuZGVyaW5nL1JlbmRlck9iamVjdC5jcHAKKysrIGIvU291cmNlL1dlYkNvcmUvcmVuZGVy aW5nL1JlbmRlck9iamVjdC5jcHAKQEAgLTEyNiw3ICsxMjYsNyBAQCBDT01QSUxFX0FTU0VSVChz aXplb2YoUmVuZGVyT2JqZWN0KSA9PSBzaXplb2YoU2FtZVNpemVBc1JlbmRlck9iamVjdCksIFJl bmRlck9iagogLy8gaWdub3JlIHRoZSBDU1MgcHJvcGVydHkgImJhY2tncm91bmQtYXR0YWNobWVu dDogZml4ZWQiLgogc3RhdGljIGJvb2wgc2hvdWxkUmVwYWludEZpeGVkQmFja2dyb3VuZHNPblNj cm9sbChGcmFtZVZpZXcqIGZyYW1lVmlldykKIHsKLSNpZiAhRU5BQkxFKEZBU1RfTU9CSUxFX1ND Uk9MTElORykgJiYgIVBMQVRGT1JNKFFUKQorI2lmICFFTkFCTEUoRkFTVF9NT0JJTEVfU0NST0xM SU5HKSB8fCAoRU5BQkxFKEZBU1RfTU9CSUxFX1NDUk9MTElORykgJiYgIVBMQVRGT1JNKFFUKSkK ICAgICBVTlVTRURfUEFSQU0oZnJhbWVWaWV3KTsKICNlbmRpZgogCg== 208580 2013-08-12 18:16:41 -0700 2013-08-12 22:46:20 -0700 Patch bug-119710-20130813101639.patch text/plain 1487 seokju U3VidmVyc2lvbiBSZXZpc2lvbjogMTUzOTY1CmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViQ29yZS9D aGFuZ2VMb2cgYi9Tb3VyY2UvV2ViQ29yZS9DaGFuZ2VMb2cKaW5kZXggZGM1ZGVjYmZjOTNlOGRh OTNmMWExZDY1NDJjZDJiMDE0ODc5Y2IxMy4uY2I2MWMzNWFmZjQ4OTUwZTM2NDliY2Y1YzM1ZmFk YTMwNDlkMTllYSAxMDA2NDQKLS0tIGEvU291cmNlL1dlYkNvcmUvQ2hhbmdlTG9nCisrKyBiL1Nv dXJjZS9XZWJDb3JlL0NoYW5nZUxvZwpAQCAtMSwzICsxLDE1IEBACisyMDEzLTA4LTEyICBTZW9r anUgS3dvbiAgPHNlb2tqdUB3ZWJraXQub3JnPgorCisgICAgICAgIFVzZSB0aGUgY29ycmVjdCBw cmVwcm9jZXNzb3IgaW4gc2hvdWxkUmVwYWludEZpeGVkQmFja2dyb3VuZHNPblNjcm9sbCgpCisg ICAgICAgIGh0dHBzOi8vYnVncy53ZWJraXQub3JnL3Nob3dfYnVnLmNnaT9pZD0xMTk3MTAKKwor ICAgICAgICBSZXZpZXdlZCBieSBOT0JPRFkgKE9PUFMhKS4KKworICAgICAgICBObyBiZWhhdmlv ciBjaGFuZ2UsIG5vIG5ldyB0ZXN0cyBuZWVkZWQuCisKKyAgICAgICAgKiByZW5kZXJpbmcvUmVu ZGVyT2JqZWN0LmNwcDogUmVtb3ZlIHVudXNlZCBwYXJhbWV0ZXIgd2FybmluZy4KKyAgICAgICAg KFdlYkNvcmU6OnNob3VsZFJlcGFpbnRGaXhlZEJhY2tncm91bmRzT25TY3JvbGwpOgorCiAyMDEz LTA4LTEyICBBcm5hdWQgUmVuZXZpZXIgIDxhLnJlbmV2aWVyQHNhbXN1bmcuY29tPgogCiAgICAg ICAgIFtjYWlyb10gbWVtb3J5IGNvcnJ1cHRpb24gd2l0aCBwdXRJbWFnZURhdGEgYW5kIGFjY2Vs ZXJhdGVkIGNhbnZhcy4KZGlmZiAtLWdpdCBhL1NvdXJjZS9XZWJDb3JlL3JlbmRlcmluZy9SZW5k ZXJPYmplY3QuY3BwIGIvU291cmNlL1dlYkNvcmUvcmVuZGVyaW5nL1JlbmRlck9iamVjdC5jcHAK aW5kZXggOTc0OTI4NDJmMzk3ZjcxYjRhMzU1ZWNjOTEwMzk1NzE4NTIyNGQzNy4uOTgxOTE3NThi MDY3NTI1MzJmNjE1MmUwMDIxMjM5NmFiZjdmY2NkYSAxMDA2NDQKLS0tIGEvU291cmNlL1dlYkNv cmUvcmVuZGVyaW5nL1JlbmRlck9iamVjdC5jcHAKKysrIGIvU291cmNlL1dlYkNvcmUvcmVuZGVy aW5nL1JlbmRlck9iamVjdC5jcHAKQEAgLTEyNiw3ICsxMjYsNyBAQCBDT01QSUxFX0FTU0VSVChz aXplb2YoUmVuZGVyT2JqZWN0KSA9PSBzaXplb2YoU2FtZVNpemVBc1JlbmRlck9iamVjdCksIFJl bmRlck9iagogLy8gaWdub3JlIHRoZSBDU1MgcHJvcGVydHkgImJhY2tncm91bmQtYXR0YWNobWVu dDogZml4ZWQiLgogc3RhdGljIGJvb2wgc2hvdWxkUmVwYWludEZpeGVkQmFja2dyb3VuZHNPblNj cm9sbChGcmFtZVZpZXcqIGZyYW1lVmlldykKIHsKLSNpZiAhRU5BQkxFKEZBU1RfTU9CSUxFX1ND Uk9MTElORykgJiYgIVBMQVRGT1JNKFFUKQorI2lmICFFTkFCTEUoRkFTVF9NT0JJTEVfU0NST0xM SU5HKSB8fCAhUExBVEZPUk0oUVQpCiAgICAgVU5VU0VEX1BBUkFNKGZyYW1lVmlldyk7CiAjZW5k aWYKIAo=