119708 2013-08-12 17:23:46 -0700 Remove CodeBlock's notion of adding identifiers entirely 2013-08-12 17:27:49 -0700 1 1 1 Unclassified WebKit New Bugs 528+ (Nightly build) Unspecified Unspecified RESOLVED FIXED P2 Normal --- 1 oliver oliver oldest_to_newest 916455 0 oliver 2013-08-12 17:23:46 -0700 Remove CodeBlock's notion of adding identifiers entirely 916456 1 208574 oliver 2013-08-12 17:24:55 -0700 Created attachment 208574 Patch 916457 2 208574 ggaren 2013-08-12 17:25:47 -0700 Comment on attachment 208574 Patch r=me 916458 3 oliver 2013-08-12 17:27:49 -0700 Committed r153967: <http://trac.webkit.org/changeset/153967> 208574 2013-08-12 17:24:55 -0700 2013-08-12 17:25:46 -0700 Patch bug-119708-20130812172752.patch text/plain 4708 oliver U3VidmVyc2lvbiBSZXZpc2lvbjogMTUzOTY1CmRpZmYgLS1naXQgYS9Tb3VyY2UvSmF2YVNjcmlw dENvcmUvQ2hhbmdlTG9nIGIvU291cmNlL0phdmFTY3JpcHRDb3JlL0NoYW5nZUxvZwppbmRleCBl YzlhMTk3ZWExYTJhZjI2YjU0MTc1YmQ1ZTBiNTc5MWU4MmQ0MTExLi4xMjQ5MDBkMTc1ZWMzZWZi NzNkMjIyODhhYTdkYjljNzFiYTQyNzdiIDEwMDY0NAotLS0gYS9Tb3VyY2UvSmF2YVNjcmlwdENv cmUvQ2hhbmdlTG9nCisrKyBiL1NvdXJjZS9KYXZhU2NyaXB0Q29yZS9DaGFuZ2VMb2cKQEAgLTEs NSArMSwyNCBAQAogMjAxMy0wOC0xMiAgT2xpdmVyIEh1bnQgIDxvbGl2ZXJAYXBwbGUuY29tPgog CisgICAgICAgIFJlbW92ZSBDb2RlQmxvY2sncyBub3Rpb24gb2YgYWRkaW5nIGlkZW50aWZpZXJz IGVudGlyZWx5CisgICAgICAgIGh0dHBzOi8vYnVncy53ZWJraXQub3JnL3Nob3dfYnVnLmNnaT9p ZD0xMTk3MDgKKworICAgICAgICBSZXZpZXdlZCBieSBOT0JPRFkgKE9PUFMhKS4KKworICAgICAg ICBSZW1vdmUgYWRkQWRkaXRpb25hbElkZW50aWZpZXIgZW50aXJlbHksIGluY2x1ZGluZyB0aGUg Ym9ndXMgYXNzZXJ0aW9uLgorICAgICAgICBNb3ZlIHRoZSBhZGRpdGlvbiBvZiBpZGVudGlmaWVy cyB0byBERkdQbGFuOjpyZWFsbHlBZGQKKworICAgICAgICAqIGJ5dGVjb2RlL0NvZGVCbG9jay5o OgorICAgICAgICAqIGRmZy9ERkdEZXNpcmVkSWRlbnRpZmllcnMuY3BwOgorICAgICAgICAoSlND OjpERkc6OkRlc2lyZWRJZGVudGlmaWVyczo6cmVhbGx5QWRkKToKKyAgICAgICAgKiBkZmcvREZH RGVzaXJlZElkZW50aWZpZXJzLmg6CisgICAgICAgICogZGZnL0RGR1BsYW4uY3BwOgorICAgICAg ICAoSlNDOjpERkc6OlBsYW46OnJlYWxseUFkZCk6CisgICAgICAgIChKU0M6OkRGRzo6UGxhbjo6 ZmluYWxpemUpOgorICAgICAgICAqIGRmZy9ERkdQbGFuLmg6CisKKzIwMTMtMDgtMTIgIE9saXZl ciBIdW50ICA8b2xpdmVyQGFwcGxlLmNvbT4KKwogICAgICAgICBCdWlsZCBmaXgKIAogICAgICAg ICAqIHJ1bnRpbWUvSlNDZWxsLmg6CmRpZmYgLS1naXQgYS9Tb3VyY2UvSmF2YVNjcmlwdENvcmUv Ynl0ZWNvZGUvQ29kZUJsb2NrLmggYi9Tb3VyY2UvSmF2YVNjcmlwdENvcmUvYnl0ZWNvZGUvQ29k ZUJsb2NrLmgKaW5kZXggZDg5M2E3YjExNzk5MjhmNGE0NDhkYTQ2N2QyYzliNzYzMDc2ZmNhMS4u YTA1MGUwNDZiNGZlYzNjMTg1NmI2M2ExMzA4NmE3MzgyNTUyZGVmMCAxMDA2NDQKLS0tIGEvU291 cmNlL0phdmFTY3JpcHRDb3JlL2J5dGVjb2RlL0NvZGVCbG9jay5oCisrKyBiL1NvdXJjZS9KYXZh U2NyaXB0Q29yZS9ieXRlY29kZS9Db2RlQmxvY2suaApAQCAtNjY0LDEyICs2NjQsNiBAQCBwdWJs aWM6CiAgICAgICAgIHJldHVybiBtX2ppdENvZGUtPmRmZ0NvbW1vbigpLT5kZmdJZGVudGlmaWVy cy5zaXplKCk7CiAgICAgfQogCi0gICAgdm9pZCBhZGRBZGRpdGlvbmFsSWRlbnRpZmllcihjb25z dCBJZGVudGlmaWVyJiBpKQotICAgIHsKLSAgICAgICAgQVNTRVJUKEpJVENvZGU6OmlzT3B0aW1p emluZ0pJVChqaXRUeXBlKCkpKTsKLSAgICAgICAgcmV0dXJuIG1faml0Q29kZS0+ZGZnQ29tbW9u KCktPmRmZ0lkZW50aWZpZXJzLmFwcGVuZChpKTsKLSAgICB9Ci0KICAgICBjb25zdCBJZGVudGlm aWVyJiBpZGVudGlmaWVyKGludCBpbmRleCkgY29uc3QKICAgICB7CiAgICAgICAgIHNpemVfdCB1 bmxpbmtlZElkZW50aWZpZXJzID0gbV91bmxpbmtlZENvZGUtPm51bWJlck9mSWRlbnRpZmllcnMo KTsKZGlmZiAtLWdpdCBhL1NvdXJjZS9KYXZhU2NyaXB0Q29yZS9kZmcvREZHRGVzaXJlZElkZW50 aWZpZXJzLmNwcCBiL1NvdXJjZS9KYXZhU2NyaXB0Q29yZS9kZmcvREZHRGVzaXJlZElkZW50aWZp ZXJzLmNwcAppbmRleCAyNzdhZmY0MTk5ZjBmZjVkNzkwZDg4MDg2N2FhN2RiZDdhMjlmN2QxLi5m NjU4N2Y0N2YwNDkxZGU1ODQ2N2M0NzM2NGU2NTFlN2ZjNjQ3NjQ4IDEwMDY0NAotLS0gYS9Tb3Vy Y2UvSmF2YVNjcmlwdENvcmUvZGZnL0RGR0Rlc2lyZWRJZGVudGlmaWVycy5jcHAKKysrIGIvU291 cmNlL0phdmFTY3JpcHRDb3JlL2RmZy9ERkdEZXNpcmVkSWRlbnRpZmllcnMuY3BwCkBAIC02Miwx MiArNjIsMTIgQEAgU3RyaW5nSW1wbCogRGVzaXJlZElkZW50aWZpZXJzOjphdCh1bnNpZ25lZCBp bmRleCkgY29uc3QKICAgICByZXR1cm4gcmVzdWx0OwogfQogCi12b2lkIERlc2lyZWRJZGVudGlm aWVyczo6cmVhbGx5QWRkKFZNJiB2bSkKK3ZvaWQgRGVzaXJlZElkZW50aWZpZXJzOjpyZWFsbHlB ZGQoVk0mIHZtLCBDb21tb25EYXRhKiBjb21tb25EYXRhKQogewogICAgIGZvciAodW5zaWduZWQg aSA9IDA7IGkgPCBtX2FkZGVkSWRlbnRpZmllcnMuc2l6ZSgpOyArK2kpIHsKICAgICAgICAgU3Ry aW5nSW1wbCogcmVwID0gbV9hZGRlZElkZW50aWZpZXJzW2ldOwogICAgICAgICBBU1NFUlQocmVw LT5oYXNBdExlYXN0T25lUmVmKCkpOwotICAgICAgICBtX2NvZGVCbG9jay0+YWRkQWRkaXRpb25h bElkZW50aWZpZXIoSWRlbnRpZmllcigmdm0sIHJlcCkpOworICAgICAgICBjb21tb25EYXRhLT5k ZmdJZGVudGlmaWVycy5hcHBlbmQoSWRlbnRpZmllcigmdm0sIHJlcCkpOwogICAgIH0KIH0KIApk aWZmIC0tZ2l0IGEvU291cmNlL0phdmFTY3JpcHRDb3JlL2RmZy9ERkdEZXNpcmVkSWRlbnRpZmll cnMuaCBiL1NvdXJjZS9KYXZhU2NyaXB0Q29yZS9kZmcvREZHRGVzaXJlZElkZW50aWZpZXJzLmgK aW5kZXggYjJkNzkwYjMyZDllZWZkN2EyMTRmODkyZmExMDY3ZTgyMWU4NTI5Yy4uYTQxZjIzMGIz NjYwNThkMWRjNjdhYWQwYzZlMzU5NTNmY2NkMzNlNSAxMDA2NDQKLS0tIGEvU291cmNlL0phdmFT Y3JpcHRDb3JlL2RmZy9ERkdEZXNpcmVkSWRlbnRpZmllcnMuaAorKysgYi9Tb3VyY2UvSmF2YVNj cmlwdENvcmUvZGZnL0RGR0Rlc2lyZWRJZGVudGlmaWVycy5oCkBAIC0zOCw2ICszOCw4IEBAIGNs YXNzIENvZGVCbG9jazsKIAogbmFtZXNwYWNlIERGRyB7CiAKK2NsYXNzIENvbW1vbkRhdGE7CisK IGNsYXNzIERlc2lyZWRJZGVudGlmaWVycyB7CiBwdWJsaWM6CiAgICAgRGVzaXJlZElkZW50aWZp ZXJzKENvZGVCbG9jayopOwpAQCAtNTAsNyArNTIsNyBAQCBwdWJsaWM6CiAgICAgCiAgICAgU3Ry aW5nSW1wbCogb3BlcmF0b3JbXSh1bnNpZ25lZCBpbmRleCkgY29uc3QgeyByZXR1cm4gYXQoaW5k ZXgpOyB9CiAgICAgCi0gICAgdm9pZCByZWFsbHlBZGQoVk0mKTsKKyAgICB2b2lkIHJlYWxseUFk ZChWTSYsIENvbW1vbkRhdGEqKTsKICAgICAKIHByaXZhdGU6CiAgICAgQ29kZUJsb2NrKiBtX2Nv ZGVCbG9jazsKZGlmZiAtLWdpdCBhL1NvdXJjZS9KYXZhU2NyaXB0Q29yZS9kZmcvREZHUGxhbi5j cHAgYi9Tb3VyY2UvSmF2YVNjcmlwdENvcmUvZGZnL0RGR1BsYW4uY3BwCmluZGV4IDY4ZGE4MGI0 OWQ5MzVjNDBiODc1ZDNlMjliMWFkODU1NDlmMmQyMDguLmI0ODAxODAxNjE2NDMwZGMyZWJhYTY4 MWM3N2YyODgyN2FlMmY5NjIgMTAwNjQ0Ci0tLSBhL1NvdXJjZS9KYXZhU2NyaXB0Q29yZS9kZmcv REZHUGxhbi5jcHAKKysrIGIvU291cmNlL0phdmFTY3JpcHRDb3JlL2RmZy9ERkdQbGFuLmNwcApA QCAtMjcxLDEwICsyNzEsMTAgQEAgYm9vbCBQbGFuOjppc1N0aWxsVmFsaWQoKQogICAgICAgICAm JiBjaGFpbnMuYXJlU3RpbGxWYWxpZCgpOwogfQogCi12b2lkIFBsYW46OnJlYWxseUFkZCgpCit2 b2lkIFBsYW46OnJlYWxseUFkZChDb21tb25EYXRhKiBjb21tb25EYXRhKQogewogICAgIHdhdGNo cG9pbnRzLnJlYWxseUFkZCgpOwotICAgIGlkZW50aWZpZXJzLnJlYWxseUFkZCh2bSk7CisgICAg aWRlbnRpZmllcnMucmVhbGx5QWRkKHZtLCBjb21tb25EYXRhKTsKIH0KIAogQ29tcGlsYXRpb25S ZXN1bHQgUGxhbjo6ZmluYWxpemUoUmVmUHRyPEpTQzo6SklUQ29kZT4mIGppdENvZGUsIE1hY3Jv QXNzZW1ibGVyQ29kZVB0ciogaml0Q29kZVdpdGhBcml0eUNoZWNrKQpAQCAtMjkxLDcgKzI5MSw3 IEBAIENvbXBpbGF0aW9uUmVzdWx0IFBsYW46OmZpbmFsaXplKFJlZlB0cjxKU0M6OkpJVENvZGU+ JiBqaXRDb2RlLCBNYWNyb0Fzc2VtYmxlckNvCiAgICAgaWYgKCFyZXN1bHQpCiAgICAgICAgIHJl dHVybiBDb21waWxhdGlvbkZhaWxlZDsKICAgICAKLSAgICByZWFsbHlBZGQoKTsKKyAgICByZWFs bHlBZGQoaml0Q29kZS0+ZGZnQ29tbW9uKCkpOwogICAgIAogICAgIHJldHVybiBDb21waWxhdGlv blN1Y2Nlc3NmdWw7CiB9CmRpZmYgLS1naXQgYS9Tb3VyY2UvSmF2YVNjcmlwdENvcmUvZGZnL0RG R1BsYW4uaCBiL1NvdXJjZS9KYXZhU2NyaXB0Q29yZS9kZmcvREZHUGxhbi5oCmluZGV4IDQ0M2Vl ZWI0ZjZkMjNhMjRmODEwY2U4ZWViODFlNjMxY2ViOWM4ZGEuLmFlMGJjMWQyMTdiZTgzMTA3MGE3 YzcxYjU2ZTVjMWVjMDk2NGJjMDIgMTAwNjQ0Ci0tLSBhL1NvdXJjZS9KYXZhU2NyaXB0Q29yZS9k ZmcvREZHUGxhbi5oCisrKyBiL1NvdXJjZS9KYXZhU2NyaXB0Q29yZS9kZmcvREZHUGxhbi5oCkBA IC04NSw3ICs4NSw3IEBAIHByaXZhdGU6CiAgICAgQ29tcGlsYXRpb25QYXRoIGNvbXBpbGVJblRo cmVhZEltcGwoTG9uZ0xpdmVkU3RhdGUmKTsKICAgICAKICAgICBib29sIGlzU3RpbGxWYWxpZCgp OwotICAgIHZvaWQgcmVhbGx5QWRkKCk7CisgICAgdm9pZCByZWFsbHlBZGQoQ29tbW9uRGF0YSop OwogfTsKIAogI2Vsc2UgLy8gRU5BQkxFKERGR19KSVQpCg==