119705 2013-08-12 16:21:30 -0700 Move additionalIdentifiers into DFGCommonData as only the optimising JITs use them 2013-08-12 16:40:19 -0700 1 1 1 Unclassified WebKit New Bugs 528+ (Nightly build) Unspecified Unspecified RESOLVED FIXED P2 Normal --- 1 oliver oliver oldest_to_newest 916441 0 oliver 2013-08-12 16:21:30 -0700 Move additionalIdentifiers into DFGCommonData as only the optimising JITs use them 916442 1 208571 oliver 2013-08-12 16:21:57 -0700 Created attachment 208571 Patch 916447 2 208571 ggaren 2013-08-12 16:34:30 -0700 Comment on attachment 208571 Patch View in context: https://bugs.webkit.org/attachment.cgi?id=208571&action=review r=me > Source/JavaScriptCore/bytecode/CodeBlock.h:659 > + size_t numberOfAdditionalIdentifiers() const dfgIdentifiers would be nice in this name, too. 916449 3 oliver 2013-08-12 16:40:19 -0700 Committed r153963: <http://trac.webkit.org/changeset/153963> 208571 2013-08-12 16:21:57 -0700 2013-08-12 16:34:30 -0700 Patch bug-119705-20130812162454.patch text/plain 3566 oliver U3VidmVyc2lvbiBSZXZpc2lvbjogMTUzOTYyCmRpZmYgLS1naXQgYS9Tb3VyY2UvSmF2YVNjcmlw dENvcmUvQ2hhbmdlTG9nIGIvU291cmNlL0phdmFTY3JpcHRDb3JlL0NoYW5nZUxvZwppbmRleCA3 MWJmNGYwYjQ4YTc2MjZhZGUyYTM0MzlkM2M4NWNkMjZlNDJkMmJkLi5mYWNlYWZhMjAyMjE4OTUy YjY2ODU5YWJmODkxOGFhNDI5ZGU4MTI4IDEwMDY0NAotLS0gYS9Tb3VyY2UvSmF2YVNjcmlwdENv cmUvQ2hhbmdlTG9nCisrKyBiL1NvdXJjZS9KYXZhU2NyaXB0Q29yZS9DaGFuZ2VMb2cKQEAgLTEs NSArMSwyMSBAQAogMjAxMy0wOC0xMiAgT2xpdmVyIEh1bnQgIDxvbGl2ZXJAYXBwbGUuY29tPgog CisgICAgICAgIE1vdmUgYWRkaXRpb25hbElkZW50aWZpZXJzIGludG8gREZHQ29tbW9uRGF0YSBh cyBvbmx5IHRoZSBvcHRpbWlzaW5nIEpJVHMgdXNlIHRoZW0KKyAgICAgICAgaHR0cHM6Ly9idWdz LndlYmtpdC5vcmcvc2hvd19idWcuY2dpP2lkPTExOTcwNQorCisgICAgICAgIFJldmlld2VkIGJ5 IE5PQk9EWSAoT09QUyEpLgorCisgICAgICAgIFJlbGF0aXZlbHkgdHJpdmlhbCByZWZhY3Rvcmlu ZworCisgICAgICAgICogYnl0ZWNvZGUvQ29kZUJsb2NrLmg6CisgICAgICAgIChKU0M6OkNvZGVC bG9jazo6bnVtYmVyT2ZBZGRpdGlvbmFsSWRlbnRpZmllcnMpOgorICAgICAgICAoSlNDOjpDb2Rl QmxvY2s6OmFkZEFkZGl0aW9uYWxJZGVudGlmaWVyKToKKyAgICAgICAgKEpTQzo6Q29kZUJsb2Nr OjppZGVudGlmaWVyKToKKyAgICAgICAgKEpTQzo6Q29kZUJsb2NrOjpudW1iZXJPZklkZW50aWZp ZXJzKToKKyAgICAgICAgKiBkZmcvREZHQ29tbW9uRGF0YS5oOgorCisyMDEzLTA4LTEyICBPbGl2 ZXIgSHVudCAgPG9saXZlckBhcHBsZS5jb20+CisKICAgICAgICAgU3RvcCBtYWtpbmcgdW5uZWNl c3NhcnkgY29weSBvZiBDb2RlQmxvY2sgSWRlbnRpZmllciBWZWN0b3IKICAgICAgICAgaHR0cHM6 Ly9idWdzLndlYmtpdC5vcmcvc2hvd19idWcuY2dpP2lkPTExOTcwMgogCmRpZmYgLS1naXQgYS9T b3VyY2UvSmF2YVNjcmlwdENvcmUvYnl0ZWNvZGUvQ29kZUJsb2NrLmggYi9Tb3VyY2UvSmF2YVNj cmlwdENvcmUvYnl0ZWNvZGUvQ29kZUJsb2NrLmgKaW5kZXggODcxYWY2Y2M0M2E0YmJjMjZlNmQ0 Zjc3MjMxNjMxMjA5YzBiYmIxMS4uMGJkNzE0N2JjYTVkZTY4YWI2MjY2ZDYwNmYzZTc4OTFhZGEx MjJmOSAxMDA2NDQKLS0tIGEvU291cmNlL0phdmFTY3JpcHRDb3JlL2J5dGVjb2RlL0NvZGVCbG9j ay5oCisrKyBiL1NvdXJjZS9KYXZhU2NyaXB0Q29yZS9ieXRlY29kZS9Db2RlQmxvY2suaApAQCAt NjU0LDE3ICs2NTQsMzQgQEAgcHVibGljOgogI2VuZGlmCiAKICAgICAvLyBDb25zdGFudCBQb29s Ci0KKyNpZiBFTkFCTEUoREZHX0pJVCkKICAgICBzaXplX3QgbnVtYmVyT2ZJZGVudGlmaWVycygp IGNvbnN0IHsgcmV0dXJuIG1fdW5saW5rZWRDb2RlLT5udW1iZXJPZklkZW50aWZpZXJzKCkgKyBu dW1iZXJPZkFkZGl0aW9uYWxJZGVudGlmaWVycygpOyB9Ci0gICAgc2l6ZV90IG51bWJlck9mQWRk aXRpb25hbElkZW50aWZpZXJzKCkgY29uc3QgeyByZXR1cm4gbV9hZGRpdGlvbmFsSWRlbnRpZmll cnMuc2l6ZSgpOyB9Ci0gICAgdm9pZCBhZGRBZGRpdGlvbmFsSWRlbnRpZmllcihjb25zdCBJZGVu dGlmaWVyJiBpKSB7IHJldHVybiBtX2FkZGl0aW9uYWxJZGVudGlmaWVycy5hcHBlbmQoaSk7IH0K KyAgICBzaXplX3QgbnVtYmVyT2ZBZGRpdGlvbmFsSWRlbnRpZmllcnMoKSBjb25zdAorICAgIHsK KyAgICAgICAgaWYgKCFKSVRDb2RlOjppc09wdGltaXppbmdKSVQoaml0VHlwZSgpKSkKKyAgICAg ICAgICAgIHJldHVybiAwOworCisgICAgICAgIHJldHVybiBtX2ppdENvZGUtPmRmZ0NvbW1vbigp LT5kZmdJZGVudGlmaWVycy5zaXplKCk7CisgICAgfQorCisgICAgdm9pZCBhZGRBZGRpdGlvbmFs SWRlbnRpZmllcihjb25zdCBJZGVudGlmaWVyJiBpKQorICAgIHsKKyAgICAgICAgQVNTRVJUKEpJ VENvZGU6OmlzT3B0aW1pemluZ0pJVChqaXRUeXBlKCkpKTsKKyAgICAgICAgcmV0dXJuIG1faml0 Q29kZS0+ZGZnQ29tbW9uKCktPmRmZ0lkZW50aWZpZXJzLmFwcGVuZChpKTsKKyAgICB9CisKICAg ICBjb25zdCBJZGVudGlmaWVyJiBpZGVudGlmaWVyKGludCBpbmRleCkgY29uc3QKICAgICB7CiAg ICAgICAgIHNpemVfdCB1bmxpbmtlZElkZW50aWZpZXJzID0gbV91bmxpbmtlZENvZGUtPm51bWJl ck9mSWRlbnRpZmllcnMoKTsKICAgICAgICAgaWYgKHN0YXRpY19jYXN0PHVuc2lnbmVkPihpbmRl eCkgPCB1bmxpbmtlZElkZW50aWZpZXJzKQogICAgICAgICAgICAgcmV0dXJuIG1fdW5saW5rZWRD b2RlLT5pZGVudGlmaWVyKGluZGV4KTsKLSAgICAgICAgcmV0dXJuIG1fYWRkaXRpb25hbElkZW50 aWZpZXJzW2luZGV4IC0gdW5saW5rZWRJZGVudGlmaWVyc107CisgICAgICAgIEFTU0VSVChKSVRD b2RlOjppc09wdGltaXppbmdKSVQoaml0VHlwZSgpKSk7CisgICAgICAgIHJldHVybiBtX2ppdENv ZGUtPmRmZ0NvbW1vbigpLT5kZmdJZGVudGlmaWVyc1tpbmRleCAtIHVubGlua2VkSWRlbnRpZmll cnNdOwogICAgIH0KKyNlbHNlCisgICAgc2l6ZV90IG51bWJlck9mSWRlbnRpZmllcnMoKSBjb25z dCB7IHJldHVybiBtX3VubGlua2VkQ29kZS0+bnVtYmVyT2ZJZGVudGlmaWVycygpOyB9CisgICAg Y29uc3QgSWRlbnRpZmllciYgaWRlbnRpZmllcihpbnQgaW5kZXgpIGNvbnN0IHsgcmV0dXJuIG1f dW5saW5rZWRDb2RlLT5pZGVudGlmaWVyKGluZGV4KTsgfQorI2VuZGlmCiAKICAgICBzaXplX3Qg bnVtYmVyT2ZDb25zdGFudFJlZ2lzdGVycygpIGNvbnN0IHsgcmV0dXJuIG1fY29uc3RhbnRSZWdp c3RlcnMuc2l6ZSgpOyB9CiAgICAgdW5zaWduZWQgYWRkQ29uc3RhbnQoSlNWYWx1ZSB2KQpkaWZm IC0tZ2l0IGEvU291cmNlL0phdmFTY3JpcHRDb3JlL2RmZy9ERkdDb21tb25EYXRhLmggYi9Tb3Vy Y2UvSmF2YVNjcmlwdENvcmUvZGZnL0RGR0NvbW1vbkRhdGEuaAppbmRleCBhYmY1MGZkZWFiMWVk NDE3MzJhNTM3ZTI2MWQ5ZDI5OTZjMDk0MmU3Li5mMWNmYmI0NGZhN2M0YTI5ZDJkOTU3NWI3MDc5 MDkzMmU0NDRjOGE0IDEwMDY0NAotLS0gYS9Tb3VyY2UvSmF2YVNjcmlwdENvcmUvZGZnL0RGR0Nv bW1vbkRhdGEuaAorKysgYi9Tb3VyY2UvSmF2YVNjcmlwdENvcmUvZGZnL0RGR0NvbW1vbkRhdGEu aApAQCAtMzcsNiArMzcsNyBAQAogbmFtZXNwYWNlIEpTQyB7CiAKIGNsYXNzIENvZGVCbG9jazsK K2NsYXNzIElkZW50aWZpZXI7CiAKIG5hbWVzcGFjZSBERkcgewogCkBAIC03Myw3ICs3NCw4IEBA IHB1YmxpYzoKICAgICB2b2lkIG5vdGlmeUNvbXBpbGluZ1N0cnVjdHVyZVRyYW5zaXRpb24oQ29k ZUJsb2NrKiwgTm9kZSopOwogICAgIAogICAgIHZvaWQgc2hyaW5rVG9GaXQoKTsKLSAgICAKKwor ICAgIFZlY3RvcjxJZGVudGlmaWVyPiBkZmdJZGVudGlmaWVyczsKICAgICBWZWN0b3I8V2Vha1Jl ZmVyZW5jZVRyYW5zaXRpb24+IHRyYW5zaXRpb25zOwogICAgIFZlY3RvcjxXcml0ZUJhcnJpZXI8 SlNDZWxsPiA+IHdlYWtSZWZlcmVuY2VzOwogICAgIAo=