119692 2013-08-12 10:51:19 -0700 Multiple CSP tests complain about undefined strings in echo-object-data.pl and echo-script-src.pl 2013-08-12 12:23:52 -0700 1 1 1 Unclassified WebKit Tools / Tests 528+ (Nightly build) Unspecified Unspecified RESOLVED FIXED P2 Normal --- 1 ap ap commit-queue mkwst oldest_to_newest 916340 0 ap 2013-08-12 10:51:19 -0700 Comparing $cgi->param('nonce') to a string without checking if it's provided at all. 916346 1 208550 ap 2013-08-12 11:00:32 -0700 Created attachment 208550 proposed fix 916365 2 208550 commit-queue 2013-08-12 12:23:51 -0700 Comment on attachment 208550 proposed fix Clearing flags on attachment: 208550 Committed r153953: <http://trac.webkit.org/changeset/153953> 916366 3 commit-queue 2013-08-12 12:23:52 -0700 All reviewed patches have been landed. Closing bug. 208550 2013-08-12 11:00:32 -0700 2013-08-12 12:23:50 -0700 proposed fix UninitializedCGI.txt text/plain 3778 ap SW5kZXg6IExheW91dFRlc3RzL0NoYW5nZUxvZwo9PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09Ci0tLSBMYXlvdXRUZXN0cy9D aGFuZ2VMb2cJKHJldmlzaW9uIDE1Mzk1MCkKKysrIExheW91dFRlc3RzL0NoYW5nZUxvZwkod29y a2luZyBjb3B5KQpAQCAtMSwzICsxLDE0IEBACisyMDEzLTA4LTEyICBBbGV4ZXkgUHJvc2t1cnlh a292ICA8YXBAYXBwbGUuY29tPgorCisgICAgICAgIE11bHRpcGxlIENTUCB0ZXN0cyBjb21wbGFp biBhYm91dCB1bmRlZmluZWQgc3RyaW5ncyBpbiBlY2hvLW9iamVjdC1kYXRhLnBsIGFuZCBlY2hv LXNjcmlwdC1zcmMucGwKKyAgICAgICAgaHR0cHM6Ly9idWdzLndlYmtpdC5vcmcvc2hvd19idWcu Y2dpP2lkPTExOTY5MgorCisgICAgICAgIFJldmlld2VkIGJ5IE5PQk9EWSAoT09QUyEpLgorCisg ICAgICAgICogaHR0cC90ZXN0cy9zZWN1cml0eS9jb250ZW50U2VjdXJpdHlQb2xpY3kvcmVzb3Vy Y2VzL2VjaG8tb2JqZWN0LWRhdGEucGw6CisgICAgICAgICogaHR0cC90ZXN0cy9zZWN1cml0eS9j b250ZW50U2VjdXJpdHlQb2xpY3kvcmVzb3VyY2VzL2VjaG8tc2NyaXB0LXNyYy5wbDoKKyAgICAg ICAgQ2hlY2sgd2hldGhlciBvcHRpb25hbCBDR0kgcGFyYW1ldGVycyBhcmUgcHJvdmlkZWQuCisK IDIwMTMtMDgtMTIgIERlYW4gSmFja3NvbiAgPGRpbm9AYXBwbGUuY29tPgogCiAgICAgICAgIFNo YWRvd3MgZG9uJ3Qgc3VwcG9ydCB2aWV3cG9ydCB1bml0cwpJbmRleDogTGF5b3V0VGVzdHMvaHR0 cC90ZXN0cy9zZWN1cml0eS9jb250ZW50U2VjdXJpdHlQb2xpY3kvcmVzb3VyY2VzL2VjaG8tb2Jq ZWN0LWRhdGEucGwKPT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PQotLS0gTGF5b3V0VGVzdHMvaHR0cC90ZXN0cy9zZWN1cml0 eS9jb250ZW50U2VjdXJpdHlQb2xpY3kvcmVzb3VyY2VzL2VjaG8tb2JqZWN0LWRhdGEucGwJKHJl dmlzaW9uIDE1Mzk0NCkKKysrIExheW91dFRlc3RzL2h0dHAvdGVzdHMvc2VjdXJpdHkvY29udGVu dFNlY3VyaXR5UG9saWN5L3Jlc291cmNlcy9lY2hvLW9iamVjdC1kYXRhLnBsCSh3b3JraW5nIGNv cHkpCkBAIC01LDE5ICs1LDIwIEBAIHVzZSBDR0k7CiBteSAkY2dpID0gbmV3IENHSTsKIAogcHJp bnQgIkNvbnRlbnQtVHlwZTogdGV4dC9odG1sOyBjaGFyc2V0PVVURi04XG4iOwotaWYgKCRjZ2kt PnBhcmFtKCdleHBlcmltZW50YWwnKSBlcSAndHJ1ZScpIHsKLSAgICBwcmludCAiWC1XZWJLaXQt Q1NQOiAiLiRjZ2ktPnBhcmFtKCdjc3AnKS4iXG5cbiI7CitteSAkZXhwZXJpbWVudGFsID0gJGNn aS0+cGFyYW0oJ2V4cGVyaW1lbnRhbCcpIHx8ICIiOworaWYgKCRleHBlcmltZW50YWwgZXEgJ3Ry dWUnKSB7CisgICAgcHJpbnQgIlgtV2ViS2l0LUNTUDogIiAuICRjZ2ktPnBhcmFtKCdjc3AnKSAu ICJcblxuIjsKIH0gZWxzZSB7Ci0gICAgcHJpbnQgIkNvbnRlbnQtU2VjdXJpdHktUG9saWN5OiAi LiRjZ2ktPnBhcmFtKCdjc3AnKS4iXG5cbiI7CisgICAgcHJpbnQgIkNvbnRlbnQtU2VjdXJpdHkt UG9saWN5OiAiIC4gJGNnaS0+cGFyYW0oJ2NzcCcpIC4gIlxuXG4iOwogfQogCiBwcmludCAiPCFE T0NUWVBFIGh0bWw+XG4iOwogcHJpbnQgIjxodG1sPlxuIjsKIHByaW50ICI8Ym9keT5cbiI7CiBw cmludCAiPHNjcmlwdCBzcmM9XCIvcGx1Z2lucy9yZXNvdXJjZXMvbW9jay1wbHVnaW4tbG9nZ2Vy LmpzXCI+PC9zY3JpcHQ+XG4iOwotcHJpbnQgIjxvYmplY3QgZGF0YT1cIiIuJGNnaS0+cGFyYW0o J3BsdWdpbicpLiJcIlxuIjsKLXByaW50ICIgICAgICAgIGxvZz1cIiIuJGNnaS0+cGFyYW0oJ2xv ZycpLiJcIlxuIiBpZiAkY2dpLT5wYXJhbSgnbG9nJyk7Ci1wcmludCAiICAgICAgICB0eXBlPVwi Ii4kY2dpLT5wYXJhbSgndHlwZScpLiJcIlxuIiBpZiAkY2dpLT5wYXJhbSgndHlwZScpOworcHJp bnQgIjxvYmplY3QgZGF0YT1cIiIgLiAkY2dpLT5wYXJhbSgncGx1Z2luJykgLiAiXCJcbiI7Citw cmludCAiICAgICAgICBsb2c9XCIiIC4gJGNnaS0+cGFyYW0oJ2xvZycpIC4gIlwiXG4iIGlmICRj Z2ktPnBhcmFtKCdsb2cnKTsKK3ByaW50ICIgICAgICAgIHR5cGU9XCIiIC4gJGNnaS0+cGFyYW0o J3R5cGUnKSAuICJcIlxuIiBpZiAkY2dpLT5wYXJhbSgndHlwZScpOwogcHJpbnQgIj48L29iamVj dD5cbiI7CiBwcmludCAiPC9ib2R5PlxuIjsKIHByaW50ICI8L2h0bWw+XG4iOwpJbmRleDogTGF5 b3V0VGVzdHMvaHR0cC90ZXN0cy9zZWN1cml0eS9jb250ZW50U2VjdXJpdHlQb2xpY3kvcmVzb3Vy Y2VzL2VjaG8tc2NyaXB0LXNyYy5wbAo9PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09Ci0tLSBMYXlvdXRUZXN0cy9odHRwL3Rl c3RzL3NlY3VyaXR5L2NvbnRlbnRTZWN1cml0eVBvbGljeS9yZXNvdXJjZXMvZWNoby1zY3JpcHQt c3JjLnBsCShyZXZpc2lvbiAxNTM5NDQpCisrKyBMYXlvdXRUZXN0cy9odHRwL3Rlc3RzL3NlY3Vy aXR5L2NvbnRlbnRTZWN1cml0eVBvbGljeS9yZXNvdXJjZXMvZWNoby1zY3JpcHQtc3JjLnBsCSh3 b3JraW5nIGNvcHkpCkBAIC01LDE4ICs1LDE5IEBAIHVzZSBDR0k7CiBteSAkY2dpID0gbmV3IENH STsKIAogcHJpbnQgIkNvbnRlbnQtVHlwZTogdGV4dC9odG1sOyBjaGFyc2V0PVVURi04XG4iOwot aWYgKCRjZ2ktPnBhcmFtKCdleHBlcmltZW50YWwnKSBlcSAndHJ1ZScpIHsKLSAgICBwcmludCAi WC1XZWJLaXQtQ1NQOiAiLiRjZ2ktPnBhcmFtKCdjc3AnKS4iXG5cbiI7CitteSAkZXhwZXJpbWVu dGFsID0gJGNnaS0+cGFyYW0oJ2V4cGVyaW1lbnRhbCcpIHx8ICIiOworaWYgKCRleHBlcmltZW50 YWwgZXEgJ3RydWUnKSB7CisgICAgcHJpbnQgIlgtV2ViS2l0LUNTUDogIiAuICRjZ2ktPnBhcmFt KCdjc3AnKSAuICJcblxuIjsKIH0gZWxzZSB7Ci0gICAgcHJpbnQgIkNvbnRlbnQtU2VjdXJpdHkt UG9saWN5OiAiLiRjZ2ktPnBhcmFtKCdjc3AnKS4iXG5cbiI7CisgICAgcHJpbnQgIkNvbnRlbnQt U2VjdXJpdHktUG9saWN5OiAiIC4gJGNnaS0+cGFyYW0oJ2NzcCcpIC4gIlxuXG4iOwogfQogCiBt eSAoJHRleHQsICRyZXBsYWNlbWVudCkgPSAoIkZBSUwiLCAiUEFTUyIpOwogKCR0ZXh0LCAkcmVw bGFjZW1lbnQpID0gKCRyZXBsYWNlbWVudCwgJHRleHQpIGlmICRjZ2ktPnBhcmFtKCdzaG91bGRf cnVuJykgZXEgJ25vJzsKIAotbXkgJG5vbmNlID0gIiI7Ci1pZiAoJGNnaS0+cGFyYW0oJ25vbmNl JykgbmUgJycpIHsKLSAgJG5vbmNlID0gIm5vbmNlPSciLiRjZ2ktPnBhcmFtKCdub25jZScpLiIn IjsKK215ICRub25jZSA9ICRjZ2ktPnBhcmFtKCdub25jZScpIHx8ICIiOworaWYgKCRub25jZSBu ZSAiIikgeworICAgICRub25jZSA9ICJub25jZT0nIiAuICRub25jZSAuICInIjsKIH0KIAogCkBA IC0yNiw2ICsyNyw2IEBAIHByaW50ICI8Ym9keT5cbiI7CiBwcmludCAiPGRpdiBpZD1cInJlc3Vs dFwiIHRleHQ9XCIkcmVwbGFjZW1lbnRcIj5cbiI7CiBwcmludCAiJHRleHRcbiI7CiBwcmludCAi PC9kaXY+XG4iOwotcHJpbnQgIjxzY3JpcHQgJG5vbmNlIHNyYz1cIiIuJGNnaS0+cGFyYW0oJ3En KS4iXCI+PC9zY3JpcHQ+XG4iOworcHJpbnQgIjxzY3JpcHQgJG5vbmNlIHNyYz1cIiIgLiAkY2dp LT5wYXJhbSgncScpIC4gIlwiPjwvc2NyaXB0PlxuIjsKIHByaW50ICI8L2JvZHk+XG4iOwogcHJp bnQgIjwvaHRtbD5cbiI7Cg==