119688 2013-08-12 09:01:46 -0700 [GTK] WK does not link properly against libxslt 2013-09-14 08:17:27 -0700 1 1 1 Unclassified WebKit New Bugs 528+ (Nightly build) Unspecified Unspecified RESOLVED FIXED P2 Normal --- 1 calvaris calvaris berto cgarcia changseok commit-queue gustavo mrobinson pnormand zan oldest_to_newest 916293 0 calvaris 2013-08-12 09:01:46 -0700 [GTK] WK does not compile properly against libxslt 916294 1 208544 calvaris 2013-08-12 09:06:29 -0700 Created attachment 208544 Patch Fixes the -lm match problem when linking against libxslt. 916295 2 calvaris 2013-08-12 09:07:43 -0700 (In reply to comment #1) > Created an attachment (id=208544) [details] > Patch > > Fixes the -lm match problem when linking against libxslt. The math symbols cannot be found though libxslt needs them and the cause is that we are not acknowledging its flags. 916665 3 208544 gustavo 2013-08-13 05:32:01 -0700 Comment on attachment 208544 Patch View in context: https://bugs.webkit.org/attachment.cgi?id=208544&action=review > Source/WebKit/gtk/ChangeLog:3 > + [GTK] WK does not compile properly against libxslt Nit: you should say link instead of compile 916715 4 208635 calvaris 2013-08-13 08:28:30 -0700 Created attachment 208635 Patch Fixes the -lm match problem when linking against libxslt. 916888 5 calvaris 2013-08-13 14:26:05 -0700 If this gets again the r+, I could set cq tomorrow. 917014 6 208635 commit-queue 2013-08-13 23:35:14 -0700 Comment on attachment 208635 Patch Clearing flags on attachment: 208635 Committed r154041: <http://trac.webkit.org/changeset/154041> 917015 7 commit-queue 2013-08-13 23:35:16 -0700 All reviewed patches have been landed. Closing bug. 920556 8 cgarcia 2013-08-24 01:36:10 -0700 This still happens to me with Debian testing: /usr/lib/gcc/x86_64-linux-gnu/4.7/../../../x86_64-linux-gnu/libxslt.so: error: undefined reference to 'fmod' /usr/lib/gcc/x86_64-linux-gnu/4.7/../../../x86_64-linux-gnu/libxslt.so: error: undefined reference to 'floor' /usr/lib/gcc/x86_64-linux-gnu/4.7/../../../x86_64-linux-gnu/libxslt.so: error: undefined reference to 'pow' collect2: error: ld returned 1 exit status make[1]: *** [Programs/unittests/testdomdomwindow] Error 1 The only way I managed to build was adding -lm explicitly to WK1 tests, MiniBrowser and WTR makefiles. Adding LIBXSLT_LIBS doesn't seem to be enough here. I wonder why it works in the bots, though. 920558 9 calvaris 2013-08-24 02:19:00 -0700 (In reply to comment #8) > This still happens to me with Debian testing: > > /usr/lib/gcc/x86_64-linux-gnu/4.7/../../../x86_64-linux-gnu/libxslt.so: error: undefined reference to 'fmod' > /usr/lib/gcc/x86_64-linux-gnu/4.7/../../../x86_64-linux-gnu/libxslt.so: error: undefined reference to 'floor' > /usr/lib/gcc/x86_64-linux-gnu/4.7/../../../x86_64-linux-gnu/libxslt.so: error: undefined reference to 'pow' > collect2: error: ld returned 1 exit status > make[1]: *** [Programs/unittests/testdomdomwindow] Error 1 > > The only way I managed to build was adding -lm explicitly to WK1 tests, MiniBrowser and WTR makefiles. Adding LIBXSLT_LIBS doesn't seem to be enough here. I wonder why it works in the bots, though. Yes, you need to recompile libxslt, because the one in your system doesn't have -lm when you do a pkg-config --libs libxslt . The one upstream does. 923614 10 pnormand 2013-09-02 01:05:17 -0700 (In reply to comment #9) > (In reply to comment #8) > > This still happens to me with Debian testing: > > > > /usr/lib/gcc/x86_64-linux-gnu/4.7/../../../x86_64-linux-gnu/libxslt.so: error: undefined reference to 'fmod' > > /usr/lib/gcc/x86_64-linux-gnu/4.7/../../../x86_64-linux-gnu/libxslt.so: error: undefined reference to 'floor' > > /usr/lib/gcc/x86_64-linux-gnu/4.7/../../../x86_64-linux-gnu/libxslt.so: error: undefined reference to 'pow' > > collect2: error: ld returned 1 exit status > > make[1]: *** [Programs/unittests/testdomdomwindow] Error 1 > > > > The only way I managed to build was adding -lm explicitly to WK1 tests, MiniBrowser and WTR makefiles. Adding LIBXSLT_LIBS doesn't seem to be enough here. I wonder why it works in the bots, though. > > Yes, you need to recompile libxslt, because the one in your system doesn't have -lm when you do a pkg-config --libs libxslt . The one upstream does. This is rather annoying. Shouldn't we (for now) put libxslt in our jhbuild? I'd like to avoid "all" our Debian users to rebuild a system-wide lib... 923619 11 calvaris 2013-09-02 01:23:04 -0700 (In reply to comment #10) > This is rather annoying. Shouldn't we (for now) put libxslt in our jhbuild? I'd like to avoid "all" our Debian users to rebuild a system-wide lib... We could, but if we go for current master, we need to apply https://bugzilla.gnome.org/show_bug.cgi?id=706882 . 928715 12 changseok 2013-09-13 02:26:07 -0700 *** Bug 121282 has been marked as a duplicate of this bug. *** 928717 13 berto 2013-09-13 02:28:35 -0700 A workaround is to add -lm to the Libs: section in /usr/lib/*/pkgconfig/libxslt.pc See also http://bugs.debian.org/721602 928907 14 mrobinson 2013-09-13 10:44:39 -0700 This patch seems wrong, because it's adding libxslt to the linker line of binaries that do not use it directly. 929019 15 berto 2013-09-13 14:33:40 -0700 (In reply to comment #14) > This patch seems wrong, because it's adding libxslt to the linker line of binaries that do not use it directly. Okay, after our IRC conversation I've been trying to understand the whole thing. I've just reverted this patch (r154041) and compiled WebKit again from scratch but I didn't notice anything wrong. Xabier, what was exactly the original problem you were trying to solve with this? 929229 16 berto 2013-09-14 08:17:27 -0700 I just filed bug 121356 in order to revert this and other XSLT changes. 208544 2013-08-12 09:06:29 -0700 2013-08-13 08:28:26 -0700 Patch bug-119688-20130812180628.patch text/plain 2713 calvaris U3VidmVyc2lvbiBSZXZpc2lvbjogMTUzOTMzCmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViS2l0L2d0 ay9DaGFuZ2VMb2cgYi9Tb3VyY2UvV2ViS2l0L2d0ay9DaGFuZ2VMb2cKaW5kZXggOGNjZmNmODg5 MWEzYTI1NjBkYTdjNWI4OGQyMDM0ZDMzODU1YzhiNC4uMjBkYWUyODk5ODJiNmEwYmRlYmFjNzJh OWIzYzY3ZjkyM2Q3YWEzNyAxMDA2NDQKLS0tIGEvU291cmNlL1dlYktpdC9ndGsvQ2hhbmdlTG9n CisrKyBiL1NvdXJjZS9XZWJLaXQvZ3RrL0NoYW5nZUxvZwpAQCAtMSwzICsxLDEyIEBACisyMDEz LTA4LTEyICBYYWJpZXIgUm9kcmlndWV6IENhbHZhciAgPGNhbHZhcmlzQGlnYWxpYS5jb20+CisK KyAgICAgICAgW0dUS10gV0sgZG9lcyBub3QgY29tcGlsZSBwcm9wZXJseSBhZ2FpbnN0IGxpYnhz bHQKKyAgICAgICAgaHR0cHM6Ly9idWdzLndlYmtpdC5vcmcvc2hvd19idWcuY2dpP2lkPTExOTY4 OAorCisgICAgICAgIFJldmlld2VkIGJ5IE5PQk9EWSAoT09QUyEpLgorCisgICAgICAgICogR05V bWFrZWZpbGUuYW06IEFkZGVkIExJQlhTTFRfTElCUyB0byB0aGUgdW5pdCB0ZXN0cy4KKwogMjAx My0wOC0xMSAgQ2FybG9zIEdhcmNpYSBDYW1wb3MgIDxjZ2FyY2lhQGlnYWxpYS5jb20+CiAKICAg ICAgICAgVW5yZXZpZXdlZC4gVXBkYXRlIE5FV1MgYW5kIFZlcnNpb25zLm00IGZvciAyLjEuNCBy ZWxlYXNlLgpkaWZmIC0tZ2l0IGEvU291cmNlL1dlYktpdC9ndGsvR05VbWFrZWZpbGUuYW0gYi9T b3VyY2UvV2ViS2l0L2d0ay9HTlVtYWtlZmlsZS5hbQppbmRleCA1MjBjODRjZDMzZmNkZTBmOTdk NDA1MDYyZjcyOGExMDNiYWU5M2I4Li41MjI3NzBiNzlkNjk2Y2RiZTkyMDI1MjMxMjEzNDZkNTZj OTU4ZGVlIDEwMDY0NAotLS0gYS9Tb3VyY2UvV2ViS2l0L2d0ay9HTlVtYWtlZmlsZS5hbQorKysg Yi9Tb3VyY2UvV2ViS2l0L2d0ay9HTlVtYWtlZmlsZS5hbQpAQCAtNDQyLDYgKzQ0Miw3IEBAIHdl YmtpdF90ZXN0c19sZGFkZCA9IFwKIAkkKEdUS19MSUJTKSBcCiAJJChHTElCX0xJQlMpIFwKIAkk KExJQlNPVVBfTElCUykgXAorCSQoTElCWFNMVF9MSUJTKSBcCiAJJChYUkVOREVSX0xJQlMpCiAK IHdlYmtpdF90ZXN0c19sZGZsYWdzID0gXApkaWZmIC0tZ2l0IGEvVG9vbHMvQ2hhbmdlTG9nIGIv VG9vbHMvQ2hhbmdlTG9nCmluZGV4IDNlNzI4NDUzNjU0MmY0YzhkYTUxYzg3MjhmMWJhN2MyYjQw Njk1YjQuLjgyMjdkYWI2NzNkNDM3NmM5ZTA3N2E5OThlY2EwNmJiMWFmNjdiZTIgMTAwNjQ0Ci0t LSBhL1Rvb2xzL0NoYW5nZUxvZworKysgYi9Ub29scy9DaGFuZ2VMb2cKQEAgLTEsMyArMSwxNCBA QAorMjAxMy0wOC0xMiAgWGFiaWVyIFJvZHJpZ3VleiBDYWx2YXIgIDxjYWx2YXJpc0BpZ2FsaWEu Y29tPgorCisgICAgICAgIFtHVEtdIFdLIGRvZXMgbm90IGNvbXBpbGUgcHJvcGVybHkgYWdhaW5z dCBsaWJ4c2x0CisgICAgICAgIGh0dHBzOi8vYnVncy53ZWJraXQub3JnL3Nob3dfYnVnLmNnaT9p ZD0xMTk2ODgKKworICAgICAgICBSZXZpZXdlZCBieSBOT0JPRFkgKE9PUFMhKS4KKworICAgICAg ICAqIE1pbmlCcm93c2VyL2d0ay9HTlVtYWtlZmlsZS5hbTogQWRkZWQgTElCWFNMVF9MSUJTIHRv CisgICAgICAgIE1pbmlCcm93c2VyLgorICAgICAgICAqIFdlYktpdFRlc3RSdW5uZXIvR05VbWFr ZWZpbGUuYW06IEFkZGVkIExJQlhTTFRfTElCUyB0byBXVFIuCisKIDIwMTMtMDgtMTEgIENoYW5n U2VvayBPaCAgPGNoYW5nc2Vvay5vaEBjb2xsYWJvcmEuY29tPgogCiAgICAgICAgIFVucmV2aWV3 ZWQuIENoYW5nZSBteSBwcmltYXJ5IG1haWwgYWRkcmVzcy4KZGlmZiAtLWdpdCBhL1Rvb2xzL01p bmlCcm93c2VyL2d0ay9HTlVtYWtlZmlsZS5hbSBiL1Rvb2xzL01pbmlCcm93c2VyL2d0ay9HTlVt YWtlZmlsZS5hbQppbmRleCBmNDJhMzBiNzkyYjI3MGM1ZWZiZGJhNThiOWViYjZmMWQ2ZTJiMWY4 Li40ZTI1MzViZmY4YmYzMjJlZDVjOWQwODA0OWYxNjE4ZmRiYWFiNGJkIDEwMDY0NAotLS0gYS9U b29scy9NaW5pQnJvd3Nlci9ndGsvR05VbWFrZWZpbGUuYW0KKysrIGIvVG9vbHMvTWluaUJyb3dz ZXIvZ3RrL0dOVW1ha2VmaWxlLmFtCkBAIC0zOSw2ICszOSw3IEBAIFByb2dyYW1zX01pbmlCcm93 c2VyX0xEQUREID0gXAogCSQoRlJFRVRZUEVfTElCUykgXAogCSQoR0xJQl9MSUJTKSBcCiAJJChH VEtfTElCUykgXAorCSQoTElCWFNMVF9MSUJTKSBcCiAJJChMSUJTT1VQX0xJQlMpCiAKIFByb2dy YW1zX01pbmlCcm93c2VyX0xERkxBR1MgPSBcCmRpZmYgLS1naXQgYS9Ub29scy9XZWJLaXRUZXN0 UnVubmVyL0dOVW1ha2VmaWxlLmFtIGIvVG9vbHMvV2ViS2l0VGVzdFJ1bm5lci9HTlVtYWtlZmls ZS5hbQppbmRleCBiZDA0ZjRkNDI1OTk3YjMxYmRiMDc0MDcwNTc4MDIwZDI3MThjZTE1Li43MGI0 YWFlY2FmZDExOTVmMGFjYmMwZTZmYjE4YTNmMTBiMjUyYThmIDEwMDY0NAotLS0gYS9Ub29scy9X ZWJLaXRUZXN0UnVubmVyL0dOVW1ha2VmaWxlLmFtCisrKyBiL1Rvb2xzL1dlYktpdFRlc3RSdW5u ZXIvR05VbWFrZWZpbGUuYW0KQEAgLTU5LDYgKzU5LDcgQEAgUHJvZ3JhbXNfV2ViS2l0VGVzdFJ1 bm5lcl9MREFERCA9IFwKIAkkKEZSRUVUWVBFX0xJQlMpIFwKIAkkKFdJTk1NX0xJQlMpIFwKIAkk KFhSRU5ERVJfTElCUykgXAorCSQoTElCWFNMVF9MSUJTKSBcCiAJJChYVF9MSUJTKQogCiBQcm9n cmFtc19XZWJLaXRUZXN0UnVubmVyX0xERkxBR1MgPSBcCg== 208635 2013-08-13 08:28:30 -0700 2013-08-13 23:35:13 -0700 Patch bug-119688-20130813172828.patch text/plain 2707 calvaris U3VidmVyc2lvbiBSZXZpc2lvbjogMTUzOTMzCmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViS2l0L2d0 ay9DaGFuZ2VMb2cgYi9Tb3VyY2UvV2ViS2l0L2d0ay9DaGFuZ2VMb2cKaW5kZXggOGNjZmNmODg5 MWEzYTI1NjBkYTdjNWI4OGQyMDM0ZDMzODU1YzhiNC4uZTA2YzExNWVmYTVmZjhmYzU3NjZhMTQ4 MGI3ZTQ2MmM5MzViODVhZSAxMDA2NDQKLS0tIGEvU291cmNlL1dlYktpdC9ndGsvQ2hhbmdlTG9n CisrKyBiL1NvdXJjZS9XZWJLaXQvZ3RrL0NoYW5nZUxvZwpAQCAtMSwzICsxLDEyIEBACisyMDEz LTA4LTEzICBYYWJpZXIgUm9kcmlndWV6IENhbHZhciAgPGNhbHZhcmlzQGlnYWxpYS5jb20+CisK KyAgICAgICAgW0dUS10gV0sgZG9lcyBub3QgbGluayBwcm9wZXJseSBhZ2FpbnN0IGxpYnhzbHQK KyAgICAgICAgaHR0cHM6Ly9idWdzLndlYmtpdC5vcmcvc2hvd19idWcuY2dpP2lkPTExOTY4OAor CisgICAgICAgIFJldmlld2VkIGJ5IE5PQk9EWSAoT09QUyEpLgorCisgICAgICAgICogR05VbWFr ZWZpbGUuYW06IEFkZGVkIExJQlhTTFRfTElCUyB0byB0aGUgdW5pdCB0ZXN0cy4KKwogMjAxMy0w OC0xMSAgQ2FybG9zIEdhcmNpYSBDYW1wb3MgIDxjZ2FyY2lhQGlnYWxpYS5jb20+CiAKICAgICAg ICAgVW5yZXZpZXdlZC4gVXBkYXRlIE5FV1MgYW5kIFZlcnNpb25zLm00IGZvciAyLjEuNCByZWxl YXNlLgpkaWZmIC0tZ2l0IGEvU291cmNlL1dlYktpdC9ndGsvR05VbWFrZWZpbGUuYW0gYi9Tb3Vy Y2UvV2ViS2l0L2d0ay9HTlVtYWtlZmlsZS5hbQppbmRleCA1MjBjODRjZDMzZmNkZTBmOTdkNDA1 MDYyZjcyOGExMDNiYWU5M2I4Li41MjI3NzBiNzlkNjk2Y2RiZTkyMDI1MjMxMjEzNDZkNTZjOTU4 ZGVlIDEwMDY0NAotLS0gYS9Tb3VyY2UvV2ViS2l0L2d0ay9HTlVtYWtlZmlsZS5hbQorKysgYi9T b3VyY2UvV2ViS2l0L2d0ay9HTlVtYWtlZmlsZS5hbQpAQCAtNDQyLDYgKzQ0Miw3IEBAIHdlYmtp dF90ZXN0c19sZGFkZCA9IFwKIAkkKEdUS19MSUJTKSBcCiAJJChHTElCX0xJQlMpIFwKIAkkKExJ QlNPVVBfTElCUykgXAorCSQoTElCWFNMVF9MSUJTKSBcCiAJJChYUkVOREVSX0xJQlMpCiAKIHdl YmtpdF90ZXN0c19sZGZsYWdzID0gXApkaWZmIC0tZ2l0IGEvVG9vbHMvQ2hhbmdlTG9nIGIvVG9v bHMvQ2hhbmdlTG9nCmluZGV4IDNlNzI4NDUzNjU0MmY0YzhkYTUxYzg3MjhmMWJhN2MyYjQwNjk1 YjQuLjIzZmQ3NWY1YTY2MDQ4MDliNTM5ZThmMDAwNzIxNDkwYzY2YmJmMzYgMTAwNjQ0Ci0tLSBh L1Rvb2xzL0NoYW5nZUxvZworKysgYi9Ub29scy9DaGFuZ2VMb2cKQEAgLTEsMyArMSwxNCBAQAor MjAxMy0wOC0xMyAgWGFiaWVyIFJvZHJpZ3VleiBDYWx2YXIgIDxjYWx2YXJpc0BpZ2FsaWEuY29t PgorCisgICAgICAgIFtHVEtdIFdLIGRvZXMgbm90IGxpbmsgcHJvcGVybHkgYWdhaW5zdCBsaWJ4 c2x0CisgICAgICAgIGh0dHBzOi8vYnVncy53ZWJraXQub3JnL3Nob3dfYnVnLmNnaT9pZD0xMTk2 ODgKKworICAgICAgICBSZXZpZXdlZCBieSBOT0JPRFkgKE9PUFMhKS4KKworICAgICAgICAqIE1p bmlCcm93c2VyL2d0ay9HTlVtYWtlZmlsZS5hbTogQWRkZWQgTElCWFNMVF9MSUJTIHRvCisgICAg ICAgIE1pbmlCcm93c2VyLgorICAgICAgICAqIFdlYktpdFRlc3RSdW5uZXIvR05VbWFrZWZpbGUu YW06IEFkZGVkIExJQlhTTFRfTElCUyB0byBXVFIuCisKIDIwMTMtMDgtMTEgIENoYW5nU2VvayBP aCAgPGNoYW5nc2Vvay5vaEBjb2xsYWJvcmEuY29tPgogCiAgICAgICAgIFVucmV2aWV3ZWQuIENo YW5nZSBteSBwcmltYXJ5IG1haWwgYWRkcmVzcy4KZGlmZiAtLWdpdCBhL1Rvb2xzL01pbmlCcm93 c2VyL2d0ay9HTlVtYWtlZmlsZS5hbSBiL1Rvb2xzL01pbmlCcm93c2VyL2d0ay9HTlVtYWtlZmls ZS5hbQppbmRleCBmNDJhMzBiNzkyYjI3MGM1ZWZiZGJhNThiOWViYjZmMWQ2ZTJiMWY4Li40ZTI1 MzViZmY4YmYzMjJlZDVjOWQwODA0OWYxNjE4ZmRiYWFiNGJkIDEwMDY0NAotLS0gYS9Ub29scy9N aW5pQnJvd3Nlci9ndGsvR05VbWFrZWZpbGUuYW0KKysrIGIvVG9vbHMvTWluaUJyb3dzZXIvZ3Rr L0dOVW1ha2VmaWxlLmFtCkBAIC0zOSw2ICszOSw3IEBAIFByb2dyYW1zX01pbmlCcm93c2VyX0xE QUREID0gXAogCSQoRlJFRVRZUEVfTElCUykgXAogCSQoR0xJQl9MSUJTKSBcCiAJJChHVEtfTElC UykgXAorCSQoTElCWFNMVF9MSUJTKSBcCiAJJChMSUJTT1VQX0xJQlMpCiAKIFByb2dyYW1zX01p bmlCcm93c2VyX0xERkxBR1MgPSBcCmRpZmYgLS1naXQgYS9Ub29scy9XZWJLaXRUZXN0UnVubmVy L0dOVW1ha2VmaWxlLmFtIGIvVG9vbHMvV2ViS2l0VGVzdFJ1bm5lci9HTlVtYWtlZmlsZS5hbQpp bmRleCBiZDA0ZjRkNDI1OTk3YjMxYmRiMDc0MDcwNTc4MDIwZDI3MThjZTE1Li43MGI0YWFlY2Fm ZDExOTVmMGFjYmMwZTZmYjE4YTNmMTBiMjUyYThmIDEwMDY0NAotLS0gYS9Ub29scy9XZWJLaXRU ZXN0UnVubmVyL0dOVW1ha2VmaWxlLmFtCisrKyBiL1Rvb2xzL1dlYktpdFRlc3RSdW5uZXIvR05V bWFrZWZpbGUuYW0KQEAgLTU5LDYgKzU5LDcgQEAgUHJvZ3JhbXNfV2ViS2l0VGVzdFJ1bm5lcl9M REFERCA9IFwKIAkkKEZSRUVUWVBFX0xJQlMpIFwKIAkkKFdJTk1NX0xJQlMpIFwKIAkkKFhSRU5E RVJfTElCUykgXAorCSQoTElCWFNMVF9MSUJTKSBcCiAJJChYVF9MSUJTKQogCiBQcm9ncmFtc19X ZWJLaXRUZXN0UnVubmVyX0xERkxBR1MgPSBcCg==