11968 2006-12-25 08:13:12 -0800 BidiContext's m_basicDir is redundant 2006-12-27 13:34:19 -0800 1 1 1 Unclassified WebKit Layout and Rendering 420+ Mac OS X 10.4 RESOLVED FIXED P2 Normal --- 1 mitz webkit-unassigned oldest_to_newest 39813 0 mitz 2006-12-25 08:13:12 -0800 BidiContext's m_basicDir is redundant. The only place it's used it can be replaced with style()->direction(). 39685 1 12035 mitz 2006-12-26 09:42:41 -0800 Created attachment 12035 Remove m_basicDir No layout test regressions. 39689 2 12035 ggaren 2006-12-26 10:32:05 -0800 Comment on attachment 12035 Remove m_basicDir r=me 39370 3 sam 2006-12-27 13:34:19 -0800 Landed in r18439. 12035 2006-12-26 09:42:41 -0800 2006-12-26 10:32:05 -0800 Remove m_basicDir 11968_r1.patch text/plain 2713 mitz SW5kZXg6IFdlYkNvcmUvQ2hhbmdlTG9nCj09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT0KLS0tIFdlYkNvcmUvQ2hhbmdlTG9n CShyZXZpc2lvbiAxODQyMSkKKysrIFdlYkNvcmUvQ2hhbmdlTG9nCSh3b3JraW5nIGNvcHkpCkBA IC0xLDMgKzEsMjAgQEAKKzIwMDYtMTItMjYgIE1pdHogUGV0dGVsICA8bWl0ekB3ZWJraXQub3Jn PgorCisgICAgICAgIFJldmlld2VkIGJ5IE5PQk9EWSAoT09QUyEpLgorCisgICAgICAgIC0gaHR0 cDovL2J1Z3Mud2Via2l0Lm9yZy9zaG93X2J1Zy5jZ2k/aWQ9MTE5NjgKKyAgICAgICAgICBCaWRp Q29udGV4dCdzIG1fYmFzaWNEaXIgaXMgcmVkdW5kYW50CisKKyAgICAgICAgTm8gdGVzdCBwb3Nz aWJsZSAobm8gZnVuY3Rpb25hbGl0eSBjaGFuZ2UpCisKKyAgICAgICAgKiByZW5kZXJpbmcvYmlk aS5jcHA6CisgICAgICAgIChXZWJDb3JlOjpCaWRpQ29udGV4dDo6QmlkaUNvbnRleHQpOgorICAg ICAgICAoV2ViQ29yZTo6b3BlcmF0b3I9PSk6CisgICAgICAgIChXZWJDb3JlOjpSZW5kZXJCbG9j azo6Y29tcHV0ZUhvcml6b250YWxQb3NpdGlvbnNGb3JMaW5lKTogVXNlIHRoZSBibG9jaydzCisg ICAgICAgIGRpcmVjdGlvbiB0byByZXNvbHZlICdhdXRvbWF0aWMnIHRleHQtYWxpZ24uCisgICAg ICAgICogcmVuZGVyaW5nL2JpZGkuaDoKKyAgICAgICAgKFdlYkNvcmU6OkJpZGlDb250ZXh0Ojpk aXIpOgorCiAyMDA2LTEyLTI2ICBFcmljIFNlaWRlbCAgPGVyaWNAd2Via2l0Lm9yZz4KIAogICAg ICAgICBSZXZpZXdlZCBieSByd2xidWlzLgpJbmRleDogV2ViQ29yZS9yZW5kZXJpbmcvYmlkaS5j cHAKPT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PQotLS0gV2ViQ29yZS9yZW5kZXJpbmcvYmlkaS5jcHAJKHJldmlzaW9uIDE4 NDIwKQorKysgV2ViQ29yZS9yZW5kZXJpbmcvYmlkaS5jcHAJKHdvcmtpbmcgY29weSkKQEAgLTIw MywxMSArMjAzLDggQEAgQmlkaUNvbnRleHQ6OkJpZGlDb250ZXh0KHVuc2lnbmVkIGNoYXIgbAog ICAgIDogbGV2ZWwobCksIG92ZXJyaWRlKG8pLCBtX2RpcihlKQogewogICAgIHBhcmVudCA9IHA7 Ci0gICAgaWYgKHApIHsKKyAgICBpZiAocCkKICAgICAgICAgcC0+cmVmKCk7Ci0gICAgICAgIG1f YmFzaWNEaXIgPSBwLT5iYXNpY0RpcigpOwotICAgIH0gZWxzZQotICAgICAgICBtX2Jhc2ljRGly ID0gZTsKICAgICBjb3VudCA9IDA7CiB9CiAKQEAgLTIzMyw3ICsyMzAsNyBAQCBib29sIG9wZXJh dG9yPT0oY29uc3QgQmlkaUNvbnRleHQmIGMxLCBjCiB7CiAgICAgaWYgKCZjMSA9PSAmYzIpCiAg ICAgICAgIHJldHVybiB0cnVlOwotICAgIGlmIChjMS5sZXZlbCAhPSBjMi5sZXZlbCB8fCBjMS5v dmVycmlkZSAhPSBjMi5vdmVycmlkZSB8fCBjMS5kaXIoKSAhPSBjMi5kaXIoKSB8fCBjMS5iYXNp Y0RpcigpICE9IGMyLmJhc2ljRGlyKCkpCisgICAgaWYgKGMxLmxldmVsICE9IGMyLmxldmVsIHx8 IGMxLm92ZXJyaWRlICE9IGMyLm92ZXJyaWRlIHx8IGMxLmRpcigpICE9IGMyLmRpcigpKQogICAg ICAgICByZXR1cm4gZmFsc2U7CiAgICAgaWYgKCFjMS5wYXJlbnQpCiAgICAgICAgIHJldHVybiAh YzIucGFyZW50OwpAQCAtOTIxLDcgKzkxOCw3IEBAIHZvaWQgUmVuZGVyQmxvY2s6OmNvbXB1dGVI b3Jpem9udGFsUG9zaXQKICAgICAgICAgY2FzZSBUQUFVVE86CiAgICAgICAgICAgICBudW1TcGFj ZXMgPSAwOwogICAgICAgICAgICAgLy8gZm9yIHJpZ2h0IHRvIGxlZnQgZmFsbCB0aHJvdWdoIHRv IHJpZ2h0IGFsaWduZWQKLSAgICAgICAgICAgIGlmIChiaWRpLmNvbnRleHQtPmJhc2ljRGlyKCkg PT0gV1RGOjpVbmljb2RlOjpMZWZ0VG9SaWdodCkKKyAgICAgICAgICAgIGlmIChzdHlsZSgpLT5k aXJlY3Rpb24oKSA9PSBMVFIpCiAgICAgICAgICAgICAgICAgYnJlYWs7CiAgICAgICAgIGNhc2Ug UklHSFQ6CiAgICAgICAgIGNhc2UgS0hUTUxfUklHSFQ6CkluZGV4OiBXZWJDb3JlL3JlbmRlcmlu Zy9iaWRpLmgKPT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PQotLS0gV2ViQ29yZS9yZW5kZXJpbmcvYmlkaS5oCShyZXZpc2lv biAxODQyMCkKKysrIFdlYkNvcmUvcmVuZGVyaW5nL2JpZGkuaAkod29ya2luZyBjb3B5KQpAQCAt NTUsMTIgKzU1LDEwIEBAIG5hbWVzcGFjZSBXZWJDb3JlIHsKICAgICAgICAgdm9pZCBkZXJlZigp IGNvbnN0OwogCiAgICAgICAgIFdURjo6VW5pY29kZTo6RGlyZWN0aW9uIGRpcigpIGNvbnN0IHsg cmV0dXJuIHN0YXRpY19jYXN0PFdURjo6VW5pY29kZTo6RGlyZWN0aW9uPihtX2Rpcik7IH0KLSAg ICAgICAgV1RGOjpVbmljb2RlOjpEaXJlY3Rpb24gYmFzaWNEaXIoKSBjb25zdCB7IHJldHVybiBz dGF0aWNfY2FzdDxXVEY6OlVuaWNvZGU6OkRpcmVjdGlvbj4obV9iYXNpY0Rpcik7IH0KIAogICAg ICAgICB1bnNpZ25lZCBjaGFyIGxldmVsOwogICAgICAgICBib29sIG92ZXJyaWRlIDogMTsKICAg ICAgICAgdW5zaWduZWQgbV9kaXIgOiA1OyAvLyBXVEY6OlVuaWNvZGU6OkRpcmVjdGlvbgotICAg ICAgICB1bnNpZ25lZCBtX2Jhc2ljRGlyIDogNTsgLy8gV1RGOjpVbmljb2RlOjpEaXJlY3Rpb24K IAogICAgICAgICBCaWRpQ29udGV4dCogcGFyZW50OwogCg==