119671 2013-08-12 00:15:11 -0700 FEComponentTransfer could be faster 2013-08-14 00:48:21 -0700 1 1 1 Unclassified WebKit SVG 528+ (Nightly build) All All RESOLVED FIXED P4 Enhancement --- 0 jw00.jeong webkit-unassigned cdumez commit-queue dino kondapallykalyan zimmermann oldest_to_newest 916187 0 jw00.jeong 2013-08-12 00:15:11 -0700 Change using SET method to direct accessing. 916198 1 208515 jw00.jeong 2013-08-12 01:01:02 -0700 Created attachment 208515 Patch 916200 2 jw00.jeong 2013-08-12 01:14:21 -0700 In this case, the type of pixelArray->data() is unsigned char. It means we can avoid calling of SET function. And I measured the spent time of before and after patching when visit http://www.w3.org/TR/filter-effects/examples/feComponentTransfer.svg. Before adopting this patch, the function spent 190(ms). After patching, it spent only 35(ms). So this could reduce 80% of spent time. Below is about testing environment. OS: Ubuntu 12.04 64bit CPU: Intel Core i7-3770 CPU @ 3.40GHz Memory: 8,123,696 kB 916336 3 208515 cdumez 2013-08-12 10:46:42 -0700 Comment on attachment 208515 Patch View in context: https://bugs.webkit.org/attachment.cgi?id=208515&action=review > Source/WebCore/ChangeLog:7 > + Missing changelog. Please explain what you did and why it is better / faster. > Source/WebCore/platform/graphics/filters/FEComponentTransfer.cpp:-171 > - unsigned char c = pixelArray->item(pixelOffset + channel); Removing the char variable reduces the readability a bit IMHO. 916382 4 208515 dino 2013-08-12 12:57:19 -0700 Comment on attachment 208515 Patch +1 to Christophe's review. 916486 5 208582 jw00.jeong 2013-08-12 18:59:24 -0700 Created attachment 208582 Patch 916487 6 jw00.jeong 2013-08-12 19:03:36 -0700 Ok, I inserted some comment in ChangeLog. But the code that you checked is the deletion part of my changes. 916552 7 cdumez 2013-08-12 22:53:35 -0700 (In reply to comment #6) > Ok, I inserted some comment in ChangeLog. > But the code that you checked is the deletion part of my changes. Does keeping the 'char c' local variable really affect performance when building in release with -O2 or -O3? This would be surprising. What makes your code really faster is avoiding the call to set() and therefore skipping data validation (since you already know the data is fine). 916559 8 208582 cdumez 2013-08-12 22:57:10 -0700 Comment on attachment 208582 Patch View in context: https://bugs.webkit.org/attachment.cgi?id=208582&action=review The change looks good overall. > Source/WebCore/ChangeLog:8 > + Use direct writing to target data instead of calling SET function. SET -> Uint8ClampedArray::set() > Source/WebCore/platform/graphics/filters/FEComponentTransfer.cpp:-171 > - unsigned char c = pixelArray->item(pixelOffset + channel); could we maybe keep "unsigned char c = data[pixelOffset + channel];" just to improve readability a bit. It shouldn't affect performance but let me know if I'm wrong. 916583 9 208600 jw00.jeong 2013-08-12 23:54:58 -0700 Created attachment 208600 Patch 916585 10 208600 cdumez 2013-08-12 23:59:12 -0700 Comment on attachment 208600 Patch View in context: https://bugs.webkit.org/attachment.cgi?id=208600&action=review > Source/WebCore/ChangeLog:11 > + The SET function has index checking code, value checking code and value casting code. nit: Please update other uses of SET in the changelog as well > Source/WebCore/ChangeLog:14 > + Thus all works in SET function is duplicated. duplicated -> redundant > Source/WebCore/ChangeLog:15 > + So deletion of calling SET function do not reduce stability, but improve the performance. Removing the call to set() does not reduce stability but improves performance. 916589 11 208601 jw00.jeong 2013-08-13 00:06:37 -0700 Created attachment 208601 Patch 916595 12 208601 cdumez 2013-08-13 00:18:15 -0700 Comment on attachment 208601 Patch Looks good, thanks. r=me but please let Dean take a final look before landing as he was reviewing this as well. 916606 13 jw00.jeong 2013-08-13 00:49:04 -0700 CC'ing Dean, could you take a final look ? I would land this patch :) 916965 14 jw00.jeong 2013-08-13 17:42:15 -0700 Dean, if you don't have time to review this patch until tonight, I will ask another committer for landing this patch. 917021 15 208601 krit 2013-08-14 00:24:36 -0700 Comment on attachment 208601 Patch (In reply to comment #14) > Dean, if you don't have time to review this patch until tonight, I will ask another committer for landing this patch. Looks good. 917030 16 208601 commit-queue 2013-08-14 00:48:18 -0700 Comment on attachment 208601 Patch Clearing flags on attachment: 208601 Committed r154042: <http://trac.webkit.org/changeset/154042> 917031 17 commit-queue 2013-08-14 00:48:21 -0700 All reviewed patches have been landed. Closing bug. 208515 2013-08-12 01:01:02 -0700 2013-08-12 18:59:13 -0700 Patch bug-119671-20130812170100.patch text/plain 1711 jw00.jeong U3VidmVyc2lvbiBSZXZpc2lvbjogMTUzODY4CmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViQ29yZS9D aGFuZ2VMb2cgYi9Tb3VyY2UvV2ViQ29yZS9DaGFuZ2VMb2cKaW5kZXggZWVlZjU3MGEyYTJhZTJk Y2Y1MjZiMDFkMmQ0NDY1MTZhMThmOGVmOS4uMmRkNjUxMmY5OGI4ZDk2YzM3ZDdhZDNlZDg1ODE5 ZDZmZGU1OWNkZiAxMDA2NDQKLS0tIGEvU291cmNlL1dlYkNvcmUvQ2hhbmdlTG9nCisrKyBiL1Nv dXJjZS9XZWJDb3JlL0NoYW5nZUxvZwpAQCAtMSwzICsxLDEzIEBACisyMDEzLTA4LTEyICBKaW53 b28gSmVvbmcgIDxqdzAwLmplb25nQHNhbXN1bmcuY29tPgorCisgICAgICAgIEZFQ29tcG9uZW50 VHJhbnNmZXIgY291bGQgYmUgZmFzdGVyLgorICAgICAgICBodHRwczovL2J1Z3Mud2Via2l0Lm9y Zy9zaG93X2J1Zy5jZ2k/aWQ9MTE5NjcxCisKKyAgICAgICAgUmV2aWV3ZWQgYnkgTk9CT0RZIChP T1BTISkuCisKKyAgICAgICAgKiBwbGF0Zm9ybS9ncmFwaGljcy9maWx0ZXJzL0ZFQ29tcG9uZW50 VHJhbnNmZXIuY3BwOgorICAgICAgICAoV2ViQ29yZTo6RkVDb21wb25lbnRUcmFuc2Zlcjo6cGxh dGZvcm1BcHBseVNvZnR3YXJlKToKKwogMjAxMy0wOC0wOCAgSmVyIE5vYmxlICA8amVyLm5vYmxl QGFwcGxlLmNvbT4KIAogICAgICAgICBbRU1FXSBNZWRpYUtleSBBUElzIHNob3VsZCBiZSBwcmVm aXhlZC4KZGlmZiAtLWdpdCBhL1NvdXJjZS9XZWJDb3JlL3BsYXRmb3JtL2dyYXBoaWNzL2ZpbHRl cnMvRkVDb21wb25lbnRUcmFuc2Zlci5jcHAgYi9Tb3VyY2UvV2ViQ29yZS9wbGF0Zm9ybS9ncmFw aGljcy9maWx0ZXJzL0ZFQ29tcG9uZW50VHJhbnNmZXIuY3BwCmluZGV4IGU0OTRiMDhiZDFmMDY2 Y2YwMmQ5OTEwMjc1NmUxMDc5YzI1YmY5ZGYuLmQ0ZmRlOWFmNGViNWQ4YzI0NDFhMjU2N2MzYWY5 N2ZmZGI4ZWQyYTUgMTAwNjQ0Ci0tLSBhL1NvdXJjZS9XZWJDb3JlL3BsYXRmb3JtL2dyYXBoaWNz L2ZpbHRlcnMvRkVDb21wb25lbnRUcmFuc2Zlci5jcHAKKysrIGIvU291cmNlL1dlYkNvcmUvcGxh dGZvcm0vZ3JhcGhpY3MvZmlsdGVycy9GRUNvbXBvbmVudFRyYW5zZmVyLmNwcApAQCAtMTY2LDEw ICsxNjYsMTAgQEAgdm9pZCBGRUNvbXBvbmVudFRyYW5zZmVyOjpwbGF0Zm9ybUFwcGx5U29mdHdh cmUoKQogICAgIGluLT5jb3B5VW5tdWx0aXBsaWVkSW1hZ2UocGl4ZWxBcnJheSwgZHJhd2luZ1Jl Y3QpOwogCiAgICAgdW5zaWduZWQgcGl4ZWxBcnJheUxlbmd0aCA9IHBpeGVsQXJyYXktPmxlbmd0 aCgpOworICAgIHVuc2lnbmVkIGNoYXIqIGRhdGEgPSBwaXhlbEFycmF5LT5kYXRhKCk7CiAgICAg Zm9yICh1bnNpZ25lZCBwaXhlbE9mZnNldCA9IDA7IHBpeGVsT2Zmc2V0IDwgcGl4ZWxBcnJheUxl bmd0aDsgcGl4ZWxPZmZzZXQgKz0gNCkgewogICAgICAgICBmb3IgKHVuc2lnbmVkIGNoYW5uZWwg PSAwOyBjaGFubmVsIDwgNDsgKytjaGFubmVsKSB7Ci0gICAgICAgICAgICB1bnNpZ25lZCBjaGFy IGMgPSBwaXhlbEFycmF5LT5pdGVtKHBpeGVsT2Zmc2V0ICsgY2hhbm5lbCk7Ci0gICAgICAgICAg ICBwaXhlbEFycmF5LT5zZXQocGl4ZWxPZmZzZXQgKyBjaGFubmVsLCB0YWJsZXNbY2hhbm5lbF1b Y10pOworICAgICAgICAgICAgZGF0YVtwaXhlbE9mZnNldCArIGNoYW5uZWxdID0gdGFibGVzW2No YW5uZWxdW2RhdGFbcGl4ZWxPZmZzZXQgKyBjaGFubmVsXV07CiAgICAgICAgIH0KICAgICB9CiB9 Cg== 208582 2013-08-12 18:59:24 -0700 2013-08-12 23:54:49 -0700 Patch bug-119671-20130813105923.patch text/plain 2278 jw00.jeong U3VidmVyc2lvbiBSZXZpc2lvbjogMTUzODY4CmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViQ29yZS9D aGFuZ2VMb2cgYi9Tb3VyY2UvV2ViQ29yZS9DaGFuZ2VMb2cKaW5kZXggZWVlZjU3MGEyYTJhZTJk Y2Y1MjZiMDFkMmQ0NDY1MTZhMThmOGVmOS4uYjY4NmM5NjllNjk3YzNkM2QwMjAyOTAyNTQ5YjNj MTc0MDBlZmUyNSAxMDA2NDQKLS0tIGEvU291cmNlL1dlYkNvcmUvQ2hhbmdlTG9nCisrKyBiL1Nv dXJjZS9XZWJDb3JlL0NoYW5nZUxvZwpAQCAtMSwzICsxLDIyIEBACisyMDEzLTA4LTEyICBKaW53 b28gSmVvbmcgIDxqdzAwLmplb25nQHNhbXN1bmcuY29tPgorCisgICAgICAgIEZFQ29tcG9uZW50 VHJhbnNmZXIgY291bGQgYmUgZmFzdGVyLgorICAgICAgICBodHRwczovL2J1Z3Mud2Via2l0Lm9y Zy9zaG93X2J1Zy5jZ2k/aWQ9MTE5NjcxCisKKyAgICAgICAgUmV2aWV3ZWQgYnkgTk9CT0RZIChP T1BTISkuCisKKyAgICAgICAgVXNlIGRpcmVjdCB3cml0aW5nIHRvIHRhcmdldCBkYXRhIGluc3Rl YWQgb2YgY2FsbGluZyBTRVQgZnVuY3Rpb24uCisgICAgICAgIFRoaXMgY2hhbmdlIHJlZHVjZXMg YXQgbGVhc3QgODAlIHRpbWUgaW4gdGhlIGxvb3Agb2YgdGhhdCBmdW5jdGlvbi4KKworICAgICAg ICBUaGUgU0VUIGZ1bmN0aW9uIGhhcyBpbmRleCBjaGVja2luZyBjb2RlLCB2YWx1ZSBjaGVja2lu ZyBjb2RlIGFuZCB2YWx1ZSBjYXN0aW5nIGNvZGUuCisgICAgICAgIEJ1dCB0aGUgaW5kZXggaXMg bWFuYWdlZCBieSBmb3IgbG9vcCBjb25kaXRpb24sIHRoZSB2YWx1ZSBpcyBnZW5lcmF0ZWQgYnkg dHJhbnNmZXJGdW5jdGlvbi4KKyAgICAgICAgQW5kIHRoZSB2YWx1ZSBpcyBhbHJlYWR5IGRlZmlu ZWQgYXMgdW5zaWduZWQgY2hhci4KKyAgICAgICAgVGh1cyBhbGwgd29ya3MgaW4gU0VUIGZ1bmN0 aW9uIGlzIGR1cGxpY2F0ZWQuCisgICAgICAgIFNvIGRlbGV0aW9uIG9mIGNhbGxpbmcgU0VUIGZ1 bmN0aW9uIGRvIG5vdCByZWR1Y2Ugc3RhYmlsaXR5LCBidXQgaW1wcm92ZSB0aGUgcGVyZm9ybWFu Y2UuCisKKyAgICAgICAgKiBwbGF0Zm9ybS9ncmFwaGljcy9maWx0ZXJzL0ZFQ29tcG9uZW50VHJh bnNmZXIuY3BwOgorICAgICAgICAoV2ViQ29yZTo6RkVDb21wb25lbnRUcmFuc2Zlcjo6cGxhdGZv cm1BcHBseVNvZnR3YXJlKToKKwogMjAxMy0wOC0wOCAgSmVyIE5vYmxlICA8amVyLm5vYmxlQGFw cGxlLmNvbT4KIAogICAgICAgICBbRU1FXSBNZWRpYUtleSBBUElzIHNob3VsZCBiZSBwcmVmaXhl ZC4KZGlmZiAtLWdpdCBhL1NvdXJjZS9XZWJDb3JlL3BsYXRmb3JtL2dyYXBoaWNzL2ZpbHRlcnMv RkVDb21wb25lbnRUcmFuc2Zlci5jcHAgYi9Tb3VyY2UvV2ViQ29yZS9wbGF0Zm9ybS9ncmFwaGlj cy9maWx0ZXJzL0ZFQ29tcG9uZW50VHJhbnNmZXIuY3BwCmluZGV4IGU0OTRiMDhiZDFmMDY2Y2Yw MmQ5OTEwMjc1NmUxMDc5YzI1YmY5ZGYuLmQ0ZmRlOWFmNGViNWQ4YzI0NDFhMjU2N2MzYWY5N2Zm ZGI4ZWQyYTUgMTAwNjQ0Ci0tLSBhL1NvdXJjZS9XZWJDb3JlL3BsYXRmb3JtL2dyYXBoaWNzL2Zp bHRlcnMvRkVDb21wb25lbnRUcmFuc2Zlci5jcHAKKysrIGIvU291cmNlL1dlYkNvcmUvcGxhdGZv cm0vZ3JhcGhpY3MvZmlsdGVycy9GRUNvbXBvbmVudFRyYW5zZmVyLmNwcApAQCAtMTY2LDEwICsx NjYsMTAgQEAgdm9pZCBGRUNvbXBvbmVudFRyYW5zZmVyOjpwbGF0Zm9ybUFwcGx5U29mdHdhcmUo KQogICAgIGluLT5jb3B5VW5tdWx0aXBsaWVkSW1hZ2UocGl4ZWxBcnJheSwgZHJhd2luZ1JlY3Qp OwogCiAgICAgdW5zaWduZWQgcGl4ZWxBcnJheUxlbmd0aCA9IHBpeGVsQXJyYXktPmxlbmd0aCgp OworICAgIHVuc2lnbmVkIGNoYXIqIGRhdGEgPSBwaXhlbEFycmF5LT5kYXRhKCk7CiAgICAgZm9y ICh1bnNpZ25lZCBwaXhlbE9mZnNldCA9IDA7IHBpeGVsT2Zmc2V0IDwgcGl4ZWxBcnJheUxlbmd0 aDsgcGl4ZWxPZmZzZXQgKz0gNCkgewogICAgICAgICBmb3IgKHVuc2lnbmVkIGNoYW5uZWwgPSAw OyBjaGFubmVsIDwgNDsgKytjaGFubmVsKSB7Ci0gICAgICAgICAgICB1bnNpZ25lZCBjaGFyIGMg PSBwaXhlbEFycmF5LT5pdGVtKHBpeGVsT2Zmc2V0ICsgY2hhbm5lbCk7Ci0gICAgICAgICAgICBw aXhlbEFycmF5LT5zZXQocGl4ZWxPZmZzZXQgKyBjaGFubmVsLCB0YWJsZXNbY2hhbm5lbF1bY10p OworICAgICAgICAgICAgZGF0YVtwaXhlbE9mZnNldCArIGNoYW5uZWxdID0gdGFibGVzW2NoYW5u ZWxdW2RhdGFbcGl4ZWxPZmZzZXQgKyBjaGFubmVsXV07CiAgICAgICAgIH0KICAgICB9CiB9Cg== 208600 2013-08-12 23:54:58 -0700 2013-08-13 00:06:28 -0700 Patch bug-119671-20130813155457.patch text/plain 2333 jw00.jeong U3VidmVyc2lvbiBSZXZpc2lvbjogMTUzODY4CmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViQ29yZS9D aGFuZ2VMb2cgYi9Tb3VyY2UvV2ViQ29yZS9DaGFuZ2VMb2cKaW5kZXggZWVlZjU3MGEyYTJhZTJk Y2Y1MjZiMDFkMmQ0NDY1MTZhMThmOGVmOS4uNTQ0MWRjOWY0MjBhNDBjZjNhODhkN2NiMjc2MzRh YjhiMTU0NjAwMSAxMDA2NDQKLS0tIGEvU291cmNlL1dlYkNvcmUvQ2hhbmdlTG9nCisrKyBiL1Nv dXJjZS9XZWJDb3JlL0NoYW5nZUxvZwpAQCAtMSwzICsxLDIyIEBACisyMDEzLTA4LTEyICBKaW53 b28gSmVvbmcgIDxqdzAwLmplb25nQHNhbXN1bmcuY29tPgorCisgICAgICAgIEZFQ29tcG9uZW50 VHJhbnNmZXIgY291bGQgYmUgZmFzdGVyLgorICAgICAgICBodHRwczovL2J1Z3Mud2Via2l0Lm9y Zy9zaG93X2J1Zy5jZ2k/aWQ9MTE5NjcxCisKKyAgICAgICAgUmV2aWV3ZWQgYnkgTk9CT0RZIChP T1BTISkuCisKKyAgICAgICAgVXNlIGRpcmVjdCB3cml0aW5nIHRvIHRhcmdldCBkYXRhIGluc3Rl YWQgb2YgY2FsbGluZyBVaW50OENsYW1wZWRBcnJheTo6c2V0KCkgZnVuY3Rpb24uCisgICAgICAg IFRoaXMgY2hhbmdlIHJlZHVjZXMgYXQgbGVhc3QgODAlIHRpbWUgaW4gdGhlIGxvb3Agb2YgdGhh dCBmdW5jdGlvbi4KKworICAgICAgICBUaGUgU0VUIGZ1bmN0aW9uIGhhcyBpbmRleCBjaGVja2lu ZyBjb2RlLCB2YWx1ZSBjaGVja2luZyBjb2RlIGFuZCB2YWx1ZSBjYXN0aW5nIGNvZGUuCisgICAg ICAgIEJ1dCB0aGUgaW5kZXggaXMgbWFuYWdlZCBieSBmb3IgbG9vcCBjb25kaXRpb24sIHRoZSB2 YWx1ZSBpcyBnZW5lcmF0ZWQgYnkgdHJhbnNmZXJGdW5jdGlvbi4KKyAgICAgICAgQW5kIHRoZSB2 YWx1ZSBpcyBhbHJlYWR5IGRlZmluZWQgYXMgdW5zaWduZWQgY2hhci4KKyAgICAgICAgVGh1cyBh bGwgd29ya3MgaW4gU0VUIGZ1bmN0aW9uIGlzIGR1cGxpY2F0ZWQuCisgICAgICAgIFNvIGRlbGV0 aW9uIG9mIGNhbGxpbmcgU0VUIGZ1bmN0aW9uIGRvIG5vdCByZWR1Y2Ugc3RhYmlsaXR5LCBidXQg aW1wcm92ZSB0aGUgcGVyZm9ybWFuY2UuCisKKyAgICAgICAgKiBwbGF0Zm9ybS9ncmFwaGljcy9m aWx0ZXJzL0ZFQ29tcG9uZW50VHJhbnNmZXIuY3BwOgorICAgICAgICAoV2ViQ29yZTo6RkVDb21w b25lbnRUcmFuc2Zlcjo6cGxhdGZvcm1BcHBseVNvZnR3YXJlKToKKwogMjAxMy0wOC0wOCAgSmVy IE5vYmxlICA8amVyLm5vYmxlQGFwcGxlLmNvbT4KIAogICAgICAgICBbRU1FXSBNZWRpYUtleSBB UElzIHNob3VsZCBiZSBwcmVmaXhlZC4KZGlmZiAtLWdpdCBhL1NvdXJjZS9XZWJDb3JlL3BsYXRm b3JtL2dyYXBoaWNzL2ZpbHRlcnMvRkVDb21wb25lbnRUcmFuc2Zlci5jcHAgYi9Tb3VyY2UvV2Vi Q29yZS9wbGF0Zm9ybS9ncmFwaGljcy9maWx0ZXJzL0ZFQ29tcG9uZW50VHJhbnNmZXIuY3BwCmlu ZGV4IGU0OTRiMDhiZDFmMDY2Y2YwMmQ5OTEwMjc1NmUxMDc5YzI1YmY5ZGYuLjhmYTRmMzVmOGQ4 NTljZTE3ZjJmZmJmOWQ2MTkxZmQ4MzExNWFlZTkgMTAwNjQ0Ci0tLSBhL1NvdXJjZS9XZWJDb3Jl L3BsYXRmb3JtL2dyYXBoaWNzL2ZpbHRlcnMvRkVDb21wb25lbnRUcmFuc2Zlci5jcHAKKysrIGIv U291cmNlL1dlYkNvcmUvcGxhdGZvcm0vZ3JhcGhpY3MvZmlsdGVycy9GRUNvbXBvbmVudFRyYW5z ZmVyLmNwcApAQCAtMTY2LDEwICsxNjYsMTEgQEAgdm9pZCBGRUNvbXBvbmVudFRyYW5zZmVyOjpw bGF0Zm9ybUFwcGx5U29mdHdhcmUoKQogICAgIGluLT5jb3B5VW5tdWx0aXBsaWVkSW1hZ2UocGl4 ZWxBcnJheSwgZHJhd2luZ1JlY3QpOwogCiAgICAgdW5zaWduZWQgcGl4ZWxBcnJheUxlbmd0aCA9 IHBpeGVsQXJyYXktPmxlbmd0aCgpOworICAgIHVuc2lnbmVkIGNoYXIqIGRhdGEgPSBwaXhlbEFy cmF5LT5kYXRhKCk7CiAgICAgZm9yICh1bnNpZ25lZCBwaXhlbE9mZnNldCA9IDA7IHBpeGVsT2Zm c2V0IDwgcGl4ZWxBcnJheUxlbmd0aDsgcGl4ZWxPZmZzZXQgKz0gNCkgewogICAgICAgICBmb3Ig KHVuc2lnbmVkIGNoYW5uZWwgPSAwOyBjaGFubmVsIDwgNDsgKytjaGFubmVsKSB7Ci0gICAgICAg ICAgICB1bnNpZ25lZCBjaGFyIGMgPSBwaXhlbEFycmF5LT5pdGVtKHBpeGVsT2Zmc2V0ICsgY2hh bm5lbCk7Ci0gICAgICAgICAgICBwaXhlbEFycmF5LT5zZXQocGl4ZWxPZmZzZXQgKyBjaGFubmVs LCB0YWJsZXNbY2hhbm5lbF1bY10pOworICAgICAgICAgICAgdW5zaWduZWQgY2hhciBjID0gZGF0 YVtwaXhlbE9mZnNldCArIGNoYW5uZWxdOworICAgICAgICAgICAgZGF0YVtwaXhlbE9mZnNldCAr IGNoYW5uZWxdID0gdGFibGVzW2NoYW5uZWxdW2NdOwogICAgICAgICB9CiAgICAgfQogfQo= 208601 2013-08-13 00:06:37 -0700 2013-08-14 00:48:18 -0700 Patch bug-119671-20130813160636.patch text/plain 2391 jw00.jeong U3VidmVyc2lvbiBSZXZpc2lvbjogMTUzODY4CmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViQ29yZS9D aGFuZ2VMb2cgYi9Tb3VyY2UvV2ViQ29yZS9DaGFuZ2VMb2cKaW5kZXggZWVlZjU3MGEyYTJhZTJk Y2Y1MjZiMDFkMmQ0NDY1MTZhMThmOGVmOS4uZmZjMTU3YjdmZjhiZDBlMDg1OWY3NGZkMjY5YzEz MGRhNzM1MmI5MyAxMDA2NDQKLS0tIGEvU291cmNlL1dlYkNvcmUvQ2hhbmdlTG9nCisrKyBiL1Nv dXJjZS9XZWJDb3JlL0NoYW5nZUxvZwpAQCAtMSwzICsxLDIyIEBACisyMDEzLTA4LTEyICBKaW53 b28gSmVvbmcgIDxqdzAwLmplb25nQHNhbXN1bmcuY29tPgorCisgICAgICAgIEZFQ29tcG9uZW50 VHJhbnNmZXIgY291bGQgYmUgZmFzdGVyLgorICAgICAgICBodHRwczovL2J1Z3Mud2Via2l0Lm9y Zy9zaG93X2J1Zy5jZ2k/aWQ9MTE5NjcxCisKKyAgICAgICAgUmV2aWV3ZWQgYnkgTk9CT0RZIChP T1BTISkuCisKKyAgICAgICAgVXNlIGRpcmVjdCB3cml0aW5nIHRvIHRhcmdldCBkYXRhIGluc3Rl YWQgb2YgY2FsbGluZyBVaW50OENsYW1wZWRBcnJheTo6c2V0KCkgZnVuY3Rpb24uCisgICAgICAg IFRoaXMgY2hhbmdlIHJlZHVjZXMgYXQgbGVhc3QgODAlIHRpbWUgaW4gdGhlIGxvb3Agb2YgdGhh dCBmdW5jdGlvbi4KKworICAgICAgICBUaGUgVWludDhDbGFtcGVkQXJyYXk6OnNldCgpIGZ1bmN0 aW9uIGhhcyBpbmRleCBjaGVja2luZyBjb2RlLCB2YWx1ZSBjaGVja2luZyBjb2RlIGFuZCB2YWx1 ZSBjYXN0aW5nIGNvZGUuCisgICAgICAgIEJ1dCB0aGUgaW5kZXggaXMgbWFuYWdlZCBieSBmb3Ig bG9vcCBjb25kaXRpb24sIHRoZSB2YWx1ZSBpcyBnZW5lcmF0ZWQgYnkgdHJhbnNmZXJGdW5jdGlv bi4KKyAgICAgICAgQW5kIHRoZSB2YWx1ZSBpcyBhbHJlYWR5IGRlZmluZWQgYXMgdW5zaWduZWQg Y2hhci4KKyAgICAgICAgVGh1cyBhbGwgd29ya3MgaW4gVWludDhDbGFtcGVkQXJyYXk6OnNldCgp IGZ1bmN0aW9uIGlzIHJlZHVuZGFudC4KKyAgICAgICAgUmVtb3ZpbmcgdGhlIGNhbGwgdG8gVWlu dDhDbGFtcGVkQXJyYXk6OnNldCgpIGZ1bmN0aW9uIGRvZXMgbm90IHJlZHVjZSBzdGFiaWxpdHkg YnV0IGltcHJvdmVzIHBlcmZvcm1hbmNlLgorCisgICAgICAgICogcGxhdGZvcm0vZ3JhcGhpY3Mv ZmlsdGVycy9GRUNvbXBvbmVudFRyYW5zZmVyLmNwcDoKKyAgICAgICAgKFdlYkNvcmU6OkZFQ29t cG9uZW50VHJhbnNmZXI6OnBsYXRmb3JtQXBwbHlTb2Z0d2FyZSk6CisKIDIwMTMtMDgtMDggIEpl ciBOb2JsZSAgPGplci5ub2JsZUBhcHBsZS5jb20+CiAKICAgICAgICAgW0VNRV0gTWVkaWFLZXkg QVBJcyBzaG91bGQgYmUgcHJlZml4ZWQuCmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViQ29yZS9wbGF0 Zm9ybS9ncmFwaGljcy9maWx0ZXJzL0ZFQ29tcG9uZW50VHJhbnNmZXIuY3BwIGIvU291cmNlL1dl YkNvcmUvcGxhdGZvcm0vZ3JhcGhpY3MvZmlsdGVycy9GRUNvbXBvbmVudFRyYW5zZmVyLmNwcApp bmRleCBlNDk0YjA4YmQxZjA2NmNmMDJkOTkxMDI3NTZlMTA3OWMyNWJmOWRmLi44ZmE0ZjM1Zjhk ODU5Y2UxN2YyZmZiZjlkNjE5MWZkODMxMTVhZWU5IDEwMDY0NAotLS0gYS9Tb3VyY2UvV2ViQ29y ZS9wbGF0Zm9ybS9ncmFwaGljcy9maWx0ZXJzL0ZFQ29tcG9uZW50VHJhbnNmZXIuY3BwCisrKyBi L1NvdXJjZS9XZWJDb3JlL3BsYXRmb3JtL2dyYXBoaWNzL2ZpbHRlcnMvRkVDb21wb25lbnRUcmFu c2Zlci5jcHAKQEAgLTE2NiwxMCArMTY2LDExIEBAIHZvaWQgRkVDb21wb25lbnRUcmFuc2Zlcjo6 cGxhdGZvcm1BcHBseVNvZnR3YXJlKCkKICAgICBpbi0+Y29weVVubXVsdGlwbGllZEltYWdlKHBp eGVsQXJyYXksIGRyYXdpbmdSZWN0KTsKIAogICAgIHVuc2lnbmVkIHBpeGVsQXJyYXlMZW5ndGgg PSBwaXhlbEFycmF5LT5sZW5ndGgoKTsKKyAgICB1bnNpZ25lZCBjaGFyKiBkYXRhID0gcGl4ZWxB cnJheS0+ZGF0YSgpOwogICAgIGZvciAodW5zaWduZWQgcGl4ZWxPZmZzZXQgPSAwOyBwaXhlbE9m ZnNldCA8IHBpeGVsQXJyYXlMZW5ndGg7IHBpeGVsT2Zmc2V0ICs9IDQpIHsKICAgICAgICAgZm9y ICh1bnNpZ25lZCBjaGFubmVsID0gMDsgY2hhbm5lbCA8IDQ7ICsrY2hhbm5lbCkgewotICAgICAg ICAgICAgdW5zaWduZWQgY2hhciBjID0gcGl4ZWxBcnJheS0+aXRlbShwaXhlbE9mZnNldCArIGNo YW5uZWwpOwotICAgICAgICAgICAgcGl4ZWxBcnJheS0+c2V0KHBpeGVsT2Zmc2V0ICsgY2hhbm5l bCwgdGFibGVzW2NoYW5uZWxdW2NdKTsKKyAgICAgICAgICAgIHVuc2lnbmVkIGNoYXIgYyA9IGRh dGFbcGl4ZWxPZmZzZXQgKyBjaGFubmVsXTsKKyAgICAgICAgICAgIGRhdGFbcGl4ZWxPZmZzZXQg KyBjaGFubmVsXSA9IHRhYmxlc1tjaGFubmVsXVtjXTsKICAgICAgICAgfQogICAgIH0KIH0K