119651 2013-08-09 20:28:51 -0700 [GObject] Wrap KeyboardEvent 2013-08-10 08:44:17 -0700 1 1 1 Unclassified WebKit New Bugs 528+ (Nightly build) Unspecified Unspecified RESOLVED FIXED P2 Normal --- 1 gustavo gustavo cdumez commit-queue esprehn+autocc kangil.han kondapallykalyan mrobinson xan.lopez zan oldest_to_newest 916030 0 gustavo 2013-08-09 20:28:51 -0700 [GObject] Wrap KeyboardEvent 916032 1 208471 gustavo 2013-08-09 20:32:38 -0700 Created attachment 208471 Patch 916033 2 gustavo 2013-08-09 20:34:12 -0700 This is required for this to work: https://bugzilla.gnome.org/show_bug.cgi?id=675060 (A UI to show users which have passwords saved for a site in Epiphany) 916039 3 208471 cdumez 2013-08-09 22:47:40 -0700 Comment on attachment 208471 Patch View in context: https://bugs.webkit.org/attachment.cgi?id=208471&action=review > Source/WebCore/bindings/scripts/CodeGeneratorGObject.pm:114 > + return "Event" if $parent eq "UIEvent" or $parent eq "MouseEvent" or $parent eq "KeyboardEvent"; Could we simply use $codeGenerator->InheritsInterface("Event") ? This does not look very scalable. 916049 4 gustavo 2013-08-10 08:44:17 -0700 Committed r153921: <http://trac.webkit.org/changeset/153921> 208471 2013-08-09 20:32:38 -0700 2013-08-09 22:47:40 -0700 Patch bug-119651-20130810003236.patch text/plain 5104 gustavo U3VidmVyc2lvbiBSZXZpc2lvbjogMTUzOTA4CmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViQ29yZS9D aGFuZ2VMb2cgYi9Tb3VyY2UvV2ViQ29yZS9DaGFuZ2VMb2cKaW5kZXggZmI3ZTM3NjdjZDcwYWFm MDY0NzllOTNjYmVhYzBlZGM3NDA3ZDhmMC4uZDgzNzY1ZTBjMzZjZDQwM2Y1YTU1ZmY5YzY4MDg1 OGU2ZTdhOTBmNSAxMDA2NDQKLS0tIGEvU291cmNlL1dlYkNvcmUvQ2hhbmdlTG9nCisrKyBiL1Nv dXJjZS9XZWJDb3JlL0NoYW5nZUxvZwpAQCAtMSwzICsxLDIyIEBACisyMDEzLTA4LTA5ICBHdXN0 YXZvIE5vcm9uaGEgU2lsdmEgIDxnbnNAZ25vbWUub3JnPgorCisgICAgICAgIFtHT2JqZWN0XSBX cmFwIEtleWJvYXJkRXZlbnQKKyAgICAgICAgaHR0cHM6Ly9idWdzLndlYmtpdC5vcmcvc2hvd19i dWcuY2dpP2lkPTExOTY1MQorCisgICAgICAgIFJldmlld2VkIGJ5IE5PQk9EWSAoT09QUyEpLgor CisgICAgICAgIFRoaXMgZXhwb3NlcyBLZXlib2FyZEV2ZW50IHRvIG91ciBHT2JqZWN0IEFQSS4g SXQgaXMgcmVxdWlyZWQgZm9yIGhhbmRsaW5nCisgICAgICAgIGtleWJvYXJkIGV2ZW50cywgc3Vj aCBhcyBrZXlkb3duLCBrZXlwcmVzcywgYW5kIHNvIG9uLgorCisgICAgICAgICogYmluZGluZ3Mv Z29iamVjdC9HTlVtYWtlZmlsZS5hbToKKyAgICAgICAgKiBiaW5kaW5ncy9nb2JqZWN0L1dlYktp dERPTVByaXZhdGUuY3BwOgorICAgICAgICAoV2ViS2l0Ojp3cmFwKTogbWFrZSBzdXJlIHdlIGNy ZWF0ZSBhIFdlYktpdERPTUtleWJvYXJkRXZlbnQgZm9yIGEgRE9NIGV2ZW50IHRoYXQKKyAgICAg ICAgaXMgYSBLZXlib2FyZEV2ZW50LgorICAgICAgICAqIGJpbmRpbmdzL3NjcmlwdHMvQ29kZUdl bmVyYXRvckdPYmplY3QucG06CisgICAgICAgIChHZXRCYXNlQ2xhc3MpOiBtYWtlIFdlYktpdERP TUV2ZW50IGJlIFdlYktpdERPTUtleWJvYXJkRXZlbnQncyBwYXJlbnQsIGxpa2Ugd2UgZG8KKyAg ICAgICAgZm9yIFdlYktpdERPTU1vdXNlRXZlbnQuCisgICAgICAgICogZG9tL0tleWJvYXJkRXZl bnQuaWRsOiBnZW5lcmF0ZSBhIHNpbmdsZSBpbml0aWFsaXphdGlvbiBtZXRob2QuCisKIDIwMTMt MDgtMDkgIEJldGggRGFraW4gIDxiZGFraW5AYXBwbGUuY29tPgogCiAgICAgICAgIEFYOiBOb3Qg YWJsZSB0byB1c2UgYXJyb3cga2V5cyB0byByZWFkIHRleHQgaW4gYSBXSzIgYXBwCmRpZmYgLS1n aXQgYS9Tb3VyY2UvV2ViQ29yZS9iaW5kaW5ncy9nb2JqZWN0L0dOVW1ha2VmaWxlLmFtIGIvU291 cmNlL1dlYkNvcmUvYmluZGluZ3MvZ29iamVjdC9HTlVtYWtlZmlsZS5hbQppbmRleCA2YTIzNWM1 YzNjMmVjYzIxYTQ1OGM5YTBmZmM2ZjVjZTU5Yzk0MTQ0Li45NjU5OWU4NGQ2NTZmNDllZTQ3Nzlk YWJkMWJlN2ZmMmI3MDU3YjAxIDEwMDY0NAotLS0gYS9Tb3VyY2UvV2ViQ29yZS9iaW5kaW5ncy9n b2JqZWN0L0dOVW1ha2VmaWxlLmFtCisrKyBiL1NvdXJjZS9XZWJDb3JlL2JpbmRpbmdzL2dvYmpl Y3QvR05VbWFrZWZpbGUuYW0KQEAgLTIwMyw2ICsyMDMsOCBAQCB3ZWJraXRndGtfZ2RvbV9idWls dF9zb3VyY2VzICs9IFwKIAlEZXJpdmVkU291cmNlcy93ZWJraXRkb20vV2ViS2l0RE9NSFRNTFRp dGxlRWxlbWVudFByaXZhdGUuaCBcCiAJRGVyaXZlZFNvdXJjZXMvd2Via2l0ZG9tL1dlYktpdERP TUhUTUxVTGlzdEVsZW1lbnQuY3BwIFwKIAlEZXJpdmVkU291cmNlcy93ZWJraXRkb20vV2ViS2l0 RE9NSFRNTFVMaXN0RWxlbWVudFByaXZhdGUuaCBcCisJRGVyaXZlZFNvdXJjZXMvd2Via2l0ZG9t L1dlYktpdERPTUtleWJvYXJkRXZlbnQuY3BwIFwKKwlEZXJpdmVkU291cmNlcy93ZWJraXRkb20v V2ViS2l0RE9NS2V5Ym9hcmRFdmVudFByaXZhdGUuaCBcCiAJRGVyaXZlZFNvdXJjZXMvd2Via2l0 ZG9tL1dlYktpdERPTUxvY2F0aW9uLmNwcCBcCiAJRGVyaXZlZFNvdXJjZXMvd2Via2l0ZG9tL1dl YktpdERPTUxvY2F0aW9uUHJpdmF0ZS5oIFwKIAlEZXJpdmVkU291cmNlcy93ZWJraXRkb20vV2Vi S2l0RE9NTWVkaWFFcnJvci5jcHAgXApAQCAtMzA1LDYgKzMwNyw3IEBAIHdlYmtpdGd0a19nZG9t X2J1aWx0X2hfYXBpICs9IFwKIAlEZXJpdmVkU291cmNlcy93ZWJraXRkb20vV2ViS2l0RE9NRWxl bWVudC5oIFwKIAlEZXJpdmVkU291cmNlcy93ZWJraXRkb20vV2ViS2l0RE9NRW50aXR5UmVmZXJl bmNlLmggXAogCURlcml2ZWRTb3VyY2VzL3dlYmtpdGRvbS9XZWJLaXRET01FdmVudC5oIFwKKwlE ZXJpdmVkU291cmNlcy93ZWJraXRkb20vV2ViS2l0RE9NS2V5Ym9hcmRFdmVudC5oIFwKIAlEZXJp dmVkU291cmNlcy93ZWJraXRkb20vV2ViS2l0RE9NTWVzc2FnZVBvcnQuaCBcCiAJRGVyaXZlZFNv dXJjZXMvd2Via2l0ZG9tL1dlYktpdERPTU1vdXNlRXZlbnQuaCBcCiAJRGVyaXZlZFNvdXJjZXMv d2Via2l0ZG9tL1dlYktpdERPTU5hbWVkTm9kZU1hcC5oIFwKZGlmZiAtLWdpdCBhL1NvdXJjZS9X ZWJDb3JlL2JpbmRpbmdzL2dvYmplY3QvV2ViS2l0RE9NUHJpdmF0ZS5jcHAgYi9Tb3VyY2UvV2Vi Q29yZS9iaW5kaW5ncy9nb2JqZWN0L1dlYktpdERPTVByaXZhdGUuY3BwCmluZGV4IGNkZjQzNWIx NmVhYWIyYWZkNTY5NmUxNTY5ZWFkMGQwNjc0ZmRmNzQuLmY1MGRjY2ZjYzZjZjUyY2FkNWZhNWMw ZTA3NjQwYWNjNTBhZjkzNmMgMTAwNjQ0Ci0tLSBhL1NvdXJjZS9XZWJDb3JlL2JpbmRpbmdzL2dv YmplY3QvV2ViS2l0RE9NUHJpdmF0ZS5jcHAKKysrIGIvU291cmNlL1dlYkNvcmUvYmluZGluZ3Mv Z29iamVjdC9XZWJLaXRET01Qcml2YXRlLmNwcApAQCAtMzMsNiArMzMsNyBAQAogI2luY2x1ZGUg IkZpbGUuaCIKICNpbmNsdWRlICJIVE1MRWxlbWVudC5oIgogI2luY2x1ZGUgIkhUTUxOYW1lcy5o IgorI2luY2x1ZGUgIktleWJvYXJkRXZlbnQuaCIKICNpbmNsdWRlICJNb3VzZUV2ZW50LmgiCiAj aW5jbHVkZSAiU3R5bGVTaGVldC5oIgogI2luY2x1ZGUgIlVJRXZlbnQuaCIKQEAgLTU0LDYgKzU1 LDcgQEAKICNpbmNsdWRlICJXZWJLaXRET01IVE1MRG9jdW1lbnRQcml2YXRlLmgiCiAjaW5jbHVk ZSAiV2ViS2l0RE9NSFRNTE9wdGlvbnNDb2xsZWN0aW9uUHJpdmF0ZS5oIgogI2luY2x1ZGUgIldl YktpdERPTUhUTUxQcml2YXRlLmgiCisjaW5jbHVkZSAiV2ViS2l0RE9NS2V5Ym9hcmRFdmVudFBy aXZhdGUuaCIKICNpbmNsdWRlICJXZWJLaXRET01Nb3VzZUV2ZW50UHJpdmF0ZS5oIgogI2luY2x1 ZGUgIldlYktpdERPTU5vZGVQcml2YXRlLmgiCiAjaW5jbHVkZSAiV2ViS2l0RE9NUHJvY2Vzc2lu Z0luc3RydWN0aW9uUHJpdmF0ZS5oIgpAQCAtMTEyLDYgKzExNCw5IEBAIFdlYktpdERPTUV2ZW50 KiB3cmFwKEV2ZW50KiBldmVudCkKICAgICBpZiAoZXZlbnQtPmlzTW91c2VFdmVudCgpKQogICAg ICAgICByZXR1cm4gV0VCS0lUX0RPTV9FVkVOVCh3cmFwTW91c2VFdmVudChzdGF0aWNfY2FzdDxN b3VzZUV2ZW50Kj4oZXZlbnQpKSk7CiAKKyAgICBpZiAoZXZlbnQtPmlzS2V5Ym9hcmRFdmVudCgp KQorICAgICAgICByZXR1cm4gV0VCS0lUX0RPTV9FVkVOVCh3cmFwS2V5Ym9hcmRFdmVudChzdGF0 aWNfY2FzdDxLZXlib2FyZEV2ZW50Kj4oZXZlbnQpKSk7CisKICAgICBpZiAoZXZlbnQtPmlzVUlF dmVudCgpKQogICAgICAgICByZXR1cm4gV0VCS0lUX0RPTV9FVkVOVCh3cmFwVUlFdmVudChzdGF0 aWNfY2FzdDxVSUV2ZW50Kj4oZXZlbnQpKSk7CiAKZGlmZiAtLWdpdCBhL1NvdXJjZS9XZWJDb3Jl L2JpbmRpbmdzL3NjcmlwdHMvQ29kZUdlbmVyYXRvckdPYmplY3QucG0gYi9Tb3VyY2UvV2ViQ29y ZS9iaW5kaW5ncy9zY3JpcHRzL0NvZGVHZW5lcmF0b3JHT2JqZWN0LnBtCmluZGV4IDVjNWI3ZGUy MDA3ZWIzZDVhNGEzNzQ4NWQ3YjlhYTRkYjgyNzIwYjkuLmQyOThiYjYyNTI3ODFmZDk2YjBlZGM4 Nzc3NmIyOThhMGVhMmExMzggMTAwNjQ0Ci0tLSBhL1NvdXJjZS9XZWJDb3JlL2JpbmRpbmdzL3Nj cmlwdHMvQ29kZUdlbmVyYXRvckdPYmplY3QucG0KKysrIGIvU291cmNlL1dlYkNvcmUvYmluZGlu Z3Mvc2NyaXB0cy9Db2RlR2VuZXJhdG9yR09iamVjdC5wbQpAQCAtMTExLDcgKzExMSw3IEBAIHN1 YiBHZXRCYXNlQ2xhc3MKICAgICAkcGFyZW50ID0gc2hpZnQ7CiAKICAgICByZXR1cm4gJHBhcmVu dCBpZiAkcGFyZW50IGVxICJPYmplY3QiIG9yIElzQmFzZVR5cGUoJHBhcmVudCk7Ci0gICAgcmV0 dXJuICJFdmVudCIgaWYgJHBhcmVudCBlcSAiVUlFdmVudCIgb3IgJHBhcmVudCBlcSAiTW91c2VF dmVudCI7CisgICAgcmV0dXJuICJFdmVudCIgaWYgJHBhcmVudCBlcSAiVUlFdmVudCIgb3IgJHBh cmVudCBlcSAiTW91c2VFdmVudCIgb3IgJHBhcmVudCBlcSAiS2V5Ym9hcmRFdmVudCI7CiAgICAg cmV0dXJuICJDU1NWYWx1ZSIgaWYgJHBhcmVudCBlcSAiU1ZHQ29sb3IiIG9yICRwYXJlbnQgZXEg IkNTU1ZhbHVlTGlzdCI7CiAgICAgcmV0dXJuICJOb2RlIjsKIH0KZGlmZiAtLWdpdCBhL1NvdXJj ZS9XZWJDb3JlL2RvbS9LZXlib2FyZEV2ZW50LmlkbCBiL1NvdXJjZS9XZWJDb3JlL2RvbS9LZXli b2FyZEV2ZW50LmlkbAppbmRleCA3ZjM0NjAyY2QxYmJjOTg1ZjgyMTM5OGY0ZTc3NjVhNGYwOWFi MzI2Li5iZTlmOGYxMWM1ZmEyYmQ4OTM1ODY3YWZmMDhhYTZjMzcxYmIwZDE1IDEwMDY0NAotLS0g YS9Tb3VyY2UvV2ViQ29yZS9kb20vS2V5Ym9hcmRFdmVudC5pZGwKKysrIGIvU291cmNlL1dlYkNv cmUvZG9tL0tleWJvYXJkRXZlbnQuaWRsCkBAIC01OCw3ICs1OCw3IEBACiAgICAgICAgICAgICAg ICAgICAgICAgICAgICBbRGVmYXVsdD1VbmRlZmluZWRdIG9wdGlvbmFsIGJvb2xlYW4gYWx0R3Jh cGhLZXkpOwogCiAgICAgLy8gV2ViS2l0IEV4dGVuc2lvbnMKLSNpZiAhZGVmaW5lZChMQU5HVUFH RV9KQVZBU0NSSVBUKSB8fCAhTEFOR1VBR0VfSkFWQVNDUklQVAorI2lmICghZGVmaW5lZChMQU5H VUFHRV9KQVZBU0NSSVBUKSB8fCAhTEFOR1VBR0VfSkFWQVNDUklQVCkgJiYgKCFkZWZpbmVkKExB TkdVQUdFX0dPQkpFQ1QpIHx8ICFMQU5HVUFHRV9HT0JKRUNUKQogICAgIHJlYWRvbmx5IGF0dHJp YnV0ZSBsb25nICAgICAgICAgICAgIGtleUNvZGU7CiAgICAgcmVhZG9ubHkgYXR0cmlidXRlIGxv bmcgICAgICAgICAgICAgY2hhckNvZGU7CiAgICAgCg==