119619 2013-08-09 03:23:34 -0700 [Win] TestWebKitAPI fails to link. 2013-08-13 21:45:26 -0700 1 1 1 Unclassified WebKit WebKit Misc. 528+ (Nightly build) PC Unspecified RESOLVED FIXED P2 Normal --- 0 peavo webkit-unassigned achristensen bfulgham commit-queue oldest_to_newest 915748 0 peavo 2013-08-09 03:23:34 -0700 Linking TestWebKitAPI fails with the following error: error LNK2019: unresolved external symbol "protected: class WebCore::ImageOrientation __thiscall WebCore::BitmapImage::frameOrientationAtIndex(unsigned int)" (?frameOrientationAtIndex@BitmapImage@WebCore@@IAE?AVImageOrientation@2@I@Z) referenced in function "public: virtual class WebCore::ImageOrientation __thiscall WebCore::BitmapImage::orientationForCurrentFrame(void)" (?orientationForCurrentFrame@BitmapImage@WebCore@@UAE?AVImageOrientation@2@XZ) 915749 1 208412 peavo 2013-08-09 03:29:14 -0700 Created attachment 208412 Patch 916301 2 208412 bfulgham 2013-08-12 09:23:06 -0700 Comment on attachment 208412 Patch r=me 916306 3 208412 commit-queue 2013-08-12 09:31:50 -0700 Comment on attachment 208412 Patch Clearing flags on attachment: 208412 Committed r153943: <http://trac.webkit.org/changeset/153943> 916307 4 commit-queue 2013-08-12 09:31:51 -0700 All reviewed patches have been landed. Closing bug. 916997 5 achristensen 2013-08-13 21:45:26 -0700 The parameter of this function is a size_t, which is the size of a pointer, which changes with the 64-bit build. This should have been the following: symbolWithPointer(?frameOrientationAtIndex@BitmapImage@WebCore@@IAE?AVImageOrientation@2@I@Z, ?frameOrientationAtIndex@BitmapImage@WebCore@@IEAA?AVImageOrientation@2@_K@Z) I'll commit this manually. It doesn't break anything any bots are doing right now. 208412 2013-08-09 03:29:14 -0700 2013-08-12 09:31:50 -0700 Patch bug-119619-20130809122900.patch text/plain 2220 peavo SW5kZXg6IFNvdXJjZS9XZWJLaXQvQ2hhbmdlTG9nCj09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT0KLS0tIFNvdXJjZS9XZWJL aXQvQ2hhbmdlTG9nCShyZXZpc2lvbiAxNTM4ODEpCisrKyBTb3VyY2UvV2ViS2l0L0NoYW5nZUxv Zwkod29ya2luZyBjb3B5KQpAQCAtMSwzICsxLDEyIEBACisyMDEzLTA4LTA5ICBwZWF2b0BvdXRs b29rLmNvbSAgPHBlYXZvQG91dGxvb2suY29tPgorCisgICAgICAgIFtXaW5dIFRlc3RXZWJLaXRB UEkgZmFpbHMgdG8gbGluay4KKyAgICAgICAgaHR0cHM6Ly9idWdzLndlYmtpdC5vcmcvc2hvd19i dWcuY2dpP2lkPTExOTYxOQorCisgICAgICAgIFJldmlld2VkIGJ5IE5PQk9EWSAoT09QUyEpLgor CisgICAgICAgICogV2ViS2l0LnZjeHByb2ovV2ViS2l0RXhwb3J0R2VuZXJhdG9yL1dlYktpdEV4 cG9ydHMuZGVmLmluOiBFeHBvcnQgbmVlZGVkIHN5bWJvbC4KKwogMjAxMy0wOC0wNyAgUnl1YW4g Q2hvaSAgPHJ5dWFuLmNob2lAc2Ftc3VuZy5jb20+CiAKICAgICAgICAgVW5yZXZpZXdlZCBidWls ZCBmaXggb24gRWZsIHBvcnQgYWZ0ZXIgcjE1Mzc4NS4KSW5kZXg6IFNvdXJjZS9XZWJLaXQvV2Vi S2l0LnZjeHByb2ovV2ViS2l0RXhwb3J0R2VuZXJhdG9yL1dlYktpdEV4cG9ydHMuZGVmLmluCj09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT0KLS0tIFNvdXJjZS9XZWJLaXQvV2ViS2l0LnZjeHByb2ovV2ViS2l0RXhwb3J0R2Vu ZXJhdG9yL1dlYktpdEV4cG9ydHMuZGVmLmluCShyZXZpc2lvbiAxNTM4NzUpCisrKyBTb3VyY2Uv V2ViS2l0L1dlYktpdC52Y3hwcm9qL1dlYktpdEV4cG9ydEdlbmVyYXRvci9XZWJLaXRFeHBvcnRz LmRlZi5pbgkod29ya2luZyBjb3B5KQpAQCAtMzk2LDYgKzM5Niw3IEBAIEVYUE9SVFMKICAgICAg ICAgc3ltYm9sV2l0aFBvaW50ZXIoP3NvbGlkQ29sb3JAQml0bWFwSW1hZ2VAV2ViQ29yZUBATUJF P0FWQ29sb3JAMkBYWiwgP3NvbGlkQ29sb3JAQml0bWFwSW1hZ2VAV2ViQ29yZUBATUVCQT9BVkNv bG9yQDJAWFopCiAgICAgICAgIHN5bWJvbFdpdGhQb2ludGVyKD9kcmF3QEJpdG1hcEltYWdlQFdl YkNvcmVAQE1BRVhQQVZHcmFwaGljc0NvbnRleHRAMkBBQlZGbG9hdFJlY3RAMkAxVzRDb2xvclNw YWNlQDJAVzRDb21wb3NpdGVPcGVyYXRvckAyQFc0QmxlbmRNb2RlQDJAVzRSZXNwZWN0SW1hZ2VP cmllbnRhdGlvbkVudW1AMkBAWiwgP2RyYXdAQml0bWFwSW1hZ2VAV2ViQ29yZUBATUVBQVhQRUFW R3JhcGhpY3NDb250ZXh0QDJAQUVCVkZsb2F0UmVjdEAyQDFXNENvbG9yU3BhY2VAMkBXNENvbXBv c2l0ZU9wZXJhdG9yQDJAVzRCbGVuZE1vZGVAMkBXNFJlc3BlY3RJbWFnZU9yaWVudGF0aW9uRW51 bUAyQEBaKQogICAgICAgICBzeW1ib2xXaXRoUG9pbnRlcig/ZnJhbWVDb3VudEBCaXRtYXBJbWFn ZUBXZWJDb3JlQEBNQUVJWFosID9mcmFtZUNvdW50QEJpdG1hcEltYWdlQFdlYkNvcmVAQE1FQUFf S1haKQorICAgICAgICA/ZnJhbWVPcmllbnRhdGlvbkF0SW5kZXhAQml0bWFwSW1hZ2VAV2ViQ29y ZUBASUFFP0FWSW1hZ2VPcmllbnRhdGlvbkAyQElAWgogICAgICAgICBzeW1ib2xXaXRoUG9pbnRl cig/YWRkQXV0aG9yU2hlZXRARG9jdW1lbnRTdHlsZVNoZWV0Q29sbGVjdGlvbkBXZWJDb3JlQEBR QUVYVj8kUGFzc1JlZlB0ckBWU3R5bGVTaGVldENvbnRlbnRzQFdlYkNvcmVAQEBXVEZAQEBaLCA/ YWRkQXV0aG9yU2hlZXRARG9jdW1lbnRTdHlsZVNoZWV0Q29sbGVjdGlvbkBXZWJDb3JlQEBRRUFB WFY/JFBhc3NSZWZQdHJAVlN0eWxlU2hlZXRDb250ZW50c0BXZWJDb3JlQEBAV1RGQEBAWikKICAg ICAgICAgc3ltYm9sV2l0aFBvaW50ZXIoP3BhcnNlU3RyaW5nQFN0eWxlU2hlZXRDb250ZW50c0BX ZWJDb3JlQEBRQUVfTkFCVlN0cmluZ0BXVEZAQEBaLCA/cGFyc2VTdHJpbmdAU3R5bGVTaGVldENv bnRlbnRzQFdlYkNvcmVAQFFFQUFfTkFFQlZTdHJpbmdAV1RGQEBAWikKICAgICAgICAgc3ltYm9s V2l0aFBvaW50ZXIoPz8wQ1NTUGFyc2VyQ29udGV4dEBXZWJDb3JlQEBRQUVAUEFWRG9jdW1lbnRA MUBBQlZLVVJMQDFAQUJWU3RyaW5nQFdURkBAQFosID8/MENTU1BhcnNlckNvbnRleHRAV2ViQ29y ZUBAUUVBQUBQRUFWRG9jdW1lbnRAMUBBRUJWS1VSTEAxQEFFQlZTdHJpbmdAV1RGQEBAWikK