119616 2013-08-09 01:04:29 -0700 [Qt] Build fix (typo in WebCore/xml/parser/XMLDocumentParserQt.cpp) 2013-08-09 02:03:46 -0700 1 1 1 Unclassified WebKit WebCore Misc. 528+ (Nightly build) Unspecified Unspecified RESOLVED FIXED P2 Normal --- 0 jbriance webkit-unassigned commit-queue oldest_to_newest 915723 0 jbriance 2013-08-09 01:04:29 -0700 Changeset r153826 broke our sh4 build bot: http://build.webkit.org/builders/Qt%20Linux%20SH4%20Release/builds/28477 /local/wkit/slavebuildbot_LOCAL/workspace_LOCAL/qt-linux-sh4-release/build/Source/WebCore/xml/parser/XMLDocumentParserQt.cpp: In constructor 'WebCore::XMLDocumentParser::XMLDocumentParser(WebCore::DocumentFragment*, WebCore::Element*, WebCore::ParserContentPolicy)': /local/wkit/slavebuildbot_LOCAL/workspace_LOCAL/qt-linux-sh4-release/build/Source/WebCore/xml/parser/XMLDocumentParserQt.cpp:159:49: error: base operand of '->' has non-pointer type 'const WebCore::Attribute' make[3]: *** [.obj/release-shared/xml/parser/XMLDocumentParserQt.o] Error 1 make[3]: *** Waiting for unfinished jobs.... 915724 1 208403 jbriance 2013-08-09 01:12:24 -0700 Created attachment 208403 Build fix 915730 2 208403 commit-queue 2013-08-09 02:03:43 -0700 Comment on attachment 208403 Build fix Clearing flags on attachment: 208403 Committed r153878: <http://trac.webkit.org/changeset/153878> 915731 3 commit-queue 2013-08-09 02:03:46 -0700 All reviewed patches have been landed. Closing bug. 208403 2013-08-09 01:12:24 -0700 2013-08-09 02:03:43 -0700 Build fix bug-119616.patch text/plain 1439 jbriance SW5kZXg6IFNvdXJjZS9XZWJDb3JlL0NoYW5nZUxvZwo9PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09Ci0tLSBTb3VyY2UvV2Vi Q29yZS9DaGFuZ2VMb2cJKHJldmlzaW9uIDE1Mzg3NykKKysrIFNvdXJjZS9XZWJDb3JlL0NoYW5n ZUxvZwkod29ya2luZyBjb3B5KQpAQCAtMSwzICsxLDEzIEBACisyMDEzLTA4LTA5ICBKdWxpZW4g QnJpYW5jZWF1ICA8amJyaWFuY2VhdUBuZHMuY29tPgorCisgICAgICAgIFtRdF0gRml4IGJ1aWxk IChicm9rZW4gYnkgY2hhbmdlc2V0IHIxNTM4MjYpLgorICAgICAgICBodHRwczovL2J1Z3Mud2Vi a2l0Lm9yZy9zaG93X2J1Zy5jZ2k/aWQ9MTE5NjE2CisKKyAgICAgICAgUmV2aWV3ZWQgYnkgTk9C T0RZIChPT1BTISkuCisKKyAgICAgICAgKiB4bWwvcGFyc2VyL1hNTERvY3VtZW50UGFyc2VyUXQu Y3BwOgorICAgICAgICAoV2ViQ29yZTo6WE1MRG9jdW1lbnRQYXJzZXI6OlhNTERvY3VtZW50UGFy c2VyKToKKwogMjAxMy0wOC0wOCAgVGltIEhvcnRvbiAgPHRpbW90aHlfaG9ydG9uQGFwcGxlLmNv bT4KIAogICAgICAgICBuYXZpZ2F0b3IucGx1Z2lucyBoYXMgcGx1Z2lucyBpbiBpdCB3aGVuIHBs dWdpbnMgYXJlIGRpc2FibGVkCkluZGV4OiBTb3VyY2UvV2ViQ29yZS94bWwvcGFyc2VyL1hNTERv Y3VtZW50UGFyc2VyUXQuY3BwCj09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT0KLS0tIFNvdXJjZS9XZWJDb3JlL3htbC9wYXJz ZXIvWE1MRG9jdW1lbnRQYXJzZXJRdC5jcHAJKHJldmlzaW9uIDE1Mzg3NykKKysrIFNvdXJjZS9X ZWJDb3JlL3htbC9wYXJzZXIvWE1MRG9jdW1lbnRQYXJzZXJRdC5jcHAJKHdvcmtpbmcgY29weSkK QEAgLTE1Niw3ICsxNTYsNyBAQCBYTUxEb2N1bWVudFBhcnNlcjo6WE1MRG9jdW1lbnRQYXJzZXIo RG9jCiAgICAgICAgICAgICBmb3IgKHVuc2lnbmVkIGkgPSAwOyBpIDwgYXR0cnMtPmxlbmd0aCgp OyBpKyspIHsKICAgICAgICAgICAgICAgICBjb25zdCBBdHRyaWJ1dGUmIGF0dHIgPSBhdHRycy0+ YXR0cmlidXRlQXQoaSk7CiAgICAgICAgICAgICAgICAgaWYgKGF0dHIubG9jYWxOYW1lKCkgPT0g InhtbG5zIikKLSAgICAgICAgICAgICAgICAgICAgbV9kZWZhdWx0TmFtZXNwYWNlVVJJID0gYXR0 ci0+dmFsdWUoKTsKKyAgICAgICAgICAgICAgICAgICAgbV9kZWZhdWx0TmFtZXNwYWNlVVJJID0g YXR0ci52YWx1ZSgpOwogICAgICAgICAgICAgICAgIGVsc2UgaWYgKGF0dHIucHJlZml4KCkgPT0g InhtbG5zIikKICAgICAgICAgICAgICAgICAgICAgbmFtZXNwYWNlcy5hcHBlbmQoUVhtbFN0cmVh bU5hbWVzcGFjZURlY2xhcmF0aW9uKGF0dHIubG9jYWxOYW1lKCksIGF0dHIudmFsdWUoKSkpOwog ICAgICAgICAgICAgfQo=