119594 2013-08-08 14:21:51 -0700 Add logging to the primary plugin detection 2013-08-08 14:33:25 -0700 1 1 1 Unclassified WebKit Plug-ins 528+ (Nightly build) Unspecified Unspecified RESOLVED FIXED InRadar P2 Normal --- 1 dino dino thorton webkit-bug-importer oldest_to_newest 915589 0 dino 2013-08-08 14:21:51 -0700 We're seeing some unusual behaviour. Add some logging for diagnosis. 915590 1 webkit-bug-importer 2013-08-08 14:22:31 -0700 <rdar://problem/14689986> 915592 2 208370 dino 2013-08-08 14:24:40 -0700 Created attachment 208370 Patch 915593 3 208370 thorton 2013-08-08 14:26:16 -0700 Comment on attachment 208370 Patch View in context: https://bugs.webkit.org/attachment.cgi?id=208370&action=review > Source/WebKit2/WebProcess/WebPage/WebPage.cpp:4056 > + LOG(Plugins, "Primary Plug-In Detection: began."); Might also be nice to log when we start the timer-if-it's-not-already-started, and at which source (didFinishLoad or addPluginView). 915596 4 dino 2013-08-08 14:33:25 -0700 Committed r153848: <http://trac.webkit.org/changeset/153848> 208370 2013-08-08 14:24:40 -0700 2013-08-08 14:26:16 -0700 Patch bug-119594-20130809072438.patch text/plain 2810 dino U3VidmVyc2lvbiBSZXZpc2lvbjogMTUzODQzCmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViS2l0Mi9D aGFuZ2VMb2cgYi9Tb3VyY2UvV2ViS2l0Mi9DaGFuZ2VMb2cKaW5kZXggZDkwYmNlYzUzMmQ0Njlh YzRmY2JlMzc3MWRlNjMwN2QxMWM0MGE3ZC4uNDI1MjkwY2FkNTVjN2Y2ZDVhMTNjOTkzMzlhZjVi NGMxYTNlYjhkZiAxMDA2NDQKLS0tIGEvU291cmNlL1dlYktpdDIvQ2hhbmdlTG9nCisrKyBiL1Nv dXJjZS9XZWJLaXQyL0NoYW5nZUxvZwpAQCAtMSwzICsxLDE1IEBACisyMDEzLTA4LTA4ICBEZWFu IEphY2tzb24gIDxkaW5vQGFwcGxlLmNvbT4KKworICAgICAgICBBZGQgbG9nZ2luZyB0byB0aGUg cHJpbWFyeSBwbHVnaW4gZGV0ZWN0aW9uCisgICAgICAgIGh0dHBzOi8vYnVncy53ZWJraXQub3Jn L3Nob3dfYnVnLmNnaT9pZD0xMTk1OTQKKworICAgICAgICBSZXZpZXdlZCBieSBOT0JPRFkgKE9P UFMhKS4KKworICAgICAgICBBZGQgc29tZSBzaW1wbGUgbG9nZ2luZyB0byBvdXIgcHJpbWFyeSBw bHVnLWluIGRldGVjdGlvbi4KKworICAgICAgICAqIFdlYlByb2Nlc3MvV2ViUGFnZS9XZWJQYWdl LmNwcDoKKyAgICAgICAgKFdlYktpdDo6V2ViUGFnZTo6ZGV0ZXJtaW5lUHJpbWFyeVNuYXBzaG90 dGVkUGx1Z0luKToKKwogMjAxMy0wOC0wOCAgQWxleGV5IFByb3NrdXJ5YWtvdiAgPGFwQGFwcGxl LmNvbT4KIAogICAgICAgICBXS0J1bmRsZUZyYW1lQ29weVByb3Zpc2lvbmFsVVJMIGNyYXNoZXMg d2hlbiB0aGVyZSBpcyBubyBwcm92aXNpb25hbCBsb2FkZXIKZGlmZiAtLWdpdCBhL1NvdXJjZS9X ZWJLaXQyL1dlYlByb2Nlc3MvV2ViUGFnZS9XZWJQYWdlLmNwcCBiL1NvdXJjZS9XZWJLaXQyL1dl YlByb2Nlc3MvV2ViUGFnZS9XZWJQYWdlLmNwcAppbmRleCA4YjM3ZjllYjQ1ZWEwOTRhMjQ1ZDk3 MTkxNTg4ZDZiZTNlNTIxNjY2Li4wYWZjOTU1OTNlODAzZWFiYTQ2NzIzNzZmZDMyZTg3YWRkMzgx Y2ZmIDEwMDY0NAotLS0gYS9Tb3VyY2UvV2ViS2l0Mi9XZWJQcm9jZXNzL1dlYlBhZ2UvV2ViUGFn ZS5jcHAKKysrIGIvU291cmNlL1dlYktpdDIvV2ViUHJvY2Vzcy9XZWJQYWdlL1dlYlBhZ2UuY3Bw CkBAIC0zNyw2ICszNyw3IEBACiAjaW5jbHVkZSAiSW5qZWN0ZWRCdW5kbGVCYWNrRm9yd2FyZExp c3QuaCIKICNpbmNsdWRlICJJbmplY3RlZEJ1bmRsZVVzZXJNZXNzYWdlQ29kZXJzLmgiCiAjaW5j bHVkZSAiTGF5ZXJUcmVlSG9zdC5oIgorI2luY2x1ZGUgIkxvZ2dpbmcuaCIKICNpbmNsdWRlICJO ZXRzY2FwZVBsdWdpbi5oIgogI2luY2x1ZGUgIk5vdGlmaWNhdGlvblBlcm1pc3Npb25SZXF1ZXN0 TWFuYWdlci5oIgogI2luY2x1ZGUgIlBhZ2VCYW5uZXIuaCIKQEAgLTQwNTIsMTQgKzQwNTMsMjIg QEAgdm9pZCBXZWJQYWdlOjpkZXRlcm1pbmVQcmltYXJ5U25hcHNob3R0ZWRQbHVnSW4oKQogICAg IGlmICghbV9wYWdlLT5zZXR0aW5ncygpLT5wbHVnSW5TbmFwc2hvdHRpbmdFbmFibGVkKCkpCiAg ICAgICAgIHJldHVybjsKIAotICAgIGlmICghbV9yZWFkeVRvRmluZFByaW1hcnlTbmFwc2hvdHRl ZFBsdWdpbikKKyAgICBMT0coUGx1Z2lucywgIlByaW1hcnkgUGx1Zy1JbiBEZXRlY3Rpb246IGJl Z2FuLiIpOworCisgICAgaWYgKCFtX3JlYWR5VG9GaW5kUHJpbWFyeVNuYXBzaG90dGVkUGx1Z2lu KSB7CisgICAgICAgIExPRyhQbHVnaW5zLCAiUHJpbWFyeSBQbHVnLUluIERldGVjdGlvbjogZXhp dGluZyAtIG5vdCByZWFkeSB0byBmaW5kIHBsdWdpbnMuIik7CiAgICAgICAgIHJldHVybjsKKyAg ICB9CiAKLSAgICBpZiAobV9wbHVnaW5WaWV3cy5pc0VtcHR5KCkpCisgICAgaWYgKG1fcGx1Z2lu Vmlld3MuaXNFbXB0eSgpKSB7CisgICAgICAgIExPRyhQbHVnaW5zLCAiUHJpbWFyeSBQbHVnLUlu IERldGVjdGlvbjogZXhpdGluZyAtIG5vIHBsdWdpbiB2aWV3cy4iKTsKICAgICAgICAgcmV0dXJu OworICAgIH0KIAotICAgIGlmIChtX2RpZEZpbmRQcmltYXJ5U25hcHNob3R0ZWRQbHVnaW4pCisg ICAgaWYgKG1fZGlkRmluZFByaW1hcnlTbmFwc2hvdHRlZFBsdWdpbikgeworICAgICAgICBMT0co UGx1Z2lucywgIlByaW1hcnkgUGx1Zy1JbiBEZXRlY3Rpb246IGV4aXRpbmcgLSB3ZSd2ZSBhbHJl YWR5IGZvdW5kIGEgcHJpbWFyeSBwbHVnLWluLiIpOwogICAgICAgICByZXR1cm47CisgICAgfQog CiAgICAgUmVuZGVyVmlldyogcmVuZGVyVmlldyA9IGNvcmVQYWdlKCktPm1haW5GcmFtZSgpLT52 aWV3KCktPnJlbmRlclZpZXcoKTsKIApAQCAtNDExNCw5ICs0MTIzLDEyIEBAIHZvaWQgV2ViUGFn ZTo6ZGV0ZXJtaW5lUHJpbWFyeVNuYXBzaG90dGVkUGx1Z0luKCkKICAgICAgICAgfQogICAgIH0K IAotICAgIGlmICghY2FuZGlkYXRlUGx1Z0luKQorICAgIGlmICghY2FuZGlkYXRlUGx1Z0luKSB7 CisgICAgICAgIExPRyhQbHVnaW5zLCAiUHJpbWFyeSBQbHVnLUluIERldGVjdGlvbjogZmFpbCAt IGRpZCBub3QgZmluZCBhIGNhbmRpZGF0ZSBwbHVnLWluLiIpOwogICAgICAgICByZXR1cm47Cisg ICAgfQogCisgICAgTE9HKFBsdWdpbnMsICJQcmltYXJ5IFBsdWctSW4gRGV0ZWN0aW9uOiBzdWNj ZXNzIC0gZm91bmQgYSBjYW5kaWRhdGUgcGx1Z2lpbiAtIGluZm9ybSBpdC4iKTsKICAgICBtX2Rp ZEZpbmRQcmltYXJ5U25hcHNob3R0ZWRQbHVnaW4gPSB0cnVlOwogICAgIG1fcHJpbWFyeVBsdWdJ blBhZ2VPcmlnaW4gPSBtX3BhZ2UtPm1haW5GcmFtZSgpLT5kb2N1bWVudCgpLT5iYXNlVVJMKCku aG9zdCgpOwogICAgIG1fcHJpbWFyeVBsdWdJbk9yaWdpbiA9IGNhbmRpZGF0ZVBsdWdJbi0+bG9h ZGVkVXJsKCkuaG9zdCgpOwo=