119593 2013-08-08 13:59:28 -0700 [Windows] Improper Caption Button Displayed to Users 2013-08-08 14:11:18 -0700 1 1 1 Unclassified WebKit WebKit Misc. 528+ (Nightly build) Unspecified Unspecified RESOLVED FIXED P2 Normal --- 1 bfulgham bfulgham commit-queue esprehn+autocc glenn kondapallykalyan oldest_to_newest 915576 0 bfulgham 2013-08-08 13:59:28 -0700 The Mac port displays a closed caption button that looks like a speech bubble. On Windows, this is displayed using the old-style "CC" icon. We should be consistent on both platforms. 915579 1 bfulgham 2013-08-08 14:01:18 -0700 <rdar://problem/14688769> 915584 2 208369 bfulgham 2013-08-08 14:09:05 -0700 Created attachment 208369 Patch 915586 3 bfulgham 2013-08-08 14:11:18 -0700 Committed r153845: <http://trac.webkit.org/changeset/153845> 208369 2013-08-08 14:09:05 -0700 2013-08-08 14:10:28 -0700 Patch bug-119593-20130808140900.patch text/plain 2585 bfulgham SW5kZXg6IFNvdXJjZS9XZWJDb3JlL0NoYW5nZUxvZwo9PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09Ci0tLSBTb3VyY2UvV2Vi Q29yZS9DaGFuZ2VMb2cJKHJldmlzaW9uIDE1Mzg0MykKKysrIFNvdXJjZS9XZWJDb3JlL0NoYW5n ZUxvZwkod29ya2luZyBjb3B5KQpAQCAtMSwzICsxLDE2IEBACisyMDEzLTA4LTA4ICBCcmVudCBG dWxnaGFtICA8YmZ1bGdoYW1AYXBwbGUuY29tPgorCisgICAgICAgIFtXaW5kb3dzXSBJbXByb3Bl ciBDYXB0aW9uIEJ1dHRvbiBEaXNwbGF5ZWQgdG8gVXNlcnMKKyAgICAgICAgaHR0cHM6Ly9idWdz LndlYmtpdC5vcmcvc2hvd19idWcuY2dpP2lkPTExOTU5MyAKKworICAgICAgICBSZXZpZXdlZCBi eSBOT0JPRFkgKE9PUFMhKS4KKworICAgICAgICBSZW1vdmUgdGhlIGN1c3RvbSBkcmF3aW5nIGNv ZGUgZm9yIHRoZSBXaW5kb3dzIHBvcnQsIGFuZAorICAgICAgICBoYXZlIGl0IHJlbmRlciB1c2lu ZyB0aGUgQ1NTL1NWRyBtYXJrdXAgbGlrZSB3ZSBkbyBvbiBPUyBYLgorCisgICAgICAgICogcmVu ZGVyaW5nL1JlbmRlclRoZW1lV2luLmNwcDogUmVtb3ZlIGRyYXdpbmcgY29kZS4KKyAgICAgICAg KiByZW5kZXJpbmcvUmVuZGVyVGhlbWVXaW4uaDogUmVtb3ZlIGRlY2xhcmF0aW9uLgorCiAyMDEz LTA4LTA4ICBBbGV4IENocmlzdGVuc2VuICA8YWNocmlzdGVuc2VuQGFwcGxlLmNvbT4KIAogICAg ICAgICBXb3JrIHRvd2FyZHMgV2ViR0wgb24gQXBwbGVXaW4gcG9ydC4KSW5kZXg6IFNvdXJjZS9X ZWJDb3JlL3JlbmRlcmluZy9SZW5kZXJUaGVtZVdpbi5jcHAKPT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PQotLS0gU291cmNl L1dlYkNvcmUvcmVuZGVyaW5nL1JlbmRlclRoZW1lV2luLmNwcAkocmV2aXNpb24gMTUzNzY2KQor KysgU291cmNlL1dlYkNvcmUvcmVuZGVyaW5nL1JlbmRlclRoZW1lV2luLmNwcAkod29ya2luZyBj b3B5KQpAQCAtMTEzOCwxMSArMTEzOCw2IEBAIGJvb2wgUmVuZGVyVGhlbWVXaW46OnBhaW50TWVk aWFTbGlkZXJUaHUKICAgICByZXR1cm4gUmVuZGVyTWVkaWFDb250cm9sczo6cGFpbnRNZWRpYUNv bnRyb2xzUGFydChNZWRpYVNsaWRlclRodW1iLCBvLCBwYWludEluZm8sIHIpOwogfQogCi1ib29s IFJlbmRlclRoZW1lV2luOjpwYWludE1lZGlhVG9nZ2xlQ2xvc2VkQ2FwdGlvbnNCdXR0b24oUmVu ZGVyT2JqZWN0KiBvLCBjb25zdCBQYWludEluZm8mIHBhaW50SW5mbywgY29uc3QgSW50UmVjdCYg cikKLXsKLSAgICByZXR1cm4gUmVuZGVyTWVkaWFDb250cm9sczo6cGFpbnRNZWRpYUNvbnRyb2xz UGFydChNZWRpYVNob3dDbG9zZWRDYXB0aW9uc0J1dHRvbiwgbywgcGFpbnRJbmZvLCByKTsKLX0K LQogYm9vbCBSZW5kZXJUaGVtZVdpbjo6cGFpbnRNZWRpYUNvbnRyb2xzQmFja2dyb3VuZChSZW5k ZXJPYmplY3QqIG8sIGNvbnN0IFBhaW50SW5mbyYgcGFpbnRJbmZvLCBjb25zdCBJbnRSZWN0JiBy KQogewogICAgIHJldHVybiBSZW5kZXJNZWRpYUNvbnRyb2xzOjpwYWludE1lZGlhQ29udHJvbHNQ YXJ0KE1lZGlhVGltZWxpbmVDb250YWluZXIsIG8sIHBhaW50SW5mbywgcik7CkluZGV4OiBTb3Vy Y2UvV2ViQ29yZS9yZW5kZXJpbmcvUmVuZGVyVGhlbWVXaW4uaAo9PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09Ci0tLSBTb3Vy Y2UvV2ViQ29yZS9yZW5kZXJpbmcvUmVuZGVyVGhlbWVXaW4uaAkocmV2aXNpb24gMTUzNzY2KQor KysgU291cmNlL1dlYkNvcmUvcmVuZGVyaW5nL1JlbmRlclRoZW1lV2luLmgJKHdvcmtpbmcgY29w eSkKQEAgLTEzNyw3ICsxMzcsNiBAQCBwdWJsaWM6CiAgICAgdmlydHVhbCBib29sIHBhaW50TWVk aWFTZWVrRm9yd2FyZEJ1dHRvbihSZW5kZXJPYmplY3QqLCBjb25zdCBQYWludEluZm8mLCBjb25z dCBJbnRSZWN0Jik7CiAgICAgdmlydHVhbCBib29sIHBhaW50TWVkaWFTbGlkZXJUcmFjayhSZW5k ZXJPYmplY3QqLCBjb25zdCBQYWludEluZm8mLCBjb25zdCBJbnRSZWN0Jik7CiAgICAgdmlydHVh bCBib29sIHBhaW50TWVkaWFTbGlkZXJUaHVtYihSZW5kZXJPYmplY3QqLCBjb25zdCBQYWludElu Zm8mLCBjb25zdCBJbnRSZWN0Jik7Ci0gICAgdmlydHVhbCBib29sIHBhaW50TWVkaWFUb2dnbGVD bG9zZWRDYXB0aW9uc0J1dHRvbihSZW5kZXJPYmplY3QqLCBjb25zdCBQYWludEluZm8mLCBjb25z dCBJbnRSZWN0Jik7CiAgICAgdmlydHVhbCBib29sIHBhaW50TWVkaWFWb2x1bWVTbGlkZXJDb250 YWluZXIoUmVuZGVyT2JqZWN0KiwgY29uc3QgUGFpbnRJbmZvJiwgY29uc3QgSW50UmVjdCYpOwog ICAgIHZpcnR1YWwgYm9vbCBwYWludE1lZGlhVm9sdW1lU2xpZGVyVHJhY2soUmVuZGVyT2JqZWN0 KiwgY29uc3QgUGFpbnRJbmZvJiwgY29uc3QgSW50UmVjdCYpOwogICAgIHZpcnR1YWwgYm9vbCBw YWludE1lZGlhVm9sdW1lU2xpZGVyVGh1bWIoUmVuZGVyT2JqZWN0KiwgY29uc3QgUGFpbnRJbmZv JiwgY29uc3QgSW50UmVjdCYpOwo=