119551 2013-08-07 10:43:48 -0700 Every scroll causes additional layer tree work because of flatteningLayer->removeFromParent(); 2013-08-13 13:17:27 -0700 1 1 1 Unclassified WebKit Layout and Rendering 528+ (Nightly build) Unspecified Unspecified RESOLVED FIXED P2 Normal --- 1 simon.fraser simon.fraser commit-queue dino esprehn+autocc glenn kondapallykalyan simon.fraser oldest_to_newest 915209 0 simon.fraser 2013-08-07 10:43:48 -0700 Whenever we update layer geometry on a layer with a tile cache flattening layer, we hit: if (GraphicsLayer* flatteningLayer = tileCacheFlatteningLayer()) { flatteningLayer->removeFromParent(); m_graphicsLayer->addChild(flatteningLayer); } which is normally a no-op, but does cause us to push a new sublayers array down to CA. We should avoid this. 916853 1 208668 simon.fraser 2013-08-13 13:07:22 -0700 Created attachment 208668 Patch 916856 2 simon.fraser 2013-08-13 13:17:27 -0700 https://trac.webkit.org/r154018 208668 2013-08-13 13:07:22 -0700 2013-08-13 13:08:57 -0700 Patch bug-119551-20130813130724.patch text/plain 1862 simon.fraser U3VidmVyc2lvbiBSZXZpc2lvbjogMTU0MDE1CmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViQ29yZS9D aGFuZ2VMb2cgYi9Tb3VyY2UvV2ViQ29yZS9DaGFuZ2VMb2cKaW5kZXggZTMyMDIzMmRlYzI3ZDBj Njg2Y2U1YWViMDQ4MjJhYjMzMjg3NDhiZC4uMzE3MTZiNzkyOTViNDY4ZDM1Yzc1NjBkZjQ3MGNk ZjJjNTFkZDQyNiAxMDA2NDQKLS0tIGEvU291cmNlL1dlYkNvcmUvQ2hhbmdlTG9nCisrKyBiL1Nv dXJjZS9XZWJDb3JlL0NoYW5nZUxvZwpAQCAtMSwzICsxLDIwIEBACisyMDEzLTA4LTEzICBTaW1v biBGcmFzZXIgIDxzaW1vbi5mcmFzZXJAYXBwbGUuY29tPgorCisgICAgICAgIEV2ZXJ5IHNjcm9s bCBjYXVzZXMgYWRkaXRpb25hbCBsYXllciB0cmVlIHdvcmsgYmVjYXVzZSBvZiBmbGF0dGVuaW5n TGF5ZXItPnJlbW92ZUZyb21QYXJlbnQoKTsKKyAgICAgICAgaHR0cHM6Ly9idWdzLndlYmtpdC5v cmcvc2hvd19idWcuY2dpP2lkPTExOTU1MQorCisgICAgICAgIFJldmlld2VkIGJ5IE5PQk9EWSAo T09QUyEpLgorCisgICAgICAgIE9ubHkgcmUtcGFyZW50IHRoZSBmbGF0dGVuaW5nIGxheWVyIGlm IHdlIGhhZCB0byB1cGRhdGUgb3VyCisgICAgICAgIGxheWVyIGNvbmZpZ3VyYXRpb24gKHJlcGFy ZW50aW5nIGlzIG5lY2Vzc2FyeSB0aGVuIHRvIGdldAorICAgICAgICB0aGUgY29ycmVjdCBzaWJs aW5nIG9yZGVyaW5nKSwgb3IgaWYgaXQgd2FzIHBhcmVudGVkIGluIHNvbWUKKyAgICAgICAgb3Ro ZXIgbGF5ZXIuCisgICAgICAgIAorICAgICAgICBUaGlzIGF2b2lkIHVubmVjZXNzYXJ5IGZsdXNo aW5nIG9mIHN0YXRlIHRvIENBLgorCisgICAgICAgICogcmVuZGVyaW5nL1JlbmRlckxheWVyQmFj a2luZy5jcHA6CisgICAgICAgIChXZWJDb3JlOjpSZW5kZXJMYXllckJhY2tpbmc6OnVwZGF0ZUdy YXBoaWNzTGF5ZXJDb25maWd1cmF0aW9uKToKKwogMjAxMy0wOC0xMyAgUm9iZXJ0IEhvZ2FuICA8 cm9iZXJ0QHdlYmtpdC5vcmc+CiAKICAgICAgICAgU2VjdGlvbidzIGNvbGxhcHNlZCBib3JkZXJz IHBhaW50ZWQgaW4gd3JvbmcgcGxhY2UgaW4gcnRsIHRhYmxlcwpkaWZmIC0tZ2l0IGEvU291cmNl L1dlYkNvcmUvcmVuZGVyaW5nL1JlbmRlckxheWVyQmFja2luZy5jcHAgYi9Tb3VyY2UvV2ViQ29y ZS9yZW5kZXJpbmcvUmVuZGVyTGF5ZXJCYWNraW5nLmNwcAppbmRleCBjNzM2MzcyZTg3ZjVjMjlk ZWY4MWE4MmFmYzY4ODAzNzdmYTQwZDlhLi42ZmE0NjM1YzI0NmE5MjljOTVkOTcyNjE1MzFhZWJm NGFjMDg0OTg1IDEwMDY0NAotLS0gYS9Tb3VyY2UvV2ViQ29yZS9yZW5kZXJpbmcvUmVuZGVyTGF5 ZXJCYWNraW5nLmNwcAorKysgYi9Tb3VyY2UvV2ViQ29yZS9yZW5kZXJpbmcvUmVuZGVyTGF5ZXJC YWNraW5nLmNwcApAQCAtNTM5LDggKzUzOSw4IEBAIGJvb2wgUmVuZGVyTGF5ZXJCYWNraW5nOjp1 cGRhdGVHcmFwaGljc0xheWVyQ29uZmlndXJhdGlvbigpCiAgICAgICAgIHVwZGF0ZUludGVybmFs SGllcmFyY2h5KCk7CiAKICAgICBpZiAoR3JhcGhpY3NMYXllciogZmxhdHRlbmluZ0xheWVyID0g dGlsZUNhY2hlRmxhdHRlbmluZ0xheWVyKCkpIHsKLSAgICAgICAgZmxhdHRlbmluZ0xheWVyLT5y ZW1vdmVGcm9tUGFyZW50KCk7Ci0gICAgICAgIG1fZ3JhcGhpY3NMYXllci0+YWRkQ2hpbGQoZmxh dHRlbmluZ0xheWVyKTsKKyAgICAgICAgaWYgKGxheWVyQ29uZmlnQ2hhbmdlZCB8fCBmbGF0dGVu aW5nTGF5ZXItPnBhcmVudCgpICE9IG1fZ3JhcGhpY3NMYXllcikKKyAgICAgICAgICAgIG1fZ3Jh cGhpY3NMYXllci0+YWRkQ2hpbGQoZmxhdHRlbmluZ0xheWVyKTsKICAgICB9CiAKICAgICBpZiAo dXBkYXRlTWFza0xheWVyKHJlbmRlcmVyLT5oYXNNYXNrKCkpKQo=