119533 2013-08-06 17:55:01 -0700 Hashing SecurityOrigin's can lead to trouble if you mutate them :( 2013-08-08 15:00:39 -0700 1 1 1 Unclassified WebKit WebCore Misc. 528+ (Nightly build) Unspecified Unspecified RESOLVED FIXED P2 Normal --- 1 sam sam ap buildbot dimitris.apostolou rniwa oldest_to_newest 915006 0 sam 2013-08-06 17:55:01 -0700 Hashing SecurityOrigin's can lead to trouble if you mutate them :( 915008 1 208230 sam 2013-08-06 18:06:18 -0700 Created attachment 208230 Patch 915011 2 208230 buildbot 2013-08-06 18:34:28 -0700 Comment on attachment 208230 Patch Attachment 208230 did not pass mac-wk2-ews (mac-wk2): Output: http://webkit-queues.appspot.com/results/1418039 915013 3 208230 buildbot 2013-08-06 18:49:44 -0700 Comment on attachment 208230 Patch Attachment 208230 did not pass mac-ews (mac): Output: http://webkit-queues.appspot.com/results/1417041 915017 4 208232 sam 2013-08-06 19:24:47 -0700 Created attachment 208232 Patch 915121 5 208232 kling 2013-08-07 06:05:43 -0700 Comment on attachment 208232 Patch r=me Very related: bug 99266. 915235 6 ap 2013-08-07 11:40:32 -0700 Could you please also address comments around equal() in SecurityOrigin.h, and add a Radar link? 915606 7 sam 2013-08-08 14:59:58 -0700 Committed r153850: <http://trac.webkit.org/changeset/153850> 915608 8 sam 2013-08-08 15:00:39 -0700 *** Bug 99266 has been marked as a duplicate of this bug. *** 208230 2013-08-06 18:06:18 -0700 2013-08-06 19:24:45 -0700 Patch bug-119533-20130806180618.patch text/plain 2239 sam SW5kZXg6IFNvdXJjZS9XZWJDb3JlL0NoYW5nZUxvZwo9PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09Ci0tLSBTb3VyY2UvV2Vi Q29yZS9DaGFuZ2VMb2cJKHJldmlzaW9uIDE1Mzc3NCkKKysrIFNvdXJjZS9XZWJDb3JlL0NoYW5n ZUxvZwkod29ya2luZyBjb3B5KQpAQCAtMSwzICsxLDI4IEBACisyMDEzLTA4LTA2ICBTYW0gV2Vp bmlnICA8c2FtQHdlYmtpdC5vcmc+CisKKyAgICAgICAgSGFzaGluZyBTZWN1cml0eU9yaWdpbidz IGNhbiBsZWFkIHRvIHRyb3VibGUgaWYgeW91IG11dGF0ZSB0aGVtIDooCisgICAgICAgIGh0dHBz Oi8vYnVncy53ZWJraXQub3JnL3Nob3dfYnVnLmNnaT9pZD0xMTk1MzMKKworICAgICAgICBSZXZp ZXdlZCBieSBOT0JPRFkgKE9PUFMhKS4KKworICAgICAgICBXZSBhcmUgZ2V0dGluZyBpbnRvIHRy b3VibGUgaW4gdGhlIGZvbGxvd2luZyBjaXJjdW1zdGFuY2U6CisgICAgICAgIC0gWW91IGhhdmUg YSBIYXNoTWFwPFJlZlB0cjxTZWN1cml0eU9yaWdpbj4sIFZhbHVlPiBtYXAuCisgICAgICAgIC0g WW91IGFkZCBzZWN1cml0eSBvcmlnaW4gQSAoaHR0cCwgd3d3LndlYmtpdC5vcmcsIDgwKSB0byB0 aGUgbWFwLgorICAgICAgICAtIFlvdSBtdXRhdGUgc2VjdXJpdHkgb3JpZ2luIEEgYnkgZG9tYWlu IHJlbGF4YXRpb24sIHNvIHRoYXQgaXQgaGFzIHRoZSBkb21haW4gd2Via2l0Lm9yZy4KKyAgICAg ICAgLSBZb3UgYWRkIHNlY3VyaXR5IG9yaWdpbiBCIChodHRwLCB3d3cud2Via2l0Lm9yZywgODAp IHRvIHRoZSBtYXAuCisgICAgICAgIC0gWW91IG11dGF0ZSBzZWN1cml0eSBvcmlnaW4gQiBieSBk b21haW4gcmVsYXhhdGlvbiwgc28gdGhhdCBpdCBoYXMgdGhlIGRvbWFpbiB3ZWJraXQub3JnLgor ICAgICAgICAgICAgWW91IG5vdyBoYXZlIHR3byBpZGVudGljYWwga2V5cyBpbiB0aGUgbWFwLgor ICAgICAgICAtIEFkZCBmZXcgbW9yZSBpdGVtcyB0byB0aGUgbWFwIGNhdXNpbmcgYSByZWhhc2gu CisgICAgICAgIC0gV2hlbiB5b3UgdHJ5IHRvIGFkZCBBIGFuZCBCIGJhY2sgaW50byB0aGUgbWFw LCB5b3Ugd2lsbCBoYXZlIGEgY29sbGlzaW9uLCBiZWNhdXNlIHRoZXkgbm93IGVxdWFsIGVhY2gg b3RoZXIuCisKKyAgICAgICAgV2Ugc2hvdWxkIHByb2JhYmx5IHN0b3AgdXNpbmcgU2VjdXJpdHlP cmlnaW5zIGFzIGtleXMgaW4gSGFzaE1hcHMgKGFuZCBtb3ZlIHRvIHVzaW5nIGEgbm9uLW11dGFi bGUgU2VjdXJpdHlPcmlnaW5UdXBsZSwKKyAgICAgICAgb3Igc29tZXRoaW5nKSwgYnV0IGZvciBu b3csIHdlIGNhbiBqdXN0IG9ubHkgdXNlIHRoZSBzY2hlbWUgLyBob3N0IC8gcG9ydCBwYXJ0IGZv ciBlcXVhbGl0eSwgd2hpY2ggaXMgd2hhdCBhbGwgdGhlIHVzZXJzCisgICAgICAgIHJlYWxseSB3 YW50LgorCisgICAgICAgICogcGFnZS9TZWN1cml0eU9yaWdpbkhhc2guaDoKKyAgICAgICAgKFdl YkNvcmU6OlNlY3VyaXR5T3JpZ2luSGFzaDo6ZXF1YWwpOgorICAgICAgICBTd2l0Y2ggdG8gdXNp bmcgaXNTYW1lU2NoZW1lSG9zdFBvcnQoKSBmb3IgU2VjdXJpdHlPcmlnaW5IYXNoOjplcXVhbCgp LgorCiAyMDEzLTA4LTA0ICBTYW0gV2VpbmlnICA8c2FtQHdlYmtpdC5vcmc+CiAKICAgICAgICAg UmVtb3ZlIHN1cHBvcnQgZm9yIEhUTUw1IE1pY3JvZGF0YQpJbmRleDogU291cmNlL1dlYkNvcmUv cGFnZS9TZWN1cml0eU9yaWdpbkhhc2guaAo9PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09Ci0tLSBTb3VyY2UvV2ViQ29yZS9w YWdlL1NlY3VyaXR5T3JpZ2luSGFzaC5oCShyZXZpc2lvbiAxNTM3NzEpCisrKyBTb3VyY2UvV2Vi Q29yZS9wYWdlL1NlY3VyaXR5T3JpZ2luSGFzaC5oCSh3b3JraW5nIGNvcHkpCkBAIC01OCw3ICs1 OCw3IEBAIHN0cnVjdCBTZWN1cml0eU9yaWdpbkhhc2ggewogICAgICAgICAvLyBlcXVhbCB3aXRo b3V0IGNoYW5naW5nIGhhc2ggdG8gbWF0Y2ggaXQuCiAgICAgICAgIGlmICghYSB8fCAhYikKICAg ICAgICAgICAgIHJldHVybiBhID09IGI7Ci0gICAgICAgIHJldHVybiBhLT5lcXVhbChiKTsKKyAg ICAgICAgcmV0dXJuIGEtPmlzU2FtZVNjaGVtZUhvc3RQb3J0KGIpOwogICAgIH0KICAgICBzdGF0 aWMgYm9vbCBlcXVhbChTZWN1cml0eU9yaWdpbiogYSwgY29uc3QgUmVmUHRyPFNlY3VyaXR5T3Jp Z2luPiYgYikKICAgICB7Cg== 208232 2013-08-06 19:24:47 -0700 2013-08-07 06:05:43 -0700 Patch bug-119533-20130806192446.patch text/plain 2885 sam SW5kZXg6IFNvdXJjZS9XZWJDb3JlL0NoYW5nZUxvZwo9PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09Ci0tLSBTb3VyY2UvV2Vi Q29yZS9DaGFuZ2VMb2cJKHJldmlzaW9uIDE1Mzc3NCkKKysrIFNvdXJjZS9XZWJDb3JlL0NoYW5n ZUxvZwkod29ya2luZyBjb3B5KQpAQCAtMSwzICsxLDI4IEBACisyMDEzLTA4LTA2ICBTYW0gV2Vp bmlnICA8c2FtQHdlYmtpdC5vcmc+CisKKyAgICAgICAgSGFzaGluZyBTZWN1cml0eU9yaWdpbidz IGNhbiBsZWFkIHRvIHRyb3VibGUgaWYgeW91IG11dGF0ZSB0aGVtIDooCisgICAgICAgIGh0dHBz Oi8vYnVncy53ZWJraXQub3JnL3Nob3dfYnVnLmNnaT9pZD0xMTk1MzMKKworICAgICAgICBSZXZp ZXdlZCBieSBOT0JPRFkgKE9PUFMhKS4KKworICAgICAgICBXZSBhcmUgZ2V0dGluZyBpbnRvIHRy b3VibGUgaW4gdGhlIGZvbGxvd2luZyBjaXJjdW1zdGFuY2U6CisgICAgICAgIC0gWW91IGhhdmUg YSBIYXNoTWFwPFJlZlB0cjxTZWN1cml0eU9yaWdpbj4sIFZhbHVlPiBtYXAuCisgICAgICAgIC0g WW91IGFkZCBzZWN1cml0eSBvcmlnaW4gQSAoaHR0cCwgd3d3LndlYmtpdC5vcmcsIDgwKSB0byB0 aGUgbWFwLgorICAgICAgICAtIFlvdSBtdXRhdGUgc2VjdXJpdHkgb3JpZ2luIEEgYnkgZG9tYWlu IHJlbGF4YXRpb24sIHNvIHRoYXQgaXQgaGFzIHRoZSBkb21haW4gd2Via2l0Lm9yZy4KKyAgICAg ICAgLSBZb3UgYWRkIHNlY3VyaXR5IG9yaWdpbiBCIChodHRwLCB3d3cud2Via2l0Lm9yZywgODAp IHRvIHRoZSBtYXAuCisgICAgICAgIC0gWW91IG11dGF0ZSBzZWN1cml0eSBvcmlnaW4gQiBieSBk b21haW4gcmVsYXhhdGlvbiwgc28gdGhhdCBpdCBoYXMgdGhlIGRvbWFpbiB3ZWJraXQub3JnLgor ICAgICAgICAgICAgWW91IG5vdyBoYXZlIHR3byBpZGVudGljYWwga2V5cyBpbiB0aGUgbWFwLgor ICAgICAgICAtIEFkZCBmZXcgbW9yZSBpdGVtcyB0byB0aGUgbWFwIGNhdXNpbmcgYSByZWhhc2gu CisgICAgICAgIC0gV2hlbiB5b3UgdHJ5IHRvIGFkZCBBIGFuZCBCIGJhY2sgaW50byB0aGUgbWFw LCB5b3Ugd2lsbCBoYXZlIGEgY29sbGlzaW9uLCBiZWNhdXNlIHRoZXkgbm93IGVxdWFsIGVhY2gg b3RoZXIuCisKKyAgICAgICAgV2Ugc2hvdWxkIHByb2JhYmx5IHN0b3AgdXNpbmcgU2VjdXJpdHlP cmlnaW5zIGFzIGtleXMgaW4gSGFzaE1hcHMgKGFuZCBtb3ZlIHRvIHVzaW5nIGEgbm9uLW11dGFi bGUgU2VjdXJpdHlPcmlnaW5UdXBsZSwKKyAgICAgICAgb3Igc29tZXRoaW5nKSwgYnV0IGZvciBu b3csIHdlIGNhbiBqdXN0IG9ubHkgdXNlIHRoZSBzY2hlbWUgLyBob3N0IC8gcG9ydCBwYXJ0IGZv ciBlcXVhbGl0eSwgd2hpY2ggaXMgd2hhdCBhbGwgdGhlIHVzZXJzCisgICAgICAgIHJlYWxseSB3 YW50LgorCisgICAgICAgICogcGFnZS9TZWN1cml0eU9yaWdpbkhhc2guaDoKKyAgICAgICAgKFdl YkNvcmU6OlNlY3VyaXR5T3JpZ2luSGFzaDo6ZXF1YWwpOgorICAgICAgICBTd2l0Y2ggdG8gdXNp bmcgaXNTYW1lU2NoZW1lSG9zdFBvcnQoKSBmb3IgU2VjdXJpdHlPcmlnaW5IYXNoOjplcXVhbCgp LgorCiAyMDEzLTA4LTA0ICBTYW0gV2VpbmlnICA8c2FtQHdlYmtpdC5vcmc+CiAKICAgICAgICAg UmVtb3ZlIHN1cHBvcnQgZm9yIEhUTUw1IE1pY3JvZGF0YQpJbmRleDogU291cmNlL1dlYkNvcmUv V2ViQ29yZS5leHAuaW4KPT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PQotLS0gU291cmNlL1dlYkNvcmUvV2ViQ29yZS5leHAu aW4JKHJldmlzaW9uIDE1Mzc3MSkKKysrIFNvdXJjZS9XZWJDb3JlL1dlYkNvcmUuZXhwLmluCSh3 b3JraW5nIGNvcHkpCkBAIC0xNDQ0LDYgKzE0NDQsNyBAQCBfX1pOSzdXZWJDb3JlMTRTZWN1cml0 eU9yaWdpbjExdG9SYXdTdHJpCiBfX1pOSzdXZWJDb3JlMTRTZWN1cml0eU9yaWdpbjEyaXNvbGF0 ZWRDb3B5RXYKIF9fWk5LN1dlYkNvcmUxNFNlY3VyaXR5T3JpZ2luMTZjYW5BY2Nlc3NTdG9yYWdl RVBLUzBfTlMwXzI1U2hvdWxkQWxsb3dGcm9tVGhpcmRQYXJ0eUUKIF9fWk5LN1dlYkNvcmUxNFNl Y3VyaXR5T3JpZ2luMThkYXRhYmFzZUlkZW50aWZpZXJFdgorX19aTks3V2ViQ29yZTE0U2VjdXJp dHlPcmlnaW4yMGlzU2FtZVNjaGVtZUhvc3RQb3J0RVBLUzBfCiBfX1pOSzdXZWJDb3JlMTRTZWN1 cml0eU9yaWdpbjVlcXVhbEVQS1MwXwogX19aTks3V2ViQ29yZTE0U2VjdXJpdHlPcmlnaW44dG9T dHJpbmdFdgogX19aTks3V2ViQ29yZTE1QWZmaW5lVHJhbnNmb3JtMTBpc0lkZW50aXR5RXYKSW5k ZXg6IFNvdXJjZS9XZWJDb3JlL3BhZ2UvU2VjdXJpdHlPcmlnaW5IYXNoLmgKPT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PQot LS0gU291cmNlL1dlYkNvcmUvcGFnZS9TZWN1cml0eU9yaWdpbkhhc2guaAkocmV2aXNpb24gMTUz NzcxKQorKysgU291cmNlL1dlYkNvcmUvcGFnZS9TZWN1cml0eU9yaWdpbkhhc2guaAkod29ya2lu ZyBjb3B5KQpAQCAtNTgsNyArNTgsNyBAQCBzdHJ1Y3QgU2VjdXJpdHlPcmlnaW5IYXNoIHsKICAg ICAgICAgLy8gZXF1YWwgd2l0aG91dCBjaGFuZ2luZyBoYXNoIHRvIG1hdGNoIGl0LgogICAgICAg ICBpZiAoIWEgfHwgIWIpCiAgICAgICAgICAgICByZXR1cm4gYSA9PSBiOwotICAgICAgICByZXR1 cm4gYS0+ZXF1YWwoYik7CisgICAgICAgIHJldHVybiBhLT5pc1NhbWVTY2hlbWVIb3N0UG9ydChi KTsKICAgICB9CiAgICAgc3RhdGljIGJvb2wgZXF1YWwoU2VjdXJpdHlPcmlnaW4qIGEsIGNvbnN0 IFJlZlB0cjxTZWN1cml0eU9yaWdpbj4mIGIpCiAgICAgewo=