119532 2013-08-06 17:05:15 -0700 Assertion failure in emitExpressionInfo when reloading with Web Inspector open 2013-08-06 17:18:58 -0700 1 1 1 Unclassified WebKit JavaScriptCore 528+ (Nightly build) Unspecified Unspecified RESOLVED FIXED InRadar P2 Normal --- 1 mark.lam mark.lam ap fpizlo ggaren mhahnenberg msaboff oliver oldest_to_newest 914999 0 mark.lam 2013-08-06 17:05:15 -0700 Steps to reproduce (using a debug build): 1. Open <https://www.hsbccreditcard.com> (no need to log in) 2. Open Web Inspector (Cmd+Option+C) 3. Reload The issue is that the Parser's JSTokenLocation is not fully initialized during construction. Once this is fixed, the above assertion no longer manifests. ref: <rdar://problem/14633089> 915001 1 208229 mark.lam 2013-08-06 17:13:04 -0700 Created attachment 208229 the patch 915002 2 mark.lam 2013-08-06 17:18:58 -0700 Thanks for the review. Landed in r153774: <http://trac.webkit.org/r153774>. 208229 2013-08-06 17:13:04 -0700 2013-08-06 17:14:15 -0700 the patch bug-119532.patch text/plain 1404 mark.lam SW5kZXg6IFNvdXJjZS9KYXZhU2NyaXB0Q29yZS9DaGFuZ2VMb2cKPT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PQotLS0gU291 cmNlL0phdmFTY3JpcHRDb3JlL0NoYW5nZUxvZwkocmV2aXNpb24gMTUzNzcyKQorKysgU291cmNl L0phdmFTY3JpcHRDb3JlL0NoYW5nZUxvZwkod29ya2luZyBjb3B5KQpAQCAtMSwzICsxLDE1IEBA CisyMDEzLTA4LTA2ICBNYXJrIExhbSAgPG1hcmsubGFtQGFwcGxlLmNvbT4KKworICAgICAgICBB c3NlcnRpb24gZmFpbHVyZSBpbiBlbWl0RXhwcmVzc2lvbkluZm8gd2hlbiByZWxvYWRpbmcgd2l0 aCBXZWIgSW5zcGVjdG9yIG9wZW4uCisgICAgICAgIGh0dHBzOi8vYnVncy53ZWJraXQub3JnL3No b3dfYnVnLmNnaT9pZD0xMTk1MzIuCisKKyAgICAgICAgUmV2aWV3ZWQgYnkgTk9CT0RZIChPT1BT ISkuCisKKyAgICAgICAgKiBwYXJzZXIvUGFyc2VyLmNwcDoKKyAgICAgICAgKEpTQzo6OjpQYXJz ZXIpOgorICAgICAgICAtIEp1c3QgbmVlZCB0byBpbml0aWFsaXplIHRoZSBQYXJzZXIncyBKU1Rv a2VuTG9jYXRpb24ncyBpbml0aWFsIGxpbmUgYW5kCisgICAgICAgICAgc3RhcnRPZmZzZXQgYXMg d2VsbCBkdXJpbmcgUGFyc2VyIGNvbnN0cnVjdGlvbi4KKwogMjAxMy0wOC0wNCAgU2FtIFdlaW5p ZyAgPHNhbUB3ZWJraXQub3JnPgogCiAgICAgICAgIFJlbW92ZSBzdXBwb3J0IGZvciBIVE1MNSBN aWNyb0RhdGEKSW5kZXg6IFNvdXJjZS9KYXZhU2NyaXB0Q29yZS9wYXJzZXIvUGFyc2VyLmNwcAo9 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09Ci0tLSBTb3VyY2UvSmF2YVNjcmlwdENvcmUvcGFyc2VyL1BhcnNlci5jcHAJKHJl dmlzaW9uIDE1Mzc2MCkKKysrIFNvdXJjZS9KYXZhU2NyaXB0Q29yZS9wYXJzZXIvUGFyc2VyLmNw cAkod29ya2luZyBjb3B5KQpAQCAtODAsNiArODAsOCBAQCBQYXJzZXI8TGV4ZXJUeXBlPjo6UGFy c2VyKFZNKiB2bSwgY29uc3QgCiAgICAgbV9sZXhlciA9IGFkb3B0UHRyKG5ldyBMZXhlclR5cGUo dm0pKTsKICAgICBtX2FyZW5hID0gbV92bS0+cGFyc2VyQXJlbmEuZ2V0KCk7CiAgICAgbV9sZXhl ci0+c2V0Q29kZShzb3VyY2UsIG1fYXJlbmEpOworICAgIG1fdG9rZW4ubV9sb2NhdGlvbi5saW5l ID0gc291cmNlLmZpcnN0TGluZSgpOworICAgIG1fdG9rZW4ubV9sb2NhdGlvbi5zdGFydE9mZnNl dCA9IHNvdXJjZS5zdGFydE9mZnNldCgpOwogICAgIG1fdG9rZW4ubV9sb2NhdGlvbi5lbmRPZmZz ZXQgPSBzb3VyY2Uuc3RhcnRPZmZzZXQoKTsKICAgICBtX3Rva2VuLm1fbG9jYXRpb24ubGluZVN0 YXJ0T2Zmc2V0ID0gc291cmNlLnN0YXJ0T2Zmc2V0KCk7CiAK