119523 2013-08-06 10:14:12 -0700 Improper Calculation of In-band Cue Colors 2013-08-06 11:38:57 -0700 1 1 1 Unclassified WebKit Media 528+ (Nightly build) Unspecified Unspecified RESOLVED FIXED P2 Normal --- 1 bfulgham bfulgham oldest_to_newest 914889 0 bfulgham 2013-08-06 10:14:12 -0700 The logic used to convert the attributed strings from In-band caption content was improperly converting from floating point values to byte values. We are getting a directive to draw 100% opaque black background in TextTrackCueGenericBoxElement::applyCSSProperties. This is coming from the cue's background color property. It looks like the code in InbandTextTrackPrivateAVF.cpp (makeRGBA32FromARGBCFArray) is improperly converting from floating point values to bytes. I see a 50% opacity value coming into the function, which is multiplied by 255 when being passed to the makeRGBA32FromFloats function. That function calls 'colorFloatToRGBAByte', which performs a bounded multiplication by 255. This means we have (0.5 * 255) * 255 -> 125 * (255) -> the max of 255. If I take away the outer (redundant) multiplication by 255, I get correct behavior. 914891 1 bfulgham 2013-08-06 10:14:36 -0700 <rdar://problem/14627254> 914892 2 208198 bfulgham 2013-08-06 10:16:29 -0700 Created attachment 208198 Patch 914917 3 bfulgham 2013-08-06 11:38:57 -0700 Committed r153758: <http://trac.webkit.org/changeset/153758> 208198 2013-08-06 10:16:29 -0700 2013-08-06 11:10:15 -0700 Patch bug-119523-20130806101627.patch text/plain 1454 bfulgham SW5kZXg6IFNvdXJjZS9XZWJDb3JlL0NoYW5nZUxvZwo9PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09Ci0tLSBTb3VyY2UvV2Vi Q29yZS9DaGFuZ2VMb2cJKHJldmlzaW9uIDE1Mzc1NSkKKysrIFNvdXJjZS9XZWJDb3JlL0NoYW5n ZUxvZwkod29ya2luZyBjb3B5KQpAQCAtMSwzICsxLDE0IEBACisyMDEzLTA4LTA2ICBCcmVudCBG dWxnaGFtICA8YmZ1bGdoYW1AYXBwbGUuY29tPgorCisgICAgICAgIEltcHJvcGVyIENhbGN1bGF0 aW9uIG9mIEluLWJhbmQgQ3VlIENvbG9ycworICAgICAgICBodHRwczovL2J1Z3Mud2Via2l0Lm9y Zy9zaG93X2J1Zy5jZ2k/aWQ9MTE5NTIzCisKKyAgICAgICAgUmV2aWV3ZWQgYnkgTk9CT0RZIChP T1BTISkuCisKKyAgICAgICAgKiBwbGF0Zm9ybS9ncmFwaGljcy9hdmZvdW5kYXRpb24vSW5iYW5k VGV4dFRyYWNrUHJpdmF0ZUFWRi5jcHA6CisgICAgICAgIChXZWJDb3JlOjptYWtlUkdCQTMyRnJv bUFSR0JDRkFycmF5KTogUmVtb3ZlIHJlZHVuZGFudCBtdWx0aXBsaWNhdGlvbiBieQorICAgICAg ICAyNTUuICBUaGUgaW50ZXJuYWwgY29udmVyc2lvbiBsb2dpYyBhbHJlYWR5IGNvbnZlcnRzIHRv IGJ5dGVzLgorCiAyMDEzLTA4LTA1ICBSb2IgQnVpcyAgPHJ3bGJ1aXNAd2Via2l0Lm9yZz4KIAog ICAgICAgICBTVkcgc3Ryb2tlLWRhc2hhcnJheSBpcyBub3QgYW5pbWF0YWJsZQpJbmRleDogU291 cmNlL1dlYkNvcmUvcGxhdGZvcm0vZ3JhcGhpY3MvYXZmb3VuZGF0aW9uL0luYmFuZFRleHRUcmFj a1ByaXZhdGVBVkYuY3BwCj09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT0KLS0tIFNvdXJjZS9XZWJDb3JlL3BsYXRmb3JtL2dy YXBoaWNzL2F2Zm91bmRhdGlvbi9JbmJhbmRUZXh0VHJhY2tQcml2YXRlQVZGLmNwcAkocmV2aXNp b24gMTUzNzE0KQorKysgU291cmNlL1dlYkNvcmUvcGxhdGZvcm0vZ3JhcGhpY3MvYXZmb3VuZGF0 aW9uL0luYmFuZFRleHRUcmFja1ByaXZhdGVBVkYuY3BwCSh3b3JraW5nIGNvcHkpCkBAIC0xMjYs NyArMTI2LDcgQEAgc3RhdGljIGJvb2wgbWFrZVJHQkEzMkZyb21BUkdCQ0ZBcnJheShDRgogICAg ICAgICBjb21wb25lbnRBcnJheVtpXSA9IGNvbXBvbmVudDsKICAgICB9CiAKLSAgICBjb2xvciA9 IG1ha2VSR0JBMzJGcm9tRmxvYXRzKGNvbXBvbmVudEFycmF5WzFdICogMjU1LCBjb21wb25lbnRB cnJheVsyXSAqIDI1NSwgY29tcG9uZW50QXJyYXlbM10gKiAyNTUsIGNvbXBvbmVudEFycmF5WzBd ICogMjU1KTsKKyAgICBjb2xvciA9IG1ha2VSR0JBMzJGcm9tRmxvYXRzKGNvbXBvbmVudEFycmF5 WzFdLCBjb21wb25lbnRBcnJheVsyXSwgY29tcG9uZW50QXJyYXlbM10sIGNvbXBvbmVudEFycmF5 WzBdKTsKICAgICByZXR1cm4gdHJ1ZTsKIH0KIAo=