119504 2013-08-05 18:00:53 -0700 DFG optimizes out strict mode arguments tear off 2013-08-16 22:37:00 -0700 1 1 1 Unclassified WebKit JavaScriptCore 528+ (Nightly build) Unspecified Unspecified RESOLVED FIXED InRadar P2 Normal --- 1 oliver fpizlo fpizlo oldest_to_newest 914749 0 oliver 2013-08-05 18:00:53 -0700 If i have a strict mode function: function f(a) { "use strict"; a = 5; return arguments[0]; } var x = 0; for (var i = 0; i < N; i++) x = x + f(1); The result should be N, but the DFG optimizes out the eager tear off of the Arguments object, leading to arguments[0] eventually being optimized to return 5, which is incorrect. 918135 1 208962 fpizlo 2013-08-16 16:19:26 -0700 Created attachment 208962 the patch 918211 2 fpizlo 2013-08-16 22:36:06 -0700 <rdar://problem/14764160> 918212 3 fpizlo 2013-08-16 22:37:00 -0700 Landed in http://trac.webkit.org/changeset/154217 208962 2013-08-16 16:19:26 -0700 2013-08-16 16:21:00 -0700 the patch blah.patch text/plain 5900 fpizlo SW5kZXg6IFNvdXJjZS9KYXZhU2NyaXB0Q29yZS9DaGFuZ2VMb2cKPT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PQotLS0gU291 cmNlL0phdmFTY3JpcHRDb3JlL0NoYW5nZUxvZwkocmV2aXNpb24gMTU0MjA2KQorKysgU291cmNl L0phdmFTY3JpcHRDb3JlL0NoYW5nZUxvZwkod29ya2luZyBjb3B5KQpAQCAtMSwzICsxLDE2IEBA CisyMDEzLTA4LTE2ICBGaWxpcCBQaXpsbyAgPGZwaXpsb0BhcHBsZS5jb20+CisKKyAgICAgICAg REZHIG9wdGltaXplcyBvdXQgc3RyaWN0IG1vZGUgYXJndW1lbnRzIHRlYXIgb2ZmCisgICAgICAg IGh0dHBzOi8vYnVncy53ZWJraXQub3JnL3Nob3dfYnVnLmNnaT9pZD0xMTk1MDQKKworICAgICAg ICBSZXZpZXdlZCBieSBOT0JPRFkgKE9PUFMhKS4KKyAgICAgICAgCisgICAgICAgIERvbid0IGRv IHRoZSBvcHRpbWl6YXRpb24gZm9yIHN0cmljdCBtb2RlLgorCisgICAgICAgICogZGZnL0RGR0Fy Z3VtZW50c1NpbXBsaWZpY2F0aW9uUGhhc2UuY3BwOgorICAgICAgICAoSlNDOjpERkc6OkFyZ3Vt ZW50c1NpbXBsaWZpY2F0aW9uUGhhc2U6OnJ1bik6CisgICAgICAgIChKU0M6OkRGRzo6QXJndW1l bnRzU2ltcGxpZmljYXRpb25QaGFzZTo6cHJ1bmVPYnZpb3VzQXJndW1lbnRDcmVhdGlvbnMpOgor CiAyMDEzLTA4LTE2ICBNYXJrIExhbSAgPG1hcmsubGFtQGFwcGxlLmNvbT4KIAogICAgICAgICA8 aHR0cHM6Ly9idWdzLndlYmtpdC5vcmcvc2hvd19idWcuY2dpP2lkPTExOTkxMz4gQmFzZWxpbmUg SklUIGdpdmVzIGVycm9uZW91cwpJbmRleDogU291cmNlL0phdmFTY3JpcHRDb3JlL2RmZy9ERkdB cmd1bWVudHNTaW1wbGlmaWNhdGlvblBoYXNlLmNwcAo9PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09Ci0tLSBTb3VyY2UvSmF2 YVNjcmlwdENvcmUvZGZnL0RGR0FyZ3VtZW50c1NpbXBsaWZpY2F0aW9uUGhhc2UuY3BwCShyZXZp c2lvbiAxNTQyMDIpCisrKyBTb3VyY2UvSmF2YVNjcmlwdENvcmUvZGZnL0RGR0FyZ3VtZW50c1Np bXBsaWZpY2F0aW9uUGhhc2UuY3BwCSh3b3JraW5nIGNvcHkpCkBAIC0xMjIsMTIgKzEyMiw5IEBA IHB1YmxpYzoKICAgICAgICAgYm9vbCBjaGFuZ2VkID0gZmFsc2U7CiAgICAgICAgIAogICAgICAg ICAvLyBSZWNvcmQgd2hpY2ggYXJndW1lbnRzIGFyZSBrbm93biB0byBlc2NhcGUgbm8gbWF0dGVy IHdoYXQuCi0gICAgICAgIGZvciAodW5zaWduZWQgaSA9IGNvZGVCbG9jaygpLT5pbmxpbmVDYWxs RnJhbWVzKCkuc2l6ZSgpOyBpLS07KSB7Ci0gICAgICAgICAgICBJbmxpbmVDYWxsRnJhbWUqIGlu bGluZUNhbGxGcmFtZSA9ICZjb2RlQmxvY2soKS0+aW5saW5lQ2FsbEZyYW1lcygpW2ldOwotICAg ICAgICAgICAgaWYgKG1fZ3JhcGgubV9leGVjdXRhYmxlc1dob3NlQXJndW1lbnRzRXNjYXBlZC5j b250YWlucygKLSAgICAgICAgICAgICAgICAgICAgbV9ncmFwaC5leGVjdXRhYmxlRm9yKGlubGlu ZUNhbGxGcmFtZSkpKQotICAgICAgICAgICAgICAgIG1fY3JlYXRlc0FyZ3VtZW50cy5hZGQoaW5s aW5lQ2FsbEZyYW1lKTsKLSAgICAgICAgfQorICAgICAgICBmb3IgKHVuc2lnbmVkIGkgPSBjb2Rl QmxvY2soKS0+aW5saW5lQ2FsbEZyYW1lcygpLnNpemUoKTsgaS0tOykKKyAgICAgICAgICAgIHBy dW5lT2J2aW91c0FyZ3VtZW50Q3JlYXRpb25zKCZjb2RlQmxvY2soKS0+aW5saW5lQ2FsbEZyYW1l cygpW2ldKTsKKyAgICAgICAgcHJ1bmVPYnZpb3VzQXJndW1lbnRDcmVhdGlvbnMoMCk7IC8vIHRo ZSBtYWNoaW5lIGNhbGwgZnJhbWUuCiAgICAgICAgIAogICAgICAgICAvLyBDcmVhdGUgZGF0YSBm b3IgdmFyaWFibGUgYWNjZXNzIGRhdGFzIHRoYXQgd2Ugd2lsbCB3YW50IHRvIGFuYWx5emUuCiAg ICAgICAgIGZvciAodW5zaWduZWQgaSA9IG1fZ3JhcGgubV92YXJpYWJsZUFjY2Vzc0RhdGEuc2l6 ZSgpOyBpLS07KSB7CkBAIC02OTQsNiArNjkxLDE2IEBAIHByaXZhdGU6CiAgICAgICAgICAgICBO dWxsYWJsZUhhc2hUcmFpdHM8VmFyaWFibGVBY2Nlc3NEYXRhKj4gPiBtX2FyZ3VtZW50c0FsaWFz aW5nOwogICAgIEhhc2hTZXQ8VmFyaWFibGVBY2Nlc3NEYXRhKj4gbV9pc0xpdmU7CiAKKyAgICB2 b2lkIHBydW5lT2J2aW91c0FyZ3VtZW50Q3JlYXRpb25zKElubGluZUNhbGxGcmFtZSogaW5saW5l Q2FsbEZyYW1lKQorICAgIHsKKyAgICAgICAgU2NyaXB0RXhlY3V0YWJsZSogZXhlY3V0YWJsZSA9 IG1fZ3JhcGguZXhlY3V0YWJsZUZvcihpbmxpbmVDYWxsRnJhbWUpOworICAgICAgICBpZiAobV9n cmFwaC5tX2V4ZWN1dGFibGVzV2hvc2VBcmd1bWVudHNFc2NhcGVkLmNvbnRhaW5zKGV4ZWN1dGFi bGUpCisgICAgICAgICAgICB8fCBleGVjdXRhYmxlLT5pc1N0cmljdE1vZGUoKSkgeworICAgICAg ICAgICAgZGF0YUxvZygiQWRkaW5nICIsIFJhd1BvaW50ZXIoaW5saW5lQ2FsbEZyYW1lKSwgIiBh cyBjcmVhdGluZyBhcmd1bWVudHMuXG4iKTsKKyAgICAgICAgICAgIG1fY3JlYXRlc0FyZ3VtZW50 cy5hZGQoaW5saW5lQ2FsbEZyYW1lKTsKKyAgICAgICAgfQorICAgIH0KKyAgICAKICAgICB2b2lk IG9ic2VydmVCYWRBcmd1bWVudHNVc2UoTm9kZSogbm9kZSkKICAgICB7CiAgICAgICAgIGlmICgh bm9kZSkKSW5kZXg6IExheW91dFRlc3RzL0NoYW5nZUxvZwo9PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09Ci0tLSBMYXlvdXRU ZXN0cy9DaGFuZ2VMb2cJKHJldmlzaW9uIDE1NDIwNikKKysrIExheW91dFRlc3RzL0NoYW5nZUxv Zwkod29ya2luZyBjb3B5KQpAQCAtMSwzICsxLDE2IEBACisyMDEzLTA4LTE2ICBGaWxpcCBQaXps byAgPGZwaXpsb0BhcHBsZS5jb20+CisKKyAgICAgICAgREZHIG9wdGltaXplcyBvdXQgc3RyaWN0 IG1vZGUgYXJndW1lbnRzIHRlYXIgb2ZmCisgICAgICAgIGh0dHBzOi8vYnVncy53ZWJraXQub3Jn L3Nob3dfYnVnLmNnaT9pZD0xMTk1MDQKKworICAgICAgICBSZXZpZXdlZCBieSBOT0JPRFkgKE9P UFMhKS4KKworICAgICAgICAqIGZhc3QvanMvZGZnLWFyZ3VtZW50cy1zdHJpY3QtbW9kZS1leHBl Y3RlZC50eHQ6IEFkZGVkLgorICAgICAgICAqIGZhc3QvanMvZGZnLWFyZ3VtZW50cy1zdHJpY3Qt bW9kZS5odG1sOiBBZGRlZC4KKyAgICAgICAgKiBmYXN0L2pzL2pzYy10ZXN0LWxpc3Q6CisgICAg ICAgICogZmFzdC9qcy9zY3JpcHQtdGVzdHMvZGZnLWFyZ3VtZW50cy1zdHJpY3QtbW9kZS5qczog QWRkZWQuCisgICAgICAgIChmKToKKwogMjAxMy0wOC0xNiAgUnlvc3VrZSBOaXdhICA8cm5pd2FA d2Via2l0Lm9yZz4KIAogICAgICAgICA8aHR0cHM6Ly93ZWJraXQub3JnL2IvMTE5OTE1PiBSRUdS RVNTSU9OKHIxNTQxNDQpOiBBU1NFUlRJT04gRkFJTEVEOiBtX2hpc3RvcnktPnByb3Zpc2lvbmFs SXRlbSgpID09IG1fcmVxdWVzdGVkSGlzdG9yeUl0ZW0uZ2V0KCkKSW5kZXg6IExheW91dFRlc3Rz L2Zhc3QvanMvZGZnLWFyZ3VtZW50cy1zdHJpY3QtbW9kZS1leHBlY3RlZC50eHQKPT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PQotLS0gTGF5b3V0VGVzdHMvZmFzdC9qcy9kZmctYXJndW1lbnRzLXN0cmljdC1tb2RlLWV4cGVj dGVkLnR4dAkocmV2aXNpb24gMCkKKysrIExheW91dFRlc3RzL2Zhc3QvanMvZGZnLWFyZ3VtZW50 cy1zdHJpY3QtbW9kZS1leHBlY3RlZC50eHQJKHJldmlzaW9uIDApCkBAIC0wLDAgKzEsMTAgQEAK K1Rlc3RzIHdoYXQgaGFwcGVucyB3aGVuIHlvdSB1c2UgYXJndW1lbnRzIGluIHN0cmljdCBtb2Rl IGFuZCBwcmVzZW50IHRoZSBERkcgd2l0aCBhIHRlbXB0aW5nIG9wdGltaXphdGlvbiBvcHBvcnR1 bml0eS4KKworT24gc3VjY2VzcywgeW91IHdpbGwgc2VlIGEgc2VyaWVzIG9mICJQQVNTIiBtZXNz YWdlcywgZm9sbG93ZWQgYnkgIlRFU1QgQ09NUExFVEUiLgorCisKK1BBU1MgZigxKSBpcyAxCitQ QVNTIHN1Y2Nlc3NmdWxseVBhcnNlZCBpcyB0cnVlCisKK1RFU1QgQ09NUExFVEUKKwpJbmRleDog TGF5b3V0VGVzdHMvZmFzdC9qcy9kZmctYXJndW1lbnRzLXN0cmljdC1tb2RlLmh0bWwKPT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PQotLS0gTGF5b3V0VGVzdHMvZmFzdC9qcy9kZmctYXJndW1lbnRzLXN0cmljdC1tb2RlLmh0 bWwJKHJldmlzaW9uIDApCisrKyBMYXlvdXRUZXN0cy9mYXN0L2pzL2RmZy1hcmd1bWVudHMtc3Ry aWN0LW1vZGUuaHRtbAkocmV2aXNpb24gMCkKQEAgLTAsMCArMSwxMCBAQAorPCFET0NUWVBFIEhU TUwgUFVCTElDICItLy9JRVRGLy9EVEQgSFRNTC8vRU4iPgorPGh0bWw+Cis8aGVhZD4KKzxzY3Jp cHQgc3JjPSJyZXNvdXJjZXMvanMtdGVzdC1wcmUuanMiPjwvc2NyaXB0PgorPC9oZWFkPgorPGJv ZHk+Cis8c2NyaXB0IHNyYz0ic2NyaXB0LXRlc3RzL2RmZy1hcmd1bWVudHMtc3RyaWN0LW1vZGUu anMiPjwvc2NyaXB0PgorPHNjcmlwdCBzcmM9InJlc291cmNlcy9qcy10ZXN0LXBvc3QuanMiPjwv c2NyaXB0PgorPC9ib2R5PgorPC9odG1sPgpJbmRleDogTGF5b3V0VGVzdHMvZmFzdC9qcy9qc2Mt dGVzdC1saXN0Cj09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT0KLS0tIExheW91dFRlc3RzL2Zhc3QvanMvanNjLXRlc3QtbGlz dAkocmV2aXNpb24gMTU0MjAyKQorKysgTGF5b3V0VGVzdHMvZmFzdC9qcy9qc2MtdGVzdC1saXN0 CSh3b3JraW5nIGNvcHkpCkBAIC04Niw2ICs4Niw3IEBAIGZhc3QvanMvZGZnLWFyZ3VtZW50cy1v c3ItZXhpdAogZmFzdC9qcy9kZmctYXJndW1lbnRzLW9zci1leGl0LW11bHRpcGxlLWJsb2Nrcwog ZmFzdC9qcy9kZmctYXJndW1lbnRzLW9zci1leGl0LW11bHRpcGxlLWJsb2Nrcy1iZWZvcmUtZXhp dAogZmFzdC9qcy9kZmctYXJndW1lbnRzLW91dC1vZi1ib3VuZHMKK2Zhc3QvanMvZGZnLWFyZ3Vt ZW50cy1zdHJpY3QtbW9kZQogZmFzdC9qcy9kZmctYXJndW1lbnRzLXVuZXhwZWN0ZWQtZXNjYXBl CiBmYXN0L2pzL2RmZy1hcml0aC1hZGQtb3ZlcmZsb3ctY2hlY2stZWxpbWluYXRpb24tcHJlZGlj dGVkLWJ1dC1ub3QtcHJvdmVuLWludAogZmFzdC9qcy9kZmctYXJpdGgtYWRkLW92ZXJmbG93LWNo ZWNrLWVsaW1pbmF0aW9uLXRvd2VyLW9mLWxhcmdlLW51bWJlcnMKSW5kZXg6IExheW91dFRlc3Rz L2Zhc3QvanMvc2NyaXB0LXRlc3RzL2RmZy1hcmd1bWVudHMtc3RyaWN0LW1vZGUuanMKPT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PQotLS0gTGF5b3V0VGVzdHMvZmFzdC9qcy9zY3JpcHQtdGVzdHMvZGZnLWFyZ3VtZW50cy1z dHJpY3QtbW9kZS5qcwkocmV2aXNpb24gMCkKKysrIExheW91dFRlc3RzL2Zhc3QvanMvc2NyaXB0 LXRlc3RzL2RmZy1hcmd1bWVudHMtc3RyaWN0LW1vZGUuanMJKHJldmlzaW9uIDApCkBAIC0wLDAg KzEsMTcgQEAKK2Rlc2NyaXB0aW9uKAorIlRlc3RzIHdoYXQgaGFwcGVucyB3aGVuIHlvdSB1c2Ug YXJndW1lbnRzIGluIHN0cmljdCBtb2RlIGFuZCBwcmVzZW50IHRoZSBERkcgd2l0aCBhIHRlbXB0 aW5nIG9wdGltaXphdGlvbiBvcHBvcnR1bml0eS4iCispOworCitmdW5jdGlvbiBmKGEpIHsKKyAg ICAidXNlIHN0cmljdCI7CisgICAgYSA9IDU7CisgICAgcmV0dXJuIGFyZ3VtZW50c1swXTsKK30K Kworbm9JbmxpbmUoZik7CisKK3doaWxlICghZGZnQ29tcGlsZWQoe2Y6Zn0pKQorICAgIGYoMSk7 CisKK3Nob3VsZEJlKCJmKDEpIiwgIjEiKTsKKwo=