119501 2013-08-05 16:51:57 -0700 Editor::updateMarkersForWordsAffectedByEditing(bool) shouldn't compute start and end of words when there are nor markers 2013-08-05 19:00:45 -0700 1 1 1 Unclassified WebKit HTML Editing 528+ (Nightly build) Unspecified Unspecified RESOLVED FIXED InRadar P2 Normal --- 1 rniwa rniwa ap darin enrica morrita oldest_to_newest 914733 0 rniwa 2013-08-05 16:51:57 -0700 setMarkedText is lower on ToT. To mitigate this, avoid computing the start and the end of words in Editor::updateMarkersForWordsAffectedByEditing(bool) when there are no document markers. <rdar://problem/14439234> 914748 1 208161 rniwa 2013-08-05 17:45:56 -0700 Created attachment 208161 Fixes the bug 914759 2 208161 enrica 2013-08-05 18:59:52 -0700 Comment on attachment 208161 Fixes the bug View in context: https://bugs.webkit.org/attachment.cgi?id=208161&action=review Yes! > Source/WebCore/ChangeLog:3 > + Editor::updateMarkersForWordsAffectedByEditing(bool) shouldn't compute start and end of words when there are nor markers typo: 'not' 914760 3 rniwa 2013-08-05 19:00:45 -0700 Committed r153734: <http://trac.webkit.org/changeset/153734> 208161 2013-08-05 17:45:56 -0700 2013-08-05 18:59:52 -0700 Fixes the bug bug-119501-20130805174555.patch text/plain 3186 rniwa SW5kZXg6IFNvdXJjZS9XZWJDb3JlL0NoYW5nZUxvZwo9PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09Ci0tLSBTb3VyY2UvV2Vi Q29yZS9DaGFuZ2VMb2cJKHJldmlzaW9uIDE1MzczMikKKysrIFNvdXJjZS9XZWJDb3JlL0NoYW5n ZUxvZwkod29ya2luZyBjb3B5KQpAQCAtMSwzICsxLDE3IEBACisyMDEzLTA4LTA1ICBSeW9zdWtl IE5pd2EgIDxybml3YUB3ZWJraXQub3JnPgorCisgICAgICAgIEVkaXRvcjo6dXBkYXRlTWFya2Vy c0ZvcldvcmRzQWZmZWN0ZWRCeUVkaXRpbmcoYm9vbCkgc2hvdWxkbid0IGNvbXB1dGUgc3RhcnQg YW5kIGVuZCBvZiB3b3JkcyB3aGVuIHRoZXJlIGFyZSBub3IgbWFya2VycworICAgICAgICBodHRw czovL2J1Z3Mud2Via2l0Lm9yZy9zaG93X2J1Zy5jZ2k/aWQ9MTE5NTAxCisKKyAgICAgICAgUmV2 aWV3ZWQgYnkgTk9CT0RZIChPT1BTISkuCisKKyAgICAgICAgRXhpdCBlYXJseSBpbiB1cGRhdGVN YXJrZXJzRm9yV29yZHNBZmZlY3RlZEJ5RWRpdGluZyBiZWZvcmUgY2FsbGluZyBzdGFydE9mV29y ZCBhbmQgZW5kT2ZXb3JkIGlmIHRoZXJlIGFyZSBubyBkb2N1bWVudCBtYXJrZXJzLgorCisgICAg ICAgICogZG9tL0RvY3VtZW50TWFya2VyQ29udHJvbGxlci5oOgorICAgICAgICAoV2ViQ29yZTo6 RG9jdW1lbnRNYXJrZXJDb250cm9sbGVyOjpoYXNNYXJrZXJzKTogQWRkZWQuCisgICAgICAgICog ZWRpdGluZy9FZGl0b3IuY3BwOgorICAgICAgICAoV2ViQ29yZTo6RWRpdG9yOjp1cGRhdGVNYXJr ZXJzRm9yV29yZHNBZmZlY3RlZEJ5RWRpdGluZyk6CisKIDIwMTMtMDgtMDUgIE9saXZlciBIdW50 ICA8b2xpdmVyQGFwcGxlLmNvbT4KIAogICAgICAgICBNb3ZlIFR5cGVkQXJyYXkgaW1wbGVtZW50 YXRpb24gaW50byBKU0MKSW5kZXg6IFNvdXJjZS9XZWJDb3JlL2RvbS9Eb2N1bWVudE1hcmtlckNv bnRyb2xsZXIuaAo9PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09Ci0tLSBTb3VyY2UvV2ViQ29yZS9kb20vRG9jdW1lbnRNYXJr ZXJDb250cm9sbGVyLmgJKHJldmlzaW9uIDE1MzcyOSkKKysrIFNvdXJjZS9XZWJDb3JlL2RvbS9E b2N1bWVudE1hcmtlckNvbnRyb2xsZXIuaAkod29ya2luZyBjb3B5KQpAQCAtNTUsNiArNTUsMTEg QEAgcHVibGljOgogICAgIHZvaWQgYWRkVGV4dE1hdGNoTWFya2VyKGNvbnN0IFJhbmdlKiwgYm9v bCBhY3RpdmVNYXRjaCk7CiAKICAgICB2b2lkIGNvcHlNYXJrZXJzKE5vZGUqIHNyY05vZGUsIHVu c2lnbmVkIHN0YXJ0T2Zmc2V0LCBpbnQgbGVuZ3RoLCBOb2RlKiBkc3ROb2RlLCBpbnQgZGVsdGEp OworICAgIGJvb2wgaGFzTWFya2VycygpIGNvbnN0CisgICAgeworICAgICAgICBBU1NFUlQobV9t YXJrZXJzLmlzRW1wdHkoKSA9PSAhbV9wb3NzaWJseUV4aXN0aW5nTWFya2VyVHlwZXMuaW50ZXJz ZWN0cyhEb2N1bWVudE1hcmtlcjo6QWxsTWFya2VycygpKSk7CisgICAgICAgIHJldHVybiAhbV9t YXJrZXJzLmlzRW1wdHkoKTsKKyAgICB9CiAgICAgYm9vbCBoYXNNYXJrZXJzKFJhbmdlKiwgRG9j dW1lbnRNYXJrZXI6Ok1hcmtlclR5cGVzID0gRG9jdW1lbnRNYXJrZXI6OkFsbE1hcmtlcnMoKSk7 CiAKICAgICAvLyBXaGVuIGEgbWFya2VyIHBhcnRpYWxseSBvdmVybGFwcyB3aXRoIHJhbmdlLCBp ZiByZW1vdmVQYXJ0aWFsbHlPdmVybGFwcGluZ01hcmtlcnMgaXMgdHJ1ZSwgd2UgY29tcGxldGVs eQpJbmRleDogU291cmNlL1dlYkNvcmUvZWRpdGluZy9FZGl0b3IuY3BwCj09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT0KLS0t IFNvdXJjZS9XZWJDb3JlL2VkaXRpbmcvRWRpdG9yLmNwcAkocmV2aXNpb24gMTUzNzI5KQorKysg U291cmNlL1dlYkNvcmUvZWRpdGluZy9FZGl0b3IuY3BwCSh3b3JraW5nIGNvcHkpCkBAIC0yMzc2 LDYgKzIzNzYsMTAgQEAgdm9pZCBFZGl0b3I6OnVuYXBwbGllZFNwZWxsQ29ycmVjdGlvbihjbwog CiB2b2lkIEVkaXRvcjo6dXBkYXRlTWFya2Vyc0ZvcldvcmRzQWZmZWN0ZWRCeUVkaXRpbmcoYm9v bCBkb05vdFJlbW92ZUlmU2VsZWN0aW9uQXRXb3JkQm91bmRhcnkpCiB7CisgICAgRG9jdW1lbnQq IGRvY3VtZW50ID0gbV9mcmFtZS0+ZG9jdW1lbnQoKTsKKyAgICBpZiAoIWRvY3VtZW50IHx8ICFk b2N1bWVudC0+bWFya2VycygpLT5oYXNNYXJrZXJzKCkpCisgICAgICAgIHJldHVybjsKKwogICAg IGlmICghbV9hbHRlcm5hdGl2ZVRleHRDb250cm9sbGVyLT5zaG91bGRSZW1vdmVNYXJrZXJzVXBv bkVkaXRpbmcoKSAmJiAoIXRleHRDaGVja2VyKCkgfHwgdGV4dENoZWNrZXIoKS0+c2hvdWxkRXJh c2VNYXJrZXJzQWZ0ZXJDaGFuZ2VTZWxlY3Rpb24oVGV4dENoZWNraW5nVHlwZVNwZWxsaW5nKSkp CiAgICAgICAgIHJldHVybjsKIApAQCAtMjQzNyw3ICsyNDQxLDYgQEAgdm9pZCBFZGl0b3I6OnVw ZGF0ZU1hcmtlcnNGb3JXb3Jkc0FmZmVjdAogICAgIC8vIGdhcmRlIiwgd2Ugd2lsbCBoYXZlIENv cnJlY3Rpb25JbmRpY2F0b3IgbWFya2VyIG9uIGJvdGggd29yZHMgYW5kIG9uIHRoZSB3aGl0ZXNw YWNlIGJldHdlZW4gdGhlbS4gSWYgd2UgdGhlbiBlZGl0IGdhcmRlLAogICAgIC8vIHdlIHdvdWxk IGxpa2UgdG8gcmVtb3ZlIHRoZSBtYXJrZXIgZnJvbSB3b3JkICJhdmFudCIgYW5kIHdoaXRlc3Bh Y2UgYXMgd2VsbC4gU28gd2UgbmVlZCB0byBnZXQgdGhlIGNvbnRpbm91cyByYW5nZSBvZgogICAg IC8vIG9mIG1hcmtlciB0aGF0IGNvbnRhaW5zIHRoZSB3b3JkIGluIHF1ZXN0aW9uLCBhbmQgcmVt b3ZlIG1hcmtlciBvbiB0aGF0IHdob2xlIHJhbmdlLgotICAgIERvY3VtZW50KiBkb2N1bWVudCA9 IG1fZnJhbWUtPmRvY3VtZW50KCk7CiAgICAgUmVmUHRyPFJhbmdlPiB3b3JkUmFuZ2UgPSBSYW5n ZTo6Y3JlYXRlKGRvY3VtZW50LCBzdGFydE9mRmlyc3RXb3JkLmRlZXBFcXVpdmFsZW50KCksIGVu ZE9mTGFzdFdvcmQuZGVlcEVxdWl2YWxlbnQoKSk7CiAKICAgICBWZWN0b3I8RG9jdW1lbnRNYXJr ZXIqPiBtYXJrZXJzID0gZG9jdW1lbnQtPm1hcmtlcnMoKS0+bWFya2Vyc0luUmFuZ2Uod29yZFJh bmdlLmdldCgpLCBEb2N1bWVudE1hcmtlcjo6RGljdGF0aW9uQWx0ZXJuYXRpdmVzKTsK