119496 2013-08-05 14:33:13 -0700 REGRESSION (r153060?): Microphone appears in the way of text when dictating an e-mail 2013-08-05 14:55:10 -0700 1 1 1 Unclassified WebKit HTML Editing 528+ (Nightly build) Unspecified Unspecified RESOLVED FIXED InRadar, Regression P2 Normal --- 1 ap ap commit-queue esprehn+autocc glenn kondapallykalyan oldest_to_newest 914693 0 ap 2013-08-05 14:33:13 -0700 Steps to reproduce: 1. In Blot, or another WebKit1 application, type a line of text, then press Enter. 2. With insertion point at the beginning of line,invoke dictation. Results: dictation popover covers the text you have. <rdar://problem/14637103> 914699 1 208150 ap 2013-08-05 14:45:00 -0700 Created attachment 208150 proposed fix 914700 2 208150 rniwa 2013-08-05 14:47:33 -0700 Comment on attachment 208150 proposed fix View in context: https://bugs.webkit.org/attachment.cgi?id=208150&action=review Seems sensible. > Source/WebCore/ChangeLog:3 > + <rdar://problem/14637103> REGRESSION (r153060?): Microphone appears in the way You should put <rdar://problem/14637103> on a separate line below the bugzilla URL. 914706 3 ap 2013-08-05 14:53:31 -0700 So what happened was that the rect remained null as originally set: FloatRect result; for (size_t i = 0; i < quads.size(); ++i) result.unite(quads[i].boundingBox()); The unite() call does nothing when appending an empty rect, but we want to return the empty caret rect, not the initial null one! We also don't want the initial null rect as part of the result, which would happen if I simply changed unite() to uniteEvenIfEmpty(). 914707 4 ap 2013-08-05 14:55:10 -0700 Committed <http://trac.webkit.org/r153725>. 208150 2013-08-05 14:45:00 -0700 2013-08-05 14:47:33 -0700 proposed fix FixDictation.txt text/plain 5983 ap SW5kZXg6IFNvdXJjZS9XZWJDb3JlL0NoYW5nZUxvZwo9PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09Ci0tLSBTb3VyY2UvV2Vi Q29yZS9DaGFuZ2VMb2cJKHJldmlzaW9uIDE1MzcyNCkKKysrIFNvdXJjZS9XZWJDb3JlL0NoYW5n ZUxvZwkod29ya2luZyBjb3B5KQpAQCAtMSwzICsxLDE4IEBACisyMDEzLTA4LTA1ICBBbGV4ZXkg UHJvc2t1cnlha292ICA8YXBAYXBwbGUuY29tPgorCisgICAgICAgIDxyZGFyOi8vcHJvYmxlbS8x NDYzNzEwMz4gUkVHUkVTU0lPTiAocjE1MzA2MD8pOiBNaWNyb3Bob25lIGFwcGVhcnMgaW4gdGhl IHdheQorICAgICAgICBvZiB0ZXh0IHdoZW4gZGljdGF0aW5nIGFuIGUtbWFpbAorICAgICAgICBo dHRwczovL2J1Z3Mud2Via2l0Lm9yZy9zaG93X2J1Zy5jZ2k/aWQ9MTE5NDk2CisKKyAgICAgICAg UmV2aWV3ZWQgYnkgTk9CT0RZIChPT1BTISkuCisKKyAgICAgICAgVGVzdDogcGxhdGZvcm0vbWFj L2VkaXRpbmcvaW5wdXQvZmlyc3RyZWN0Zm9yY2hhcmFjdGVycmFuZ2UtY2FyZXQtaW4tYnIuaHRt bAorCisgICAgICAgICogcmVuZGVyaW5nL1JlbmRlck9iamVjdC5jcHA6IChXZWJDb3JlOjpSZW5k ZXJPYmplY3Q6OmFic29sdXRlQm91bmRpbmdCb3hSZWN0Rm9yUmFuZ2UpOgorICAgICAgICBGbG9h dFJlY3Q6OnVuaXRlKCkgZG9lc24ndCBwcmVzZXJ2ZSBlbXB0eSByZWN0cywgd2hpY2ggd2UgbmVl ZCBoZXJlLgorICAgICAgICBXZSBhbHJhZHkgaGFuZGxlIHRoZSBjYXNlIG9mIGNvbGxhcHNlZCBy YW5nZSBpbiBFZGl0b3I6OmZpcnN0UmVjdEZvclJhbmdlKCksIGFuZAorICAgICAgICB0aGlzIGlz IHNpbWlsYXIsIGJ1dCB3ZSBjYW4ndCBjdXJyZW50bHkgY292ZXIgYm90aCB3aXRoIG9uZSBzaW1w bGUgZml4LgorCiAyMDEzLTA4LTA1ICBNb3J0ZW4gU3RlbnNob3JuZSAgPG1zdGVuc2hvQG9wZXJh LmNvbT4KIAogICAgICAgICBSZWdpb24gYmFzZWQgY29sdW1ucyBub3QgcGFpbnRlZCBjb3JyZWN0 bHkgaW4gbm9uLWRlZmF1bHQgd3JpdGluZy1tb2RlcwpJbmRleDogU291cmNlL1dlYkNvcmUvcmVu ZGVyaW5nL1JlbmRlck9iamVjdC5jcHAKPT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PQotLS0gU291cmNlL1dlYkNvcmUvcmVu ZGVyaW5nL1JlbmRlck9iamVjdC5jcHAJKHJldmlzaW9uIDE1MzY1MykKKysrIFNvdXJjZS9XZWJD b3JlL3JlbmRlcmluZy9SZW5kZXJPYmplY3QuY3BwCSh3b3JraW5nIGNvcHkpCkBAIC0xMjQzLDkg KzEyNDMsMTIgQEAgRmxvYXRSZWN0IFJlbmRlck9iamVjdDo6YWJzb2x1dGVCb3VuZGluZwogICAg IFZlY3RvcjxGbG9hdFF1YWQ+IHF1YWRzOwogICAgIHJhbmdlLT50ZXh0UXVhZHMocXVhZHMpOwog Ci0gICAgRmxvYXRSZWN0IHJlc3VsdDsKLSAgICBmb3IgKHNpemVfdCBpID0gMDsgaSA8IHF1YWRz LnNpemUoKTsgKytpKQotICAgICAgICByZXN1bHQudW5pdGUocXVhZHNbaV0uYm91bmRpbmdCb3go KSk7CisgICAgaWYgKHF1YWRzLmlzRW1wdHkoKSkKKyAgICAgICAgcmV0dXJuIEZsb2F0UmVjdCgp OworCisgICAgRmxvYXRSZWN0IHJlc3VsdCA9IHF1YWRzWzBdLmJvdW5kaW5nQm94KCk7CisgICAg Zm9yIChzaXplX3QgaSA9IDE7IGkgPCBxdWFkcy5zaXplKCk7ICsraSkKKyAgICAgICAgcmVzdWx0 LnVuaXRlRXZlbklmRW1wdHkocXVhZHNbaV0uYm91bmRpbmdCb3goKSk7CiAKICAgICByZXR1cm4g cmVzdWx0OwogfQpJbmRleDogTGF5b3V0VGVzdHMvQ2hhbmdlTG9nCj09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT0KLS0tIExh eW91dFRlc3RzL0NoYW5nZUxvZwkocmV2aXNpb24gMTUzNzI0KQorKysgTGF5b3V0VGVzdHMvQ2hh bmdlTG9nCSh3b3JraW5nIGNvcHkpCkBAIC0xLDMgKzEsMTcgQEAKKzIwMTMtMDgtMDUgIEFsZXhl eSBQcm9za3VyeWFrb3YgIDxhcEBhcHBsZS5jb20+CisKKyAgICAgICAgPHJkYXI6Ly9wcm9ibGVt LzE0NjM3MTAzPiBSRUdSRVNTSU9OIChyMTUzMDYwPyk6IE1pY3JvcGhvbmUgYXBwZWFycyBpbiB0 aGUgd2F5CisgICAgICAgIG9mIHRleHQgd2hlbiBkaWN0YXRpbmcgYW4gZS1tYWlsCisgICAgICAg IGh0dHBzOi8vYnVncy53ZWJraXQub3JnL3Nob3dfYnVnLmNnaT9pZD0xMTk0OTYKKworICAgICAg ICBSZXZpZXdlZCBieSBOT0JPRFkgKE9PUFMhKS4KKworICAgICAgICAqIHBsYXRmb3JtL21hYy9l ZGl0aW5nL2lucHV0L2ZpcnN0cmVjdGZvcmNoYXJhY3RlcnJhbmdlLWNhcmV0LWluLWJyLWV4cGVj dGVkLnR4dDogQWRkZWQuCisgICAgICAgICogcGxhdGZvcm0vbWFjL2VkaXRpbmcvaW5wdXQvZmly c3RyZWN0Zm9yY2hhcmFjdGVycmFuZ2UtY2FyZXQtaW4tYnIuaHRtbDogQWRkZWQuCisKKyAgICAg ICAgKiBwbGF0Zm9ybS93azIvVGVzdEV4cGVjdGF0aW9uczogdGV4dElucHV0Q29udHJvbGxlci5m aXJzdFJlY3RGb3JDaGFyYWN0ZXJSYW5nZSBpcworICAgICAgICBub3QgYXZhaWxhYmxlIGluIFdU Ui4KKwogMjAxMy0wOC0wNSAgTW9ydGVuIFN0ZW5zaG9ybmUgIDxtc3RlbnNob0BvcGVyYS5jb20+ CiAKICAgICAgICAgUmVnaW9uIGJhc2VkIGNvbHVtbnMgbm90IHBhaW50ZWQgY29ycmVjdGx5IGlu IG5vbi1kZWZhdWx0IHdyaXRpbmctbW9kZXMKSW5kZXg6IExheW91dFRlc3RzL3BsYXRmb3JtL21h Yy9lZGl0aW5nL2lucHV0L2ZpcnN0cmVjdGZvcmNoYXJhY3RlcnJhbmdlLWNhcmV0LWluLWJyLWV4 cGVjdGVkLnR4dAo9PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09Ci0tLSBMYXlvdXRUZXN0cy9wbGF0Zm9ybS9tYWMvZWRpdGlu Zy9pbnB1dC9maXJzdHJlY3Rmb3JjaGFyYWN0ZXJyYW5nZS1jYXJldC1pbi1ici1leHBlY3RlZC50 eHQJKHJldmlzaW9uIDApCisrKyBMYXlvdXRUZXN0cy9wbGF0Zm9ybS9tYWMvZWRpdGluZy9pbnB1 dC9maXJzdHJlY3Rmb3JjaGFyYWN0ZXJyYW5nZS1jYXJldC1pbi1ici1leHBlY3RlZC50eHQJKHdv cmtpbmcgY29weSkKQEAgLTAsMCArMSw5IEBACitQQVNTIHhMb2NhdGlvbiA+IDAgaXMgdHJ1ZQor UEFTUyB3aWR0aCBpcyAwCitQQVNTIGhlaWdodCA+IDEwIGlzIHRydWUKK1BBU1MgaGVpZ2h0IDwg MzAgaXMgdHJ1ZQorUEFTUyBzdWNjZXNzZnVsbHlQYXJzZWQgaXMgdHJ1ZQorCitURVNUIENPTVBM RVRFCisKKwoKUHJvcGVydHkgY2hhbmdlcyBvbjogTGF5b3V0VGVzdHMvcGxhdGZvcm0vbWFjL2Vk aXRpbmcvaW5wdXQvZmlyc3RyZWN0Zm9yY2hhcmFjdGVycmFuZ2UtY2FyZXQtaW4tYnItZXhwZWN0 ZWQudHh0Cl9fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19f X19fX19fX19fX19fX19fX18KQWRkZWQ6IHN2bjptaW1lLXR5cGUKIyMgLTAsMCArMSAjIwordGV4 dC9wbGFpbgpcIE5vIG5ld2xpbmUgYXQgZW5kIG9mIHByb3BlcnR5CkFkZGVkOiBzdm46ZW9sLXN0 eWxlCiMjIC0wLDAgKzEgIyMKK25hdGl2ZQpcIE5vIG5ld2xpbmUgYXQgZW5kIG9mIHByb3BlcnR5 CkluZGV4OiBMYXlvdXRUZXN0cy9wbGF0Zm9ybS9tYWMvZWRpdGluZy9pbnB1dC9maXJzdHJlY3Rm b3JjaGFyYWN0ZXJyYW5nZS1jYXJldC1pbi1ici5odG1sCj09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT0KLS0tIExheW91dFRl c3RzL3BsYXRmb3JtL21hYy9lZGl0aW5nL2lucHV0L2ZpcnN0cmVjdGZvcmNoYXJhY3RlcnJhbmdl LWNhcmV0LWluLWJyLmh0bWwJKHJldmlzaW9uIDApCisrKyBMYXlvdXRUZXN0cy9wbGF0Zm9ybS9t YWMvZWRpdGluZy9pbnB1dC9maXJzdHJlY3Rmb3JjaGFyYWN0ZXJyYW5nZS1jYXJldC1pbi1ici5o dG1sCSh3b3JraW5nIGNvcHkpCkBAIC0wLDAgKzEsMzIgQEAKKzxoZWFkPgorPHNjcmlwdCBzcmM9 Ii4uLy4uLy4uLy4uL2Zhc3QvanMvcmVzb3VyY2VzL2pzLXRlc3QtcHJlLmpzIj48L3NjcmlwdD4K KzwvaGVhZD4KKzxib2R5IHN0eWxlPSJ3b3JkLXdyYXA6IGJyZWFrLXdvcmQ7IC13ZWJraXQtbmJz cC1tb2RlOiBzcGFjZTsgLXdlYmtpdC1saW5lLWJyZWFrOiBhZnRlci13aGl0ZS1zcGFjZTsiPmEK KzxkaXY+PGJyPjwvZGl2PgorPHNjcmlwdD4KK2RvY3VtZW50LmRlc2lnbk1vZGU9J29uJzsKK3dp bmRvdy5nZXRTZWxlY3Rpb24oKS5zZXRQb3NpdGlvbihkb2N1bWVudC5ib2R5LCAyKTsKKworaWYg KHdpbmRvdy50ZXh0SW5wdXRDb250cm9sbGVyKSB7CisgICAgdmFyIGZpcnN0UmVjdCA9IHRleHRJ bnB1dENvbnRyb2xsZXIuZmlyc3RSZWN0Rm9yQ2hhcmFjdGVyUmFuZ2UoMiwgMSk7CisKKyAgICAv LyBUaGlzIHNob3VsZCBiZSBhIHJlYXNvbmFibGUgcmVjdCBmb3IgYSBjYXJldC4KKyAgICB2YXIg eExvY2F0aW9uID0gZmlyc3RSZWN0WzBdOworICAgIHZhciB3aWR0aCA9IGZpcnN0UmVjdFsyXTsK KyAgICB2YXIgaGVpZ2h0ID0gZmlyc3RSZWN0WzNdOworICAgIHNob3VsZEJlVHJ1ZSgieExvY2F0 aW9uID4gMCIpOworICAgIHNob3VsZEJlKCJ3aWR0aCIsICIwIik7CisgICAgc2hvdWxkQmVUcnVl KCJoZWlnaHQgPiAxMCIpOworICAgIHNob3VsZEJlVHJ1ZSgiaGVpZ2h0IDwgMzAiKTsKKworICAg IC8vIERlbGV0ZSB0ZXN0IGRhdGEgZm9yIG5pY2VyIG91dHB1dC4KKyAgICBkb2N1bWVudC5leGVj Q29tbWFuZCgiRGVsZXRlIik7CisgICAgZG9jdW1lbnQuZXhlY0NvbW1hbmQoIkRlbGV0ZSIpOwor fSBlbHNlIHsKKyAgICBkZWJ1ZygiVG8gdGVzdCBtYW51YWxseSwgaW52b2tlIERpY3RhdGlvbi4g SXRzIHBvcG92ZXIgc2hvdWxkIGJlIHBvc2l0aW9uZWQgcmVhc29uYWJseS4iKTsKK30KKzwvc2Ny aXB0PgorPGRpdiBpZD1yZXN1bHQ+PC9kaXY+Cis8L2JvZHk+Cis8c2NyaXB0IHNyYz0iLi4vLi4v Li4vLi4vZmFzdC9qcy9yZXNvdXJjZXMvanMtdGVzdC1wb3N0LmpzIj48L3NjcmlwdD4KKzwvaHRt bD4KClByb3BlcnR5IGNoYW5nZXMgb246IExheW91dFRlc3RzL3BsYXRmb3JtL21hYy9lZGl0aW5n L2lucHV0L2ZpcnN0cmVjdGZvcmNoYXJhY3RlcnJhbmdlLWNhcmV0LWluLWJyLmh0bWwKX19fX19f X19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19f X19fXwpBZGRlZDogc3ZuOm1pbWUtdHlwZQojIyAtMCwwICsxICMjCit0ZXh0L2h0bWwKXCBObyBu ZXdsaW5lIGF0IGVuZCBvZiBwcm9wZXJ0eQpJbmRleDogTGF5b3V0VGVzdHMvcGxhdGZvcm0vd2sy L1Rlc3RFeHBlY3RhdGlvbnMKPT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PQotLS0gTGF5b3V0VGVzdHMvcGxhdGZvcm0vd2sy L1Rlc3RFeHBlY3RhdGlvbnMJKHJldmlzaW9uIDE1MzY1MykKKysrIExheW91dFRlc3RzL3BsYXRm b3JtL3drMi9UZXN0RXhwZWN0YXRpb25zCSh3b3JraW5nIGNvcHkpCkBAIC0xMjUsNiArMTI1LDcg QEAgZmFzdC90ZXh0L2ludGVybmF0aW9uYWwvdGhhaS1jdXJzb3ItcG9zaQogcGxhdGZvcm0vbWFj L2VkaXRpbmcvaW5wdXQvNTU3NjYxOS5odG1sCiBwbGF0Zm9ybS9tYWMvZWRpdGluZy9pbnB1dC9i b2xkLW5vZGUuaHRtbAogcGxhdGZvcm0vbWFjL2VkaXRpbmcvaW5wdXQvY2FyZXQtcHJpbWFyeS1i aWRpLmh0bWwKK3BsYXRmb3JtL21hYy9lZGl0aW5nL2lucHV0L2ZpcnN0cmVjdGZvcmNoYXJhY3Rl cnJhbmdlLWNhcmV0LWluLWJyLmh0bWwKIHBsYXRmb3JtL21hYy9lZGl0aW5nL2lucHV0L2ZpcnN0 cmVjdGZvcmNoYXJhY3RlcnJhbmdlLXBsYWluLmh0bWwKIHBsYXRmb3JtL21hYy9lZGl0aW5nL2lu cHV0L2ZpcnN0cmVjdGZvcmNoYXJhY3RlcnJhbmdlLXN0eWxlZC5odG1sCiBwbGF0Zm9ybS9tYWMv ZWRpdGluZy9pbnB1dC9maXJzdHJlY3Rmb3JjaGFyYWN0ZXJyYW5nZS12ZXJ0aWNhbC5odG1sCg==