119483 2013-08-05 01:45:42 -0700 XMLTreeViewer should be created only in the XML viewer mode 2013-08-12 23:47:39 -0700 1 1 1 Unclassified WebKit XML 528+ (Nightly build) Unspecified Unspecified RESOLVED FIXED P2 Normal --- 1 vivekg vivekg commit-queue darin rniwa oldest_to_newest 914517 0 vivekg 2013-08-05 01:45:42 -0700 XMLTreeViewer is created even for the XSL transform. This should be avoided. It should also remove unnecessary conditional check while deciding for XML viewer mode. These patches are already reviewed in blink. Combining these relevant patches into a single patch for webkit. https://codereview.chromium.org/19552003/ https://codereview.chromium.org/22150003/ Patch follows. 914521 1 208112 vivekg 2013-08-05 01:54:33 -0700 Created attachment 208112 Patch 914597 2 vivekg 2013-08-05 09:00:45 -0700 @ap, thanks for the review. 914602 3 208112 commit-queue 2013-08-05 09:24:52 -0700 Comment on attachment 208112 Patch Clearing flags on attachment: 208112 Committed r153707: <http://trac.webkit.org/changeset/153707> 914603 4 commit-queue 2013-08-05 09:24:54 -0700 All reviewed patches have been landed. Closing bug. 916581 5 rniwa 2013-08-12 23:47:39 -0700 *** Bug 119723 has been marked as a duplicate of this bug. *** 208112 2013-08-05 01:54:33 -0700 2013-08-05 09:24:52 -0700 Patch bug-119483-20130805142816.patch text/plain 6338 vivekg U3VidmVyc2lvbiBSZXZpc2lvbjogMTUzNzAxCmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViQ29yZS9D aGFuZ2VMb2cgYi9Tb3VyY2UvV2ViQ29yZS9DaGFuZ2VMb2cKaW5kZXggYTI3OGUwMTQ1ZmY0YWNj MTIxNGI0MjA0YzY5MmU1MTQyZjE3OTZhZS4uYmYwZjdmYWUyNWVhNWJjZGVlZjk0MTNjNWYwZWQ2 ZjllOWQ1NmFjNiAxMDA2NDQKLS0tIGEvU291cmNlL1dlYkNvcmUvQ2hhbmdlTG9nCisrKyBiL1Nv dXJjZS9XZWJDb3JlL0NoYW5nZUxvZwpAQCAtMSwzICsxLDI3IEBACisyMDEzLTA4LTA1ICBWaXZl ayBHYWxhdGFnZSAgPHZpdmVrLnZnQHNhbXN1bmcuY29tPgorCisgICAgICAgIFhNTFRyZWVWaWV3 ZXIgc2hvdWxkIGJlIGNyZWF0ZWQgb25seSBpbiB0aGUgWE1MIHZpZXdlciBtb2RlCisgICAgICAg IGh0dHBzOi8vYnVncy53ZWJraXQub3JnL3Nob3dfYnVnLmNnaT9pZD0xMTk0ODMKKworICAgICAg ICBSZXZpZXdlZCBieSBOT0JPRFkgKE9PUFMhKS4KKworICAgICAgICBYTUxUcmVlVmlld2VyIGlz IGNyZWF0ZWQgZXZlbiBmb3IgdGhlIFhTTCB0cmFuc2Zvcm0gd2hpY2ggaXMgYXZvaWRlZCBieSB0 aGUgcGF0Y2guCisgICAgICAgIFRoZSBYTUxUcmVlVmlld2VyOjpoYXNOb1N0eWxlSW5mb3JtYXRp b24oKSBpcyBtb3ZlZCB0byBYTUxEb2N1bWVudFBhcnNlckxpYnhtbDIuY3BwCisgICAgICAgIGFz IHN0YXRpYyBpbmxpbmUgbWV0aG9kIGFzIFhNTFRyZWVWaWV3ZXIgc2hvdWxkIG5vdCBoYXZlIHRo ZSByZXNwb25zaWJpbGl0eSBmb3IgaXQuCisgICAgICAgIEFsc28gcmVtb3ZlcyBhbiB1bm5lY2Vz c2FyeSBjb25kaXRpb25hbCBjaGVjayB3aGlsZSBkZWNpZGluZyBmb3IgWE1MIHZpZXdlciBtb2Rl LgorCisgICAgICAgIEJsaW5rIHBhdGNoIHJldmlldyBsaW5rczoKKyAgICAgICAgaHR0cHM6Ly9j b2RlcmV2aWV3LmNocm9taXVtLm9yZy8xOTU1MjAwMy8KKyAgICAgICAgaHR0cHM6Ly9jb2RlcmV2 aWV3LmNocm9taXVtLm9yZy8yMjE1MDAwMy8KKworICAgICAgICBObyBuZXcgdGVzdHMgYXMgdGhl IHBhdGNoIGlzIGFib3V0IGNvZGUgcmVmYWN0b3JpbmcuCisKKyAgICAgICAgKiB4bWwvWE1MVHJl ZVZpZXdlci5jcHA6CisgICAgICAgICogeG1sL1hNTFRyZWVWaWV3ZXIuaDoKKyAgICAgICAgKiB4 bWwvcGFyc2VyL1hNTERvY3VtZW50UGFyc2VyTGlieG1sMi5jcHA6CisgICAgICAgIChXZWJDb3Jl OjpoYXNOb1N0eWxlSW5mb3JtYXRpb24pOgorICAgICAgICAoV2ViQ29yZTo6WE1MRG9jdW1lbnRQ YXJzZXI6OmRvRW5kKToKKwogMjAxMy0wOC0wNCAgWmFsYW4gQnVqdGFzICA8emFsYW5AYXBwbGUu Y29tPgogCiAgICAgICAgIEJhY2tncm91bmQgZG9lc24ndCBmdWxseSByZXBhaW50IHdoZW4gYm9k eSBoYXMgbWFyZ2lucy4KZGlmZiAtLWdpdCBhL1NvdXJjZS9XZWJDb3JlL3htbC9YTUxUcmVlVmll d2VyLmNwcCBiL1NvdXJjZS9XZWJDb3JlL3htbC9YTUxUcmVlVmlld2VyLmNwcAppbmRleCBkNTJl ODExMmVmNmM0YWUyMDU1YjBhMTBhNzhkYzJkMDRlZjg4ZmE4Li44MThjMmIxMzQ5YThkYWI1MjM4 YmUzODYyNzNlYjg5MDFkOTcwNzU1IDEwMDY0NAotLS0gYS9Tb3VyY2UvV2ViQ29yZS94bWwvWE1M VHJlZVZpZXdlci5jcHAKKysrIGIvU291cmNlL1dlYkNvcmUveG1sL1hNTFRyZWVWaWV3ZXIuY3Bw CkBAIC0xLDUgKzEsNiBAQAogLyoKICAqIENvcHlyaWdodCAoQykgMjAxMSBHb29nbGUgSW5jLiBB bGwgcmlnaHRzIHJlc2VydmVkLgorICogQ29weXJpZ2h0IChDKSAyMDEzIFNhbXN1bmcgRWxlY3Ry b25pY3MuIEFsbCByaWdodHMgcmVzZXJ2ZWQuCiAgKgogICogUmVkaXN0cmlidXRpb24gYW5kIHVz ZSBpbiBzb3VyY2UgYW5kIGJpbmFyeSBmb3Jtcywgd2l0aCBvciB3aXRob3V0CiAgKiBtb2RpZmlj YXRpb24sIGFyZSBwZXJtaXR0ZWQgcHJvdmlkZWQgdGhhdCB0aGUgZm9sbG93aW5nIGNvbmRpdGlv bnMgYXJlCkBAIC0zNSwxMSArMzYsOSBAQAogI2luY2x1ZGUgIkVsZW1lbnQuaCIKICNpbmNsdWRl ICJFeGNlcHRpb25Db2RlUGxhY2Vob2xkZXIuaCIKICNpbmNsdWRlICJGcmFtZS5oIgotI2luY2x1 ZGUgIlBhZ2UuaCIKICNpbmNsdWRlICJTY3JpcHRDb250cm9sbGVyLmgiCiAjaW5jbHVkZSAiU2Ny aXB0U291cmNlQ29kZS5oIgogI2luY2x1ZGUgIlNjcmlwdFZhbHVlLmgiCi0jaW5jbHVkZSAiU2V0 dGluZ3MuaCIKICNpbmNsdWRlICJUZXh0LmgiCiAjaW5jbHVkZSAiWE1MVmlld2VyQ1NTLmgiCiAj aW5jbHVkZSAiWE1MVmlld2VySlMuaCIKQEAgLTUzLDIzICs1Miw2IEBAIFhNTFRyZWVWaWV3ZXI6 OlhNTFRyZWVWaWV3ZXIoRG9jdW1lbnQqIGRvY3VtZW50KQogewogfQogCi1ib29sIFhNTFRyZWVW aWV3ZXI6Omhhc05vU3R5bGVJbmZvcm1hdGlvbigpIGNvbnN0Ci17Ci0gICAgaWYgKG1fZG9jdW1l bnQtPnNhd0VsZW1lbnRzSW5Lbm93bk5hbWVzcGFjZXMoKSB8fCBtX2RvY3VtZW50LT50cmFuc2Zv cm1Tb3VyY2VEb2N1bWVudCgpKQotICAgICAgICByZXR1cm4gZmFsc2U7Ci0KLSAgICBpZiAoIW1f ZG9jdW1lbnQtPmZyYW1lKCkgfHwgIW1fZG9jdW1lbnQtPmZyYW1lKCktPnBhZ2UoKSkKLSAgICAg ICAgcmV0dXJuIGZhbHNlOwotCi0gICAgaWYgKCFtX2RvY3VtZW50LT5mcmFtZSgpLT5wYWdlKCkt PnNldHRpbmdzKCktPmRldmVsb3BlckV4dHJhc0VuYWJsZWQoKSkKLSAgICAgICAgcmV0dXJuIGZh bHNlOwotCi0gICAgaWYgKG1fZG9jdW1lbnQtPmZyYW1lKCktPnRyZWUoKS0+cGFyZW50KCkpCi0g ICAgICAgIHJldHVybiBmYWxzZTsgLy8gVGhpcyBkb2N1bWVudCBpcyBub3QgaW4gYSB0b3AgZnJh bWUKLQotICAgIHJldHVybiB0cnVlOwotfQotCiB2b2lkIFhNTFRyZWVWaWV3ZXI6OnRyYW5zZm9y bURvY3VtZW50VG9UcmVlVmlldygpCiB7CiAgICAgbV9kb2N1bWVudC0+c2V0SXNWaWV3U291cmNl KHRydWUpOwpkaWZmIC0tZ2l0IGEvU291cmNlL1dlYkNvcmUveG1sL1hNTFRyZWVWaWV3ZXIuaCBi L1NvdXJjZS9XZWJDb3JlL3htbC9YTUxUcmVlVmlld2VyLmgKaW5kZXggOTMwMThlN2U2YTA0MWRh ZGY3YjAyNjQyY2ZiNzUyZGVlOWI2ZGE4ZC4uZTU2MzgyZmJiMmU4N2QzYThjM2U3NzQxZTI1MTI2 Zjg2OTI4NGNhMCAxMDA2NDQKLS0tIGEvU291cmNlL1dlYkNvcmUveG1sL1hNTFRyZWVWaWV3ZXIu aAorKysgYi9Tb3VyY2UvV2ViQ29yZS94bWwvWE1MVHJlZVZpZXdlci5oCkBAIC0xLDUgKzEsNiBA QAogLyoKICAqIENvcHlyaWdodCAoQykgMjAxMSBHb29nbGUgSW5jLiBBbGwgcmlnaHRzIHJlc2Vy dmVkLgorICogQ29weXJpZ2h0IChDKSAyMDEzIFNhbXN1bmcgRWxlY3Ryb25pY3MuIEFsbCByaWdo dHMgcmVzZXJ2ZWQuCiAgKgogICogUmVkaXN0cmlidXRpb24gYW5kIHVzZSBpbiBzb3VyY2UgYW5k IGJpbmFyeSBmb3Jtcywgd2l0aCBvciB3aXRob3V0CiAgKiBtb2RpZmljYXRpb24sIGFyZSBwZXJt aXR0ZWQgcHJvdmlkZWQgdGhhdCB0aGUgZm9sbG93aW5nIGNvbmRpdGlvbnMgYXJlCkBAIC00MCw3 ICs0MSw2IEBAIHB1YmxpYzoKICAgICBleHBsaWNpdCBYTUxUcmVlVmlld2VyKERvY3VtZW50Kik7 CiAgICAgdmlydHVhbCB+WE1MVHJlZVZpZXdlcigpIHt9OwogCi0gICAgYm9vbCBoYXNOb1N0eWxl SW5mb3JtYXRpb24oKSBjb25zdDsKICAgICB2b2lkIHRyYW5zZm9ybURvY3VtZW50VG9UcmVlVmll dygpOwogCiBwcml2YXRlOgpkaWZmIC0tZ2l0IGEvU291cmNlL1dlYkNvcmUveG1sL3BhcnNlci9Y TUxEb2N1bWVudFBhcnNlckxpYnhtbDIuY3BwIGIvU291cmNlL1dlYkNvcmUveG1sL3BhcnNlci9Y TUxEb2N1bWVudFBhcnNlckxpYnhtbDIuY3BwCmluZGV4IDhiODc4NmI3YTg1YjM2MzU2MGJhNjIy MmI0Mzc4ZmFkN2M2M2M5OTEuLjQ4NDM0MjAzMWQzYzhiN2RkNTRhOWY5ZGExNmMxZDcyNWY4YTNm YTEgMTAwNjQ0Ci0tLSBhL1NvdXJjZS9XZWJDb3JlL3htbC9wYXJzZXIvWE1MRG9jdW1lbnRQYXJz ZXJMaWJ4bWwyLmNwcAorKysgYi9Tb3VyY2UvV2ViQ29yZS94bWwvcGFyc2VyL1hNTERvY3VtZW50 UGFyc2VyTGlieG1sMi5jcHAKQEAgLTcsNiArNyw3IEBACiAgKiBDb3B5cmlnaHQgKEMpIDIwMDgg SG9sZ2VyIEhhbnMgUGV0ZXIgRnJleXRoZXIKICAqIENvcHlyaWdodCAoQykgMjAwOCwgMjAwOSBU b3JjaCBNb2JpbGUgSW5jLiBBbGwgcmlnaHRzIHJlc2VydmVkLiAoaHR0cDovL3d3dy50b3JjaG1v YmlsZS5jb20vKQogICogQ29weXJpZ2h0IChDKSAyMDEwIFBhdHJpY2sgR2Fuc3RlcmVyIDxwYXJv Z2FAcGFyb2dhLmNvbT4KKyAqIENvcHlyaWdodCAoQykgMjAxMyBTYW1zdW5nIEVsZWN0cm9uaWNz LiBBbGwgcmlnaHRzIHJlc2VydmVkLgogICoKICAqIFRoaXMgbGlicmFyeSBpcyBmcmVlIHNvZnR3 YXJlOyB5b3UgY2FuIHJlZGlzdHJpYnV0ZSBpdCBhbmQvb3IKICAqIG1vZGlmeSBpdCB1bmRlciB0 aGUgdGVybXMgb2YgdGhlIEdOVSBMaWJyYXJ5IEdlbmVyYWwgUHVibGljCkBAIC00NCw2ICs0NSw3 IEBACiAjaW5jbHVkZSAiSFRNTE5hbWVzLmgiCiAjaW5jbHVkZSAiSFRNTFN0eWxlRWxlbWVudC5o IgogI2luY2x1ZGUgIkhUTUxUZW1wbGF0ZUVsZW1lbnQuaCIKKyNpbmNsdWRlICJQYWdlLmgiCiAj aW5jbHVkZSAiUHJvY2Vzc2luZ0luc3RydWN0aW9uLmgiCiAjaW5jbHVkZSAiUmVzb3VyY2VFcnJv ci5oIgogI2luY2x1ZGUgIlJlc291cmNlUmVxdWVzdC5oIgpAQCAtNTIsNiArNTQsNyBAQAogI2lu Y2x1ZGUgIlNjcmlwdFNvdXJjZUNvZGUuaCIKICNpbmNsdWRlICJTY3JpcHRWYWx1ZS5oIgogI2lu Y2x1ZGUgIlNlY3VyaXR5T3JpZ2luLmgiCisjaW5jbHVkZSAiU2V0dGluZ3MuaCIKICNpbmNsdWRl ICJUZXh0UmVzb3VyY2VEZWNvZGVyLmgiCiAjaW5jbHVkZSAiVHJhbnNmb3JtU291cmNlLmgiCiAj aW5jbHVkZSAiWE1MTlNOYW1lcy5oIgpAQCAtNzMsNiArNzYsMjMgQEAgdXNpbmcgbmFtZXNwYWNl IHN0ZDsKIAogbmFtZXNwYWNlIFdlYkNvcmUgewogCitzdGF0aWMgaW5saW5lIGJvb2wgaGFzTm9T dHlsZUluZm9ybWF0aW9uKERvY3VtZW50KiBkb2N1bWVudCkKK3sKKyAgICBpZiAoZG9jdW1lbnQt PnNhd0VsZW1lbnRzSW5Lbm93bk5hbWVzcGFjZXMoKSB8fCBkb2N1bWVudC0+dHJhbnNmb3JtU291 cmNlRG9jdW1lbnQoKSkKKyAgICAgICAgcmV0dXJuIGZhbHNlOworCisgICAgaWYgKCFkb2N1bWVu dC0+ZnJhbWUoKSB8fCAhZG9jdW1lbnQtPmZyYW1lKCktPnBhZ2UoKSkKKyAgICAgICAgcmV0dXJu IGZhbHNlOworCisgICAgaWYgKCFkb2N1bWVudC0+ZnJhbWUoKS0+cGFnZSgpLT5zZXR0aW5ncygp LT5kZXZlbG9wZXJFeHRyYXNFbmFibGVkKCkpCisgICAgICAgIHJldHVybiBmYWxzZTsKKworICAg IGlmIChkb2N1bWVudC0+ZnJhbWUoKS0+dHJlZSgpLT5wYXJlbnQoKSkKKyAgICAgICAgcmV0dXJu IGZhbHNlOyAvLyBUaGlzIGRvY3VtZW50IGlzIG5vdCBpbiBhIHRvcCBmcmFtZQorCisgICAgcmV0 dXJuIHRydWU7Cit9CisKIGNsYXNzIFBlbmRpbmdDYWxsYmFja3MgewogICAgIFdURl9NQUtFX05P TkNPUFlBQkxFKFBlbmRpbmdDYWxsYmFja3MpOyBXVEZfTUFLRV9GQVNUX0FMTE9DQVRFRDsKIHB1 YmxpYzoKQEAgLTEzNjQsMTIgKzEzODQsMTEgQEAgdm9pZCBYTUxEb2N1bWVudFBhcnNlcjo6ZG9F bmQoKQogICAgIH0KIAogI2lmIEVOQUJMRShYU0xUKQotICAgIFhNTFRyZWVWaWV3ZXIgeG1sVHJl ZVZpZXdlcihkb2N1bWVudCgpKTsKLSAgICBib29sIHhtbFZpZXdlck1vZGUgPSAhbV9zYXdFcnJv ciAmJiAhbV9zYXdDU1MgJiYgIW1fc2F3WFNMVHJhbnNmb3JtICYmIHhtbFRyZWVWaWV3ZXIuaGFz Tm9TdHlsZUluZm9ybWF0aW9uKCk7Ci0gICAgaWYgKHhtbFZpZXdlck1vZGUpCisgICAgYm9vbCB4 bWxWaWV3ZXJNb2RlID0gIW1fc2F3RXJyb3IgJiYgIW1fc2F3Q1NTICYmICFtX3Nhd1hTTFRyYW5z Zm9ybSAmJiBoYXNOb1N0eWxlSW5mb3JtYXRpb24oZG9jdW1lbnQoKSk7CisgICAgaWYgKHhtbFZp ZXdlck1vZGUpIHsKKyAgICAgICAgWE1MVHJlZVZpZXdlciB4bWxUcmVlVmlld2VyKGRvY3VtZW50 KCkpOwogICAgICAgICB4bWxUcmVlVmlld2VyLnRyYW5zZm9ybURvY3VtZW50VG9UcmVlVmlldygp OwotCi0gICAgaWYgKG1fc2F3WFNMVHJhbnNmb3JtKSB7CisgICAgfSBlbHNlIGlmIChtX3Nhd1hT TFRyYW5zZm9ybSkgewogICAgICAgICB2b2lkKiBkb2MgPSB4bWxEb2NQdHJGb3JTdHJpbmcoZG9j dW1lbnQoKS0+Y2FjaGVkUmVzb3VyY2VMb2FkZXIoKSwgbV9vcmlnaW5hbFNvdXJjZUZvclRyYW5z Zm9ybS50b1N0cmluZygpLCBkb2N1bWVudCgpLT51cmwoKS5zdHJpbmcoKSk7CiAgICAgICAgIGRv Y3VtZW50KCktPnNldFRyYW5zZm9ybVNvdXJjZShhZG9wdFB0cihuZXcgVHJhbnNmb3JtU291cmNl KGRvYykpKTsKIAo=