119462 2013-08-02 16:10:06 -0700 Force elements with perspective or preserve-3d to disallow direct composited backgrounds 2013-08-02 17:07:20 -0700 1 1 1 Unclassified WebKit Layout and Rendering 528+ (Nightly build) Unspecified Unspecified RESOLVED FIXED P2 Normal --- 1 dino dino commit-queue esprehn+autocc glenn kondapallykalyan noam simon.fraser oldest_to_newest 914316 0 dino 2013-08-02 16:10:06 -0700 As a stop-gap measure to address Bug 119461, make sure elements that have a perspective or preserve-3d don't allow directly composited backgrounds. 914317 1 208053 dino 2013-08-02 16:13:19 -0700 Created attachment 208053 Patch 914320 2 dino 2013-08-02 16:15:37 -0700 <rdar://problem/14607548> 914321 3 208053 simon.fraser 2013-08-02 16:25:25 -0700 Comment on attachment 208053 Patch View in context: https://bugs.webkit.org/attachment.cgi?id=208053&action=review > Source/WebCore/rendering/RenderLayerBacking.cpp:1518 > + if (hasPerspectiveOrPreserves3D(renderer->style())) > + return false; I think we need to do the same thing for simple image layers; they should show the same bug. 914322 4 dino 2013-08-02 16:32:38 -0700 (In reply to comment #3) > (From update of attachment 208053 [details]) > View in context: https://bugs.webkit.org/attachment.cgi?id=208053&action=review > > > Source/WebCore/rendering/RenderLayerBacking.cpp:1518 > > + if (hasPerspectiveOrPreserves3D(renderer->style())) > > + return false; > > I think we need to do the same thing for simple image layers; they should show the same bug. Simple image layers can't have children, so nothing to intersect with. 914323 5 208053 simon.fraser 2013-08-02 16:36:07 -0700 Comment on attachment 208053 Patch View in context: https://bugs.webkit.org/attachment.cgi?id=208053&action=review >>> Source/WebCore/rendering/RenderLayerBacking.cpp:1518 >>> + return false; >> >> I think we need to do the same thing for simple image layers; they should show the same bug. > > Simple image layers can't have children, so nothing to intersect with. True dat! > LayoutTests/compositing/background-color/no-composited-background-color-when-perspective-expected.html:16 > + background-image: url("data:image/png;base64,iVBORw0KGgoAAAANSUhEUgAAAAUAAAAFCAMAAAC6sdbXAAAAGXRFWHRTb2Z0d2FyZQBBZG9iZSBJbWFnZVJlYWR5ccllPAAAAAZQTFRFAAAA////pdmf3QAAAA5JREFUeNpiYMAHAAIMAAAeAAHMILKLAAAAAElFTkSuQmCC"); This might fall into a future background-image optimization. Maybe better to use border: 5px solid black and box-sizing: foo. 914324 6 208053 dino 2013-08-02 16:39:56 -0700 Comment on attachment 208053 Patch View in context: https://bugs.webkit.org/attachment.cgi?id=208053&action=review >> LayoutTests/compositing/background-color/no-composited-background-color-when-perspective-expected.html:16 >> + background-image: url("data:image/png;base64,iVBORw0KGgoAAAANSUhEUgAAAAUAAAAFCAMAAAC6sdbXAAAAGXRFWHRTb2Z0d2FyZQBBZG9iZSBJbWFnZVJlYWR5ccllPAAAAAZQTFRFAAAA////pdmf3QAAAA5JREFUeNpiYMAHAAIMAAAeAAHMILKLAAAAAElFTkSuQmCC"); > > This might fall into a future background-image optimization. Maybe better to use border: 5px solid black and box-sizing: foo. Yeah, but unfortunately that slightly changes either the perspective origin or the transform origin. I'm not sure why this is - sounds like a bug! 914330 7 dino 2013-08-02 17:07:20 -0700 Committed r153681: <http://trac.webkit.org/changeset/153681> 208053 2013-08-02 16:13:19 -0700 2013-08-02 16:39:56 -0700 Patch bug-119462-20130803091317.patch text/plain 5744 dino U3VidmVyc2lvbiBSZXZpc2lvbjogMTUzNjI4CmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViQ29yZS9D aGFuZ2VMb2cgYi9Tb3VyY2UvV2ViQ29yZS9DaGFuZ2VMb2cKaW5kZXggMzhjNjYwZThiNGNmYmY2 YzNiM2EzZGFmMTNkNjJiOWQ0NzExMTMxNi4uNDdjNWM3ZTViNjQ4NDg1N2EwOGQxMDlkNGM5ODQ0 ODVhN2MyM2NlZCAxMDA2NDQKLS0tIGEvU291cmNlL1dlYkNvcmUvQ2hhbmdlTG9nCisrKyBiL1Nv dXJjZS9XZWJDb3JlL0NoYW5nZUxvZwpAQCAtMSwzICsxLDIyIEBACisyMDEzLTA4LTAyICBEZWFu IEphY2tzb24gIDxkaW5vQGFwcGxlLmNvbT4KKworICAgICAgICBGb3JjZSBlbGVtZW50cyB3aXRo IHBlcnNwZWN0aXZlIG9yIHByZXNlcnZlLTNkIHRvIGRpc2FsbG93IGRpcmVjdCBjb21wb3NpdGVk IGJhY2tncm91bmRzCisgICAgICAgIGh0dHBzOi8vYnVncy53ZWJraXQub3JnL3Nob3dfYnVnLmNn aT9pZD0xMTk0NjIKKworICAgICAgICBSZXZpZXdlZCBieSBOT0JPRFkgKE9PUFMhKS4KKworICAg ICAgICBCdWcgMTE5NDYxIChodHRwOi8vd2tiLnVnLzExOTQ2MSkgZGVzY3JpYmVzIGhvdyBhIGRp cmVjdGx5IGNvbXBvc2l0ZWQKKyAgICAgICAgYmFja2dyb3VuZCBjb2xvciBjYW4gaW50ZXJzZWN0 IHdpdGggaXRzIGNoaWxkcmVuLiBJdCdzIG5vdCBjbGVhciBleGFjdGx5CisgICAgICAgIHdoYXQg dGhlIGJlc3Qgd2F5IHRvIGZpeCB0aGF0IGlzLCBidXQgZm9yIHRoZSBtb21lbnQgd2Ugc2hvdWxk IGRpc2FsbG93CisgICAgICAgIGFueSBlbGVtZW50IHRoYXQgaGFzIHBlcnNwZWN0aXZlIG9yIGEg cHJlc2VydmUtM2QgdHJhbnNmb3JtIHN0eWxlIGZyb20KKyAgICAgICAgZ2V0dGluZyBhIGRpcmVj dGx5IGNvbXBvc2l0ZWQgYmFja2dyb3VuZC4KKworICAgICAgICBUZXN0OiBjb21wb3NpdGluZy9i YWNrZ3JvdW5kLWNvbG9yL25vLWNvbXBvc2l0ZWQtYmFja2dyb3VuZC1jb2xvci13aGVuLXBlcnNw ZWN0aXZlLmh0bWwKKworICAgICAgICAqIHJlbmRlcmluZy9SZW5kZXJMYXllckJhY2tpbmcuY3Bw OgorICAgICAgICAoV2ViQ29yZTo6aGFzUGVyc3BlY3RpdmVPclByZXNlcnZlczNEKTogTmV3IHN0 YXRpYyBoZWxwZXIuCisgICAgICAgIChXZWJDb3JlOjpzdXBwb3J0c0RpcmVjdEJveERlY29yYXRp b25zQ29tcG9zaXRpb24pOiBSZXR1cm4gZmFsc2UgaWYgdGhlIGFib3ZlIGZ1bmN0aW9uIGlzIHRy dWUuCisKIDIwMTMtMDgtMDEgIEJyZW50IEZ1bGdoYW0gIDxiZnVsZ2hhbUBhcHBsZS5jb20+CiAK ICAgICAgICAgW1dpbmRvd3NdIFdlYktpdDEgRnVsbHNjcmVlbiBWaWRlbyBQbGF5IGlzIEJyb2tl bgpkaWZmIC0tZ2l0IGEvU291cmNlL1dlYkNvcmUvcmVuZGVyaW5nL1JlbmRlckxheWVyQmFja2lu Zy5jcHAgYi9Tb3VyY2UvV2ViQ29yZS9yZW5kZXJpbmcvUmVuZGVyTGF5ZXJCYWNraW5nLmNwcApp bmRleCBjMzkyZjVmM2ZhMDczOTRkNDMzMzE1MTQwODIzMzAyNGQ1M2FhMGJiLi5jOTUxNTNhMGY0 OTg5OWEzY2EyNTZjNjUyOGJkMDhmMWU5YmIyOTYwIDEwMDY0NAotLS0gYS9Tb3VyY2UvV2ViQ29y ZS9yZW5kZXJpbmcvUmVuZGVyTGF5ZXJCYWNraW5nLmNwcAorKysgYi9Tb3VyY2UvV2ViQ29yZS9y ZW5kZXJpbmcvUmVuZGVyTGF5ZXJCYWNraW5nLmNwcApAQCAtMTM4OSw2ICsxMzg5LDExIEBAIHN0 YXRpYyBib29sIGhhc0JveERlY29yYXRpb25zT3JCYWNrZ3JvdW5kSW1hZ2UoY29uc3QgUmVuZGVy U3R5bGUqIHN0eWxlKQogICAgIHJldHVybiAhR3JhcGhpY3NMYXllcjo6c3VwcG9ydHNDb250ZW50 c1RpbGluZygpIHx8ICFjYW5DcmVhdGVUaWxlZEltYWdlKHN0eWxlKTsKIH0KIAorc3RhdGljIGJv b2wgaGFzUGVyc3BlY3RpdmVPclByZXNlcnZlczNEKGNvbnN0IFJlbmRlclN0eWxlKiBzdHlsZSkK K3sKKyAgICByZXR1cm4gc3R5bGUtPmhhc1BlcnNwZWN0aXZlKCkgfHwgc3R5bGUtPnByZXNlcnZl czNEKCk7Cit9CisKIENvbG9yIFJlbmRlckxheWVyQmFja2luZzo6cmVuZGVyZXJCYWNrZ3JvdW5k Q29sb3IoKSBjb25zdAogewogICAgIFJlbmRlck9iamVjdCogYmFja2dyb3VuZFJlbmRlcmVyID0g cmVuZGVyZXIoKTsKQEAgLTE1MDQsNiArMTUwOSwxNCBAQCBzdGF0aWMgYm9vbCBzdXBwb3J0c0Rp cmVjdEJveERlY29yYXRpb25zQ29tcG9zaXRpb24oY29uc3QgUmVuZGVyT2JqZWN0KiByZW5kZXJl cgogICAgIGlmIChoYXNCb3hEZWNvcmF0aW9uc09yQmFja2dyb3VuZEltYWdlKHJlbmRlcmVyLT5z dHlsZSgpKSkKICAgICAgICAgcmV0dXJuIGZhbHNlOwogCisgICAgLy8gRklYTUU6IFdlIGNhbid0 IGNyZWF0ZSBhIGRpcmVjdGx5IGNvbXBvc2l0ZWQgYmFja2dyb3VuZCBpZiB0aGlzCisgICAgLy8g bGF5ZXIgd2lsbCBoYXZlIGNoaWxkcmVuIHRoYXQgaW50ZXJzZWN0IHdpdGggdGhlIGJhY2tncm91 bmQgbGF5ZXIuCisgICAgLy8gQSBiZXR0ZXIgc29sdXRpb24gbWlnaHQgYmUgdG8gaW50cm9kdWNl IGEgZmxhdHRlbmluZyBsYXllciBpZgorICAgIC8vIHdlIGRvIGRpcmVjdCBib3ggZGVjb3JhdGlv biBjb21wb3NpdGlvbi4KKyAgICAvLyBodHRwczovL2J1Z3Mud2Via2l0Lm9yZy9zaG93X2J1Zy5j Z2k/aWQ9MTE5NDYxCisgICAgaWYgKGhhc1BlcnNwZWN0aXZlT3JQcmVzZXJ2ZXMzRChyZW5kZXJl ci0+c3R5bGUoKSkpCisgICAgICAgIHJldHVybiBmYWxzZTsKKwogICAgIC8vIEZJWE1FOiB3ZSBz aG91bGQgYmUgYWJsZSB0byBhbGxvdyBiYWNrZ3JvdW5kQ29tcG9zaXRlOyBIb3dldmVyIHNpbmNl IHRoaXMgaXMgbm90IGEgY29tbW9uIHVzZSBjYXNlIGl0IGhhcyBiZWVuIGRlZmVycmVkIGZvciBu b3cuCiAgICAgaWYgKHJlbmRlcmVyLT5zdHlsZSgpLT5iYWNrZ3JvdW5kQ29tcG9zaXRlKCkgIT0g Q29tcG9zaXRlU291cmNlT3ZlcikKICAgICAgICAgcmV0dXJuIGZhbHNlOwpkaWZmIC0tZ2l0IGEv TGF5b3V0VGVzdHMvQ2hhbmdlTG9nIGIvTGF5b3V0VGVzdHMvQ2hhbmdlTG9nCmluZGV4IDFmYjM1 MDhmYzVlMDYzNTk3ODRjYjQ4NmMyN2E3Y2E0NmRhYjAzZGMuLjdhNzk2NTlkZThmNTNmNzk0NTI1 YzdhZTEwOTMxMmM5ZjViOTRjZjIgMTAwNjQ0Ci0tLSBhL0xheW91dFRlc3RzL0NoYW5nZUxvZwor KysgYi9MYXlvdXRUZXN0cy9DaGFuZ2VMb2cKQEAgLTEsMyArMSwxMyBAQAorMjAxMy0wOC0wMiAg RGVhbiBKYWNrc29uICA8ZGlub0BhcHBsZS5jb20+CisKKyAgICAgICAgRm9yY2UgZWxlbWVudHMg d2l0aCBwZXJzcGVjdGl2ZSBvciBwcmVzZXJ2ZS0zZCB0byBkaXNhbGxvdyBkaXJlY3QgY29tcG9z aXRlZCBiYWNrZ3JvdW5kcworICAgICAgICBodHRwczovL2J1Z3Mud2Via2l0Lm9yZy9zaG93X2J1 Zy5jZ2k/aWQ9MTE5NDYyCisKKyAgICAgICAgUmV2aWV3ZWQgYnkgTk9CT0RZIChPT1BTISkuCisK KyAgICAgICAgKiBjb21wb3NpdGluZy9iYWNrZ3JvdW5kLWNvbG9yL25vLWNvbXBvc2l0ZWQtYmFj a2dyb3VuZC1jb2xvci13aGVuLXBlcnNwZWN0aXZlLWV4cGVjdGVkLmh0bWw6IEFkZGVkLgorICAg ICAgICAqIGNvbXBvc2l0aW5nL2JhY2tncm91bmQtY29sb3Ivbm8tY29tcG9zaXRlZC1iYWNrZ3Jv dW5kLWNvbG9yLXdoZW4tcGVyc3BlY3RpdmUuaHRtbDogQWRkZWQuCisKIDIwMTMtMDgtMDEgIERl YW4gSmFja3NvbiAgPGRpbm9AYXBwbGUuY29tPgogCiAgICAgICAgIHNyY3NldCBhbGdvcml0aG0g YnJlYWtzIGJhc2U2NCBzcmMgYXR0cmlidXRlcwpkaWZmIC0tZ2l0IGEvTGF5b3V0VGVzdHMvY29t cG9zaXRpbmcvYmFja2dyb3VuZC1jb2xvci9uby1jb21wb3NpdGVkLWJhY2tncm91bmQtY29sb3It d2hlbi1wZXJzcGVjdGl2ZS1leHBlY3RlZC5odG1sIGIvTGF5b3V0VGVzdHMvY29tcG9zaXRpbmcv YmFja2dyb3VuZC1jb2xvci9uby1jb21wb3NpdGVkLWJhY2tncm91bmQtY29sb3Itd2hlbi1wZXJz cGVjdGl2ZS1leHBlY3RlZC5odG1sCm5ldyBmaWxlIG1vZGUgMTAwNjQ0CmluZGV4IDAwMDAwMDAw MDAwMDAwMDAwMDAwMDAwMDAwMDAwMDAwMDAwMDAwMDAuLjNjODhjZTQwZTEwMzFhNDdhNTgyOWMz Nzg0N2I5MTY4YzYxZGMxNTcKLS0tIC9kZXYvbnVsbAorKysgYi9MYXlvdXRUZXN0cy9jb21wb3Np dGluZy9iYWNrZ3JvdW5kLWNvbG9yL25vLWNvbXBvc2l0ZWQtYmFja2dyb3VuZC1jb2xvci13aGVu LXBlcnNwZWN0aXZlLWV4cGVjdGVkLmh0bWwKQEAgLTAsMCArMSwyNyBAQAorPG1ldGEgbmFtZT0i dmlld3BvcnQiIGNvbnRlbnQ9IndpZHRoPWRldmljZS13aWR0aCxpbml0aWFsLXNjYWxlPTEsdXNl ci1zY2FsYWJsZT1ubyI+Cis8c3R5bGU+Citib2R5IHsKKyAgICBtYXJnaW46IDA7Cit9CisKK2Rp diB7CisgICAgcG9zaXRpb246IGFic29sdXRlOworICAgIGhlaWdodDogMjAwcHg7CisgICAgd2lk dGg6IDIwMHB4OworfQorCisjY29udGFpbmVyIHsKKyAgICAvKiBGb3JjZSBib3ggZGVjb3JhdGlv bnMgc28gbm8gZGlyZWN0IGNvbXBvc2l0ZWQgYmFja2dyb3VuZCAqLworICAgIC8qIFRoaXMgaXMg anVzdCBhIGJsYWNrIGltYWdlICovCisgICAgYmFja2dyb3VuZC1pbWFnZTogdXJsKCJkYXRhOmlt YWdlL3BuZztiYXNlNjQsaVZCT1J3MEtHZ29BQUFBTlNVaEVVZ0FBQUFVQUFBQUZDQU1BQUFDNnNk YlhBQUFBR1hSRldIUlRiMlowZDJGeVpRQkJaRzlpWlNCSmJXRm5aVkpsWVdSNWNjbGxQQUFBQUFa UVRGUkZBQUFBLy8vL3BkbWYzUUFBQUE1SlJFRlVlTnBpWU1BSEFBSU1BQUFlQUFITUlMS0xBQUFB QUVsRlRrU3VRbUNDIik7CisgICAgLXdlYmtpdC1wZXJzcGVjdGl2ZTogNDAwOworfQorCisjZmFj ZSB7CisgICAgLXdlYmtpdC10cmFuc2Zvcm06IHJvdGF0ZVgoNDVkZWcpOworICAgIGJhY2tncm91 bmQtY29sb3I6IHJlZDsKK30KKzwvc3R5bGU+Cis8ZGl2IGlkPSJjb250YWluZXIiPgorICAgIDxk aXYgaWQ9ImZhY2UiPjwvZGl2PgorPC9kaXY+CmRpZmYgLS1naXQgYS9MYXlvdXRUZXN0cy9jb21w b3NpdGluZy9iYWNrZ3JvdW5kLWNvbG9yL25vLWNvbXBvc2l0ZWQtYmFja2dyb3VuZC1jb2xvci13 aGVuLXBlcnNwZWN0aXZlLmh0bWwgYi9MYXlvdXRUZXN0cy9jb21wb3NpdGluZy9iYWNrZ3JvdW5k LWNvbG9yL25vLWNvbXBvc2l0ZWQtYmFja2dyb3VuZC1jb2xvci13aGVuLXBlcnNwZWN0aXZlLmh0 bWwKbmV3IGZpbGUgbW9kZSAxMDA2NDQKaW5kZXggMDAwMDAwMDAwMDAwMDAwMDAwMDAwMDAwMDAw MDAwMDAwMDAwMDAwMC4uZWZjMTk2ZTQ1YjEyNDc3NWViZjQ3ZjliM2U3OTQyMGQ1NGM4OTNmOAot LS0gL2Rldi9udWxsCisrKyBiL0xheW91dFRlc3RzL2NvbXBvc2l0aW5nL2JhY2tncm91bmQtY29s b3Ivbm8tY29tcG9zaXRlZC1iYWNrZ3JvdW5kLWNvbG9yLXdoZW4tcGVyc3BlY3RpdmUuaHRtbApA QCAtMCwwICsxLDI1IEBACis8bWV0YSBuYW1lPSJ2aWV3cG9ydCIgY29udGVudD0id2lkdGg9ZGV2 aWNlLXdpZHRoLGluaXRpYWwtc2NhbGU9MSx1c2VyLXNjYWxhYmxlPW5vIj4KKzxzdHlsZT4KK2Jv ZHkgeworICAgIG1hcmdpbjogMDsKK30KKworZGl2IHsKKyAgICBwb3NpdGlvbjogYWJzb2x1dGU7 CisgICAgaGVpZ2h0OiAyMDBweDsKKyAgICB3aWR0aDogMjAwcHg7Cit9CisKKyNjb250YWluZXIg eworICAgIGJhY2tncm91bmQtY29sb3I6IGJsYWNrOworICAgIC13ZWJraXQtcGVyc3BlY3RpdmU6 IDQwMDsKK30KKworI2ZhY2UgeworICAgIC13ZWJraXQtdHJhbnNmb3JtOiByb3RhdGVYKDQ1ZGVn KTsKKyAgICBiYWNrZ3JvdW5kLWNvbG9yOiByZWQ7Cit9Cis8L3N0eWxlPgorPGRpdiBpZD0iY29u dGFpbmVyIj4KKyAgICA8ZGl2IGlkPSJmYWNlIj48L2Rpdj4KKzwvZGl2Pgo=