119455 2013-08-02 13:00:58 -0700 [Forms: color] The positioning of the popover color well is inverted 2013-08-02 14:26:17 -0700 1 1 1 Unclassified WebKit Forms 528+ (Nightly build) Unspecified Unspecified RESOLVED FIXED InRadar P2 Normal --- 0 ruthiecftg webkit-unassigned bdakin beidson commit-queue dino jonlee ruthiecftg webkit-bug-importer oldest_to_newest 914243 0 ruthiecftg 2013-08-02 13:00:58 -0700 The IntRect object passed to WebColorPickerMac assumes that the origin is at the top-left of the screen, while by default NSRect assumes that the origin is at bottom-left of the screen. The needed change will be in WKColorPopoverMac::initWithFrame: inView:. 914244 1 webkit-bug-importer 2013-08-02 13:02:07 -0700 <rdar://problem/14635621> 914251 2 208039 ruthiecftg 2013-08-02 13:25:54 -0700 Created attachment 208039 Patch 914252 3 208039 thorton 2013-08-02 13:27:56 -0700 Comment on attachment 208039 Patch View in context: https://bugs.webkit.org/attachment.cgi?id=208039&action=review > Source/WebKit2/ChangeLog:12 > + (-[WKColorPopoverMac initWithFrame:WebCore::inView:]): Looks like the change log thing did something crazy here. Please take the random WebCore namespace out. 914253 4 208040 ruthiecftg 2013-08-02 13:31:32 -0700 Created attachment 208040 Patch 914254 5 208040 commit-queue 2013-08-02 13:34:23 -0700 Comment on attachment 208040 Patch Rejecting attachment 208040 from review queue. ruthiecftg@gmail.com does not have reviewer permissions according to http://trac.webkit.org/browser/trunk/Tools/Scripts/webkitpy/common/config/contributors.json. - If you do not have reviewer rights please read http://webkit.org/coding/contributing.html for instructions on how to use bugzilla flags. - If you have reviewer rights please correct the error in Tools/Scripts/webkitpy/common/config/contributors.json by adding yourself to the file (no review needed). The commit-queue restarts itself every 2 hours. After restart the commit-queue will correctly respect your reviewer rights. 914275 6 208040 commit-queue 2013-08-02 14:26:15 -0700 Comment on attachment 208040 Patch Clearing flags on attachment: 208040 Committed r153667: <http://trac.webkit.org/changeset/153667> 914276 7 commit-queue 2013-08-02 14:26:17 -0700 All reviewed patches have been landed. Closing bug. 208039 2013-08-02 13:25:54 -0700 2013-08-02 13:31:29 -0700 Patch bug-119455-20130802132554.patch text/plain 1486 ruthiecftg SW5kZXg6IFNvdXJjZS9XZWJLaXQyL0NoYW5nZUxvZwo9PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09Ci0tLSBTb3VyY2UvV2Vi S2l0Mi9DaGFuZ2VMb2cJKHJldmlzaW9uIDE1MzY2NCkKKysrIFNvdXJjZS9XZWJLaXQyL0NoYW5n ZUxvZwkod29ya2luZyBjb3B5KQpAQCAtMSwzICsxLDE2IEBACisyMDEzLTA4LTAyICBSdXRoIEZv bmcgIDxydXRoX2ZvbmdAYXBwbGUuY29tPgorCisgICAgICAgIFtGb3JtczogY29sb3JdIFRoZSBw b3NpdGlvbmluZyBvZiB0aGUgcG9wb3ZlciBjb2xvciB3ZWxsIGlzIGludmVydGVkCisgICAgICAg IDxyZGFyOi8vcHJvYmxlbS8xNDYzNTYyMT4gYW5kIGh0dHBzOi8vYnVncy53ZWJraXQub3JnL3No b3dfYnVnLmNnaT9pZD0xMTk0NTUKKworICAgICAgICBSZXZpZXdlZCBieSBOT0JPRFkgKE9PUFMh KS4KKworICAgICAgICBUaGlzIHBhdGNoIGNvbnZlcnRzIHRoZSBjb29yZGluYXRlcyBvZiB0aGUg PGlucHV0IHR5cGU9J2NvbG9yJz4gZWxlbWVudCB0bworICAgICAgICB0aGUgd2luZG93J3MgYmFz ZSBjb29yZGluYXRlIHN5c3RlbS4KKworICAgICAgICAqIFVJUHJvY2Vzcy9tYWMvV2ViQ29sb3JQ aWNrZXJNYWMubW06CisgICAgICAgICgtW1dLQ29sb3JQb3BvdmVyTWFjIGluaXRXaXRoRnJhbWU6 V2ViQ29yZTo6aW5WaWV3Ol0pOgorCiAyMDEzLTA4LTAxICBSdXRoIEZvbmcgIDxydXRoX2ZvbmdA YXBwbGUuY29tPgogCiAgICAgICAgIFtGb3JtczogY29sb3JdIDxpbnB1dCB0eXBlPSdjb2xvcic+ IHBvcG92ZXIgY29sb3Igd2VsbCBpbXBsZW1lbnRhdGlvbgpJbmRleDogU291cmNlL1dlYktpdDIv VUlQcm9jZXNzL21hYy9XZWJDb2xvclBpY2tlck1hYy5tbQo9PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09Ci0tLSBTb3VyY2Uv V2ViS2l0Mi9VSVByb2Nlc3MvbWFjL1dlYkNvbG9yUGlja2VyTWFjLm1tCShyZXZpc2lvbiAxNTM2 NjQpCisrKyBTb3VyY2UvV2ViS2l0Mi9VSVByb2Nlc3MvbWFjL1dlYkNvbG9yUGlja2VyTWFjLm1t CSh3b3JraW5nIGNvcHkpCkBAIC0xNDUsNyArMTQ1LDcgQEAgLSAoaWQpaW5pdFdpdGhGcmFtZToo Y29uc3QgV2ViQ29yZTo6SW50UgogICAgIGlmKCEoc2VsZiA9IFtzdXBlciBpbml0XSkpCiAgICAg ICAgIHJldHVybiBzZWxmOwogCi0gICAgX3BvcG92ZXJXZWxsID0gYWRvcHROUyhbW05TUG9wb3Zl ckNvbG9yV2VsbCBhbGxvY10gaW5pdFdpdGhGcmFtZTpOU1JlY3RGcm9tQ0dSZWN0KHJlY3QpXSk7 CisgICAgX3BvcG92ZXJXZWxsID0gYWRvcHROUyhbW05TUG9wb3ZlckNvbG9yV2VsbCBhbGxvY10g aW5pdFdpdGhGcmFtZTpbdmlldyBjb252ZXJ0UmVjdDpOU1JlY3RGcm9tQ0dSZWN0KHJlY3QpIHRv VmlldzpuaWxdXSk7CiAgICAgaWYgKCFfcG9wb3ZlcldlbGwpCiAgICAgICAgIHJldHVybiBzZWxm OwogCg== 208040 2013-08-02 13:31:32 -0700 2013-08-02 14:26:15 -0700 Patch bug-119455-20130802133131.patch text/plain 1477 ruthiecftg SW5kZXg6IFNvdXJjZS9XZWJLaXQyL0NoYW5nZUxvZwo9PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09Ci0tLSBTb3VyY2UvV2Vi S2l0Mi9DaGFuZ2VMb2cJKHJldmlzaW9uIDE1MzY2NCkKKysrIFNvdXJjZS9XZWJLaXQyL0NoYW5n ZUxvZwkod29ya2luZyBjb3B5KQpAQCAtMSwzICsxLDE2IEBACisyMDEzLTA4LTAyICBSdXRoIEZv bmcgIDxydXRoX2ZvbmdAYXBwbGUuY29tPgorCisgICAgICAgIFtGb3JtczogY29sb3JdIFRoZSBw b3NpdGlvbmluZyBvZiB0aGUgcG9wb3ZlciBjb2xvciB3ZWxsIGlzIGludmVydGVkCisgICAgICAg IDxyZGFyOi8vcHJvYmxlbS8xNDYzNTYyMT4gYW5kIGh0dHBzOi8vYnVncy53ZWJraXQub3JnL3No b3dfYnVnLmNnaT9pZD0xMTk0NTUKKworICAgICAgICBSZXZpZXdlZCBieSBOT0JPRFkgKE9PUFMh KS4KKworICAgICAgICBUaGlzIHBhdGNoIGNvbnZlcnRzIHRoZSBjb29yZGluYXRlcyBvZiB0aGUg PGlucHV0IHR5cGU9J2NvbG9yJz4gZWxlbWVudCB0bworICAgICAgICB0aGUgd2luZG93J3MgYmFz ZSBjb29yZGluYXRlIHN5c3RlbS4KKworICAgICAgICAqIFVJUHJvY2Vzcy9tYWMvV2ViQ29sb3JQ aWNrZXJNYWMubW06CisgICAgICAgICgtW1dLQ29sb3JQb3BvdmVyTWFjIGluaXRXaXRoRnJhbWU6 aW5WaWV3Ol0pOgorCiAyMDEzLTA4LTAxICBSdXRoIEZvbmcgIDxydXRoX2ZvbmdAYXBwbGUuY29t PgogCiAgICAgICAgIFtGb3JtczogY29sb3JdIDxpbnB1dCB0eXBlPSdjb2xvcic+IHBvcG92ZXIg Y29sb3Igd2VsbCBpbXBsZW1lbnRhdGlvbgpJbmRleDogU291cmNlL1dlYktpdDIvVUlQcm9jZXNz L21hYy9XZWJDb2xvclBpY2tlck1hYy5tbQo9PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09Ci0tLSBTb3VyY2UvV2ViS2l0Mi9V SVByb2Nlc3MvbWFjL1dlYkNvbG9yUGlja2VyTWFjLm1tCShyZXZpc2lvbiAxNTM2NjQpCisrKyBT b3VyY2UvV2ViS2l0Mi9VSVByb2Nlc3MvbWFjL1dlYkNvbG9yUGlja2VyTWFjLm1tCSh3b3JraW5n IGNvcHkpCkBAIC0xNDUsNyArMTQ1LDcgQEAgLSAoaWQpaW5pdFdpdGhGcmFtZTooY29uc3QgV2Vi Q29yZTo6SW50UgogICAgIGlmKCEoc2VsZiA9IFtzdXBlciBpbml0XSkpCiAgICAgICAgIHJldHVy biBzZWxmOwogCi0gICAgX3BvcG92ZXJXZWxsID0gYWRvcHROUyhbW05TUG9wb3ZlckNvbG9yV2Vs bCBhbGxvY10gaW5pdFdpdGhGcmFtZTpOU1JlY3RGcm9tQ0dSZWN0KHJlY3QpXSk7CisgICAgX3Bv cG92ZXJXZWxsID0gYWRvcHROUyhbW05TUG9wb3ZlckNvbG9yV2VsbCBhbGxvY10gaW5pdFdpdGhG cmFtZTpbdmlldyBjb252ZXJ0UmVjdDpOU1JlY3RGcm9tQ0dSZWN0KHJlY3QpIHRvVmlldzpuaWxd XSk7CiAgICAgaWYgKCFfcG9wb3ZlcldlbGwpCiAgICAgICAgIHJldHVybiBzZWxmOwogCg==