119444 2013-08-02 06:54:43 -0700 Buildfix for !ENABLE(SVG) platforms after r153581 2013-08-02 08:39:50 -0700 1 1 1 Unclassified WebKit WebCore Misc. 528+ (Nightly build) Unspecified Unspecified RESOLVED FIXED P2 Normal --- 117715 1 zarvai webkit-unassigned allan.jensen commit-queue esprehn+autocc glenn kling macpherson menard ossy oldest_to_newest 914119 0 zarvai 2013-08-02 06:54:43 -0700 Patch is coming soon. /ramdisk/qt-linux-release-minimal/build/Source/WebCore/css/StylePropertyShorthand.cpp: In function ‘const WebCore::StylePropertyShorthand& WebCore::markerShorthand()’: /ramdisk/qt-linux-release-minimal/build/Source/WebCore/css/StylePropertyShorthand.cpp:236:9: error: ‘CSSPropertyMarkerStart’ was not declared in this scope /ramdisk/qt-linux-release-minimal/build/Source/WebCore/css/StylePropertyShorthand.cpp:237:9: error: ‘CSSPropertyMarkerMid’ was not declared in this scope /ramdisk/qt-linux-release-minimal/build/Source/WebCore/css/StylePropertyShorthand.cpp:238:9: error: ‘CSSPropertyMarkerEnd’ was not declared in this scope /ramdisk/qt-linux-release-minimal/build/Source/WebCore/css/StylePropertyShorthand.cpp:240:5: error: ‘CSSPropertyMarker’ was not declared in this scope /ramdisk/qt-linux-release-minimal/build/Source/WebCore/css/StylePropertyShorthand.cpp: In function ‘const WTF::Vector<const WebCore::StylePropertyShorthand*> WebCore::matchingShorthandsForLonghand(WebCore::CSSPropertyID)’: /ramdisk/qt-linux-release-minimal/build/Source/WebCore/css/StylePropertyShorthand.cpp:769:17: error: ‘CSSPropertyMarkerStart’ was not declared in this scope /ramdisk/qt-linux-release-minimal/build/Source/WebCore/css/StylePropertyShorthand.cpp:770:17: error: ‘CSSPropertyMarkerMid’ was not declared in this scope /ramdisk/qt-linux-release-minimal/build/Source/WebCore/css/StylePropertyShorthand.cpp:771:17: error: ‘CSSPropertyMarkerEnd’ was not declared in this scope These are generated from SVGCSSPropertyNames.in that guarded by ENABLE_SVG. 914122 1 208012 zarvai 2013-08-02 06:57:55 -0700 Created attachment 208012 buildfix Adding guards for SVG related parts. 914123 2 208012 kling 2013-08-02 06:59:02 -0700 Comment on attachment 208012 buildfix View in context: https://bugs.webkit.org/attachment.cgi?id=208012&action=review r=me > Source/WebCore/css/StylePropertyShorthand.cpp:233 > +#if defined(ENABLE_SVG) && ENABLE_SVG This should just be #if ENABLE(SVG) > Source/WebCore/css/StylePropertyShorthand.cpp:769 > +#if defined(ENABLE_SVG) && ENABLE_SVG Ditto. > Source/WebCore/css/StylePropertyShorthand.h:88 > +#if defined(ENABLE_SVG) && ENABLE_SVG Ditto. 914130 3 208017 zarvai 2013-08-02 07:15:15 -0700 Created attachment 208017 buildfix Buildfix with corrected guards. 914160 4 208017 commit-queue 2013-08-02 08:39:46 -0700 Comment on attachment 208017 buildfix Clearing flags on attachment: 208017 Committed r153650: <http://trac.webkit.org/changeset/153650> 914161 5 commit-queue 2013-08-02 08:39:50 -0700 All reviewed patches have been landed. Closing bug. 208012 2013-08-02 06:57:55 -0700 2013-08-02 07:15:15 -0700 buildfix webcore-css-fix.patch text/plain 2774 zarvai ZGlmZiAtLWdpdCBhL1NvdXJjZS9XZWJDb3JlL0NoYW5nZUxvZyBiL1NvdXJjZS9XZWJDb3JlL0No YW5nZUxvZwppbmRleCBmZDA2YTA5Li42Mzk5MDY1IDEwMDY0NAotLS0gYS9Tb3VyY2UvV2ViQ29y ZS9DaGFuZ2VMb2cKKysrIGIvU291cmNlL1dlYkNvcmUvQ2hhbmdlTG9nCkBAIC0xLDMgKzEsMTYg QEAKKzIwMTMtMDgtMDIgIFpvbHRhbiBBcnZhaSAgPHphcnZhaUBpbmYudS1zemVnZWQuaHU+CisK KyAgICAgICAgQnVpbGRmaXggZm9yICFFTkFCTEUoU1ZHKSBwbGF0Zm9ybXMgYWZ0ZXIgcjE1MzU4 MS4KKyAgICAgICAgaHR0cHM6Ly9idWdzLndlYmtpdC5vcmcvc2hvd19idWcuY2dpP2lkPTExOTQ0 NAorCisgICAgICAgIFJldmlld2VkIGJ5IE5PQk9EWSAoT09QUyEpLgorCisgICAgICAgIEFkZGlu ZyBtaXNzaW5nIGd1YXJkcy4KKworICAgICAgICAqIGNzcy9TdHlsZVByb3BlcnR5U2hvcnRoYW5k LmNwcDoKKyAgICAgICAgKFdlYkNvcmU6Om1hdGNoaW5nU2hvcnRoYW5kc0ZvckxvbmdoYW5kKToK KyAgICAgICAgKiBjc3MvU3R5bGVQcm9wZXJ0eVNob3J0aGFuZC5oOgorCiAyMDEzLTA4LTAxICBD b21taXQgUXVldWUgIDxjb21taXQtcXVldWVAd2Via2l0Lm9yZz4KIAogICAgICAgICBVbnJldmll d2VkLCByb2xsaW5nIG91dCByMTUzNjA4LgpkaWZmIC0tZ2l0IGEvU291cmNlL1dlYkNvcmUvY3Nz L1N0eWxlUHJvcGVydHlTaG9ydGhhbmQuY3BwIGIvU291cmNlL1dlYkNvcmUvY3NzL1N0eWxlUHJv cGVydHlTaG9ydGhhbmQuY3BwCmluZGV4IDM4OWQ0NzMuLjEzMjNmYTIgMTAwNjQ0Ci0tLSBhL1Nv dXJjZS9XZWJDb3JlL2Nzcy9TdHlsZVByb3BlcnR5U2hvcnRoYW5kLmNwcAorKysgYi9Tb3VyY2Uv V2ViQ29yZS9jc3MvU3R5bGVQcm9wZXJ0eVNob3J0aGFuZC5jcHAKQEAgLTIzMCw2ICsyMzAsNyBA QCBjb25zdCBTdHlsZVByb3BlcnR5U2hvcnRoYW5kJiBtYXJnaW5TaG9ydGhhbmQoKQogICAgIHJl dHVybiBtYXJnaW5Mb25naGFuZHM7CiB9CiAKKyNpZiBkZWZpbmVkKEVOQUJMRV9TVkcpICYmIEVO QUJMRV9TVkcKIGNvbnN0IFN0eWxlUHJvcGVydHlTaG9ydGhhbmQmIG1hcmtlclNob3J0aGFuZCgp CiB7CiAgICAgc3RhdGljIGNvbnN0IENTU1Byb3BlcnR5SUQgbWFya2VyUHJvcGVydGllc1tdID0g ewpAQCAtMjQwLDYgKzI0MSw3IEBAIGNvbnN0IFN0eWxlUHJvcGVydHlTaG9ydGhhbmQmIG1hcmtl clNob3J0aGFuZCgpCiAgICAgREVGSU5FX1NUQVRJQ19MT0NBTChTdHlsZVByb3BlcnR5U2hvcnRo YW5kLCBtYXJrZXJMb25naGFuZHMsIChDU1NQcm9wZXJ0eU1hcmtlciwgbWFya2VyUHJvcGVydGll cywgV1RGX0FSUkFZX0xFTkdUSChtYXJrZXJQcm9wZXJ0aWVzKSkpOwogICAgIHJldHVybiBtYXJr ZXJMb25naGFuZHM7CiB9CisjZW5kaWYKIAogY29uc3QgU3R5bGVQcm9wZXJ0eVNob3J0aGFuZCYg b3V0bGluZVNob3J0aGFuZCgpCiB7CkBAIC03NjQsMTEgKzc2NiwxMyBAQCBjb25zdCBWZWN0b3I8 Y29uc3QgU3R5bGVQcm9wZXJ0eVNob3J0aGFuZCo+IG1hdGNoaW5nU2hvcnRoYW5kc0Zvckxvbmdo YW5kKENTU1BybwogICAgICAgICBtYXAuc2V0KENTU1Byb3BlcnR5TWFyZ2luQm90dG9tLCBtYXJn aW4pOwogICAgICAgICBtYXAuc2V0KENTU1Byb3BlcnR5TWFyZ2luTGVmdCwgbWFyZ2luKTsKIAor I2lmIGRlZmluZWQoRU5BQkxFX1NWRykgJiYgRU5BQkxFX1NWRwogICAgICAgICBWZWN0b3I8Y29u c3QgU3R5bGVQcm9wZXJ0eVNob3J0aGFuZCosIDE+IG1hcmtlcjsKICAgICAgICAgbWFya2VyLnVu Y2hlY2tlZEFwcGVuZCgmbWFya2VyU2hvcnRoYW5kKCkpOwogICAgICAgICBtYXAuc2V0KENTU1By b3BlcnR5TWFya2VyU3RhcnQsIG1hcmtlcik7CiAgICAgICAgIG1hcC5zZXQoQ1NTUHJvcGVydHlN YXJrZXJNaWQsIG1hcmtlcik7CiAgICAgICAgIG1hcC5zZXQoQ1NTUHJvcGVydHlNYXJrZXJFbmQs IG1hcmtlcik7CisjZW5kaWYKIAogICAgICAgICBWZWN0b3I8Y29uc3QgU3R5bGVQcm9wZXJ0eVNo b3J0aGFuZCosIDE+IG91dGxpbmU7CiAgICAgICAgIG91dGxpbmUudW5jaGVja2VkQXBwZW5kKCZv dXRsaW5lU2hvcnRoYW5kKCkpOwpkaWZmIC0tZ2l0IGEvU291cmNlL1dlYkNvcmUvY3NzL1N0eWxl UHJvcGVydHlTaG9ydGhhbmQuaCBiL1NvdXJjZS9XZWJDb3JlL2Nzcy9TdHlsZVByb3BlcnR5U2hv cnRoYW5kLmgKaW5kZXggNjM1YzAxOS4uMzQyZGQ0OSAxMDA2NDQKLS0tIGEvU291cmNlL1dlYkNv cmUvY3NzL1N0eWxlUHJvcGVydHlTaG9ydGhhbmQuaAorKysgYi9Tb3VyY2UvV2ViQ29yZS9jc3Mv U3R5bGVQcm9wZXJ0eVNob3J0aGFuZC5oCkBAIC04NSw3ICs4NSw5IEBAIGNvbnN0IFN0eWxlUHJv cGVydHlTaG9ydGhhbmQmIGxpc3RTdHlsZVNob3J0aGFuZCgpOwogY29uc3QgU3R5bGVQcm9wZXJ0 eVNob3J0aGFuZCYgZm9udFNob3J0aGFuZCgpOwogY29uc3QgU3R5bGVQcm9wZXJ0eVNob3J0aGFu ZCYgaGVpZ2h0U2hvcnRoYW5kKCk7CiBjb25zdCBTdHlsZVByb3BlcnR5U2hvcnRoYW5kJiBtYXJn aW5TaG9ydGhhbmQoKTsKKyNpZiBkZWZpbmVkKEVOQUJMRV9TVkcpICYmIEVOQUJMRV9TVkcKIGNv bnN0IFN0eWxlUHJvcGVydHlTaG9ydGhhbmQmIG1hcmtlclNob3J0aGFuZCgpOworI2VuZGlmCiBj b25zdCBTdHlsZVByb3BlcnR5U2hvcnRoYW5kJiBvdXRsaW5lU2hvcnRoYW5kKCk7CiBjb25zdCBT dHlsZVByb3BlcnR5U2hvcnRoYW5kJiBvdmVyZmxvd1Nob3J0aGFuZCgpOwogY29uc3QgU3R5bGVQ cm9wZXJ0eVNob3J0aGFuZCYgcGFkZGluZ1Nob3J0aGFuZCgpOwo= 208017 2013-08-02 07:15:15 -0700 2013-08-02 08:39:46 -0700 buildfix webcore-css-fix.patch text/plain 2717 zarvai ZGlmZiAtLWdpdCBhL1NvdXJjZS9XZWJDb3JlL0NoYW5nZUxvZyBiL1NvdXJjZS9XZWJDb3JlL0No YW5nZUxvZwppbmRleCA1YmRjYzRlLi5iOTRjMmIwIDEwMDY0NAotLS0gYS9Tb3VyY2UvV2ViQ29y ZS9DaGFuZ2VMb2cKKysrIGIvU291cmNlL1dlYkNvcmUvQ2hhbmdlTG9nCkBAIC0xLDMgKzEsMTYg QEAKKzIwMTMtMDgtMDIgIFpvbHRhbiBBcnZhaSAgPHphcnZhaUBpbmYudS1zemVnZWQuaHU+CisK KyAgICAgICAgQnVpbGRmaXggZm9yICFFTkFCTEUoU1ZHKSBwbGF0Zm9ybXMgYWZ0ZXIgcjE1MzU4 MS4KKyAgICAgICAgaHR0cHM6Ly9idWdzLndlYmtpdC5vcmcvc2hvd19idWcuY2dpP2lkPTExOTQ0 NAorCisgICAgICAgIFJldmlld2VkIGJ5IEFuZHJlYXMgS2xpbmcuCisKKyAgICAgICAgQWRkaW5n IG1pc3NpbmcgZ3VhcmRzLgorCisgICAgICAgICogY3NzL1N0eWxlUHJvcGVydHlTaG9ydGhhbmQu Y3BwOgorICAgICAgICAoV2ViQ29yZTo6bWF0Y2hpbmdTaG9ydGhhbmRzRm9yTG9uZ2hhbmQpOgor ICAgICAgICAqIGNzcy9TdHlsZVByb3BlcnR5U2hvcnRoYW5kLmg6CisKIDIwMTMtMDgtMDIgIFBh dHJpY2sgR2Fuc3RlcmVyICA8cGFyb2dhQHdlYmtpdC5vcmc+CiAKICAgICAgICAgW1dJTl0gRml4 IGJ1aWxkIHdpdGhvdXQgcHJlY29tcGlsZWQgaGVhZGVyLgpkaWZmIC0tZ2l0IGEvU291cmNlL1dl YkNvcmUvY3NzL1N0eWxlUHJvcGVydHlTaG9ydGhhbmQuY3BwIGIvU291cmNlL1dlYkNvcmUvY3Nz L1N0eWxlUHJvcGVydHlTaG9ydGhhbmQuY3BwCmluZGV4IDM4OWQ0NzMuLmIzZTJhYTAgMTAwNjQ0 Ci0tLSBhL1NvdXJjZS9XZWJDb3JlL2Nzcy9TdHlsZVByb3BlcnR5U2hvcnRoYW5kLmNwcAorKysg Yi9Tb3VyY2UvV2ViQ29yZS9jc3MvU3R5bGVQcm9wZXJ0eVNob3J0aGFuZC5jcHAKQEAgLTIzMCw2 ICsyMzAsNyBAQCBjb25zdCBTdHlsZVByb3BlcnR5U2hvcnRoYW5kJiBtYXJnaW5TaG9ydGhhbmQo KQogICAgIHJldHVybiBtYXJnaW5Mb25naGFuZHM7CiB9CiAKKyNpZiBFTkFCTEUoU1ZHKQogY29u c3QgU3R5bGVQcm9wZXJ0eVNob3J0aGFuZCYgbWFya2VyU2hvcnRoYW5kKCkKIHsKICAgICBzdGF0 aWMgY29uc3QgQ1NTUHJvcGVydHlJRCBtYXJrZXJQcm9wZXJ0aWVzW10gPSB7CkBAIC0yNDAsNiAr MjQxLDcgQEAgY29uc3QgU3R5bGVQcm9wZXJ0eVNob3J0aGFuZCYgbWFya2VyU2hvcnRoYW5kKCkK ICAgICBERUZJTkVfU1RBVElDX0xPQ0FMKFN0eWxlUHJvcGVydHlTaG9ydGhhbmQsIG1hcmtlckxv bmdoYW5kcywgKENTU1Byb3BlcnR5TWFya2VyLCBtYXJrZXJQcm9wZXJ0aWVzLCBXVEZfQVJSQVlf TEVOR1RIKG1hcmtlclByb3BlcnRpZXMpKSk7CiAgICAgcmV0dXJuIG1hcmtlckxvbmdoYW5kczsK IH0KKyNlbmRpZgogCiBjb25zdCBTdHlsZVByb3BlcnR5U2hvcnRoYW5kJiBvdXRsaW5lU2hvcnRo YW5kKCkKIHsKQEAgLTc2NCwxMSArNzY2LDEzIEBAIGNvbnN0IFZlY3Rvcjxjb25zdCBTdHlsZVBy b3BlcnR5U2hvcnRoYW5kKj4gbWF0Y2hpbmdTaG9ydGhhbmRzRm9yTG9uZ2hhbmQoQ1NTUHJvCiAg ICAgICAgIG1hcC5zZXQoQ1NTUHJvcGVydHlNYXJnaW5Cb3R0b20sIG1hcmdpbik7CiAgICAgICAg IG1hcC5zZXQoQ1NTUHJvcGVydHlNYXJnaW5MZWZ0LCBtYXJnaW4pOwogCisjaWYgRU5BQkxFKFNW RykKICAgICAgICAgVmVjdG9yPGNvbnN0IFN0eWxlUHJvcGVydHlTaG9ydGhhbmQqLCAxPiBtYXJr ZXI7CiAgICAgICAgIG1hcmtlci51bmNoZWNrZWRBcHBlbmQoJm1hcmtlclNob3J0aGFuZCgpKTsK ICAgICAgICAgbWFwLnNldChDU1NQcm9wZXJ0eU1hcmtlclN0YXJ0LCBtYXJrZXIpOwogICAgICAg ICBtYXAuc2V0KENTU1Byb3BlcnR5TWFya2VyTWlkLCBtYXJrZXIpOwogICAgICAgICBtYXAuc2V0 KENTU1Byb3BlcnR5TWFya2VyRW5kLCBtYXJrZXIpOworI2VuZGlmCiAKICAgICAgICAgVmVjdG9y PGNvbnN0IFN0eWxlUHJvcGVydHlTaG9ydGhhbmQqLCAxPiBvdXRsaW5lOwogICAgICAgICBvdXRs aW5lLnVuY2hlY2tlZEFwcGVuZCgmb3V0bGluZVNob3J0aGFuZCgpKTsKZGlmZiAtLWdpdCBhL1Nv dXJjZS9XZWJDb3JlL2Nzcy9TdHlsZVByb3BlcnR5U2hvcnRoYW5kLmggYi9Tb3VyY2UvV2ViQ29y ZS9jc3MvU3R5bGVQcm9wZXJ0eVNob3J0aGFuZC5oCmluZGV4IDYzNWMwMTkuLmEzZDFiYjMgMTAw NjQ0Ci0tLSBhL1NvdXJjZS9XZWJDb3JlL2Nzcy9TdHlsZVByb3BlcnR5U2hvcnRoYW5kLmgKKysr IGIvU291cmNlL1dlYkNvcmUvY3NzL1N0eWxlUHJvcGVydHlTaG9ydGhhbmQuaApAQCAtODUsNyAr ODUsOSBAQCBjb25zdCBTdHlsZVByb3BlcnR5U2hvcnRoYW5kJiBsaXN0U3R5bGVTaG9ydGhhbmQo KTsKIGNvbnN0IFN0eWxlUHJvcGVydHlTaG9ydGhhbmQmIGZvbnRTaG9ydGhhbmQoKTsKIGNvbnN0 IFN0eWxlUHJvcGVydHlTaG9ydGhhbmQmIGhlaWdodFNob3J0aGFuZCgpOwogY29uc3QgU3R5bGVQ cm9wZXJ0eVNob3J0aGFuZCYgbWFyZ2luU2hvcnRoYW5kKCk7CisjaWYgRU5BQkxFKFNWRykKIGNv bnN0IFN0eWxlUHJvcGVydHlTaG9ydGhhbmQmIG1hcmtlclNob3J0aGFuZCgpOworI2VuZGlmCiBj b25zdCBTdHlsZVByb3BlcnR5U2hvcnRoYW5kJiBvdXRsaW5lU2hvcnRoYW5kKCk7CiBjb25zdCBT dHlsZVByb3BlcnR5U2hvcnRoYW5kJiBvdmVyZmxvd1Nob3J0aGFuZCgpOwogY29uc3QgU3R5bGVQ cm9wZXJ0eVNob3J0aGFuZCYgcGFkZGluZ1Nob3J0aGFuZCgpOwo=