119432 2013-08-01 23:39:37 -0700 Remove redundant call of argsList->current() from loops in CSSParser 2013-08-02 03:47:53 -0700 1 1 1 Unclassified WebKit CSS 528+ (Nightly build) Unspecified Unspecified RESOLVED FIXED BlinkMergeCandidate P2 Normal --- 1 bw80.lee bw80.lee commit-queue esprehn+autocc glenn gyuyoung.kim macpherson menard oldest_to_newest 914024 0 bw80.lee 2013-08-01 23:39:37 -0700 while loops in CSSParser call argList->current() function at the start of each iteration, but this is redundant because argsList->next() at the end of the iteration calls the argList->current() and returns the result. 914025 1 bw80.lee 2013-08-01 23:40:35 -0700 blink merge from : https://src.chromium.org/viewvc/blink?view=rev&revision=155402 914027 2 207986 bw80.lee 2013-08-01 23:47:33 -0700 Created attachment 207986 Patch 914029 3 207986 cdumez 2013-08-02 00:01:57 -0700 Comment on attachment 207986 Patch Ok, r=me. 914084 4 207986 commit-queue 2013-08-02 03:47:50 -0700 Comment on attachment 207986 Patch Clearing flags on attachment: 207986 Committed r153643: <http://trac.webkit.org/changeset/153643> 914085 5 commit-queue 2013-08-02 03:47:53 -0700 All reviewed patches have been landed. Closing bug. 207986 2013-08-01 23:47:33 -0700 2013-08-02 03:47:50 -0700 Patch bug-119432-20130802154731.patch text/plain 3700 bw80.lee U3VidmVyc2lvbiBSZXZpc2lvbjogMTUzNjM0CmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViQ29yZS9D aGFuZ2VMb2cgYi9Tb3VyY2UvV2ViQ29yZS9DaGFuZ2VMb2cKaW5kZXggZmQwNmEwOTFjZDUwNmQz MDk2NjU4YTZlODU5YTY4Yjk0NzAwYjkyNC4uOTQwMmZhMDBiODM5ZjE5YWQ0N2MyNTE2MDc5NzEx NzFlOTA3ODlhNiAxMDA2NDQKLS0tIGEvU291cmNlL1dlYkNvcmUvQ2hhbmdlTG9nCisrKyBiL1Nv dXJjZS9XZWJDb3JlL0NoYW5nZUxvZwpAQCAtMSwzICsxLDIxIEBACisyMDEzLTA4LTAxICBCeXVu Z3dvbyBMZWUgIDxidzgwLmxlZUBzYW1zdW5nLmNvbT4KKworICAgICAgICBSZW1vdmUgcmVkdW5k YW50IGNhbGwgb2YgYXJnc0xpc3QtPmN1cnJlbnQoKSBmcm9tIGxvb3BzIGluIENTU1BhcnNlci4K KyAgICAgICAgaHR0cHM6Ly9idWdzLndlYmtpdC5vcmcvc2hvd19idWcuY2dpP2lkPTExOTQzMgor CisgICAgICAgIFJldmlld2VkIGJ5IE5PQk9EWSAoT09QUyEpLgorCisgICAgICAgIHdoaWxlIGxv b3BzIGluIENTU1BhcnNlciBjYWxsIGFyZ0xpc3QtPmN1cnJlbnQoKSBmdW5jdGlvbiBhdCB0aGUg c3RhcnQKKyAgICAgICAgb2YgZWFjaCBpdGVyYXRpb24sIGJ1dCB0aGlzIGlzIHJlZHVuZGFudCBi ZWNhdXNlIGFyZ3NMaXN0LT5uZXh0KCkgYXQKKyAgICAgICAgdGhlIGVuZCBvZiB0aGUgaXRlcmF0 aW9uIGNhbGxzIHRoZSBhcmdMaXN0LT5jdXJyZW50KCkgYW5kIHJldHVybnMgdGhlCisgICAgICAg IHJlc3VsdC4KKworICAgICAgICBCbGluayBtZXJnZSBmcm9tIGh0dHBzOi8vc3JjLmNocm9taXVt Lm9yZy92aWV3dmMvYmxpbms/dmlldz1yZXYmcmV2aXNpb249MTU1NDAyCisKKyAgICAgICAgKiBj c3MvQ1NTUGFyc2VyLmNwcDoKKyAgICAgICAgKFdlYkNvcmU6OkNTU1BhcnNlcjo6cGFyc2VNaXhG dW5jdGlvbik6CisgICAgICAgIChXZWJDb3JlOjpDU1NQYXJzZXI6OnBhcnNlQ3VzdG9tRmlsdGVy RnVuY3Rpb25XaXRoSW5saW5lU3ludGF4KToKKwogMjAxMy0wOC0wMSAgQ29tbWl0IFF1ZXVlICA8 Y29tbWl0LXF1ZXVlQHdlYmtpdC5vcmc+CiAKICAgICAgICAgVW5yZXZpZXdlZCwgcm9sbGluZyBv dXQgcjE1MzYwOC4KZGlmZiAtLWdpdCBhL1NvdXJjZS9XZWJDb3JlL2Nzcy9DU1NQYXJzZXIuY3Bw IGIvU291cmNlL1dlYkNvcmUvY3NzL0NTU1BhcnNlci5jcHAKaW5kZXggNWQ0YzFiNWQ0NTAwMDg5 NzQwNDJjM2Q0MGNjNjIxM2UwZDdlYWM0OS4uM2NmZWY2MzYyMDNmYWQ2NDcyNWI3MDgyMWU0ZTZi MWI1OWY4MmFlOCAxMDA2NDQKLS0tIGEvU291cmNlL1dlYkNvcmUvY3NzL0NTU1BhcnNlci5jcHAK KysrIGIvU291cmNlL1dlYkNvcmUvY3NzL0NTU1BhcnNlci5jcHAKQEAgLTg2MDIsOCArODYwMiw4 IEBAIFBhc3NSZWZQdHI8V2ViS2l0Q1NTTWl4RnVuY3Rpb25WYWx1ZT4gQ1NTUGFyc2VyOjpwYXJz ZU1peEZ1bmN0aW9uKENTU1BhcnNlclZhbHVlCiAKICAgICBib29sIGhhc0JsZW5kTW9kZSA9IGZh bHNlOwogICAgIGJvb2wgaGFzQWxwaGFDb21wb3NpdGluZyA9IGZhbHNlOwotICAgIENTU1BhcnNl clZhbHVlKiBhcmc7Ci0gICAgd2hpbGUgKChhcmcgPSBhcmdzTGlzdC0+Y3VycmVudCgpKSkgewor CisgICAgZm9yIChDU1NQYXJzZXJWYWx1ZSogYXJnID0gYXJnc0xpc3QtPmN1cnJlbnQoKTsgYXJn OyBhcmcgPSBhcmdzTGlzdC0+bmV4dCgpKSB7CiAgICAgICAgIFJlZlB0cjxDU1NWYWx1ZT4gdmFs dWU7CiAKICAgICAgICAgdW5zaWduZWQgYXJnTnVtYmVyID0gYXJnc0xpc3QtPmN1cnJlbnRJbmRl eCgpOwpAQCAtODYyNiw4ICs4NjI2LDYgQEAgUGFzc1JlZlB0cjxXZWJLaXRDU1NNaXhGdW5jdGlv blZhbHVlPiBDU1NQYXJzZXI6OnBhcnNlTWl4RnVuY3Rpb24oQ1NTUGFyc2VyVmFsdWUKICAgICAg ICAgICAgIHJldHVybiAwOwogCiAgICAgICAgIG1peEZ1bmN0aW9uLT5hcHBlbmQodmFsdWUucmVs ZWFzZSgpKTsKLQotICAgICAgICBhcmcgPSBhcmdzTGlzdC0+bmV4dCgpOwogICAgIH0KIAogICAg IHJldHVybiBtaXhGdW5jdGlvbjsKQEAgLTg3OTYsNyArODc5NCw3IEBAIFBhc3NSZWZQdHI8V2Vi S2l0Q1NTRmlsdGVyVmFsdWU+IENTU1BhcnNlcjo6cGFyc2VDdXN0b21GaWx0ZXJGdW5jdGlvbldp dGhJbmxpbmVTCiAgICAgUmVmUHRyPENTU1ZhbHVlTGlzdD4gc2hhZGVyc0xpc3QgPSBDU1NWYWx1 ZUxpc3Q6OmNyZWF0ZVNwYWNlU2VwYXJhdGVkKCk7CiAgICAgYm9vbCBoYWRBdExlYXN0T25lQ3Vz dG9tU2hhZGVyID0gZmFsc2U7CiAgICAgQ1NTUGFyc2VyVmFsdWUqIGFyZzsKLSAgICB3aGlsZSAo KGFyZyA9IGFyZ3NMaXN0LT5jdXJyZW50KCkpKSB7CisgICAgZm9yIChhcmcgPSBhcmdzTGlzdC0+ Y3VycmVudCgpOyBhcmc7IGFyZyA9IGFyZ3NMaXN0LT5uZXh0KCkpIHsKICAgICAgICAgUmVmUHRy PENTU1ZhbHVlPiB2YWx1ZTsKICAgICAgICAgaWYgKGFyZy0+aWQgPT0gQ1NTVmFsdWVOb25lKQog ICAgICAgICAgICAgdmFsdWUgPSBjc3NWYWx1ZVBvb2woKS5jcmVhdGVJZGVudGlmaWVyVmFsdWUo Q1NTVmFsdWVOb25lKTsKQEAgLTg4MTMsNyArODgxMSw2IEBAIFBhc3NSZWZQdHI8V2ViS2l0Q1NT RmlsdGVyVmFsdWU+IENTU1BhcnNlcjo6cGFyc2VDdXN0b21GaWx0ZXJGdW5jdGlvbldpdGhJbmxp bmVTCiAgICAgICAgIGlmICghdmFsdWUpCiAgICAgICAgICAgICBicmVhazsKICAgICAgICAgc2hh ZGVyc0xpc3QtPmFwcGVuZCh2YWx1ZS5yZWxlYXNlKCkpOwotICAgICAgICBhcmdzTGlzdC0+bmV4 dCgpOwogICAgIH0KIAogICAgIGlmICghc2hhZGVyc0xpc3QtPmxlbmd0aCgpIHx8ICFoYWRBdExl YXN0T25lQ3VzdG9tU2hhZGVyIHx8IHNoYWRlcnNMaXN0LT5sZW5ndGgoKSA+IDIgfHwgIWFjY2Vw dENvbW1hT3BlcmF0b3IoYXJnc0xpc3QpKQpAQCAtODgyNCw3ICs4ODIxLDcgQEAgUGFzc1JlZlB0 cjxXZWJLaXRDU1NGaWx0ZXJWYWx1ZT4gQ1NTUGFyc2VyOjpwYXJzZUN1c3RvbUZpbHRlckZ1bmN0 aW9uV2l0aElubGluZVMKICAgICAvLyAyLiBQYXJzZSB0aGUgbWVzaCBzaXplIDx2ZXJ0ZXgtbWVz aD4KICAgICBSZWZQdHI8Q1NTVmFsdWVMaXN0PiBtZXNoU2l6ZUxpc3QgPSBDU1NWYWx1ZUxpc3Q6 OmNyZWF0ZVNwYWNlU2VwYXJhdGVkKCk7CiAgICAgCi0gICAgd2hpbGUgKChhcmcgPSBhcmdzTGlz dC0+Y3VycmVudCgpKSkgeworICAgIGZvciAoYXJnID0gYXJnc0xpc3QtPmN1cnJlbnQoKTsgYXJn OyBhcmcgPSBhcmdzTGlzdC0+bmV4dCgpKSB7CiAgICAgICAgIGlmICghdmFsaWRVbml0KGFyZywg RkludGVnZXIgfCBGTm9uTmVnLCBDU1NTdHJpY3RNb2RlKSkKICAgICAgICAgICAgIGJyZWFrOwog ICAgICAgICBpbnQgaW50ZWdlclZhbHVlID0gY2xhbXBUb0ludGVnZXIoYXJnLT5mVmFsdWUpOwpA QCAtODgzMiw3ICs4ODI5LDYgQEAgUGFzc1JlZlB0cjxXZWJLaXRDU1NGaWx0ZXJWYWx1ZT4gQ1NT UGFyc2VyOjpwYXJzZUN1c3RvbUZpbHRlckZ1bmN0aW9uV2l0aElubGluZVMKICAgICAgICAgaWYg KGludGVnZXJWYWx1ZSA8IDEpCiAgICAgICAgICAgICByZXR1cm4gMDsKICAgICAgICAgbWVzaFNp emVMaXN0LT5hcHBlbmQoY3NzVmFsdWVQb29sKCkuY3JlYXRlVmFsdWUoaW50ZWdlclZhbHVlLCBD U1NQcmltaXRpdmVWYWx1ZTo6Q1NTX05VTUJFUikpOwotICAgICAgICBhcmdzTGlzdC0+bmV4dCgp OwogICAgIH0KICAgICAKICAgICBpZiAobWVzaFNpemVMaXN0LT5sZW5ndGgoKSA+IDIpCg==