119419 2013-08-01 17:58:22 -0700 [Forms: color] WebColorPickerMac deconstructor shouldn't assert a variable 2013-08-02 14:34:27 -0700 1 1 1 Unclassified WebKit Forms 528+ (Nightly build) Unspecified Unspecified RESOLVED FIXED InRadar P2 Normal --- 0 ruthiecftg webkit-unassigned bdakin beidson benjamin commit-queue jonlee ruthiecftg webkit-bug-importer oldest_to_newest 913947 0 ruthiecftg 2013-08-01 17:58:22 -0700 In WebColorPickerMac.mm, ~WebColorPickerMac asserts to see if one of its variables is null. Instead it should check to see if its null; if not, it should properly invalidate it. 913948 1 webkit-bug-importer 2013-08-01 18:00:58 -0700 <rdar://problem/14627633> 914200 2 208033 ruthiecftg 2013-08-02 10:53:52 -0700 Created attachment 208033 Patch 914219 3 208033 thorton 2013-08-02 11:27:24 -0700 Comment on attachment 208033 Patch View in context: https://bugs.webkit.org/attachment.cgi?id=208033&action=review > Source/WebKit2/UIProcess/mac/WebColorPickerMac.mm:-85 > -#if ENABLE(INPUT_TYPE_COLOR_POPOVER) So, we need to endPicker() for all <input type='color'>? 914285 4 208033 commit-queue 2013-08-02 14:34:26 -0700 Comment on attachment 208033 Patch Clearing flags on attachment: 208033 Committed r153670: <http://trac.webkit.org/changeset/153670> 914286 5 commit-queue 2013-08-02 14:34:27 -0700 All reviewed patches have been landed. Closing bug. 208033 2013-08-02 10:53:52 -0700 2013-08-02 14:34:25 -0700 Patch bug-119419-20130802105352.patch text/plain 1491 ruthiecftg SW5kZXg6IFNvdXJjZS9XZWJLaXQyL0NoYW5nZUxvZwo9PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09Ci0tLSBTb3VyY2UvV2Vi S2l0Mi9DaGFuZ2VMb2cJKHJldmlzaW9uIDE1MzY1NCkKKysrIFNvdXJjZS9XZWJLaXQyL0NoYW5n ZUxvZwkod29ya2luZyBjb3B5KQpAQCAtMSwzICsxLDE0IEBACisyMDEzLTA4LTAyICBSdXRoIEZv bmcgIDxydXRoX2ZvbmdAYXBwbGUuY29tPgorCisgICAgICAgIFtGb3JtczogY29sb3JdIFdlYkNv bG9yUGlja2VyTWFjIGRlY29uc3RydWN0b3Igc2hvdWxkbid0IGFzc2VydCBhIHZhcmlhYmxlCisg ICAgICAgIDxyZGFyOi8vcHJvYmxlbS8xNDYyNzYzMz4gYW5kIGh0dHBzOi8vYnVncy53ZWJraXQu b3JnL3Nob3dfYnVnLmNnaT9pZD0xMTk0MTkKKworICAgICAgICBSZXZpZXdlZCBieSBOT0JPRFkg KE9PUFMhKS4KKworICAgICAgICAqIFVJUHJvY2Vzcy9tYWMvV2ViQ29sb3JQaWNrZXJNYWMubW06 CisgICAgICAgIChXZWJLaXQ6OldlYkNvbG9yUGlja2VyTWFjOjp+V2ViQ29sb3JQaWNrZXJNYWMp OiBJZiB0aGUgbV9jb2xvclBpY2tlclVJIHZhcmlhYmxlCisgICAgICAgICAgaXMgbm90IG51bGws IHRoZW4gcHJvcGVybHkgZGVzdHJveSBpdCBmaXJzdCBiZWZvcmUgZGVzdHJveWluZyBXZWJDb2xv clBpY2tlck1hYyBvYmplY3QuCisKIDIwMTMtMDgtMDEgIFJ1dGggRm9uZyAgPHJ1dGhfZm9uZ0Bh cHBsZS5jb20+CiAKICAgICAgICAgW0Zvcm1zOiBjb2xvcl0gPGlucHV0IHR5cGU9J2NvbG9yJz4g cG9wb3ZlciBjb2xvciB3ZWxsIGltcGxlbWVudGF0aW9uCkluZGV4OiBTb3VyY2UvV2ViS2l0Mi9V SVByb2Nlc3MvbWFjL1dlYkNvbG9yUGlja2VyTWFjLm1tCj09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT0KLS0tIFNvdXJjZS9X ZWJLaXQyL1VJUHJvY2Vzcy9tYWMvV2ViQ29sb3JQaWNrZXJNYWMubW0JKHJldmlzaW9uIDE1MzY1 MykKKysrIFNvdXJjZS9XZWJLaXQyL1VJUHJvY2Vzcy9tYWMvV2ViQ29sb3JQaWNrZXJNYWMubW0J KHdvcmtpbmcgY29weSkKQEAgLTgyLDEyICs4Miw4IEBAIFBhc3NSZWZQdHI8V2ViQ29sb3JQaWNr ZXJNYWM+IFdlYkNvbG9yUGkKIAogV2ViQ29sb3JQaWNrZXJNYWM6On5XZWJDb2xvclBpY2tlck1h YygpCiB7Ci0jaWYgRU5BQkxFKElOUFVUX1RZUEVfQ09MT1JfUE9QT1ZFUikKICAgICBpZiAobV9j b2xvclBpY2tlclVJKQogICAgICAgICBlbmRQaWNrZXIoKTsKLSNlbHNlCi0gICAgQVNTRVJUKCFt X2NvbG9yUGlja2VyVUkpOwotI2VuZGlmCiB9CiAKIFdlYkNvbG9yUGlja2VyTWFjOjpXZWJDb2xv clBpY2tlck1hYyhXZWJDb2xvclBpY2tlcjo6Q2xpZW50KiBjbGllbnQsIGNvbnN0IFdlYkNvcmU6 OkNvbG9yJiBpbml0aWFsQ29sb3IsIGNvbnN0IFdlYkNvcmU6OkludFJlY3QmIHJlY3QsIFdLVmll dyogdmlldykK