119416 2013-08-01 17:21:18 -0700 REGRESSION (r130783): Scrolling is broken going back to a cached page from a page that still has outstanding subresources 2013-08-02 08:17:19 -0700 1 1 1 Unclassified WebKit Page Loading 528+ (Nightly build) All All RESOLVED FIXED InRadar P2 Normal --- 1 beidson beidson commit-queue japhet simon.fraser oldest_to_newest 913937 0 beidson 2013-08-01 17:21:18 -0700 REGRESSION (r130783): Scrolling is broken going back to a cached page from a page that still has outstanding sub resources This has the exact same symptom - but subtly different cause - as https://bugs.webkit.org/show_bug.cgi?id=117112 In radar as <rdar://problem/14601124> 913949 1 207973 beidson 2013-08-01 18:04:07 -0700 Created attachment 207973 Patch v1 Uploading for EWS and review while layout tests also run locally. 913954 2 simon.fraser 2013-08-01 18:12:21 -0700 Can you please file 2 more bugs to: 1. make the web process assert before the UI process does when things go wrong 2. make the loading logging detailed enough to detect mistakes like this 913990 3 207973 darin 2013-08-01 20:27:49 -0700 Comment on attachment 207973 Patch v1 View in context: https://bugs.webkit.org/attachment.cgi?id=207973&action=review r=me; I know you want to wait to see what Mac and Win EWS says, and I’m sure you’ll get those results soon. > Source/WebCore/loader/DocumentLoader.cpp:311 > + if (Document* doc = document()) > + doc->cancelParsing(); When moving this it might be nice to get rid of the abbreviation too: if (Document* document = this->document()) document->cancelParsing(); 914009 4 beidson 2013-08-01 21:55:57 -0700 (In reply to comment #3) > (From update of attachment 207973 [details]) > View in context: https://bugs.webkit.org/attachment.cgi?id=207973&action=review > > r=me; I know you want to wait to see what Mac and Win EWS says, and I’m sure you’ll get those results soon. > > > Source/WebCore/loader/DocumentLoader.cpp:311 > > + if (Document* doc = document()) > > + doc->cancelParsing(); > > When moving this it might be nice to get rid of the abbreviation too: > > if (Document* document = this->document()) > document->cancelParsing(); DANGIT - I know you made the same comment last time after the fact, and I even made a mental note to do it this time. Will do! 914011 5 beidson 2013-08-01 22:00:19 -0700 (In reply to comment #2) > Can you please file 2 more bugs to: > 1. make the web process assert before the UI process does when things go wrong > 2. make the loading logging detailed enough to detect mistakes like this Doesn't really seem necessary to file two bugs for these. Filed https://bugs.webkit.org/show_bug.cgi?id=119430 914156 6 beidson 2013-08-02 08:17:19 -0700 http://trac.webkit.org/changeset/153649 207973 2013-08-01 18:04:07 -0700 2013-08-01 20:27:49 -0700 Patch v1 patch text/plain 11472 beidson ZGlmZiAtLWdpdCBhL0xheW91dFRlc3RzL0NoYW5nZUxvZyBiL0xheW91dFRlc3RzL0NoYW5nZUxv ZwppbmRleCAzOTQ0OGQ4Li5lOWVjZjFkIDEwMDY0NAotLS0gYS9MYXlvdXRUZXN0cy9DaGFuZ2VM b2cKKysrIGIvTGF5b3V0VGVzdHMvQ2hhbmdlTG9nCkBAIC0xLDMgKzEsMTcgQEAKKzIwMTMtMDgt MDEgIEJyYWR5IEVpZHNvbiAgPGJlaWRzb25AYXBwbGUuY29tPgorCisgICAgICAgIFJFR1JFU1NJ T04gKHIxMzA3ODMpOiBTY3JvbGxpbmcgaXMgYnJva2VuIGdvaW5nIGJhY2sgdG8gYSBjYWNoZWQg cGFnZSBmcm9tIGEgcGFnZSB0aGF0IHN0aWxsIGhhcyBvdXRzdGFuZGluZyBzdWJyZXNvdXJjZXMu CisgICAgICAgIDxyZGFyOi8vcHJvYmxlbS8xNDYwMTEyND4gYW5kIGh0dHBzOi8vYnVncy53ZWJr aXQub3JnL3Nob3dfYnVnLmNnaT9pZD0xMTk0MTYKKworICAgICAgICBSZXZpZXdlZCBieSBOT0JP RFkgKE9PUFMhKS4KKworICAgICAgICAqIGh0dHAvdGVzdHMvbG9hZGluZy9yZXNvdXJjZXMvcGFn ZS13aXRoLXNsb3ctbG9hZGluZy1zdWJyZXNvdXJjZS5odG1sOiBBZGRlZC4KKyAgICAgICAgKiBo dHRwL3Rlc3RzL2xvYWRpbmcvcmVzb3VyY2VzL3Nsb3dpbWFnZS5waHA6IEFkZGVkLgorICAgICAg ICAqIGh0dHAvdGVzdHMvbG9hZGluZy91bmZpbmlzaGVkLWxvYWQtYmFjay10by1jYWNoZWQtcGFn ZS1jYWxsYmFja3MtZXhwZWN0ZWQudHh0OgorICAgICAgICAqIGh0dHAvdGVzdHMvbG9hZGluZy91 bmZpbmlzaGVkLWxvYWQtYmFjay10by1jYWNoZWQtcGFnZS1jYWxsYmFja3MuaHRtbDoKKyAgICAg ICAgKiBodHRwL3Rlc3RzL2xvYWRpbmcvdW5maW5pc2hlZC1tYWluLXJlc291cmNlLWJhY2stdG8t Y2FjaGVkLXBhZ2UtY2FsbGJhY2tzLWV4cGVjdGVkLnR4dDogQ29waWVkIGZyb20gTGF5b3V0VGVz dHMvaHR0cC90ZXN0cy9sb2FkaW5nL3VuZmluaXNoZWQtbG9hZC1iYWNrLXRvLWNhY2hlZC1wYWdl LWNhbGxiYWNrcy1leHBlY3RlZC50eHQuCisgICAgICAgICogaHR0cC90ZXN0cy9sb2FkaW5nL3Vu ZmluaXNoZWQtbWFpbi1yZXNvdXJjZS1iYWNrLXRvLWNhY2hlZC1wYWdlLWNhbGxiYWNrcy5odG1s OiBDb3BpZWQgZnJvbSBMYXlvdXRUZXN0cy9odHRwL3Rlc3RzL2xvYWRpbmcvdW5maW5pc2hlZC1s b2FkLWJhY2stdG8tY2FjaGVkLXBhZ2UtY2FsbGJhY2tzLmh0bWwuCisKIDIwMTMtMDctMzEgIFJv YiBCdWlzICA8cndsYnVpc0B3ZWJraXQub3JnPgogCiAgICAgICAgIENvbnZlcnQgU1ZHIHRlc3Qg ZnJvbSByMTUzNDMzIHRvIGEgcmVmdGVzdApkaWZmIC0tZ2l0IGEvTGF5b3V0VGVzdHMvaHR0cC90 ZXN0cy9sb2FkaW5nL3Jlc291cmNlcy9wYWdlLXdpdGgtc2xvdy1sb2FkaW5nLXN1YnJlc291cmNl Lmh0bWwgYi9MYXlvdXRUZXN0cy9odHRwL3Rlc3RzL2xvYWRpbmcvcmVzb3VyY2VzL3BhZ2Utd2l0 aC1zbG93LWxvYWRpbmctc3VicmVzb3VyY2UuaHRtbApuZXcgZmlsZSBtb2RlIDEwMDY0NAppbmRl eCAwMDAwMDAwLi5kYzQxN2Y3Ci0tLSAvZGV2L251bGwKKysrIGIvTGF5b3V0VGVzdHMvaHR0cC90 ZXN0cy9sb2FkaW5nL3Jlc291cmNlcy9wYWdlLXdpdGgtc2xvdy1sb2FkaW5nLXN1YnJlc291cmNl Lmh0bWwKQEAgLTAsMCArMSwxMiBAQAorPHNjcmlwdD4KKworZnVuY3Rpb24gZG9jdW1lbnRMb2Fk ZWQoKSB7CisJc2V0VGltZW91dCgnd2luZG93Lmhpc3RvcnkuYmFjaygpJywgMCk7Cit9CisKK2Rv Y3VtZW50LmFkZEV2ZW50TGlzdGVuZXIoIkRPTUNvbnRlbnRMb2FkZWQiLCBkb2N1bWVudExvYWRl ZCwgZmFsc2UpOworCis8L3NjcmlwdD4KK1RoaXMgcGFnZSBoYXMgYW4gaW1hZ2UgdGhhdCB0YWtl cyBmb3JldmVyIHRvIGxvYWQuPGJyPgorQWZ0ZXIgdGhlIG1haW4gcmVzb3VyY2UgaXMgZmluaXNo ZWQgbG9hZGluZywgYnV0IGJlZm9yZSB0aGUgaW1hZ2UgbG9hZHMsIGl0IHNob3VsZCBnbyBiYWNr IHRvIHRoZSBwcmV2aW91cyBwYWdlLjxicj4KKzxpbWcgc3JjPSJzbG93aW1hZ2UucGhwIj4KZGlm ZiAtLWdpdCBhL0xheW91dFRlc3RzL2h0dHAvdGVzdHMvbG9hZGluZy9yZXNvdXJjZXMvc2xvd2lt YWdlLnBocCBiL0xheW91dFRlc3RzL2h0dHAvdGVzdHMvbG9hZGluZy9yZXNvdXJjZXMvc2xvd2lt YWdlLnBocApuZXcgZmlsZSBtb2RlIDEwMDY0NAppbmRleCAwMDAwMDAwLi4zZDE4OTg2Ci0tLSAv ZGV2L251bGwKKysrIGIvTGF5b3V0VGVzdHMvaHR0cC90ZXN0cy9sb2FkaW5nL3Jlc291cmNlcy9z bG93aW1hZ2UucGhwCkBAIC0wLDAgKzEsNSBAQAorPD9waHAKK3NsZWVwKDMwKTsKK2hlYWRlcign Q2FjaGUtQ29udHJvbDogbm8tY2FjaGUsIG11c3QtcmV2YWxpZGF0ZScpOworaGVhZGVyKCdMb2Nh dGlvbjogZGF0YTppbWFnZS9naWY7YmFzZTY0LFIwbEdPRGxoQVFBQkFKQUFBTWpJeUFBQUFDd0FB QUFBQVFBQkFBQUNBZ1FCQURzJTNEJyk7Cis/PgpkaWZmIC0tZ2l0IGEvTGF5b3V0VGVzdHMvaHR0 cC90ZXN0cy9sb2FkaW5nL3VuZmluaXNoZWQtbG9hZC1iYWNrLXRvLWNhY2hlZC1wYWdlLWNhbGxi YWNrcy1leHBlY3RlZC50eHQgYi9MYXlvdXRUZXN0cy9odHRwL3Rlc3RzL2xvYWRpbmcvdW5maW5p c2hlZC1sb2FkLWJhY2stdG8tY2FjaGVkLXBhZ2UtY2FsbGJhY2tzLWV4cGVjdGVkLnR4dAppbmRl eCBhY2VmMTgzLi4xODI1MDIxIDEwMDY0NAotLS0gYS9MYXlvdXRUZXN0cy9odHRwL3Rlc3RzL2xv YWRpbmcvdW5maW5pc2hlZC1sb2FkLWJhY2stdG8tY2FjaGVkLXBhZ2UtY2FsbGJhY2tzLWV4cGVj dGVkLnR4dAorKysgYi9MYXlvdXRUZXN0cy9odHRwL3Rlc3RzL2xvYWRpbmcvdW5maW5pc2hlZC1s b2FkLWJhY2stdG8tY2FjaGVkLXBhZ2UtY2FsbGJhY2tzLWV4cGVjdGVkLnR4dApAQCAtMTIsNyAr MTIsNyBAQCBtYWluIGZyYW1lIC0gZGlkQ29tbWl0TG9hZEZvckZyYW1lCiBtYWluIGZyYW1lIC0g ZGlkRmluaXNoTG9hZEZvckZyYW1lCiBUaGlzIHRlc3QgZHVtcHMgZnJhbWUgbG9hZCBjYWxsYmFj a3MuIEl0IGlzIG9ubHkgdXNlZnVsIGluc2lkZSBvZiBXZWJLaXRUZXN0UnVubmVyLgogCi1UaGlz IGxpbmsgZ29lcyB0byB0aGUgc2xvdyBsb2FkaW5nIHBhZ2UucyBCdWcgMTE3MTEyIC0gR29pbmcg ImJhY2siIHRvIGEgY2FjaGVkIHBhZ2UgZnJvbSBhIHBhZ2Ugd2l0aCBhIG1haW4gcmVzb3VyY2Ug ZXJyb3IgYnJlYWtzIHNjcm9sbGluZywgYW1vbmdzdCBvdGhlciBpc3N1ZXMKK1RoaXMgbGluayBn b2VzIHRvIGEgcGFnZSB3aXRoIGEgc2xvdyBsb2FkaW5nIHN1YnJlc291cmNlLiBCdWcgMTE5NDE2 IC0gR29pbmcgImJhY2siIHRvIGEgY2FjaGVkIHBhZ2UgZnJvbSBhIHBhZ2Ugd2l0aCBvdXRzdGFu ZGluZyBzdWJyZXNvdXJjZSBsb2FkcyBicmVha3Mgc2Nyb2xsaW5nLCBhbW9uZ3N0IG90aGVyIGlz c3Vlcy4KIAogSW4gdGhlIGJyb2tlbiBjYXNlLCB0aGUgc2Vjb25kIHBhZ2UgZ2V0cyBhIGRpZEZp bmlzaExvYWQgY2FsbGJhY2sgaW50ZXJ0d2luZWQgd2l0aCB0aGUgcmVzdG9yYXRpb24gb2YgdGhl IGNhY2hlZCBwYWdlLCBldmVuIHRob3VnaCBpdCdzIGFscmVhZHkgZ290dGVuIGEgZGlkRmFpbExv YWQgY2FsbGJhY2suCiBUaGUgZmluYWwgNCBjYWxsYmFja3MgbG9vayBsaWtlOgpkaWZmIC0tZ2l0 IGEvTGF5b3V0VGVzdHMvaHR0cC90ZXN0cy9sb2FkaW5nL3VuZmluaXNoZWQtbG9hZC1iYWNrLXRv LWNhY2hlZC1wYWdlLWNhbGxiYWNrcy5odG1sIGIvTGF5b3V0VGVzdHMvaHR0cC90ZXN0cy9sb2Fk aW5nL3VuZmluaXNoZWQtbG9hZC1iYWNrLXRvLWNhY2hlZC1wYWdlLWNhbGxiYWNrcy5odG1sCmlu ZGV4IGFhNmM3MmYuLjA2MTk2OWEgMTAwNjQ0Ci0tLSBhL0xheW91dFRlc3RzL2h0dHAvdGVzdHMv bG9hZGluZy91bmZpbmlzaGVkLWxvYWQtYmFjay10by1jYWNoZWQtcGFnZS1jYWxsYmFja3MuaHRt bAorKysgYi9MYXlvdXRUZXN0cy9odHRwL3Rlc3RzL2xvYWRpbmcvdW5maW5pc2hlZC1sb2FkLWJh Y2stdG8tY2FjaGVkLXBhZ2UtY2FsbGJhY2tzLmh0bWwKQEAgLTMzLDggKzMzLDggQEAgaWYgKHdp bmRvdy50ZXN0UnVubmVyKSB7CiA8L3NjcmlwdD4KIAogVGhpcyB0ZXN0IGR1bXBzIGZyYW1lIGxv YWQgY2FsbGJhY2tzLiAgSXQgaXMgb25seSB1c2VmdWwgaW5zaWRlIG9mIFdlYktpdFRlc3RSdW5u ZXIuPGJyPjxicj4KLTxhIGlkPSJsaW5rVG9TbG93UGFnZSIgaHJlZj0icmVzb3VyY2VzL3Jlc291 cmNlLXRoYXQtZ29lcy1iYWNrLXdoaWxlLXN0aWxsLWxvYWRpbmcucGhwIj5UaGlzIGxpbmsgZ29l cyB0byB0aGUgc2xvdyBsb2FkaW5nIHBhZ2UuPC9hPnMKLUJ1ZyA8YSBocmVmPSJodHRwczovL2J1 Z3Mud2Via2l0Lm9yZy9zaG93X2J1Zy5jZ2k/aWQ9MTE3MTEyIj4xMTcxMTIgLSBHb2luZyAiYmFj ayIgdG8gYSBjYWNoZWQgcGFnZSBmcm9tIGEgcGFnZSB3aXRoIGEgbWFpbiByZXNvdXJjZSBlcnJv ciBicmVha3Mgc2Nyb2xsaW5nLCBhbW9uZ3N0IG90aGVyIGlzc3VlczwvYT48YnI+PGJyPgorPGEg aWQ9ImxpbmtUb1Nsb3dQYWdlIiBocmVmPSJyZXNvdXJjZXMvcGFnZS13aXRoLXNsb3ctbG9hZGlu Zy1zdWJyZXNvdXJjZS5odG1sIj5UaGlzIGxpbmsgZ29lcyB0byBhIHBhZ2Ugd2l0aCBhIHNsb3cg bG9hZGluZyBzdWJyZXNvdXJjZS48L2E+CitCdWcgPGEgaHJlZj0iaHR0cHM6Ly9idWdzLndlYmtp dC5vcmcvc2hvd19idWcuY2dpP2lkPTExOTQxNiI+MTE5NDE2IC0gR29pbmcgImJhY2siIHRvIGEg Y2FjaGVkIHBhZ2UgZnJvbSBhIHBhZ2Ugd2l0aCBvdXRzdGFuZGluZyBzdWJyZXNvdXJjZSBsb2Fk cyBicmVha3Mgc2Nyb2xsaW5nLCBhbW9uZ3N0IG90aGVyIGlzc3Vlcy48L2E+PGJyPjxicj4KIElu IHRoZSBicm9rZW4gY2FzZSwgdGhlIHNlY29uZCBwYWdlIGdldHMgYSBkaWRGaW5pc2hMb2FkIGNh bGxiYWNrIGludGVydHdpbmVkIHdpdGggdGhlIHJlc3RvcmF0aW9uIG9mIHRoZSBjYWNoZWQgcGFn ZSwgZXZlbiB0aG91Z2ggaXQncyBhbHJlYWR5IGdvdHRlbiBhIGRpZEZhaWxMb2FkIGNhbGxiYWNr Ljxicj4KIFRoZSBmaW5hbCA0IGNhbGxiYWNrcyBsb29rIGxpa2U6PGJyPgogZGlkRmFpbExvYWRX aXRoRXJyb3I8YnI+CmRpZmYgLS1naXQgYS9MYXlvdXRUZXN0cy9odHRwL3Rlc3RzL2xvYWRpbmcv dW5maW5pc2hlZC1tYWluLXJlc291cmNlLWJhY2stdG8tY2FjaGVkLXBhZ2UtY2FsbGJhY2tzLWV4 cGVjdGVkLnR4dCBiL0xheW91dFRlc3RzL2h0dHAvdGVzdHMvbG9hZGluZy91bmZpbmlzaGVkLW1h aW4tcmVzb3VyY2UtYmFjay10by1jYWNoZWQtcGFnZS1jYWxsYmFja3MtZXhwZWN0ZWQudHh0Cm5l dyBmaWxlIG1vZGUgMTAwNjQ0CmluZGV4IDAwMDAwMDAuLmI0NzdmN2IKLS0tIC9kZXYvbnVsbAor KysgYi9MYXlvdXRUZXN0cy9odHRwL3Rlc3RzL2xvYWRpbmcvdW5maW5pc2hlZC1tYWluLXJlc291 cmNlLWJhY2stdG8tY2FjaGVkLXBhZ2UtY2FsbGJhY2tzLWV4cGVjdGVkLnR4dApAQCAtMCwwICsx LDI5IEBACittYWluIGZyYW1lIC0gZGlkU3RhcnRQcm92aXNpb25hbExvYWRGb3JGcmFtZQorbWFp biBmcmFtZSAtIGRpZENvbW1pdExvYWRGb3JGcmFtZQorbWFpbiBmcmFtZSAtIGRpZEZpbmlzaERv Y3VtZW50TG9hZEZvckZyYW1lCittYWluIGZyYW1lIC0gZGlkSGFuZGxlT25sb2FkRXZlbnRzRm9y RnJhbWUKK21haW4gZnJhbWUgLSBkaWRGaW5pc2hMb2FkRm9yRnJhbWUKK21haW4gZnJhbWUgLSBk aWRTdGFydFByb3Zpc2lvbmFsTG9hZEZvckZyYW1lCittYWluIGZyYW1lIC0gZGlkQ29tbWl0TG9h ZEZvckZyYW1lCittYWluIGZyYW1lIC0gZGlkRmluaXNoRG9jdW1lbnRMb2FkRm9yRnJhbWUKK21h aW4gZnJhbWUgLSBkaWRGYWlsTG9hZFdpdGhFcnJvcgorbWFpbiBmcmFtZSAtIGRpZFN0YXJ0UHJv dmlzaW9uYWxMb2FkRm9yRnJhbWUKK21haW4gZnJhbWUgLSBkaWRDb21taXRMb2FkRm9yRnJhbWUK K21haW4gZnJhbWUgLSBkaWRGaW5pc2hMb2FkRm9yRnJhbWUKK1RoaXMgdGVzdCBkdW1wcyBmcmFt ZSBsb2FkIGNhbGxiYWNrcy4gSXQgaXMgb25seSB1c2VmdWwgaW5zaWRlIG9mIFdlYktpdFRlc3RS dW5uZXIuCisKK1RoaXMgbGluayBnb2VzIHRvIGEgc2xvdyBsb2FkaW5nIHBhZ2UuIEJ1ZyAxMTcx MTIgLSBHb2luZyAiYmFjayIgdG8gYSBjYWNoZWQgcGFnZSBmcm9tIGEgcGFnZSB3aGVyZSB0aGUg bWFpbiByZXNvdXJjZSBuZXZlciBmaW5pc2hlZCBsb2FkaW5nIGJyZWFrcyBzY3JvbGxpbmcsIGFt b25nc3Qgb3RoZXIgaXNzdWVzLgorCitJbiB0aGUgYnJva2VuIGNhc2UsIHRoZSBzZWNvbmQgcGFn ZSBnZXRzIGEgZGlkRmluaXNoTG9hZCBjYWxsYmFjayBpbnRlcnR3aW5lZCB3aXRoIHRoZSByZXN0 b3JhdGlvbiBvZiB0aGUgY2FjaGVkIHBhZ2UsIGV2ZW4gdGhvdWdoIGl0J3MgYWxyZWFkeSBnb3R0 ZW4gYSBkaWRGYWlsTG9hZCBjYWxsYmFjay4KK1RoZSBmaW5hbCA0IGNhbGxiYWNrcyBsb29rIGxp a2U6CitkaWRGYWlsTG9hZFdpdGhFcnJvcgorZGlkU3RhcnRQcm92aXNpb25hbExvYWRGb3JGcmFt ZQorZGlkRmluaXNoTG9hZEZvckZyYW1lCitkaWRDb21taXRMb2FkRm9yRnJhbWUKKworV2hlbiBm aXhlZCwgdGhlIGZpbmFsIDQgY2FsbGJhY2tzIHNob3VsZCBiZToKK2RpZEZhaWxMb2FkV2l0aEVy cm9yCitkaWRTdGFydFByb3Zpc2lvbmFsTG9hZEZvckZyYW1lCitkaWRDb21taXRMb2FkRm9yRnJh bWUKK2RpZEZpbmlzaExvYWRGb3JGcmFtZQorCmRpZmYgLS1naXQgYS9MYXlvdXRUZXN0cy9odHRw L3Rlc3RzL2xvYWRpbmcvdW5maW5pc2hlZC1tYWluLXJlc291cmNlLWJhY2stdG8tY2FjaGVkLXBh Z2UtY2FsbGJhY2tzLmh0bWwgYi9MYXlvdXRUZXN0cy9odHRwL3Rlc3RzL2xvYWRpbmcvdW5maW5p c2hlZC1tYWluLXJlc291cmNlLWJhY2stdG8tY2FjaGVkLXBhZ2UtY2FsbGJhY2tzLmh0bWwKbmV3 IGZpbGUgbW9kZSAxMDA2NDQKaW5kZXggMDAwMDAwMC4uYzk1OTU0YQotLS0gL2Rldi9udWxsCisr KyBiL0xheW91dFRlc3RzL2h0dHAvdGVzdHMvbG9hZGluZy91bmZpbmlzaGVkLW1haW4tcmVzb3Vy Y2UtYmFjay10by1jYWNoZWQtcGFnZS1jYWxsYmFja3MuaHRtbApAQCAtMCwwICsxLDQ4IEBACis8 c2NyaXB0PgorCit3aW5kb3cub25wYWdlc2hvdyA9IGZ1bmN0aW9uKGV2dCkgeworICAgIGlmICgh d2luZG93LnRlc3RSdW5uZXIpCisgICAgICAgIHJldHVybjsKKworICAgIGlmICghZXZ0LnBlcnNp c3RlZCkKKyAgICAgICAgcmV0dXJuOworICAgIAorICAgIHNldFRpbWVvdXQoInRlc3RSdW5uZXIu bm90aWZ5RG9uZSgpIiwgMCk7Cit9CisKK2Z1bmN0aW9uIGNsaWNrTGlua1RvU2xvd1BhZ2UoKSB7 CisgICAgdmFyIGxpbmsgPSBkb2N1bWVudC5nZXRFbGVtZW50QnlJZCgibGlua1RvU2xvd1BhZ2Ui KTsKKyAgICB2YXIgbGlua1JlY3QgPSBsaW5rLmdldENsaWVudFJlY3RzKClbMF07CisgICAgdmFy IHRhcmdldFggPSBsaW5rUmVjdC5sZWZ0ICsgbGlua1JlY3Qud2lkdGggLyAyOworICAgIHZhciB0 YXJnZXRZID0gbGlua1JlY3QudG9wICsgbGlua1JlY3QuaGVpZ2h0IC8gMjsKKyAgICBldmVudFNl bmRlci5tb3VzZU1vdmVUbyh0YXJnZXRYLCB0YXJnZXRZKTsKKyAgICBldmVudFNlbmRlci5tb3Vz ZURvd24oKTsKKyAgICBldmVudFNlbmRlci5tb3VzZVVwKCk7Cit9CisKK3dpbmRvdy5vbmxvYWQg PSBmdW5jdGlvbihldnQpIHsKKyAgICBzZXRUaW1lb3V0KCJjbGlja0xpbmtUb1Nsb3dQYWdlKCki LCAwKTsKK30KKworaWYgKHdpbmRvdy50ZXN0UnVubmVyKSB7CisgICAgdGVzdFJ1bm5lci5vdmVy cmlkZVByZWZlcmVuY2UoIldlYktpdFVzZXNQYWdlQ2FjaGVQcmVmZXJlbmNlS2V5IiwgMSk7Cisg ICAgdGVzdFJ1bm5lci5kdW1wQXNUZXh0KCk7CisgICAgdGVzdFJ1bm5lci53YWl0VW50aWxEb25l KCk7Cit9IGVsc2UKKyAgICBkb2N1bWVudC53cml0ZSgnVGhpcyB0ZXN0IG11c3QgYmUgcnVuIGJ5 IFdlYktpdFRlc3RSdW5uZXIhJyk7Cis8L3NjcmlwdD4KKworVGhpcyB0ZXN0IGR1bXBzIGZyYW1l IGxvYWQgY2FsbGJhY2tzLiAgSXQgaXMgb25seSB1c2VmdWwgaW5zaWRlIG9mIFdlYktpdFRlc3RS dW5uZXIuPGJyPjxicj4KKzxhIGlkPSJsaW5rVG9TbG93UGFnZSIgaHJlZj0icmVzb3VyY2VzL3Jl c291cmNlLXRoYXQtZ29lcy1iYWNrLXdoaWxlLXN0aWxsLWxvYWRpbmcucGhwIj5UaGlzIGxpbmsg Z29lcyB0byBhIHNsb3cgbG9hZGluZyBwYWdlLjwvYT4KK0J1ZyA8YSBocmVmPSJodHRwczovL2J1 Z3Mud2Via2l0Lm9yZy9zaG93X2J1Zy5jZ2k/aWQ9MTE3MTEyIj4xMTcxMTIgLSBHb2luZyAiYmFj ayIgdG8gYSBjYWNoZWQgcGFnZSBmcm9tIGEgcGFnZSB3aGVyZSB0aGUgbWFpbiByZXNvdXJjZSBu ZXZlciBmaW5pc2hlZCBsb2FkaW5nIGJyZWFrcyBzY3JvbGxpbmcsIGFtb25nc3Qgb3RoZXIgaXNz dWVzLjwvYT48YnI+PGJyPgorSW4gdGhlIGJyb2tlbiBjYXNlLCB0aGUgc2Vjb25kIHBhZ2UgZ2V0 cyBhIGRpZEZpbmlzaExvYWQgY2FsbGJhY2sgaW50ZXJ0d2luZWQgd2l0aCB0aGUgcmVzdG9yYXRp b24gb2YgdGhlIGNhY2hlZCBwYWdlLCBldmVuIHRob3VnaCBpdCdzIGFscmVhZHkgZ290dGVuIGEg ZGlkRmFpbExvYWQgY2FsbGJhY2suPGJyPgorVGhlIGZpbmFsIDQgY2FsbGJhY2tzIGxvb2sgbGlr ZTo8YnI+CitkaWRGYWlsTG9hZFdpdGhFcnJvcjxicj4KK2RpZFN0YXJ0UHJvdmlzaW9uYWxMb2Fk Rm9yRnJhbWU8YnI+CitkaWRGaW5pc2hMb2FkRm9yRnJhbWU8YnI+CitkaWRDb21taXRMb2FkRm9y RnJhbWU8YnI+PGJyPgorV2hlbiBmaXhlZCwgdGhlIGZpbmFsIDQgY2FsbGJhY2tzIHNob3VsZCBi ZTo8YnI+CitkaWRGYWlsTG9hZFdpdGhFcnJvcjxicj4KK2RpZFN0YXJ0UHJvdmlzaW9uYWxMb2Fk Rm9yRnJhbWU8YnI+CitkaWRDb21taXRMb2FkRm9yRnJhbWU8YnI+CitkaWRGaW5pc2hMb2FkRm9y RnJhbWU8YnI+CmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViQ29yZS9DaGFuZ2VMb2cgYi9Tb3VyY2Uv V2ViQ29yZS9DaGFuZ2VMb2cKaW5kZXggZWFmYzBkNy4uN2I4NTE0OSAxMDA2NDQKLS0tIGEvU291 cmNlL1dlYkNvcmUvQ2hhbmdlTG9nCisrKyBiL1NvdXJjZS9XZWJDb3JlL0NoYW5nZUxvZwpAQCAt MSwzICsxLDE1IEBACisyMDEzLTA4LTAxICBCcmFkeSBFaWRzb24gIDxiZWlkc29uQGFwcGxlLmNv bT4KKworICAgICAgICBSRUdSRVNTSU9OIChyMTMwNzgzKTogU2Nyb2xsaW5nIGlzIGJyb2tlbiBn b2luZyBiYWNrIHRvIGEgY2FjaGVkIHBhZ2UgZnJvbSBhIHBhZ2UgdGhhdCBzdGlsbCBoYXMgb3V0 c3RhbmRpbmcgc3VicmVzb3VyY2VzLgorICAgICAgICA8cmRhcjovL3Byb2JsZW0vMTQ2MDExMjQ+ IGFuZCBodHRwczovL2J1Z3Mud2Via2l0Lm9yZy9zaG93X2J1Zy5jZ2k/aWQ9MTE5NDE2CisKKyAg ICAgICAgUmV2aWV3ZWQgYnkgTk9CT0RZIChPT1BTISkuCisKKyAgICAgICAgVGVzdDogaHR0cC90 ZXN0cy9sb2FkaW5nL3VuZmluaXNoZWQtbG9hZC1iYWNrLXRvLWNhY2hlZC1wYWdlLWNhbGxiYWNr cy5odG1sCisKKyAgICAgICAgKiBsb2FkZXIvRG9jdW1lbnRMb2FkZXIuY3BwOgorICAgICAgICAo V2ViQ29yZTo6RG9jdW1lbnRMb2FkZXI6OnN0b3BMb2FkaW5nKTogQWx3YXlzIGNhbmNlbCB0aGUg RG9jdW1lbnQgcGFyc2VyIHdoZW4gc3RvcExvYWRpbmcgaXMgZXhwbGljaXRseSBjYWxsZWQuCisK IDIwMTMtMDctMzEgIFJ1dGggRm9uZyAgPHJ1dGhfZm9uZ0BhcHBsZS5jb20+CiAKICAgICAgICAg PGlucHV0IHR5cGU9Y29sb3I+IE1hYyBVSSBiZWhhdmlvdXIKZGlmZiAtLWdpdCBhL1NvdXJjZS9X ZWJDb3JlL2xvYWRlci9Eb2N1bWVudExvYWRlci5jcHAgYi9Tb3VyY2UvV2ViQ29yZS9sb2FkZXIv RG9jdW1lbnRMb2FkZXIuY3BwCmluZGV4IGU1NGMxODUuLjlkNjNkZTkgMTAwNjQ0Ci0tLSBhL1Nv dXJjZS9XZWJDb3JlL2xvYWRlci9Eb2N1bWVudExvYWRlci5jcHAKKysrIGIvU291cmNlL1dlYkNv cmUvbG9hZGVyL0RvY3VtZW50TG9hZGVyLmNwcApAQCAtMjk1LDEyICsyOTUsNiBAQCB2b2lkIERv Y3VtZW50TG9hZGVyOjpzdG9wTG9hZGluZygpCiAgICAgaWYgKGlzTG9hZGluZ01haW5SZXNvdXJj ZSgpKSB7CiAgICAgICAgIC8vIFN0b3AgdGhlIG1haW4gcmVzb3VyY2UgbG9hZGVyIGFuZCBsZXQg aXQgc2VuZCB0aGUgY2FuY2VsbGVkIG1lc3NhZ2UuCiAgICAgICAgIGNhbmNlbE1haW5SZXNvdXJj ZUxvYWQoZnJhbWVMb2FkZXItPmNhbmNlbGxlZEVycm9yKG1fcmVxdWVzdCkpOwotICAgIAotICAg ICAgICAvLyBXaGVuIGNhbmNlbGxpbmcgdGhlIG1haW4gcmVzb3VyY2UgbG9hZCwgd2UgbmVlZCB0 byBhbHNvIGNhbmNlbCB0aGUgRG9jdW1lbnQncyBwYXJzZXIuCi0gICAgICAgIC8vIE90aGVyd2lz ZSBjYW5jZWxsaW5nIHRoZSBwYXJzZXIgd2hlbiBzdGFydGluZyB0aGUgbmV4dCBwYWdlIGxvYWQg bWlnaHQgcmVzdWx0Ci0gICAgICAgIC8vIGluIHVuZXhwZWN0ZWQgc2lkZSBlZmZlY3RzIHN1Y2gg YXMgZXJyb25lb3VzIGV2ZW50IGRpc3BhdGNoLiAoIGh0dHA6Ly93ZWJraXQub3JnL2IvMTE3MTEy ICkKLSAgICAgICAgaWYgKERvY3VtZW50KiBkb2MgPSBkb2N1bWVudCgpKQotICAgICAgICAgICAg ZG9jLT5jYW5jZWxQYXJzaW5nKCk7CiAgICAgfSBlbHNlIGlmICghbV9zdWJyZXNvdXJjZUxvYWRl cnMuaXNFbXB0eSgpKQogICAgICAgICAvLyBUaGUgbWFpbiByZXNvdXJjZSBsb2FkZXIgYWxyZWFk eSBmaW5pc2hlZCBsb2FkaW5nLiBTZXQgdGhlIGNhbmNlbGxlZCBlcnJvciBvbiB0aGUgCiAgICAg ICAgIC8vIGRvY3VtZW50IGFuZCBsZXQgdGhlIHN1YnJlc291cmNlTG9hZGVycyBzZW5kIGluZGl2 aWR1YWwgY2FuY2VsbGVkIG1lc3NhZ2VzIGJlbG93LgpAQCAtMzA5LDYgKzMwMywxMiBAQCB2b2lk IERvY3VtZW50TG9hZGVyOjpzdG9wTG9hZGluZygpCiAgICAgICAgIC8vIElmIHRoZXJlIGFyZSBu byByZXNvdXJjZSBsb2FkZXJzLCB3ZSBuZWVkIHRvIG1hbnVmYWN0dXJlIGEgY2FuY2VsbGVkIG1l c3NhZ2UuCiAgICAgICAgIC8vIChBIGJhY2svZm9yd2FyZCBuYXZpZ2F0aW9uIGhhcyBubyByZXNv dXJjZSBsb2FkZXJzIGJlY2F1c2UgaXRzIHJlc291cmNlcyBhcmUgY2FjaGVkLikKICAgICAgICAg bWFpblJlY2VpdmVkRXJyb3IoZnJhbWVMb2FkZXItPmNhbmNlbGxlZEVycm9yKG1fcmVxdWVzdCkp OworCisgICAgLy8gV2UgYWx3YXlzIG5lZWQgdG8gZXhwbGljaXRseSBjYW5jZWwgdGhlIERvY3Vt ZW50J3MgcGFyc2VyIHdoZW4gc3RvcHBpbmcgdGhlIGxvYWQuCisgICAgLy8gT3RoZXJ3aXNlIGNh bmNlbGxpbmcgdGhlIHBhcnNlciB3aGlsZSBzdGFydGluZyB0aGUgbmV4dCBwYWdlIGxvYWQgbWln aHQgcmVzdWx0CisgICAgLy8gaW4gdW5leHBlY3RlZCBzaWRlIGVmZmVjdHMgc3VjaCBhcyBlcnJv bmVvdXMgZXZlbnQgZGlzcGF0Y2guICggaHR0cDovL3dlYmtpdC5vcmcvYi8xMTcxMTIgKQorICAg IGlmIChEb2N1bWVudCogZG9jID0gZG9jdW1lbnQoKSkKKyAgICAgICAgZG9jLT5jYW5jZWxQYXJz aW5nKCk7CiAgICAgCiAgICAgc3RvcExvYWRpbmdTdWJyZXNvdXJjZXMoKTsKICAgICBzdG9wTG9h ZGluZ1BsdWdJbnMoKTsK