119379 2013-07-31 23:57:37 -0700 Remove return statement in void function 2013-08-01 14:49:50 -0700 1 1 1 Unclassified WebKit WebKit2 528+ (Nightly build) Unspecified Unspecified RESOLVED FIXED P2 Normal --- 1 skyul skyul commit-queue kling oldest_to_newest 913646 0 skyul 2013-07-31 23:57:37 -0700 It does not make sense to return a value in void function. 913655 1 207902 skyul 2013-08-01 00:38:36 -0700 Created attachment 207902 Patch 913656 2 commit-queue 2013-08-01 00:40:51 -0700 Attachment 207902 did not pass style-queue: Failed to run "['Tools/Scripts/check-webkit-style', '--diff-files', u'Source/WebKit2/ChangeLog', u'Source/WebKit2/WebProcess/WebProcess.cpp']" exit_code: 1 Source/WebKit2/WebProcess/WebProcess.cpp:815: Missing spaces around >> [whitespace/operators] [3] Source/WebKit2/WebProcess/WebProcess.cpp:816: Missing spaces around >> [whitespace/operators] [3] Total errors found: 2 in 2 files If any of these errors are false positives, please file a bug against check-webkit-style. 913657 3 207902 kling 2013-08-01 00:42:59 -0700 Comment on attachment 207902 Patch This patch is incorrect. If the string is 8-bit, you will now execute the second addCharacters call as well. 913658 4 207903 skyul 2013-08-01 00:45:45 -0700 Created attachment 207903 Patch 913660 5 skyul 2013-08-01 00:47:01 -0700 (In reply to comment #3) > (From update of attachment 207902 [details]) > This patch is incorrect. > If the string is 8-bit, you will now execute the second addCharacters call as well. Thanks for the quick review. I noticed it too and uploaded a new patch. 913661 6 commit-queue 2013-08-01 00:47:55 -0700 Attachment 207903 did not pass style-queue: Failed to run "['Tools/Scripts/check-webkit-style', '--diff-files', u'Source/WebKit2/ChangeLog', u'Source/WebKit2/WebProcess/WebProcess.cpp']" exit_code: 1 Source/WebKit2/WebProcess/WebProcess.cpp:815: Missing spaces around >> [whitespace/operators] [3] Source/WebKit2/WebProcess/WebProcess.cpp:818: Missing spaces around >> [whitespace/operators] [3] Total errors found: 2 in 2 files If any of these errors are false positives, please file a bug against check-webkit-style. 913663 7 skyul 2013-08-01 00:51:33 -0700 (In reply to comment #6) > Failed to run "['Tools/Scripts/check-webkit-style', '--diff-files', u'Source/WebKit2/ChangeLog', u'Source/WebKit2/WebProcess/WebProcess.cpp']" exit_code: 1 > Source/WebKit2/WebProcess/WebProcess.cpp:815: Missing spaces around >> [whitespace/operators] [3] > Source/WebKit2/WebProcess/WebProcess.cpp:818: Missing spaces around >> [whitespace/operators] [3] > Total errors found: 2 in 2 files > > > If any of these errors are false positives, please file a bug against check-webkit-style. BTW, check-webkit-style does not recognize a template within a template (no space between ending >>). We should file a bug to fix this because now we compile everything in C++11 mode. 913879 8 207903 skyul 2013-08-01 14:49:46 -0700 Comment on attachment 207903 Patch Clearing flags on attachment: 207903 Committed r153611: <http://trac.webkit.org/changeset/153611> 913880 9 skyul 2013-08-01 14:49:50 -0700 All reviewed patches have been landed. Closing bug. 207902 2013-08-01 00:38:36 -0700 2013-08-01 00:45:41 -0700 Patch bug-119379-20130801163832.patch text/plain 1810 skyul U3VidmVyc2lvbiBSZXZpc2lvbjogMTUzNTcxCmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViS2l0Mi9D aGFuZ2VMb2cgYi9Tb3VyY2UvV2ViS2l0Mi9DaGFuZ2VMb2cKaW5kZXggNTI3NGZkYWVkY2ZhMjk2 MDRhYTEyMzEzZGQ5YWE1ZTQ1MDc2Mjk4YS4uOWE2YjlhYzlkODEzOTcxMmVkNjI2YTFkMTNkMTcx N2IzMjA0MjQ1YyAxMDA2NDQKLS0tIGEvU291cmNlL1dlYktpdDIvQ2hhbmdlTG9nCisrKyBiL1Nv dXJjZS9XZWJLaXQyL0NoYW5nZUxvZwpAQCAtMSw1ICsxLDE3IEBACiAyMDEzLTA3LTMxICBLd2Fu ZyBZdWwgU2VvICA8c2t5dWxAY29tcGFueTEwMC5uZXQ+CiAKKyAgICAgICAgUmVtb3ZlIHJldHVy biBzdGF0ZW1lbnQgaW4gdm9pZCBmdW5jdGlvbgorICAgICAgICBodHRwczovL2J1Z3Mud2Via2l0 Lm9yZy9zaG93X2J1Zy5jZ2k/aWQ9MTE5Mzc5CisKKyAgICAgICAgUmV2aWV3ZWQgYnkgTk9CT0RZ IChPT1BTISkuCisKKyAgICAgICAgSXQgZG9lcyBub3QgbWFrZSBzZW5zZSB0byByZXR1cm4gYSB2 YWx1ZSBpbiB2b2lkIGZ1bmN0aW9uLgorCisgICAgICAgICogV2ViUHJvY2Vzcy9XZWJQcm9jZXNz LmNwcDoKKyAgICAgICAgKFdlYktpdDo6YWRkQ2FzZUZvbGRlZENoYXJhY3RlcnMpOgorCisyMDEz LTA3LTMxICBLd2FuZyBZdWwgU2VvICA8c2t5dWxAY29tcGFueTEwMC5uZXQ+CisKICAgICAgICAg VXNlIGVtcHR5U3RyaW5nIGluc3RlYWQgb2YgU3RyaW5nKCIiKQogICAgICAgICBodHRwczovL2J1 Z3Mud2Via2l0Lm9yZy9zaG93X2J1Zy5jZ2k/aWQ9MTE5MzM1CiAKZGlmZiAtLWdpdCBhL1NvdXJj ZS9XZWJLaXQyL1dlYlByb2Nlc3MvV2ViUHJvY2Vzcy5jcHAgYi9Tb3VyY2UvV2ViS2l0Mi9XZWJQ cm9jZXNzL1dlYlByb2Nlc3MuY3BwCmluZGV4IGY5MTQ4YmM1YTIyN2FkNTUxMmY2ZTUzNzc2MWJh MDA3OTk4N2YyZmEuLjcxMGNjODgwMzY0Yzk3N2I0OGFhNTgwZTdkNGJkNzNlMzFhZjI2YzMgMTAw NjQ0Ci0tLSBhL1NvdXJjZS9XZWJLaXQyL1dlYlByb2Nlc3MvV2ViUHJvY2Vzcy5jcHAKKysrIGIv U291cmNlL1dlYktpdDIvV2ViUHJvY2Vzcy9XZWJQcm9jZXNzLmNwcApAQCAtODEyLDggKzgxMiw4 IEBAIHN0YXRpYyBpbmxpbmUgdm9pZCBhZGRDYXNlRm9sZGVkQ2hhcmFjdGVycyhTdHJpbmdIYXNo ZXImIGhhc2hlciwgY29uc3QgU3RyaW5nJiBzCiAgICAgaWYgKHN0cmluZy5pc0VtcHR5KCkpCiAg ICAgICAgIHJldHVybjsKICAgICBpZiAoc3RyaW5nLmlzOEJpdCgpKQotICAgICAgICByZXR1cm4g aGFzaGVyLmFkZENoYXJhY3RlcnM8TENoYXIsIENhc2VGb2xkaW5nSGFzaDo6Zm9sZENhc2U8TENo YXI+PihzdHJpbmcuY2hhcmFjdGVyczgoKSwgc3RyaW5nLmxlbmd0aCgpKTsKLSAgICByZXR1cm4g aGFzaGVyLmFkZENoYXJhY3RlcnM8VUNoYXIsIENhc2VGb2xkaW5nSGFzaDo6Zm9sZENhc2U8VUNo YXI+PihzdHJpbmcuY2hhcmFjdGVyczE2KCksIHN0cmluZy5sZW5ndGgoKSk7CisgICAgICAgIGhh c2hlci5hZGRDaGFyYWN0ZXJzPExDaGFyLCBDYXNlRm9sZGluZ0hhc2g6OmZvbGRDYXNlPExDaGFy Pj4oc3RyaW5nLmNoYXJhY3RlcnM4KCksIHN0cmluZy5sZW5ndGgoKSk7CisgICAgaGFzaGVyLmFk ZENoYXJhY3RlcnM8VUNoYXIsIENhc2VGb2xkaW5nSGFzaDo6Zm9sZENhc2U8VUNoYXI+PihzdHJp bmcuY2hhcmFjdGVyczE2KCksIHN0cmluZy5sZW5ndGgoKSk7CiB9CiAKIHN0YXRpYyB1bnNpZ25l ZCBoYXNoRm9yUGx1Z0luT3JpZ2luKGNvbnN0IFN0cmluZyYgcGFnZU9yaWdpbiwgY29uc3QgU3Ry aW5nJiBwbHVnaW5PcmlnaW4sIGNvbnN0IFN0cmluZyYgbWltZVR5cGUpCg== 207903 2013-08-01 00:45:45 -0700 2013-08-01 14:49:46 -0700 Patch bug-119379-20130801164541.patch text/plain 1866 skyul U3VidmVyc2lvbiBSZXZpc2lvbjogMTUzNTcxCmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViS2l0Mi9D aGFuZ2VMb2cgYi9Tb3VyY2UvV2ViS2l0Mi9DaGFuZ2VMb2cKaW5kZXggNTI3NGZkYWVkY2ZhMjk2 MDRhYTEyMzEzZGQ5YWE1ZTQ1MDc2Mjk4YS4uOWE2YjlhYzlkODEzOTcxMmVkNjI2YTFkMTNkMTcx N2IzMjA0MjQ1YyAxMDA2NDQKLS0tIGEvU291cmNlL1dlYktpdDIvQ2hhbmdlTG9nCisrKyBiL1Nv dXJjZS9XZWJLaXQyL0NoYW5nZUxvZwpAQCAtMSw1ICsxLDE3IEBACiAyMDEzLTA3LTMxICBLd2Fu ZyBZdWwgU2VvICA8c2t5dWxAY29tcGFueTEwMC5uZXQ+CiAKKyAgICAgICAgUmVtb3ZlIHJldHVy biBzdGF0ZW1lbnQgaW4gdm9pZCBmdW5jdGlvbgorICAgICAgICBodHRwczovL2J1Z3Mud2Via2l0 Lm9yZy9zaG93X2J1Zy5jZ2k/aWQ9MTE5Mzc5CisKKyAgICAgICAgUmV2aWV3ZWQgYnkgTk9CT0RZ IChPT1BTISkuCisKKyAgICAgICAgSXQgZG9lcyBub3QgbWFrZSBzZW5zZSB0byByZXR1cm4gYSB2 YWx1ZSBpbiB2b2lkIGZ1bmN0aW9uLgorCisgICAgICAgICogV2ViUHJvY2Vzcy9XZWJQcm9jZXNz LmNwcDoKKyAgICAgICAgKFdlYktpdDo6YWRkQ2FzZUZvbGRlZENoYXJhY3RlcnMpOgorCisyMDEz LTA3LTMxICBLd2FuZyBZdWwgU2VvICA8c2t5dWxAY29tcGFueTEwMC5uZXQ+CisKICAgICAgICAg VXNlIGVtcHR5U3RyaW5nIGluc3RlYWQgb2YgU3RyaW5nKCIiKQogICAgICAgICBodHRwczovL2J1 Z3Mud2Via2l0Lm9yZy9zaG93X2J1Zy5jZ2k/aWQ9MTE5MzM1CiAKZGlmZiAtLWdpdCBhL1NvdXJj ZS9XZWJLaXQyL1dlYlByb2Nlc3MvV2ViUHJvY2Vzcy5jcHAgYi9Tb3VyY2UvV2ViS2l0Mi9XZWJQ cm9jZXNzL1dlYlByb2Nlc3MuY3BwCmluZGV4IGY5MTQ4YmM1YTIyN2FkNTUxMmY2ZTUzNzc2MWJh MDA3OTk4N2YyZmEuLjAwYjlkNWZiZTZkY2NiMWM5ODAwODI1ODVjNDM1YTIyMTdhNDA2OWQgMTAw NjQ0Ci0tLSBhL1NvdXJjZS9XZWJLaXQyL1dlYlByb2Nlc3MvV2ViUHJvY2Vzcy5jcHAKKysrIGIv U291cmNlL1dlYktpdDIvV2ViUHJvY2Vzcy9XZWJQcm9jZXNzLmNwcApAQCAtODExLDkgKzgxMSwx MSBAQCBzdGF0aWMgaW5saW5lIHZvaWQgYWRkQ2FzZUZvbGRlZENoYXJhY3RlcnMoU3RyaW5nSGFz aGVyJiBoYXNoZXIsIGNvbnN0IFN0cmluZyYgcwogewogICAgIGlmIChzdHJpbmcuaXNFbXB0eSgp KQogICAgICAgICByZXR1cm47Ci0gICAgaWYgKHN0cmluZy5pczhCaXQoKSkKLSAgICAgICAgcmV0 dXJuIGhhc2hlci5hZGRDaGFyYWN0ZXJzPExDaGFyLCBDYXNlRm9sZGluZ0hhc2g6OmZvbGRDYXNl PExDaGFyPj4oc3RyaW5nLmNoYXJhY3RlcnM4KCksIHN0cmluZy5sZW5ndGgoKSk7Ci0gICAgcmV0 dXJuIGhhc2hlci5hZGRDaGFyYWN0ZXJzPFVDaGFyLCBDYXNlRm9sZGluZ0hhc2g6OmZvbGRDYXNl PFVDaGFyPj4oc3RyaW5nLmNoYXJhY3RlcnMxNigpLCBzdHJpbmcubGVuZ3RoKCkpOworICAgIGlm IChzdHJpbmcuaXM4Qml0KCkpIHsKKyAgICAgICAgaGFzaGVyLmFkZENoYXJhY3RlcnM8TENoYXIs IENhc2VGb2xkaW5nSGFzaDo6Zm9sZENhc2U8TENoYXI+PihzdHJpbmcuY2hhcmFjdGVyczgoKSwg c3RyaW5nLmxlbmd0aCgpKTsKKyAgICAgICAgcmV0dXJuOworICAgIH0KKyAgICBoYXNoZXIuYWRk Q2hhcmFjdGVyczxVQ2hhciwgQ2FzZUZvbGRpbmdIYXNoOjpmb2xkQ2FzZTxVQ2hhcj4+KHN0cmlu Zy5jaGFyYWN0ZXJzMTYoKSwgc3RyaW5nLmxlbmd0aCgpKTsKIH0KIAogc3RhdGljIHVuc2lnbmVk IGhhc2hGb3JQbHVnSW5PcmlnaW4oY29uc3QgU3RyaW5nJiBwYWdlT3JpZ2luLCBjb25zdCBTdHJp bmcmIHBsdWdpbk9yaWdpbiwgY29uc3QgU3RyaW5nJiBtaW1lVHlwZSkK