119373 2013-07-31 19:16:20 -0700 webkit-gtk fails to build with bison-3.0 2013-08-16 05:29:43 -0700 1 1 1 Unclassified WebKit WebKitGTK 528+ (Nightly build) Unspecified Unspecified RESOLVED FIXED P2 Normal --- 119892 1 jeremyhu zan allan.jensen commit-queue contact dino gustavo kondapallykalyan mrobinson sergio zan oldest_to_newest 913609 0 jeremyhu 2013-07-31 19:16:20 -0700 Reported at https://trac.macports.org/ticket/39923 When using the recently released bison-3.0, webkit-gtk fails to build: :info:build DerivedSources/ANGLE/glslang_tab.cpp:1785:16: error: no matching function for call to 'yylex' :info:build yychar = yylex (&yylval); :info:build ^~~~~ :info:build DerivedSources/ANGLE/glslang_tab.cpp:279:12: note: candidate function not viable: requires 2 arguments, but 1 was provided :info:build extern int yylex(YYSTYPE* yylval_param, void* yyscanner); :info:build ^ :info:build 1 error generated. :info:build make[1]: *** [DerivedSources/ANGLE/libWebCore_la-glslang_tab.lo] Error 1 :info:build make[1]: *** Waiting for unfinished jobs.... 914519 1 zan 2013-08-05 01:49:01 -0700 Confirmed. There are already generated glslang_tab.cpp and glslang_tab.h files in the ANGLE directory, produced by Bison 2.7[1]. The third-party sources have these two files regenerated with Bison 2.3, for Mac port's purposes. The GTK port regenerates these with the Bison it finds during the configuration. With Bison 3.0, the generated files are causing compilation errors. Could the GTK port switch to building the files that were generated with Bison 2.3, just like the Mac port? Also, only the GTK port generates and compiles the glslang.cpp file, so this part could possibly be removed. [1] https://code.google.com/p/angleproject/source/browse/src/compiler/glslang_tab.cpp 914653 2 208140 zan 2013-08-05 12:47:09 -0700 Created attachment 208140 Patch 914715 3 208140 gustavo 2013-08-05 15:29:34 -0700 Comment on attachment 208140 Patch LGTM 914838 4 208140 zan 2013-08-06 05:43:54 -0700 Comment on attachment 208140 Patch Clearing flags on attachment: 208140 Committed r153749: <http://trac.webkit.org/changeset/153749> 914839 5 zan 2013-08-06 05:44:00 -0700 All reviewed patches have been landed. Closing bug. 917154 6 allan.jensen 2013-08-14 09:45:52 -0700 I patched glslang.y for bison 3 in bug #119798 so after landing that you might be able to revert this patch. 917182 7 zan 2013-08-14 10:43:58 -0700 (In reply to comment #6) > I patched glslang.y for bison 3 in bug #119798 so after landing that you might be able to revert this patch. Do you perhaps plan to upstream the fix into ANGLE itself? And thanks for the notice. 917192 8 allan.jensen 2013-08-14 11:00:06 -0700 (In reply to comment #7) > (In reply to comment #6) > > I patched glslang.y for bison 3 in bug #119798 so after landing that you might be able to revert this patch. > > Do you perhaps plan to upstream the fix into ANGLE itself? > And thanks for the notice. I wasn't planning on upstreaming it, but I will take a look now. I was just trying to fix the Qt build in the cleanest possible way. 917905 9 commit-queue 2013-08-16 04:40:34 -0700 Re-opened since this is blocked by bug 119892 917927 10 zan 2013-08-16 05:29:43 -0700 The revision was merged into the webkit-2.0 branch, but should stay there as the ANGLE third-party source has been updated since the branching, so merging the source generation fix into the branch would be a bit risky. Closing again. 208140 2013-08-05 12:47:09 -0700 2013-08-06 05:43:54 -0700 Patch bug-119373-20130805124709.patch text/plain 4140 zan U3VidmVyc2lvbiBSZXZpc2lvbjogMTUzNzAzCmRpZmYgLS1naXQgYS9Tb3VyY2UvVGhpcmRQYXJ0 eS9BTkdMRS9DaGFuZ2VMb2cgYi9Tb3VyY2UvVGhpcmRQYXJ0eS9BTkdMRS9DaGFuZ2VMb2cKaW5k ZXggOGQxMTVjNTdjNDcyNTc1NTkzMjE4ZDExOGM5NWE2MzA3NjMzNDFjNi4uNDkyYjFmOTg5MzY1 OTUyNjJkMThhMjY4ZjAwZGYyZDE1MTk3ZWMzNSAxMDA2NDQKLS0tIGEvU291cmNlL1RoaXJkUGFy dHkvQU5HTEUvQ2hhbmdlTG9nCisrKyBiL1NvdXJjZS9UaGlyZFBhcnR5L0FOR0xFL0NoYW5nZUxv ZwpAQCAtMSwzICsxLDE1IEBACisyMDEzLTA4LTA1ICBaYW4gRG9iZXJzZWsgIDx6ZG9iZXJzZWtA aWdhbGlhLmNvbT4KKworICAgICAgICB3ZWJraXQtZ3RrIGZhaWxzIHRvIGJ1aWxkIHdpdGggYmlz b24tMy4wCisgICAgICAgIGh0dHBzOi8vYnVncy53ZWJraXQub3JnL3Nob3dfYnVnLmNnaT9pZD0x MTkzNzMKKworICAgICAgICBSZXZpZXdlZCBieSBOT0JPRFkgKE9PUFMhKS4KKworICAgICAgICAq IEdOVW1ha2VmaWxlLmFtOiBTdG9wIHJlbHlpbmcgb24gZ2VuZXJhdGVkIGdsc2xhbmdfdGFiLihj cHB8aCkgYW5kIGdsc2xhbmcuY3BwIHNvdXJjZXMgYXMgQmlzb24gMy4wCisgICAgICAgIHByb2R1 Y2VzIG5vbi1jb21waWxhYmxlIHNvdXJjZSBjb2RlLiBJbnN0ZWFkLCBjb21waWxlIHRoZXNlIHBy ZWdlbmVyYXRlZCBmaWxlcyBhcyB0aGV5J3JlIGluY2x1ZGVkIGluCisgICAgICAgIHRoZSB0cmVl LiBPcmlnaW5hbGx5LCB0aGUgQU5HTEUgc291cmNlIHRyZWUgcHJvdmlkZXMgdGhlc2UgZmlsZXMg YXMgZ2VuZXJhdGVkIGJ5IEJpc29uIDIuNywgYnV0IHRoZXkncmUKKyAgICAgICAgYXQgdGhlIG1v bWVudCByZWdlbmVyYXRlZCB3aXRoIEJpc29uIDIuMyB3aGVuIHRoZSB0aGlyZC1wYXJ0eSBBTkdM RSBzb3VyY2UgaXMgYmVpbmcgdXBkYXRlZC4KKwogMjAxMy0wOC0wMiAgQWxleCBDaHJpc3RlbnNl biAgPGFjaHJpc3RlbnNlbkBhcHBsZS5jb20+CiAKICAgICAgICAgU29mdCBsaW5rIEFOR0xFIG9u IFdpbmRvd3MuCmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViQ29yZS9DaGFuZ2VMb2cgYi9Tb3VyY2Uv V2ViQ29yZS9DaGFuZ2VMb2cKaW5kZXggNGM5ZWU0MTU1Y2EzOGZmNzFkYTQzMzk1M2EyNjUzZTcy OTFlYjIwMy4uMjYzZGE1NjExNzJhYjFmNmFiYTcyYWE0ZmE2YzAyM2M4MWRhOWVkZSAxMDA2NDQK LS0tIGEvU291cmNlL1dlYkNvcmUvQ2hhbmdlTG9nCisrKyBiL1NvdXJjZS9XZWJDb3JlL0NoYW5n ZUxvZwpAQCAtMSwzICsxLDEyIEBACisyMDEzLTA4LTA1ICBaYW4gRG9iZXJzZWsgIDx6ZG9iZXJz ZWtAaWdhbGlhLmNvbT4KKworICAgICAgICB3ZWJraXQtZ3RrIGZhaWxzIHRvIGJ1aWxkIHdpdGgg Ymlzb24tMy4wCisgICAgICAgIGh0dHBzOi8vYnVncy53ZWJraXQub3JnL3Nob3dfYnVnLmNnaT9p ZD0xMTkzNzMKKworICAgICAgICBSZXZpZXdlZCBieSBOT0JPRFkgKE9PUFMhKS4KKworICAgICAg ICAqIEdOVW1ha2VmaWxlLmFtOiBSZW1vdmUgcnVsZXMgZm9yIGdlbmVyYXRpbmcgQU5HTEUncyBn bHNsYW5nIHNvdXJjZSBmaWxlcyB3aXRoIEJpc29uLgorCiAyMDEzLTA4LTA1ICBNaWhhaSBUaWNh ICA8bWl0aWNhQGFkb2JlLmNvbT4KIAogICAgICAgICBbQ1NTIEJhY2tncm91bmQgQmxlbmRpbmdd IFNwZWNpZnlpbmcgYmFja2dyb3VuZC1pbWFnZSBhbmQgYmFja2dyb3VuZC1jb2xvcgpkaWZmIC0t Z2l0IGEvU291cmNlL1RoaXJkUGFydHkvQU5HTEUvR05VbWFrZWZpbGUuYW0gYi9Tb3VyY2UvVGhp cmRQYXJ0eS9BTkdMRS9HTlVtYWtlZmlsZS5hbQppbmRleCBiY2VmZDJjZDUxNjY1NWRjZDYwZTNj OTA2ZjNiZmIyYzMzM2Y1MjAwLi5mNWMxZGQ3OGY3OWYxYTE3NmM0MDRiZTE2MjI5MzQwZDViMTkx MDU2IDEwMDY0NAotLS0gYS9Tb3VyY2UvVGhpcmRQYXJ0eS9BTkdMRS9HTlVtYWtlZmlsZS5hbQor KysgYi9Tb3VyY2UvVGhpcmRQYXJ0eS9BTkdMRS9HTlVtYWtlZmlsZS5hbQpAQCAtMSw2ICsxLDkg QEAKIGlmIFVTRV9PUEVOR0wKIG5vaW5zdF9MVExJQlJBUklFUyArPSBcCiAJbGliQU5HTEUubGEK KworYW5nbGVfbGliX2Zvcl9kZXAgPSBsaWJBTkdMRS5sYQorJChhbmdsZV9saWJfZm9yX2RlcCk6 ICQoc3JjZGlyKS9Tb3VyY2UvVGhpcmRQYXJ0eS9BTkdMRS9HTlVtYWtlZmlsZS5hbQogZW5kaWYK IAogbGliQU5HTEVfbGFfQ1hYRkxBR1MgPSAkKGdsb2JhbF9jeHhmbGFncykKQEAgLTEyLDExICsx NSw2IEBAIGxpYkFOR0xFX2xhX0NQUEZMQUdTID0gXAogCS1JJChzcmNkaXIpL1NvdXJjZS9UaGly ZFBhcnR5L0FOR0xFL2luY2x1ZGUvR0xTTEFORyBcCiAJLUkkKHNyY2RpcikvU291cmNlL1RoaXJk UGFydHkvQU5HTEUvaW5jbHVkZS9LSFIKIAotbm9kaXN0X2xpYkFOR0xFX2xhX1NPVVJDRVMgPSBc Ci0JRGVyaXZlZFNvdXJjZXMvQU5HTEUvZ2xzbGFuZy5jcHAgXAotCURlcml2ZWRTb3VyY2VzL0FO R0xFL2dsc2xhbmdfdGFiLmNwcCBcCi0JRGVyaXZlZFNvdXJjZXMvQU5HTEUvZ2xzbGFuZ190YWIu aAotCiBsaWJBTkdMRV9sYV9TT1VSQ0VTID0gXAogCVNvdXJjZS9UaGlyZFBhcnR5L0FOR0xFL2lu Y2x1ZGUvRUdML2VnbC5oIFwKIAlTb3VyY2UvVGhpcmRQYXJ0eS9BTkdMRS9pbmNsdWRlL0VHTC9l Z2xwbGF0Zm9ybS5oIFwKQEAgLTUzLDYgKzUxLDkgQEAgbGliQU5HTEVfbGFfU09VUkNFUyA9IFwK IAlTb3VyY2UvVGhpcmRQYXJ0eS9BTkdMRS9zcmMvY29tcGlsZXIvRm9yTG9vcFVucm9sbC5jcHAg XAogCVNvdXJjZS9UaGlyZFBhcnR5L0FOR0xFL3NyYy9jb21waWxlci9Gb3JMb29wVW5yb2xsLmgg XAogCVNvdXJjZS9UaGlyZFBhcnR5L0FOR0xFL3NyYy9jb21waWxlci9nbHNsYW5nLmggXAorCVNv dXJjZS9UaGlyZFBhcnR5L0FOR0xFL3NyYy9jb21waWxlci9nbHNsYW5nX2xleC5jcHAgXAorCVNv dXJjZS9UaGlyZFBhcnR5L0FOR0xFL3NyYy9jb21waWxlci9nbHNsYW5nX3RhYi5jcHAgXAorCVNv dXJjZS9UaGlyZFBhcnR5L0FOR0xFL3NyYy9jb21waWxlci9nbHNsYW5nX3RhYi5oIFwKIAlTb3Vy Y2UvVGhpcmRQYXJ0eS9BTkdMRS9zcmMvY29tcGlsZXIvSGFzaE5hbWVzLmggXAogCVNvdXJjZS9U aGlyZFBhcnR5L0FOR0xFL3NyYy9jb21waWxlci9JbmZvU2luay5jcHAgXAogCVNvdXJjZS9UaGly ZFBhcnR5L0FOR0xFL3NyYy9jb21waWxlci9JbmZvU2luay5oIFwKZGlmZiAtLWdpdCBhL1NvdXJj ZS9XZWJDb3JlL0dOVW1ha2VmaWxlLmFtIGIvU291cmNlL1dlYkNvcmUvR05VbWFrZWZpbGUuYW0K aW5kZXggYWNmNGM2M2FlYjRhZWJmMTI0YmZjMDUxNGE3OTg1NTNjNDRlMjE0YS4uZjBmNDI5NDRh Mzg2ZTM5YTJmMDA0MTQ4MjVhYTAyYTZiMTdkMjM3YyAxMDA2NDQKLS0tIGEvU291cmNlL1dlYkNv cmUvR05VbWFrZWZpbGUuYW0KKysrIGIvU291cmNlL1dlYkNvcmUvR05VbWFrZWZpbGUuYW0KQEAg LTM0OSwxNCArMzQ5LDYgQEAgYXVkaW9fREFUQSA9ICQoV2ViQ29yZSkvcGxhdGZvcm0vYXVkaW8v cmVzb3VyY2VzL0NvbXBvc2l0ZS53YXYKIGRpc3RfYXVkaW9fREFUQSA9ICQoYXVkaW9fREFUQSkK IGVuZGlmICAjIEVORCBFTkFCTEVfV0VCX0FVRElPCiAKLSMgQU5HTEUgdG9rZW5pemVyICYgcGFy c2VyCi1EZXJpdmVkU291cmNlcy9BTkdMRS9nbHNsYW5nLmNwcDogU291cmNlL1RoaXJkUGFydHkv QU5HTEUvc3JjL2NvbXBpbGVyL2dsc2xhbmcubCBEZXJpdmVkU291cmNlcy9BTkdMRS9nbHNsYW5n X3RhYi5jcHAKLQkkKEFNX1ZfR0VOKSQoRkxFWCkgLS1ub2xpbmUgLS1ub3VuaXN0ZCAtLW91dGZp bGU9IiRAIiAiJDwiCi0KLURlcml2ZWRTb3VyY2VzL0FOR0xFL2dsc2xhbmdfdGFiLmNwcDogU291 cmNlL1RoaXJkUGFydHkvQU5HTEUvc3JjL2NvbXBpbGVyL2dsc2xhbmcueQotCSQoQU1fVl9HRU4p JChCSVNPTikgLS1uby1saW5lcyAtLWRlZmluZXM9IkRlcml2ZWRTb3VyY2VzL0FOR0xFL2dsc2xh bmdfdGFiLmgiIC0tc2tlbGV0b249eWFjYy5jIC0tb3V0cHV0PSIkQCIgJDwKLURlcml2ZWRTb3Vy Y2VzL0FOR0xFL2dsc2xhbmdfdGFiLmg6IERlcml2ZWRTb3VyY2VzL0FOR0xFL2dsc2xhbmdfdGFi LmNwcAotCiBJRExfUEFUSCA6PSBcCiAgICAgJChXZWJDb3JlKS9Nb2R1bGVzL2JhdHRlcnkgXAog ICAgICQoV2ViQ29yZSkvTW9kdWxlcy9maWxlc3lzdGVtIFwK