119358 2013-07-31 16:42:11 -0700 Reuse of XMLHttpRequests causes character corruption in response text 2013-12-18 19:29:00 -0800 1 1 1 Unclassified WebKit XML 528+ (Nightly build) Unspecified Unspecified RESOLVED FIXED BlinkMergeCandidate, InRadar P2 Critical --- 1 rniwa rniwa abarth andersca ap beidson commit-queue ddkilzer ggaren sam webkit-bug-importer oldest_to_newest 913534 0 rniwa 2013-07-31 16:42:11 -0700 Merge https://chromiumcodereview.appspot.com/20625004 XMLHttpRequest should clear the response encoding if it clears responseText. XMLHttpRequest did not clear the response encoding when it have should, for example, when abort() is called. This caused character corruption in responseText if we re-opened the XHR object. 913535 1 webkit-bug-importer 2013-07-31 16:42:45 -0700 <rdar://problem/14612613> 913543 2 207887 rniwa 2013-07-31 16:55:34 -0700 Created attachment 207887 Fixes the bug 913570 3 207887 commit-queue 2013-07-31 17:50:25 -0700 Comment on attachment 207887 Fixes the bug Clearing flags on attachment: 207887 Committed r153553: <http://trac.webkit.org/changeset/153553> 913571 4 commit-queue 2013-07-31 17:50:27 -0700 All reviewed patches have been landed. Closing bug. 961241 5 ddkilzer 2013-12-18 19:29:00 -0800 (In reply to comment #0) > Merge https://chromiumcodereview.appspot.com/20625004 Issue 261140: Reuse of XMLHttpRequests causes character corruption in response text https://code.google.com/p/chromium/issues/detail?id=261140 207887 2013-07-31 16:55:34 -0700 2013-07-31 17:50:25 -0700 Fixes the bug bug-119358-20130731165533.patch text/plain 5944 rniwa SW5kZXg6IFNvdXJjZS9XZWJDb3JlL0NoYW5nZUxvZwo9PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09Ci0tLSBTb3VyY2UvV2Vi Q29yZS9DaGFuZ2VMb2cJKHJldmlzaW9uIDE1MzU0NikKKysrIFNvdXJjZS9XZWJDb3JlL0NoYW5n ZUxvZwkod29ya2luZyBjb3B5KQpAQCAtMSwzICsxLDE4IEBACisyMDEzLTA3LTMxICBSeW9zdWtl IE5pd2EgIDxybml3YUB3ZWJraXQub3JnPgorCisgICAgICAgIFJldXNlIG9mIFhNTEh0dHBSZXF1 ZXN0cyBjYXVzZXMgY2hhcmFjdGVyIGNvcnJ1cHRpb24gaW4gcmVzcG9uc2UgdGV4dAorICAgICAg ICBodHRwczovL2J1Z3Mud2Via2l0Lm9yZy9zaG93X2J1Zy5jZ2k/aWQ9MTE5MzU4CisKKyAgICAg ICAgUmV2aWV3ZWQgYnkgTk9CT0RZIChPT1BTISkuCisKKyAgICAgICAgTWVyZ2UgaHR0cHM6Ly9j aHJvbWl1bS5nb29nbGVzb3VyY2UuY29tL2Nocm9taXVtL2JsaW5rLysvNjQ5NmU3YmI5YTBiNDZi Yzc5MDMyYjg2ZDU5OTNiMjVmMTI3YTRjYgorCisgICAgICAgIFRlc3Q6IGh0dHAvdGVzdHMveG1s aHR0cHJlcXVlc3QvcmVvcGVuLWVuY29kaW5nLmh0bWwKKworICAgICAgICAqIHhtbC9YTUxIdHRw UmVxdWVzdC5jcHA6CisgICAgICAgIChXZWJDb3JlOjpYTUxIdHRwUmVxdWVzdDo6Y2xlYXJSZXNw b25zZUJ1ZmZlcnMpOgorICAgICAgICAoV2ViQ29yZTo6WE1MSHR0cFJlcXVlc3Q6OmRpZEZpbmlz aExvYWRpbmcpOgorCiAyMDEzLTA3LTMxICBLd2FuZyBZdWwgU2VvICA8c2t5dWxAY29tcGFueTEw MC5uZXQ+CiAKICAgICAgICAgVXNlIGVtcHR5U3RyaW5nIGluc3RlYWQgb2YgU3RyaW5nKCIiKQpJ bmRleDogU291cmNlL1dlYkNvcmUveG1sL1hNTEh0dHBSZXF1ZXN0LmNwcAo9PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09Ci0t LSBTb3VyY2UvV2ViQ29yZS94bWwvWE1MSHR0cFJlcXVlc3QuY3BwCShyZXZpc2lvbiAxNTM1NDAp CisrKyBTb3VyY2UvV2ViQ29yZS94bWwvWE1MSHR0cFJlcXVlc3QuY3BwCSh3b3JraW5nIGNvcHkp CkBAIC04ODUsNiArODg1LDcgQEAgdm9pZCBYTUxIdHRwUmVxdWVzdDo6Y2xlYXJSZXNwb25zZSgp CiB2b2lkIFhNTEh0dHBSZXF1ZXN0OjpjbGVhclJlc3BvbnNlQnVmZmVycygpCiB7CiAgICAgbV9y ZXNwb25zZUJ1aWxkZXIuY2xlYXIoKTsKKyAgICBtX3Jlc3BvbnNlRW5jb2RpbmcgPSBTdHJpbmco KTsKICAgICBtX2NyZWF0ZWREb2N1bWVudCA9IGZhbHNlOwogICAgIG1fcmVzcG9uc2VEb2N1bWVu dCA9IDA7CiAgICAgbV9yZXNwb25zZUJsb2IgPSAwOwpAQCAtMTE0OCw2ICsxMTQ5LDcgQEAgdm9p ZCBYTUxIdHRwUmVxdWVzdDo6ZGlkRmluaXNoTG9hZGluZyh1bgogICAgIG1fbG9hZGVyID0gMDsK IAogICAgIGNoYW5nZVN0YXRlKERPTkUpOworICAgIG1fcmVzcG9uc2VFbmNvZGluZyA9IFN0cmlu ZygpOwogICAgIG1fZGVjb2RlciA9IDA7CiAKICAgICBpZiAoaGFkTG9hZGVyKQpJbmRleDogTGF5 b3V0VGVzdHMvQ2hhbmdlTG9nCj09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT0KLS0tIExheW91dFRlc3RzL0NoYW5nZUxvZwko cmV2aXNpb24gMTUzNTQ2KQorKysgTGF5b3V0VGVzdHMvQ2hhbmdlTG9nCSh3b3JraW5nIGNvcHkp CkBAIC0xLDMgKzEsMTUgQEAKKzIwMTMtMDctMzEgIFJ5b3N1a2UgTml3YSAgPHJuaXdhQHdlYmtp dC5vcmc+CisKKyAgICAgICAgUmV1c2Ugb2YgWE1MSHR0cFJlcXVlc3RzIGNhdXNlcyBjaGFyYWN0 ZXIgY29ycnVwdGlvbiBpbiByZXNwb25zZSB0ZXh0CisgICAgICAgIGh0dHBzOi8vYnVncy53ZWJr aXQub3JnL3Nob3dfYnVnLmNnaT9pZD0xMTkzNTgKKworICAgICAgICBSZXZpZXdlZCBieSBOT0JP RFkgKE9PUFMhKS4KKworICAgICAgICAqIGh0dHAvdGVzdHMveG1saHR0cHJlcXVlc3QvcmVvcGVu LWVuY29kaW5nLWV4cGVjdGVkLnR4dDogQWRkZWQuCisgICAgICAgICogaHR0cC90ZXN0cy94bWxo dHRwcmVxdWVzdC9yZW9wZW4tZW5jb2RpbmcuaHRtbDogQWRkZWQuCisgICAgICAgICogaHR0cC90 ZXN0cy94bWxodHRwcmVxdWVzdC9yZXNvdXJjZXMvZ2V0LXV0Zi04LmNnaTogQWRkZWQuCisgICAg ICAgICogaHR0cC90ZXN0cy94bWxodHRwcmVxdWVzdC9yZXNvdXJjZXMvZ2V0LXdpbmRvd3MtMTI1 MS5jZ2k6IEFkZGVkLgorCiAyMDEzLTA3LTMxICBSb2IgQnVpcyAgPHJ3bGJ1aXNAd2Via2l0Lm9y Zz4KIAogICAgICAgICBDb252ZXJ0IFNWRyB0ZXN0IGZyb20gcjE1MzQzMyB0byBhIHJlZnRlc3QK SW5kZXg6IExheW91dFRlc3RzL2h0dHAvdGVzdHMveG1saHR0cHJlcXVlc3QvcmVvcGVuLWVuY29k aW5nLWV4cGVjdGVkLnR4dAo9PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09Ci0tLSBMYXlvdXRUZXN0cy9odHRwL3Rlc3RzL3ht bGh0dHByZXF1ZXN0L3Jlb3Blbi1lbmNvZGluZy1leHBlY3RlZC50eHQJKHJldmlzaW9uIDApCisr KyBMYXlvdXRUZXN0cy9odHRwL3Rlc3RzL3htbGh0dHByZXF1ZXN0L3Jlb3Blbi1lbmNvZGluZy1l eHBlY3RlZC50eHQJKHdvcmtpbmcgY29weSkKQEAgLTAsMCArMSwxMyBAQAorVGhpcyB0ZXN0IHZl cmlmaWVzIHRoYXQgWE1MSHR0cFJlcXVlc3QgcHJvcGVybHkgaGFuZGxlcyBDb250ZW50LVR5cGUg d2hlbiBpdCBpcyByZXVzZWQuCisKK09uIHN1Y2Nlc3MsIHlvdSB3aWxsIHNlZSBhIHNlcmllcyBv ZiAiUEFTUyIgbWVzc2FnZXMsIGZvbGxvd2VkIGJ5ICJURVNUIENPTVBMRVRFIi4KKworCitQQVNT IHJlcS5nZXRSZXNwb25zZUhlYWRlcignQ29udGVudC1UeXBlJykgaXMgInRleHQvcGxhaW47IGNo YXJzZXQ9dXRmLTgiCitQQVNTIHJlcS5yZXNwb25zZVRleHQgaXMgItCf0YDQvtCy0LXRgNC60LAi CitQQVNTIHJlcS5nZXRSZXNwb25zZUhlYWRlcignQ29udGVudC1UeXBlJykgaXMgInRleHQvcGxh aW47IGNoYXJzZXQ9d2luZG93cy0xMjUxIgorUEFTUyByZXEucmVzcG9uc2VUZXh0IGlzICLQn9GA 0L7QstC10YDQutCwIgorUEFTUyBzdWNjZXNzZnVsbHlQYXJzZWQgaXMgdHJ1ZQorCitURVNUIENP TVBMRVRFCisKSW5kZXg6IExheW91dFRlc3RzL2h0dHAvdGVzdHMveG1saHR0cHJlcXVlc3QvcmVv cGVuLWVuY29kaW5nLmh0bWwKPT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PQotLS0gTGF5b3V0VGVzdHMvaHR0cC90ZXN0cy94 bWxodHRwcmVxdWVzdC9yZW9wZW4tZW5jb2RpbmcuaHRtbAkocmV2aXNpb24gMCkKKysrIExheW91 dFRlc3RzL2h0dHAvdGVzdHMveG1saHR0cHJlcXVlc3QvcmVvcGVuLWVuY29kaW5nLmh0bWwJKHdv cmtpbmcgY29weSkKQEAgLTAsMCArMSwzMCBAQAorPCFET0NUWVBFIGh0bWw+Cis8aHRtbD4KKzxo ZWFkPgorPG1ldGEgY2hhcnNldD0iVVRGLTgiPgorPC9oZWFkPgorPGJvZHk+Cis8c2NyaXB0IHNy Yz0iL2pzLXRlc3QtcmVzb3VyY2VzL2pzLXRlc3QtcHJlLmpzIj48L3NjcmlwdD4KKzxzY3JpcHQ+ CisgICAgZGVzY3JpcHRpb24oJ1RoaXMgdGVzdCB2ZXJpZmllcyB0aGF0IFhNTEh0dHBSZXF1ZXN0 IHByb3Blcmx5IGhhbmRsZXMgQ29udGVudC1UeXBlIHdoZW4gaXQgaXMgcmV1c2VkLicpOworICAg IGlmICh3aW5kb3cudGVzdFJ1bm5lcikKKyAgICAgICAgdGVzdFJ1bm5lci5kdW1wQXNUZXh0KCk7 CisKKyAgICB2YXIgcmVxID0gbmV3IFhNTEh0dHBSZXF1ZXN0OworICAgIHRyeSB7CisgICAgICAg IHJlcS5vcGVuKCJHRVQiLCAicmVzb3VyY2VzL2dldC11dGYtOC5jZ2kiLCBmYWxzZSk7CisgICAg ICAgIHJlcS5zZW5kKCk7CisgICAgICAgIHNob3VsZEJlRXF1YWxUb1N0cmluZygicmVxLmdldFJl c3BvbnNlSGVhZGVyKCdDb250ZW50LVR5cGUnKSIsICJ0ZXh0L3BsYWluOyBjaGFyc2V0PXV0Zi04 Iik7CisgICAgICAgIHNob3VsZEJlRXF1YWxUb1N0cmluZygicmVxLnJlc3BvbnNlVGV4dCIsICLQ n9GA0L7QstC10YDQutCwIik7CisgICAgICAgIHJlcS5vcGVuKCJHRVQiLCAicmVzb3VyY2VzL2dl dC13aW5kb3dzLTEyNTEuY2dpIiwgZmFsc2UpOworICAgICAgICByZXEuc2VuZCgpOworICAgICAg ICBzaG91bGRCZUVxdWFsVG9TdHJpbmcoInJlcS5nZXRSZXNwb25zZUhlYWRlcignQ29udGVudC1U eXBlJykiLCAidGV4dC9wbGFpbjsgY2hhcnNldD13aW5kb3dzLTEyNTEiKTsKKyAgICAgICAgc2hv dWxkQmVFcXVhbFRvU3RyaW5nKCJyZXEucmVzcG9uc2VUZXh0IiwgItCf0YDQvtCy0LXRgNC60LAi KTsKKyAgICAgICAgZmluaXNoSlNUZXN0KCk7CisgICAgfSBjYXRjaCAoZXgpIHsKKyAgICAgICAg ZmFpbCgiYW4gZXhjZXB0aW9uIGlzIHRocm93bjogIiArIGV4KTsKKyAgICB9Cis8L3NjcmlwdD4K KzxzY3JpcHQgc3JjPSIvanMtdGVzdC1yZXNvdXJjZXMvanMtdGVzdC1wb3N0LmpzIj48L3Njcmlw dD4KKzwvYm9keT4KKzwvaHRtbD4KSW5kZXg6IExheW91dFRlc3RzL2h0dHAvdGVzdHMveG1saHR0 cHJlcXVlc3QvcmVzb3VyY2VzL2dldC11dGYtOC5jZ2kKPT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PQotLS0gTGF5b3V0VGVz dHMvaHR0cC90ZXN0cy94bWxodHRwcmVxdWVzdC9yZXNvdXJjZXMvZ2V0LXV0Zi04LmNnaQkocmV2 aXNpb24gMCkKKysrIExheW91dFRlc3RzL2h0dHAvdGVzdHMveG1saHR0cHJlcXVlc3QvcmVzb3Vy Y2VzL2dldC11dGYtOC5jZ2kJKHdvcmtpbmcgY29weSkKQEAgLTAsMCArMSw2IEBACisjIS91c3Iv YmluL3BlcmwgLXcKK3VzZSB1dGY4OwordXNlIEVuY29kZSAnZW5jb2RlJzsKKworcHJpbnQgIkNv bnRlbnQtdHlwZTogdGV4dC9wbGFpbjsgY2hhcnNldD11dGYtOFxuXG4iOworcHJpbnQgZW5jb2Rl KCJVVEYtOCIsICLQn9GA0L7QstC10YDQutCwIik7CgpQcm9wZXJ0eSBjaGFuZ2VzIG9uOiBMYXlv dXRUZXN0cy9odHRwL3Rlc3RzL3htbGh0dHByZXF1ZXN0L3Jlc291cmNlcy9nZXQtdXRmLTguY2dp Cl9fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19f X19fX19fX19fX18KQWRkZWQ6IHN2bjpleGVjdXRhYmxlCiMjIC0wLDAgKzEgIyMKKyoKXCBObyBu ZXdsaW5lIGF0IGVuZCBvZiBwcm9wZXJ0eQpJbmRleDogTGF5b3V0VGVzdHMvaHR0cC90ZXN0cy94 bWxodHRwcmVxdWVzdC9yZXNvdXJjZXMvZ2V0LXdpbmRvd3MtMTI1MS5jZ2kKPT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PQot LS0gTGF5b3V0VGVzdHMvaHR0cC90ZXN0cy94bWxodHRwcmVxdWVzdC9yZXNvdXJjZXMvZ2V0LXdp bmRvd3MtMTI1MS5jZ2kJKHJldmlzaW9uIDApCisrKyBMYXlvdXRUZXN0cy9odHRwL3Rlc3RzL3ht bGh0dHByZXF1ZXN0L3Jlc291cmNlcy9nZXQtd2luZG93cy0xMjUxLmNnaQkod29ya2luZyBjb3B5 KQpAQCAtMCwwICsxLDYgQEAKKyMhL3Vzci9iaW4vcGVybCAtdwordXNlIHV0Zjg7Cit1c2UgRW5j b2RlICdlbmNvZGUnOworCitwcmludCAiQ29udGVudC10eXBlOiB0ZXh0L3BsYWluOyBjaGFyc2V0 PXdpbmRvd3MtMTI1MVxuXG4iOworcHJpbnQgZW5jb2RlKCJ3aW5kb3dzLTEyNTEiLCAi0J/RgNC+ 0LLQtdGA0LrQsCIpOwoKUHJvcGVydHkgY2hhbmdlcyBvbjogTGF5b3V0VGVzdHMvaHR0cC90ZXN0 cy94bWxodHRwcmVxdWVzdC9yZXNvdXJjZXMvZ2V0LXdpbmRvd3MtMTI1MS5jZ2kKX19fX19fX19f X19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19f XwpBZGRlZDogc3ZuOmV4ZWN1dGFibGUKIyMgLTAsMCArMSAjIworKgpcIE5vIG5ld2xpbmUgYXQg ZW5kIG9mIHByb3BlcnR5Cg==