119349 2013-07-31 12:50:09 -0700 DFG doesn't account for inlining of functions with switch statements that haven't been executed by the baseline JIT 2022-02-12 20:01:32 -0800 1 1 1 Unclassified WebKit JavaScriptCore 528+ (Nightly build) Unspecified Unspecified RESOLVED FIXED InRadar P2 Normal --- 1 mhahnenberg mhahnenberg rniwa webkit-bug-importer oldest_to_newest 913464 0 mhahnenberg 2013-07-31 12:50:09 -0700 The baseline JIT is currently responsible for resizing the ctiOffsets Vector for SimpleJumpTables to be equal to the size of the branchOffsets Vector. If the DFG chooses to inline a function that has never been compiled by the baseline JIT then this resizing never happens and we crash at link time in the DFG. We can fix this by doing the resize in the DFG as well to catch this case. 913466 1 207873 mhahnenberg 2013-07-31 12:52:58 -0700 Created attachment 207873 Patch 913467 2 webkit-bug-importer 2013-07-31 12:53:45 -0700 <rdar://problem/14608744> 913471 3 207873 ggaren 2013-07-31 13:12:13 -0700 Comment on attachment 207873 Patch r=me 913474 4 mhahnenberg 2013-07-31 13:23:10 -0700 Committed r153540: <http://trac.webkit.org/changeset/153540> 1840837 5 bfulgham 2022-02-12 20:01:32 -0800 *** Bug 119224 has been marked as a duplicate of this bug. *** 207873 2013-07-31 12:52:58 -0700 2013-07-31 13:12:12 -0700 Patch bug-119349-20130731125701.patch text/plain 4535 mhahnenberg SW5kZXg6IFNvdXJjZS9KYXZhU2NyaXB0Q29yZS9DaGFuZ2VMb2cKPT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PQotLS0gU291 cmNlL0phdmFTY3JpcHRDb3JlL0NoYW5nZUxvZwkocmV2aXNpb24gMTUzNTM4KQorKysgU291cmNl L0phdmFTY3JpcHRDb3JlL0NoYW5nZUxvZwkod29ya2luZyBjb3B5KQpAQCAtMSwzICsxLDIxIEBA CisyMDEzLTA3LTMxICBNYXJrIEhhaG5lbmJlcmcgIDxtaGFobmVuYmVyZ0BhcHBsZS5jb20+CisK KyAgICAgICAgREZHIGRvZXNuJ3QgYWNjb3VudCBmb3IgaW5saW5pbmcgb2YgZnVuY3Rpb25zIHdp dGggc3dpdGNoIHN0YXRlbWVudHMgdGhhdCBoYXZlbid0IGJlZW4gZXhlY3V0ZWQgYnkgdGhlIGJh c2VsaW5lIEpJVAorICAgICAgICBodHRwczovL2J1Z3Mud2Via2l0Lm9yZy9zaG93X2J1Zy5jZ2k/ aWQ9MTE5MzQ5CisKKyAgICAgICAgUmV2aWV3ZWQgYnkgTk9CT0RZIChPT1BTISkuCisKKyAgICAg ICAgUHJpb3IgdG8gdGhpcyBwYXRjaCwgdGhlIGJhc2VsaW5lIEpJVCB3YXMgcmVzcG9uc2libGUg Zm9yIHJlc2l6aW5nIHRoZSBjdGlPZmZzZXRzIFZlY3RvciBmb3IgCisgICAgICAgIFNpbXBsZUp1 bXBUYWJsZXMgdG8gYmUgZXF1YWwgdG8gdGhlIHNpemUgb2YgdGhlIGJyYW5jaE9mZnNldHMgVmVj dG9yLiBUaGUgREZHIGltcGxpY2l0bHkgcmVsaWVkCisgICAgICAgIG9uIGNvZGUgaXQgY29tcGls ZWQgd2l0aCBhbnkgc3dpdGNoIHN0YXRlbWVudHMgdG8gaGF2ZSBiZWVuIHJ1biBpbiB0aGUgYmFz ZWxpbmUgSklUIGZpcnN0LiAKKyAgICAgICAgSG93ZXZlciwgaWYgdGhlIERGRyBjaG9vc2VzIHRv IGlubGluZSBhIGZ1bmN0aW9uIHRoYXQgaGFzIG5ldmVyIGJlZW4gY29tcGlsZWQgYnkgdGhlIGJh c2VsaW5lIAorICAgICAgICBKSVQgdGhlbiB0aGlzIHJlc2l6aW5nIG5ldmVyIGhhcHBlbnMgYW5k IHdlIGNyYXNoIGF0IGxpbmsgdGltZSBpbiB0aGUgREZHLgorCisgICAgICAgIFdlIGNhbiBmaXgg dGhpcyBieSBhbHNvIGRvaW5nIHRoZSByZXNpemUgaW4gdGhlIERGRyB0byBjYXRjaCB0aGlzIGNh c2UuCisKKyAgICAgICAgKiBkZmcvREZHSklUQ29tcGlsZXIuY3BwOgorICAgICAgICAoSlNDOjpE Rkc6OkpJVENvbXBpbGVyOjpsaW5rKToKKwogMjAxMy0wNy0zMSAgR2F2aW4gQmFycmFjbG91Z2gg IDxiYXJyYWNsb3VnaEBhcHBsZS5jb20+CiAKICAgICAgICAgU3BlY3VsYXRpdmUgV2luZG93cyBi dWlsZCBmaXguCkluZGV4OiBTb3VyY2UvSmF2YVNjcmlwdENvcmUvZGZnL0RGR0pJVENvbXBpbGVy LmNwcAo9PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09Ci0tLSBTb3VyY2UvSmF2YVNjcmlwdENvcmUvZGZnL0RGR0pJVENvbXBp bGVyLmNwcAkocmV2aXNpb24gMTUzNTAyKQorKysgU291cmNlL0phdmFTY3JpcHRDb3JlL2RmZy9E RkdKSVRDb21waWxlci5jcHAJKHdvcmtpbmcgY29weSkKQEAgLTE3MSw2ICsxNzEsNyBAQCB2b2lk IEpJVENvbXBpbGVyOjpsaW5rKExpbmtCdWZmZXImIGxpbmtCCiAgICAgICAgIHVzZWRKdW1wVGFi bGVzLnNldChkYXRhLnN3aXRjaFRhYmxlSW5kZXgpOwogICAgICAgICBTaW1wbGVKdW1wVGFibGUm IHRhYmxlID0gbV9jb2RlQmxvY2stPnN3aXRjaEp1bXBUYWJsZShkYXRhLnN3aXRjaFRhYmxlSW5k ZXgpOwogICAgICAgICB0YWJsZS5jdGlEZWZhdWx0ID0gbGlua0J1ZmZlci5sb2NhdGlvbk9mKG1f YmxvY2tIZWFkc1tkYXRhLmZhbGxUaHJvdWdoLT5pbmRleF0pOworICAgICAgICB0YWJsZS5jdGlP ZmZzZXRzLmdyb3codGFibGUuYnJhbmNoT2Zmc2V0cy5zaXplKCkpOwogICAgICAgICBmb3IgKHVu c2lnbmVkIGogPSB0YWJsZS5jdGlPZmZzZXRzLnNpemUoKTsgai0tOykKICAgICAgICAgICAgIHRh YmxlLmN0aU9mZnNldHNbal0gPSB0YWJsZS5jdGlEZWZhdWx0OwogICAgICAgICBmb3IgKHVuc2ln bmVkIGogPSBkYXRhLmNhc2VzLnNpemUoKTsgai0tOykgewpJbmRleDogTGF5b3V0VGVzdHMvQ2hh bmdlTG9nCj09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT0KLS0tIExheW91dFRlc3RzL0NoYW5nZUxvZwkocmV2aXNpb24gMTUz NTM4KQorKysgTGF5b3V0VGVzdHMvQ2hhbmdlTG9nCSh3b3JraW5nIGNvcHkpCkBAIC0xLDMgKzEs MTYgQEAKKzIwMTMtMDctMzEgIE1hcmsgSGFobmVuYmVyZyAgPG1oYWhuZW5iZXJnQGFwcGxlLmNv bT4KKworICAgICAgICBERkcgZG9lc24ndCBhY2NvdW50IGZvciBpbmxpbmluZyBvZiBmdW5jdGlv bnMgd2l0aCBzd2l0Y2ggc3RhdGVtZW50cyB0aGF0IGhhdmVuJ3QgYmVlbiBleGVjdXRlZCBieSB0 aGUgYmFzZWxpbmUgSklUCisgICAgICAgIGh0dHBzOi8vYnVncy53ZWJraXQub3JnL3Nob3dfYnVn LmNnaT9pZD0xMTkzNDkKKworICAgICAgICBSZXZpZXdlZCBieSBOT0JPRFkgKE9PUFMhKS4KKwor ICAgICAgICAqIGZhc3QvanMvZGZnLWlubGluZS1zd2l0Y2gtaW1tLWV4cGVjdGVkLnR4dDogQWRk ZWQuCisgICAgICAgICogZmFzdC9qcy9kZmctaW5saW5lLXN3aXRjaC1pbW0uaHRtbDogQWRkZWQu CisgICAgICAgICogZmFzdC9qcy9zY3JpcHQtdGVzdHMvZGZnLWlubGluZS1zd2l0Y2gtaW1tLmpz OiBBZGRlZC4KKyAgICAgICAgKGZvbyk6CisgICAgICAgIChiYXIpOgorCiAyMDEzLTA3LTMxICBU aW0gSG9ydG9uICA8dGltb3RoeV9ob3J0b25AYXBwbGUuY29tPgogCiAgICAgICAgIFJlbmRlckVt YmVkZGVkT2JqZWN0Ojppc1JlcGxhY2VtZW50T2JzY3VyZWQgaXMgd3JvbmcgaWYgYW4gb2JzY3Vy aW5nIGVsZW1lbnQgaGFzIHBvaW50ZXItZXZlbnRzOiBub25lIHNldApJbmRleDogTGF5b3V0VGVz dHMvZmFzdC9qcy9kZmctaW5saW5lLXN3aXRjaC1pbW0tZXhwZWN0ZWQudHh0Cj09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT0K LS0tIExheW91dFRlc3RzL2Zhc3QvanMvZGZnLWlubGluZS1zd2l0Y2gtaW1tLWV4cGVjdGVkLnR4 dAkocmV2aXNpb24gMCkKKysrIExheW91dFRlc3RzL2Zhc3QvanMvZGZnLWlubGluZS1zd2l0Y2gt aW1tLWV4cGVjdGVkLnR4dAkod29ya2luZyBjb3B5KQpAQCAtMCwwICsxLDQgQEAKK1BBU1Mgc3Vj Y2Vzc2Z1bGx5UGFyc2VkIGlzIHRydWUKKworVEVTVCBDT01QTEVURQorCkluZGV4OiBMYXlvdXRU ZXN0cy9mYXN0L2pzL2RmZy1pbmxpbmUtc3dpdGNoLWltbS5odG1sCj09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT0KLS0tIExh eW91dFRlc3RzL2Zhc3QvanMvZGZnLWlubGluZS1zd2l0Y2gtaW1tLmh0bWwJKHJldmlzaW9uIDAp CisrKyBMYXlvdXRUZXN0cy9mYXN0L2pzL2RmZy1pbmxpbmUtc3dpdGNoLWltbS5odG1sCSh3b3Jr aW5nIGNvcHkpCkBAIC0wLDAgKzEsMTAgQEAKKzwhRE9DVFlQRSBIVE1MIFBVQkxJQyAiLS8vSUVU Ri8vRFREIEhUTUwvL0VOIj4KKzxodG1sPgorPGhlYWQ+Cis8c2NyaXB0IHNyYz0icmVzb3VyY2Vz L2pzLXRlc3QtcHJlLmpzIj48L3NjcmlwdD4KKzwvaGVhZD4KKzxib2R5PgorPHNjcmlwdCBzcmM9 InNjcmlwdC10ZXN0cy9kZmctaW5saW5lLXN3aXRjaC1pbW0uanMiPjwvc2NyaXB0PgorPHNjcmlw dCBzcmM9InJlc291cmNlcy9qcy10ZXN0LXBvc3QuanMiPjwvc2NyaXB0PgorPC9ib2R5PgorPC9o dG1sPgpJbmRleDogTGF5b3V0VGVzdHMvZmFzdC9qcy9zY3JpcHQtdGVzdHMvZGZnLWlubGluZS1z d2l0Y2gtaW1tLmpzCj09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT0KLS0tIExheW91dFRlc3RzL2Zhc3QvanMvc2NyaXB0LXRl c3RzL2RmZy1pbmxpbmUtc3dpdGNoLWltbS5qcwkocmV2aXNpb24gMCkKKysrIExheW91dFRlc3Rz L2Zhc3QvanMvc2NyaXB0LXRlc3RzL2RmZy1pbmxpbmUtc3dpdGNoLWltbS5qcwkod29ya2luZyBj b3B5KQpAQCAtMCwwICsxLDMzIEBACitmdW5jdGlvbiBmb28oYSkgeworICAgIHN3aXRjaCAoYSkg eworICAgIGNhc2UgMDoKKyAgICAgICAgcmV0dXJuIDA7CisgICAgY2FzZSAxOgorICAgICAgICBy ZXR1cm4gMTsKKyAgICBjYXNlIDI6CisgICAgICAgIHJldHVybiAyOworICAgIGRlZmF1bHQ6Cisg ICAgICAgIHJldHVybiAzOworICAgIH0KK30KKworZnVuY3Rpb24gYmFyKGEsIHJ1bkZvbykgewor ICAgIGlmIChydW5Gb28pCisgICAgICAgIHJldHVybiBmb28oYSk7CisgICAgcmV0dXJuIDA7Cit9 CisKK25vSW5saW5lKGJhcik7CisKK3ZhciBzdW0gPSAwOworCitmb3IgKHZhciBpID0gMDsgaSA8 IDU7IGkrKykKKyAgICBzdW0gKz0gYmFyKGksIHRydWUpOworCit2YXIgaSA9IDA7Cit3aGlsZSAo IWRmZ0NvbXBpbGVkKHtmOmJhcn0pKSB7CisgICAgc3VtICs9IGJhcihpLCBmYWxzZSk7CisgICAg aSsrOworfQorCitzdW0gKz0gYmFyKGksIHRydWUpOwo=