119336 2013-07-31 05:03:00 -0700 [Qt] ASSERTS trigger in release builds 2013-07-31 06:47:49 -0700 1 1 1 Unclassified WebKit WebKit Qt 528+ (Nightly build) Unspecified Unspecified RESOLVED FIXED P2 Normal --- 1 allan.jensen allan.jensen abecsi commit-queue jturcotte vestbo oldest_to_newest 913301 0 allan.jensen 2013-07-31 05:03:00 -0700 Recently I have started hitting asserts when doing debug_and_release or release builds. It appears NDEBUG is not defined. 913303 1 207838 allan.jensen 2013-07-31 05:06:13 -0700 Created attachment 207838 Patch 913307 2 207838 allan.jensen 2013-07-31 05:20:28 -0700 Comment on attachment 207838 Patch I am being told this is wrong, and the old test should still work. 913310 3 allan.jensen 2013-07-31 05:32:33 -0700 It seems the build can end up being neither release nor debug according to qmake. 913311 4 207841 allan.jensen 2013-07-31 05:36:20 -0700 Created attachment 207841 Patch 913321 5 207841 allan.jensen 2013-07-31 05:48:33 -0700 Comment on attachment 207841 Patch Clearing flags on attachment: 207841 Committed r153519: <http://trac.webkit.org/changeset/153519> 913322 6 allan.jensen 2013-07-31 05:48:38 -0700 All reviewed patches have been landed. Closing bug. 913357 7 207841 vestbo 2013-07-31 06:47:49 -0700 Comment on attachment 207841 Patch View in context: https://bugs.webkit.org/attachment.cgi?id=207841&action=review > Tools/qmake/mkspecs/features/default_post.prf:32 > + !debug:!release: CONFIG += release This seems dubious. Why are we missing a config in the first place? 207838 2013-07-31 05:06:13 -0700 2013-07-31 05:36:16 -0700 Patch bug-119336-20130731140612.patch text/plain 1258 allan.jensen U3VidmVyc2lvbiBSZXZpc2lvbjogMTUzNTE1CmRpZmYgLS1naXQgYS9Ub29scy9DaGFuZ2VMb2cg Yi9Ub29scy9DaGFuZ2VMb2cKaW5kZXggZDNhODNkM2JjZWE1NmM4M2ViNTExMTdhMWYyOWNlMDAx M2VmNDI5My4uOWJmNjgyY2Q5MmZlYmVmNTQzYWZjYzViN2RkZWY5ODYyODEyYTdlNCAxMDA2NDQK LS0tIGEvVG9vbHMvQ2hhbmdlTG9nCisrKyBiL1Rvb2xzL0NoYW5nZUxvZwpAQCAtMSwzICsxLDE1 IEBACisyMDEzLTA3LTMxICBBbGxhbiBTYW5kZmVsZCBKZW5zZW4gIDxhbGxhbi5qZW5zZW5AZGln aWEuY29tPgorCisgICAgICAgIFtRdF0gQVNTRVJUUyB0cmlnZ2VyIGluIHJlbGVhc2UgYnVpbGRz CisgICAgICAgIGh0dHBzOi8vYnVncy53ZWJraXQub3JnL3Nob3dfYnVnLmNnaT9pZD0xMTkzMzYK KworICAgICAgICBSZXZpZXdlZCBieSBOT0JPRFkgKE9PUFMhKS4KKworICAgICAgICBUaGUgb2xk IHRlc3Qgbm8gbG9uZ2VyIHdvcmtzLCBzbyBqdXN0IHRlc3Qgd2UgaGF2ZSBhIGJ1aWxkIHdpdGgg cmVsZWFzZSBDT05GSUcsCisgICAgICAgIHNpbmNlIHRoaXMgYWxzbyBjb3ZlcnMgZGVidWdfYW5k X3JlbGVhc2UuCisKKyAgICAgICAgKiBxbWFrZS9ta3NwZWNzL2ZlYXR1cmVzL2RlZmF1bHRfcG9z dC5wcmY6CisKIDIwMTMtMDctMzAgIFJ1dGggRm9uZyAgPHJ1dGhfZm9uZ0BhcHBsZS5jb20+CiAK ICAgICAgICAgVW5yZXZpZXdlZDogQWRkaW5nIG15c2VsZiB0byB0aGUgY29tbWl0dGVycycgbGlz dC4KZGlmZiAtLWdpdCBhL1Rvb2xzL3FtYWtlL21rc3BlY3MvZmVhdHVyZXMvZGVmYXVsdF9wb3N0 LnByZiBiL1Rvb2xzL3FtYWtlL21rc3BlY3MvZmVhdHVyZXMvZGVmYXVsdF9wb3N0LnByZgppbmRl eCA2ZWZiMDg5OTA2YTA0ZGY3YTUyNmQ3NGFiMTQ3ODg4NzI1YzcyNDQyLi5hMmI4OWRmYTcyZWY1 ZDFhNDQxMjcwZGYxZTVmMGUyYzgxYjlmODQ3IDEwMDY0NAotLS0gYS9Ub29scy9xbWFrZS9ta3Nw ZWNzL2ZlYXR1cmVzL2RlZmF1bHRfcG9zdC5wcmYKKysrIGIvVG9vbHMvcW1ha2UvbWtzcGVjcy9m ZWF0dXJlcy9kZWZhdWx0X3Bvc3QucHJmCkBAIC0zOCw3ICszOCw3IEBAIHJvb3RfcHJvamVjdF9m aWxlOiBmaW5hbGl6ZUNvbmZpZ3VyZSgpCiBERUZJTkVTICs9IFwKICAgICBCVUlMRElOR19RVF9f PTEKIAotQ09ORklHKHJlbGVhc2UsIGRlYnVnfHJlbGVhc2UpOiBERUZJTkVTICo9IE5ERUJVRwor cmVsZWFzZTogREVGSU5FUyAqPSBOREVCVUcKIAogREVGSU5FUyArPSAkJGNvbmZpZ0RlZmluZXMo KQogCg== 207841 2013-07-31 05:36:20 -0700 2013-07-31 06:47:49 -0700 Patch bug-119336-20130731143618.patch text/plain 1589 allan.jensen U3VidmVyc2lvbiBSZXZpc2lvbjogMTUzNTE1CmRpZmYgLS1naXQgYS9Ub29scy9DaGFuZ2VMb2cg Yi9Ub29scy9DaGFuZ2VMb2cKaW5kZXggZDNhODNkM2JjZWE1NmM4M2ViNTExMTdhMWYyOWNlMDAx M2VmNDI5My4uMjM1ZGMzOWQzYmExN2M0NWY1NWUxMjlmZWNmOGJlNDllYTdlNDM5MyAxMDA2NDQK LS0tIGEvVG9vbHMvQ2hhbmdlTG9nCisrKyBiL1Rvb2xzL0NoYW5nZUxvZwpAQCAtMSwzICsxLDE0 IEBACisyMDEzLTA3LTMxICBBbGxhbiBTYW5kZmVsZCBKZW5zZW4gIDxhbGxhbi5qZW5zZW5AZGln aWEuY29tPgorCisgICAgICAgIFtRdF0gQVNTRVJUUyB0cmlnZ2VyIGluIHJlbGVhc2UgYnVpbGRz CisgICAgICAgIGh0dHBzOi8vYnVncy53ZWJraXQub3JnL3Nob3dfYnVnLmNnaT9pZD0xMTkzMzYK KworICAgICAgICBSZXZpZXdlZCBieSBOT0JPRFkgKE9PUFMhKS4KKworICAgICAgICBFbnN1cmUg dGhlIHFtYWtlIGFsc28gZGVmYXVsdHMgdG8gcmVsZWFzZSBpZiBubyBjb25maWd1cmF0aW9uIGlz IGtub3duLgorCisgICAgICAgICogcW1ha2UvbWtzcGVjcy9mZWF0dXJlcy9kZWZhdWx0X3Bvc3Qu cHJmOgorCiAyMDEzLTA3LTMwICBSdXRoIEZvbmcgIDxydXRoX2ZvbmdAYXBwbGUuY29tPgogCiAg ICAgICAgIFVucmV2aWV3ZWQ6IEFkZGluZyBteXNlbGYgdG8gdGhlIGNvbW1pdHRlcnMnIGxpc3Qu CmRpZmYgLS1naXQgYS9Ub29scy9xbWFrZS9ta3NwZWNzL2ZlYXR1cmVzL2RlZmF1bHRfcG9zdC5w cmYgYi9Ub29scy9xbWFrZS9ta3NwZWNzL2ZlYXR1cmVzL2RlZmF1bHRfcG9zdC5wcmYKaW5kZXgg NmVmYjA4OTkwNmEwNGRmN2E1MjZkNzRhYjE0Nzg4ODcyNWM3MjQ0Mi4uNmZhZTIyZmEzOGFjYmQ5 ZDk3MjUwZDZhZTBmMzllZTg0NmM4ZGNkNiAxMDA2NDQKLS0tIGEvVG9vbHMvcW1ha2UvbWtzcGVj cy9mZWF0dXJlcy9kZWZhdWx0X3Bvc3QucHJmCisrKyBiL1Rvb2xzL3FtYWtlL21rc3BlY3MvZmVh dHVyZXMvZGVmYXVsdF9wb3N0LnByZgpAQCAtMjYsNyArMjYsMTEgQEAgcm9vdF9wcm9qZWN0X2Zp bGU6IGZpbmFsaXplQ29uZmlndXJlKCkKICAgICAjIFJlbW92aW5nIGRlYnVnX2FuZF9yZWxlYXNl IGNhdXNlcyBpc3N1ZXMgd2l0aCBsaWIgc3VmZml4ZXMgd2hlbiBidWlsZGluZyBkZWJ1ZyBvbiBX aW5kb3dzLgogICAgICMgV29yayBhcm91bmQgaXQgYnkgb25seSByZW1vdmluZyBidWlsZF9hbGws IGFuZCBzdGlsbCBjcmVhdGUgdGhlIE1ha2VmaWxlcyBmb3IgYm90aCBjb25maWd1cmF0aW9ucy4K ICAgICB3aW4zMio6IENPTkZJRyAtPSBidWlsZF9hbGwKLSAgICBlbHNlOiBDT05GSUcgLT0gZGVi dWdfYW5kX3JlbGVhc2UKKyAgICBlbHNlOiB7CisgICAgICAgIENPTkZJRyAtPSBkZWJ1Z19hbmRf cmVsZWFzZQorICAgICAgICAjIERlZmF1bHQgdG8gcmVsZWFzZQorICAgICAgICAhZGVidWc6IXJl bGVhc2U6IENPTkZJRyArPSByZWxlYXNlCisgICAgfQogfSBlbHNlOmRlYnVnX2FuZF9yZWxlYXNl IHsKICAgICAjIE9ubHkgYnVpbGQgYSBzaW5nbGUgaW5zdGFuY2Ugb2YgZWFjaCBhcHBsaWNhdGlv bgogICAgIGNvbnRhaW5zKFRFTVBMQVRFLCBhcHApOiFmb3JjZV9idWlsZF9hbGwgewo=