11933 2006-12-22 10:35:26 -0800 REGRESSION: trying to change a property in a computed style declaration results in a crash 2006-12-23 23:24:59 -0800 1 1 1 Unclassified WebKit CSS 420+ Mac OS X 10.4 RESOLVED FIXED Regression P1 Normal --- 1 ap ap ggaren oldest_to_newest 40515 0 ap 2006-12-22 10:35:26 -0800 Patch forthcoming. 40475 1 11971 ap 2006-12-22 11:31:22 -0800 Created attachment 11971 proposed fix 40352 2 11971 ggaren 2006-12-22 14:40:35 -0800 Comment on attachment 11971 proposed fix r=me 40351 3 ggaren 2006-12-22 14:41:28 -0800 That assertion has proven helpful in the past, so it might be useful to assert "has stylesheet or is computedStyleDeclaration." Just a thought. 40255 4 ap 2006-12-22 22:25:12 -0800 (In reply to comment #3) > That assertion has proven helpful in the past, so it might be useful to assert > "has stylesheet or is computedStyleDeclaration." Just a thought. I also thought so, but couldn't find any way to tell that a style declaration is a computed one. Is there any? Adding a new virtual function for the sake of an assertion seemed a bit too much to me. 40249 5 ggaren 2006-12-22 22:41:22 -0800 Agreed. 40250 6 ggaren 2006-12-22 22:41:42 -0800 I can't see a good way to do what I suggested. 39964 7 ap 2006-12-23 23:24:59 -0800 Committed revision 18406, although this code will be rewritten soon, because enabling exceptions for invalid CSS turned out to be too dangerous for compatibility. 11971 2006-12-22 11:31:22 -0800 2006-12-22 14:40:35 -0800 proposed fix 11933r1_patch.txt text/plain 5502 ap SW5kZXg6IExheW91dFRlc3RzL0NoYW5nZUxvZwo9PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09Ci0tLSBMYXlvdXRUZXN0cy9D aGFuZ2VMb2cJKHJldmlzaW9uIDE4MzkxKQorKysgTGF5b3V0VGVzdHMvQ2hhbmdlTG9nCSh3b3Jr aW5nIGNvcHkpCkBAIC0xLDMgKzEsMTMgQEAKKzIwMDYtMTItMjIgIEFsZXhleSBQcm9za3VyeWFr b3YgIDxhcEB3ZWJraXQub3JnPgorCisgICAgICAgIFJldmlld2VkIGJ5IE5PQk9EWSAoT09QUyEp LgorCisgICAgICAgIFRlc3QgZm9yIGh0dHA6Ly9idWdzLndlYmtpdC5vcmcvc2hvd19idWcuY2dp P2lkPTExOTMzCisgICAgICAgIFJFR1JFU1NJT046IHRyeWluZyB0byBjaGFuZ2UgYSBwcm9wZXJ0 eSBpbiBhIGNvbXB1dGVkIHN0eWxlIGRlY2xhcmF0aW9uIHJlc3VsdHMgaW4gYSBjcmFzaAorCisg ICAgICAgICogZmFzdC9kb20vY29tcHV0ZWQtc3R5bGUtc2V0LXByb3BlcnR5LWV4cGVjdGVkLnR4 dDogQWRkZWQuCisgICAgICAgICogZmFzdC9kb20vY29tcHV0ZWQtc3R5bGUtc2V0LXByb3BlcnR5 Lmh0bWw6IEFkZGVkLgorCiAyMDA2LTEyLTIyICBFcmljIFNlaWRlbCAgPGVyaWNAd2Via2l0Lm9y Zz4KIAogICAgICAgICBSZXZpZXdlZCBieSBhcm9iZW4uCkluZGV4OiBMYXlvdXRUZXN0cy9mYXN0 L2RvbS9jb21wdXRlZC1zdHlsZS1zZXQtcHJvcGVydHktZXhwZWN0ZWQudHh0Cj09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT0K LS0tIExheW91dFRlc3RzL2Zhc3QvZG9tL2NvbXB1dGVkLXN0eWxlLXNldC1wcm9wZXJ0eS1leHBl Y3RlZC50eHQJKHJldmlzaW9uIDApCisrKyBMYXlvdXRUZXN0cy9mYXN0L2RvbS9jb21wdXRlZC1z dHlsZS1zZXQtcHJvcGVydHktZXhwZWN0ZWQudHh0CShyZXZpc2lvbiAwKQpAQCAtMCwwICsxLDYg QEAKK1lvdSBzaG91bGQgc2VlIHR3byAiUEFTUyIgbWVzc2FnZXMgYmVsb3c6CisKK0NvbXB1dGVk IHN0eWxlIHBhcmVudCAoc2hvdWxkIGJlIG51bGwpOiBudWxsCitQQVNTOiBnb3QgYW4gZXhjZXB0 aW9uIHdoZW4gdHJ5aW5nIHRvIGNoYW5nZSBhIGNvbXB1dGVkIHN0eWxlIGRlY2xhcmF0aW9uLCBF cnJvcjogTk9fTU9ESUZJQ0FUSU9OX0FMTE9XRURfRVJSOiBET00gRXhjZXB0aW9uIDcKKworUEFT UzogZ290IGFuIGV4Y2VwdGlvbiB3aGVuIHRyeWluZyB0byBjaGFuZ2UgYSBjb21wdXRlZCBzdHls ZSBkZWNsYXJhdGlvbiB2aWEgc2V0UHJvcGVydHksIEVycm9yOiBOT19NT0RJRklDQVRJT05fQUxM T1dFRF9FUlI6IERPTSBFeGNlcHRpb24gNwoKUHJvcGVydHkgY2hhbmdlcyBvbjogTGF5b3V0VGVz dHMvZmFzdC9kb20vY29tcHV0ZWQtc3R5bGUtc2V0LXByb3BlcnR5LWV4cGVjdGVkLnR4dApfX19f X19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19f X19fX19fCk5hbWU6IHN2bjptaW1lLXR5cGUKICAgKyB0ZXh0L3BsYWluCk5hbWU6IHN2bjplb2wt c3R5bGUKICAgKyBuYXRpdmUKCkluZGV4OiBMYXlvdXRUZXN0cy9mYXN0L2RvbS9jb21wdXRlZC1z dHlsZS1zZXQtcHJvcGVydHkuaHRtbAo9PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09Ci0tLSBMYXlvdXRUZXN0cy9mYXN0L2Rv bS9jb21wdXRlZC1zdHlsZS1zZXQtcHJvcGVydHkuaHRtbAkocmV2aXNpb24gMCkKKysrIExheW91 dFRlc3RzL2Zhc3QvZG9tL2NvbXB1dGVkLXN0eWxlLXNldC1wcm9wZXJ0eS5odG1sCShyZXZpc2lv biAwKQpAQCAtMCwwICsxLDI0IEBACis8Ym9keT4KKzxwPllvdSBzaG91bGQgc2VlIHR3byAiUEFT UyIgbWVzc2FnZXMgYmVsb3c6PC9wPgorCis8c2NyaXB0PgoraWYgKHdpbmRvdy5sYXlvdXRUZXN0 Q29udHJvbGxlcikKKyAgbGF5b3V0VGVzdENvbnRyb2xsZXIuZHVtcEFzVGV4dCgpOworCitkb2N1 bWVudC53cml0ZSgiQ29tcHV0ZWQgc3R5bGUgcGFyZW50IChzaG91bGQgYmUgbnVsbCk6ICIgKyBk b2N1bWVudC5kZWZhdWx0Vmlldy5nZXRDb21wdXRlZFN0eWxlKGRvY3VtZW50LmJvZHksIG51bGwp LnBhcmVudFJ1bGUpOwordHJ5IHsKKyAgZG9jdW1lbnQuZGVmYXVsdFZpZXcuZ2V0Q29tcHV0ZWRT dHlsZShkb2N1bWVudC5ib2R5LCBudWxsKS5jb2xvciA9ICJibHVlIjsKKyAgZG9jdW1lbnQud3Jp dGUoIjxwPkZBSUw6IGRpZCBub3QgZ2V0IGFuIGV4Y2VwdGlvbiB3aGVuIHRyeWluZyB0byBjaGFu Z2UgYSBjb21wdXRlZCBzdHlsZSBkZWNsYXJhdGlvbi4iKTsKK30gY2F0Y2ggKGV4KSB7CisgIGRv Y3VtZW50LndyaXRlKCI8cD5QQVNTOiBnb3QgYW4gZXhjZXB0aW9uIHdoZW4gdHJ5aW5nIHRvIGNo YW5nZSBhIGNvbXB1dGVkIHN0eWxlIGRlY2xhcmF0aW9uLCAiICsgZXgpOworfQorCit0cnkgewor ICBkb2N1bWVudC5kZWZhdWx0Vmlldy5nZXRDb21wdXRlZFN0eWxlKGRvY3VtZW50LmJvZHksIG51 bGwpLnNldFByb3BlcnR5KCJjb2xvciIsICJibHVlIik7CisgIGRvY3VtZW50LndyaXRlKCI8cD5G QUlMOiBkaWQgbm90IGdldCBhbiBleGNlcHRpb24gd2hlbiB0cnlpbmcgdG8gY2hhbmdlIGEgY29t cHV0ZWQgc3R5bGUgZGVjbGFyYXRpb24gdmlhIHNldFByb3BlcnR5LiIpOworfSBjYXRjaCAoZXgp IHsKKyAgZG9jdW1lbnQud3JpdGUoIjxwPlBBU1M6IGdvdCBhbiBleGNlcHRpb24gd2hlbiB0cnlp bmcgdG8gY2hhbmdlIGEgY29tcHV0ZWQgc3R5bGUgZGVjbGFyYXRpb24gdmlhIHNldFByb3BlcnR5 LCAiICsgZXgpOworfQorCis8L3NjcmlwdD4KKzwvYm9keT4KClByb3BlcnR5IGNoYW5nZXMgb246 IExheW91dFRlc3RzL2Zhc3QvZG9tL2NvbXB1dGVkLXN0eWxlLXNldC1wcm9wZXJ0eS5odG1sCl9f X19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19f X19fX19fX18KTmFtZTogc3ZuOm1pbWUtdHlwZQogICArIHRleHQvaHRtbAoKSW5kZXg6IFdlYkNv cmUvQ2hhbmdlTG9nCj09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT0KLS0tIFdlYkNvcmUvQ2hhbmdlTG9nCShyZXZpc2lvbiAx ODM5MSkKKysrIFdlYkNvcmUvQ2hhbmdlTG9nCSh3b3JraW5nIGNvcHkpCkBAIC0xLDMgKzEsMTcg QEAKKzIwMDYtMTItMjIgIEFsZXhleSBQcm9za3VyeWFrb3YgIDxhcEB3ZWJraXQub3JnPgorCisg ICAgICAgIFJldmlld2VkIGJ5IE5PQk9EWSAoT09QUyEpLgorCisgICAgICAgIGh0dHA6Ly9idWdz LndlYmtpdC5vcmcvc2hvd19idWcuY2dpP2lkPTExOTMzCisgICAgICAgIFJFR1JFU1NJT046IHRy eWluZyB0byBjaGFuZ2UgYSBwcm9wZXJ0eSBpbiBhIGNvbXB1dGVkIHN0eWxlIGRlY2xhcmF0aW9u IHJlc3VsdHMgaW4gYSBjcmFzaAorCisgICAgICAgIFRlc3Q6IGZhc3QvZG9tL2NvbXB1dGVkLXN0 eWxlLXNldC1wcm9wZXJ0eS5odG1sCisKKyAgICAgICAgKiBiaW5kaW5ncy9qcy9ranNfY3NzLmNw cDoKKyAgICAgICAgKEtKUzo6RE9NQ1NTU3R5bGVEZWNsYXJhdGlvbjo6cHV0KTogQWRkZWQgYSBj aGVjayBmb3IgbnVsbCBtX2ltcGwtPnN0eWxlc2hlZXQoKS4gQWxzbywgZml4ZWQKKyAgICAgICAg aW5jb3JyZWN0IGxvZ2ljIGluIERhc2hib2FyZCBicmFuY2ggLSBpdCBkaWRuJ3QgcmV0dXJuIGlu IHRpbWUgaWYgcmVtb3ZlUHJvcGVydHkoKSByYWlzZWQKKyAgICAgICAgYW4gZXhjZXB0aW9uIChj cmVkaXQgZm9yIG5vdGljaW5nIHRoaXMgYnVnIGdvZXMgdG8gR2VvZmYpLgorCiAyMDA2LTEyLTIy ICBKb2huIFN1bGxpdmFuICA8c3VsbGl2YW5AYXBwbGUuY29tPgogCiAgICAgICAgIFJldmlld2Vk IGJ5IEtldmluIERlY2tlcgpJbmRleDogV2ViQ29yZS9iaW5kaW5ncy9qcy9ranNfY3NzLmNwcAo9 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09Ci0tLSBXZWJDb3JlL2JpbmRpbmdzL2pzL2tqc19jc3MuY3BwCShyZXZpc2lvbiAx ODM5MCkKKysrIFdlYkNvcmUvYmluZGluZ3MvanMva2pzX2Nzcy5jcHAJKHdvcmtpbmcgY29weSkK QEAgLTIxOSwxNiArMjE5LDIwIEBAIHZvaWQgRE9NQ1NTU3R5bGVEZWNsYXJhdGlvbjo6cHV0KEV4 ZWNTdGEKICNpZmRlZiBLSlNfVkVSQk9TRQogICAgICAga2REZWJ1Zyg2MDcwKSA8PCAiRE9NQ1NT U3R5bGVEZWNsYXJhdGlvbjogcHJvcD0iIDw8IHByb3AgPDwgIiBwcm9wdmFsdWU9IiA8PCBwcm9w dmFsdWUgPDwgZW5kbDsKICNlbmRpZgotICAgICAgQVNTRVJUKHN0eWxlRGVjbC5zdHlsZXNoZWV0 KCktPmlzQ1NTU3R5bGVTaGVldCgpKTsKLSAgICAgIGlmIChGcmFtZSogZnJhbWUgPSBzdGF0aWNf Y2FzdDxDU1NTdHlsZVNoZWV0Kj4oc3R5bGVEZWNsLnN0eWxlc2hlZXQoKSktPmRvYygpLT5mcmFt ZSgpKQotICAgICAgICBpZiAoZnJhbWUtPnNldHRpbmdzKCktPnNob3VsZFVzZURhc2hib2FyZEJh Y2t3YXJkQ29tcGF0aWJpbGl0eU1vZGUoKSkgewotICAgICAgICAgIHN0eWxlRGVjbC5yZW1vdmVQ cm9wZXJ0eShwcm9wLCBleGNlcHRpb24pOwotICAgICAgICAgIGlmICghZXhjZXB0aW9uKSB7Ci0g ICAgICAgICAgICBFeGNlcHRpb25Db2RlIGV4Y2VwdGlvbklnbm9yZWQgPSAwOwotICAgICAgICAg ICAgc3R5bGVEZWNsLnNldFByb3BlcnR5KHByb3AsIHByb3BWYWx1ZSwgZXhjZXB0aW9uSWdub3Jl ZCk7CisgICAgICBTdHlsZVNoZWV0KiBzdHlsZXNoZWV0ID0gc3R5bGVEZWNsLnN0eWxlc2hlZXQo KTsKKyAgICAgIC8vIENvbXB1dGVkIHN0eWxlIGRlY2xhcmF0aW9ucyBkb24ndCBoYXZlIHN0eWxl c2hlZXRzLgorICAgICAgaWYgKHN0eWxlc2hlZXQpIHsKKyAgICAgICAgQVNTRVJUKHN0eWxlc2hl ZXQtPmlzQ1NTU3R5bGVTaGVldCgpKTsKKyAgICAgICAgaWYgKEZyYW1lKiBmcmFtZSA9IHN0YXRp Y19jYXN0PENTU1N0eWxlU2hlZXQqPihzdHlsZXNoZWV0KS0+ZG9jKCktPmZyYW1lKCkpCisgICAg ICAgICAgaWYgKGZyYW1lLT5zZXR0aW5ncygpLT5zaG91bGRVc2VEYXNoYm9hcmRCYWNrd2FyZENv bXBhdGliaWxpdHlNb2RlKCkpIHsKKyAgICAgICAgICAgIHN0eWxlRGVjbC5yZW1vdmVQcm9wZXJ0 eShwcm9wLCBleGNlcHRpb24pOworICAgICAgICAgICAgaWYgKCFleGNlcHRpb24pIHsKKyAgICAg ICAgICAgICAgRXhjZXB0aW9uQ29kZSBleGNlcHRpb25JZ25vcmVkID0gMDsKKyAgICAgICAgICAg ICAgc3R5bGVEZWNsLnNldFByb3BlcnR5KHByb3AsIHByb3BWYWx1ZSwgZXhjZXB0aW9uSWdub3Jl ZCk7CisgICAgICAgICAgICB9CiAgICAgICAgICAgICByZXR1cm47CiAgICAgICAgICAgfQotICAg ICAgICB9CisgICAgICB9CiAgICAgICBzdHlsZURlY2wuc2V0UHJvcGVydHkocHJvcCwgcHJvcFZh bHVlLCBleGNlcHRpb24pOwogICAgIH0gZWxzZSB7CiAgICAgICBET01PYmplY3Q6OnB1dChleGVj LCBwcm9wZXJ0eU5hbWUsIHZhbHVlLCBhdHRyKTsK