<?xml version="1.0" encoding="UTF-8" standalone="yes" ?>
<!DOCTYPE bugzilla SYSTEM "https://bugs.webkit.org/page.cgi?id=bugzilla.dtd">

<bugzilla version="5.0.4.1"
          urlbase="https://bugs.webkit.org/"
          
          maintainer="admin@webkit.org"
>

    <bug>
          <bug_id>119327</bug_id>
          
          <creation_ts>2013-07-31 00:20:10 -0700</creation_ts>
          <short_desc>Replace CRASH() on overflow with Checked&lt;&gt;</short_desc>
          <delta_ts>2013-08-01 12:45:49 -0700</delta_ts>
          <reporter_accessible>1</reporter_accessible>
          <cclist_accessible>1</cclist_accessible>
          <classification_id>1</classification_id>
          <classification>Unclassified</classification>
          <product>WebKit</product>
          <component>WebCore Misc.</component>
          <version>528+ (Nightly build)</version>
          <rep_platform>Unspecified</rep_platform>
          <op_sys>Unspecified</op_sys>
          <bug_status>RESOLVED</bug_status>
          <resolution>FIXED</resolution>
          
          
          <bug_file_loc></bug_file_loc>
          <status_whiteboard></status_whiteboard>
          <keywords></keywords>
          <priority>P2</priority>
          <bug_severity>Normal</bug_severity>
          <target_milestone>---</target_milestone>
          
          
          <everconfirmed>1</everconfirmed>
          <reporter name="Kwang Yul Seo">skyul</reporter>
          <assigned_to name="Kwang Yul Seo">skyul</assigned_to>
          <cc>commit-queue</cc>
    
    <cc>eric.carlson</cc>
    
    <cc>esprehn+autocc</cc>
    
    <cc>glenn</cc>
    
    <cc>jer.noble</cc>
    
    <cc>kangil.han</cc>
    
    <cc>oliver</cc>
          

      

      

      

          <comment_sort_order>oldest_to_newest</comment_sort_order>  
          <long_desc isprivate="0" >
    <commentid>913214</commentid>
    <comment_count>0</comment_count>
    <who name="Kwang Yul Seo">skyul</who>
    <bug_when>2013-07-31 00:20:10 -0700</bug_when>
    <thetext>Use a checked type that allows us to automate bound checks. We use a non-recording Checked&lt;&gt; to keep the behavior.</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>913217</commentid>
    <comment_count>1</comment_count>
      <attachid>207813</attachid>
    <who name="Kwang Yul Seo">skyul</who>
    <bug_when>2013-07-31 00:34:42 -0700</bug_when>
    <thetext>Created attachment 207813
Patch</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>913484</commentid>
    <comment_count>2</comment_count>
      <attachid>207813</attachid>
    <who name="Oliver Hunt">oliver</who>
    <bug_when>2013-07-31 14:07:29 -0700</bug_when>
    <thetext>Comment on attachment 207813
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=207813&amp;action=review

&gt; Source/WebCore/platform/audio/AudioArray.h:55
&gt;      void allocate(size_t n)

Make n Checked&lt;size_t&gt;, otherwise the multiplication below may silently fail before the arithmetic becomes safe.</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>913537</commentid>
    <comment_count>3</comment_count>
      <attachid>207886</attachid>
    <who name="Kwang Yul Seo">skyul</who>
    <bug_when>2013-07-31 16:46:54 -0700</bug_when>
    <thetext>Created attachment 207886
Patch</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>913538</commentid>
    <comment_count>4</comment_count>
    <who name="Kwang Yul Seo">skyul</who>
    <bug_when>2013-07-31 16:47:57 -0700</bug_when>
    <thetext>(In reply to comment #2)
&gt; Make n Checked&lt;size_t&gt;, otherwise the multiplication below may silently fail before the arithmetic becomes safe.

Done. Thanks for the review.</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>913551</commentid>
    <comment_count>5</comment_count>
    <who name="Kwang Yul Seo">skyul</who>
    <bug_when>2013-07-31 17:02:02 -0700</bug_when>
    <thetext>Committed r153548: &lt;http://trac.webkit.org/changeset/153548&gt;</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>913826</commentid>
    <comment_count>6</comment_count>
      <attachid>207886</attachid>
    <who name="Darin Adler">darin</who>
    <bug_when>2013-08-01 12:45:49 -0700</bug_when>
    <thetext>Comment on attachment 207886
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=207886&amp;action=review

&gt; Source/WebCore/platform/audio/AudioArray.h:55
&gt; +    void allocate(Checked&lt;size_t&gt; n)

I think it’s not good to make &lt;n&gt; itself a Checked. There must be a better way to make the initialSize computation be checked.</thetext>
  </long_desc>
      
          <attachment
              isobsolete="1"
              ispatch="1"
              isprivate="0"
          >
            <attachid>207813</attachid>
            <date>2013-07-31 00:34:42 -0700</date>
            <delta_ts>2013-07-31 16:46:49 -0700</delta_ts>
            <desc>Patch</desc>
            <filename>bug-119327-20130731163439.patch</filename>
            <type>text/plain</type>
            <size>4139</size>
            <attacher name="Kwang Yul Seo">skyul</attacher>
            
              <data encoding="base64">U3VidmVyc2lvbiBSZXZpc2lvbjogMTUzNTA4CmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViQ29yZS9D
aGFuZ2VMb2cgYi9Tb3VyY2UvV2ViQ29yZS9DaGFuZ2VMb2cKaW5kZXggNzMzOTQ1MmVhZjZmNGEx
MDA5OTgxZTg2MDllNTJmNGI1OWE4YTA2My4uNzcwMjJlMzQ4YzEzNDJiZTc2MjI1NmNlY2NjYmMy
ZmY1ZGQ0YjM5YyAxMDA2NDQKLS0tIGEvU291cmNlL1dlYkNvcmUvQ2hhbmdlTG9nCisrKyBiL1Nv
dXJjZS9XZWJDb3JlL0NoYW5nZUxvZwpAQCAtMSwzICsxLDIwIEBACisyMDEzLTA3LTMxICBLd2Fu
ZyBZdWwgU2VvICA8c2t5dWxAY29tcGFueTEwMC5uZXQ+CisKKyAgICAgICAgUmVwbGFjZSBDUkFT
SCgpIG9uIG92ZXJmbG93IHdpdGggQ2hlY2tlZDw+CisgICAgICAgIGh0dHBzOi8vYnVncy53ZWJr
aXQub3JnL3Nob3dfYnVnLmNnaT9pZD0xMTkzMjcKKworICAgICAgICBSZXZpZXdlZCBieSBOT0JP
RFkgKE9PUFMhKS4KKworICAgICAgICBVc2UgYSBjaGVja2VkIHR5cGUgdGhhdCBhbGxvd3MgdXMg
dG8gYXV0b21hdGUgYm91bmQgY2hlY2tzLiBXZSB1c2UgYQorICAgICAgICBub24tcmVjb3JkaW5n
IENoZWNrZWQ8PiB0byBrZWVwIHRoZSBiZWhhdmlvci4KKworICAgICAgICBObyBiZWhhdmlvciBj
aGFuZ2UsIG5vIG5ldyB0ZXN0cyBuZWVkZWQuCisKKyAgICAgICAgKiBkb20vVGV4dC5jcHA6Cisg
ICAgICAgIChXZWJDb3JlOjpUZXh0Ojp3aG9sZVRleHQpOgorICAgICAgICAqIHBsYXRmb3JtL2F1
ZGlvL0F1ZGlvQXJyYXkuaDoKKyAgICAgICAgKFdlYkNvcmU6OkF1ZGlvQXJyYXk6OmFsbG9jYXRl
KToKKwogMjAxMy0wNy0zMCAgUm9iIEJ1aXMgIDxyd2xidWlzQHdlYmtpdC5vcmc+CiAKICAgICAg
ICAgWE1MU2VyaWFsaXplciBzaG91bGQgcmVzZXQgZGVmYXVsdCBuYW1lc3BhY2Ugd2hlbiBuZWNl
c3NhcnkKZGlmZiAtLWdpdCBhL1NvdXJjZS9XZWJDb3JlL2RvbS9UZXh0LmNwcCBiL1NvdXJjZS9X
ZWJDb3JlL2RvbS9UZXh0LmNwcAppbmRleCBhODkyZGVlYjljZDg4NWNkY2FiNjI1ODA5ZWYyM2U3
ZmNjYzE4MjM1Li5kZWUxNTM4ZWE0ZTBiMzA3NmMxNDY0NTU5ZTVmOTE0NWZhZTY0MWM5IDEwMDY0
NAotLS0gYS9Tb3VyY2UvV2ViQ29yZS9kb20vVGV4dC5jcHAKKysrIGIvU291cmNlL1dlYkNvcmUv
ZG9tL1RleHQuY3BwCkBAIC0zNyw2ICszNyw3IEBACiAKICNpbmNsdWRlICJTdHlsZUluaGVyaXRl
ZERhdGEuaCIKICNpbmNsdWRlICJTdHlsZVJlc29sdmVyLmgiCisjaW5jbHVkZSA8d3RmL0NoZWNr
ZWRBcml0aG1ldGljLmg+CiAjaW5jbHVkZSA8d3RmL3RleHQvQ1N0cmluZy5oPgogI2luY2x1ZGUg
PHd0Zi90ZXh0L1N0cmluZ0J1aWxkZXIuaD4KIApAQCAtMTI2LDI1ICsxMjcsMjMgQEAgU3RyaW5n
IFRleHQ6Ondob2xlVGV4dCgpIGNvbnN0CiAgICAgY29uc3QgVGV4dCogZW5kVGV4dCA9IGxhdGVz
dExvZ2ljYWxseUFkamFjZW50VGV4dE5vZGUodGhpcyk7CiAKICAgICBOb2RlKiBvbmVQYXN0RW5k
VGV4dCA9IGVuZFRleHQtPm5leHRTaWJsaW5nKCk7Ci0gICAgdW5zaWduZWQgcmVzdWx0TGVuZ3Ro
ID0gMDsKKyAgICBDaGVja2VkPHVuc2lnbmVkPiByZXN1bHRMZW5ndGggPSAwOwogICAgIGZvciAo
Y29uc3QgTm9kZSogbiA9IHN0YXJ0VGV4dDsgbiAhPSBvbmVQYXN0RW5kVGV4dDsgbiA9IG4tPm5l
eHRTaWJsaW5nKCkpIHsKICAgICAgICAgaWYgKCFuLT5pc1RleHROb2RlKCkpCiAgICAgICAgICAg
ICBjb250aW51ZTsKICAgICAgICAgY29uc3QgVGV4dCogdCA9IHN0YXRpY19jYXN0PGNvbnN0IFRl
eHQqPihuKTsKICAgICAgICAgY29uc3QgU3RyaW5nJiBkYXRhID0gdC0+ZGF0YSgpOwotICAgICAg
ICBpZiAoc3RkOjpudW1lcmljX2xpbWl0czx1bnNpZ25lZD46Om1heCgpIC0gZGF0YS5sZW5ndGgo
KSA8IHJlc3VsdExlbmd0aCkKLSAgICAgICAgICAgIENSQVNIKCk7CiAgICAgICAgIHJlc3VsdExl
bmd0aCArPSBkYXRhLmxlbmd0aCgpOwogICAgIH0KICAgICBTdHJpbmdCdWlsZGVyIHJlc3VsdDsK
LSAgICByZXN1bHQucmVzZXJ2ZUNhcGFjaXR5KHJlc3VsdExlbmd0aCk7CisgICAgcmVzdWx0LnJl
c2VydmVDYXBhY2l0eShyZXN1bHRMZW5ndGgudW5zYWZlR2V0KCkpOwogICAgIGZvciAoY29uc3Qg
Tm9kZSogbiA9IHN0YXJ0VGV4dDsgbiAhPSBvbmVQYXN0RW5kVGV4dDsgbiA9IG4tPm5leHRTaWJs
aW5nKCkpIHsKICAgICAgICAgaWYgKCFuLT5pc1RleHROb2RlKCkpCiAgICAgICAgICAgICBjb250
aW51ZTsKICAgICAgICAgY29uc3QgVGV4dCogdCA9IHN0YXRpY19jYXN0PGNvbnN0IFRleHQqPihu
KTsKICAgICAgICAgcmVzdWx0LmFwcGVuZCh0LT5kYXRhKCkpOwogICAgIH0KLSAgICBBU1NFUlQo
cmVzdWx0Lmxlbmd0aCgpID09IHJlc3VsdExlbmd0aCk7CisgICAgQVNTRVJUKHJlc3VsdC5sZW5n
dGgoKSA9PSByZXN1bHRMZW5ndGgudW5zYWZlR2V0KCkpOwogCiAgICAgcmV0dXJuIHJlc3VsdC50
b1N0cmluZygpOwogfQpkaWZmIC0tZ2l0IGEvU291cmNlL1dlYkNvcmUvcGxhdGZvcm0vYXVkaW8v
QXVkaW9BcnJheS5oIGIvU291cmNlL1dlYkNvcmUvcGxhdGZvcm0vYXVkaW8vQXVkaW9BcnJheS5o
CmluZGV4IDM5NTkzNjFiNjI3ZjhjOGVmNjkxZWYyMTg3MTMzMjc2YWMzY2ZjMzkuLmU2MTI2MmRm
ODcyZDBmMjFjNmU3YTJmNTY5OTlkODIzZjRhNGRhNDMgMTAwNjQ0Ci0tLSBhL1NvdXJjZS9XZWJD
b3JlL3BsYXRmb3JtL2F1ZGlvL0F1ZGlvQXJyYXkuaAorKysgYi9Tb3VyY2UvV2ViQ29yZS9wbGF0
Zm9ybS9hdWRpby9BdWRpb0FycmF5LmgKQEAgLTMwLDYgKzMwLDcgQEAKICNkZWZpbmUgQXVkaW9B
cnJheV9oCiAKICNpbmNsdWRlIDxzdHJpbmcuaD4KKyNpbmNsdWRlIDx3dGYvQ2hlY2tlZEFyaXRo
bWV0aWMuaD4KICNpbmNsdWRlIDx3dGYvRmFzdE1hbGxvYy5oPgogI2luY2x1ZGUgPHd0Zi9WZWN0
b3IuaD4KIApAQCAtNTMsMTIgKzU0LDcgQEAgcHVibGljOgogICAgIC8vIGlmIHJlLWFsbG9jYXRl
ZC4gQWxsb2NhdGlvbnMgYXJlIHplcm8taW5pdGlhbGl6ZWQuCiAgICAgdm9pZCBhbGxvY2F0ZShz
aXplX3QgbikKICAgICB7Ci0gICAgICAgIC8vIEFsdGhvdWdoIG4gaXMgYSBzaXplX3QsIGl0cyB0
cnVlIGxpbWl0IGlzIG1heCB1bnNpZ25lZCBiZWNhdXNlIHdlIHVzZSB1bnNpZ25lZCBpbiB6ZXJv
UmFuZ2UoKQotICAgICAgICAvLyBhbmQgY29weVRvUmFuZ2UoKS4gQWxzbyBjaGVjayBmb3IgaW50
ZWdlciBvdmVyZmxvdy4KLSAgICAgICAgaWYgKG4gPiBzdGQ6Om51bWVyaWNfbGltaXRzPHVuc2ln
bmVkPjo6bWF4KCkgLyBzaXplb2YoVCkpCi0gICAgICAgICAgICBDUkFTSCgpOwotICAgICAgCi0g
ICAgICAgIHVuc2lnbmVkIGluaXRpYWxTaXplID0gc2l6ZW9mKFQpICogbjsKKyAgICAgICAgQ2hl
Y2tlZDx1bnNpZ25lZD4gaW5pdGlhbFNpemUgPSBzaXplb2YoVCkgKiBuOwogCiAjaWYgVVNFKFdF
QkFVRElPX0ZGTVBFRykgfHwgVVNFKFdFQkFVRElPX09QRU5NQVhfRExfRkZUKQogICAgICAgICBj
b25zdCBzaXplX3QgYWxpZ25tZW50ID0gMzI7CkBAIC03NiwxMSArNzIsNyBAQCBwdWJsaWM6CiAg
ICAgICAgICAgICAvLyB0aGVuIHdlJ2xsIGhhdmUgdG8gcmVhbGxvY2F0ZSBhbmQgZnJvbSB0aGVu
IG9uIGFsbG9jYXRlIGV4dHJhLgogICAgICAgICAgICAgc3RhdGljIHNpemVfdCBleHRyYUFsbG9j
YXRpb25CeXRlcyA9IDA7CiAKLSAgICAgICAgICAgIC8vIEFnYWluLCBjaGVjayBmb3IgaW50ZWdl
ciBvdmVyZmxvdy4KLSAgICAgICAgICAgIGlmIChpbml0aWFsU2l6ZSArIGV4dHJhQWxsb2NhdGlv
bkJ5dGVzIDwgaW5pdGlhbFNpemUpCi0gICAgICAgICAgICAgICAgQ1JBU0goKTsKLQotICAgICAg
ICAgICAgVCogYWxsb2NhdGlvbiA9IHN0YXRpY19jYXN0PFQqPihmYXN0TWFsbG9jKGluaXRpYWxT
aXplICsgZXh0cmFBbGxvY2F0aW9uQnl0ZXMpKTsKKyAgICAgICAgICAgIFQqIGFsbG9jYXRpb24g
PSBzdGF0aWNfY2FzdDxUKj4oZmFzdE1hbGxvYygoaW5pdGlhbFNpemUgKyBleHRyYUFsbG9jYXRp
b25CeXRlcykudW5zYWZlR2V0KCkpKTsKICAgICAgICAgICAgIGlmICghYWxsb2NhdGlvbikKICAg
ICAgICAgICAgICAgICBDUkFTSCgpOwogICAgICAgICAgICAgVCogYWxpZ25lZERhdGEgPSBhbGln
bmVkQWRkcmVzcyhhbGxvY2F0aW9uLCBhbGlnbm1lbnQpOwo=
</data>

          </attachment>
          <attachment
              isobsolete="0"
              ispatch="1"
              isprivate="0"
          >
            <attachid>207886</attachid>
            <date>2013-07-31 16:46:54 -0700</date>
            <delta_ts>2013-08-01 12:45:49 -0700</delta_ts>
            <desc>Patch</desc>
            <filename>bug-119327-20130801084650.patch</filename>
            <type>text/plain</type>
            <size>4645</size>
            <attacher name="Kwang Yul Seo">skyul</attacher>
            
              <data encoding="base64">U3VidmVyc2lvbiBSZXZpc2lvbjogMTUzNTA4CmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViQ29yZS9D
aGFuZ2VMb2cgYi9Tb3VyY2UvV2ViQ29yZS9DaGFuZ2VMb2cKaW5kZXggNzMzOTQ1MmVhZjZmNGEx
MDA5OTgxZTg2MDllNTJmNGI1OWE4YTA2My4uNzcwMjJlMzQ4YzEzNDJiZTc2MjI1NmNlY2NjYmMy
ZmY1ZGQ0YjM5YyAxMDA2NDQKLS0tIGEvU291cmNlL1dlYkNvcmUvQ2hhbmdlTG9nCisrKyBiL1Nv
dXJjZS9XZWJDb3JlL0NoYW5nZUxvZwpAQCAtMSwzICsxLDIwIEBACisyMDEzLTA3LTMxICBLd2Fu
ZyBZdWwgU2VvICA8c2t5dWxAY29tcGFueTEwMC5uZXQ+CisKKyAgICAgICAgUmVwbGFjZSBDUkFT
SCgpIG9uIG92ZXJmbG93IHdpdGggQ2hlY2tlZDw+CisgICAgICAgIGh0dHBzOi8vYnVncy53ZWJr
aXQub3JnL3Nob3dfYnVnLmNnaT9pZD0xMTkzMjcKKworICAgICAgICBSZXZpZXdlZCBieSBOT0JP
RFkgKE9PUFMhKS4KKworICAgICAgICBVc2UgYSBjaGVja2VkIHR5cGUgdGhhdCBhbGxvd3MgdXMg
dG8gYXV0b21hdGUgYm91bmQgY2hlY2tzLiBXZSB1c2UgYQorICAgICAgICBub24tcmVjb3JkaW5n
IENoZWNrZWQ8PiB0byBrZWVwIHRoZSBiZWhhdmlvci4KKworICAgICAgICBObyBiZWhhdmlvciBj
aGFuZ2UsIG5vIG5ldyB0ZXN0cyBuZWVkZWQuCisKKyAgICAgICAgKiBkb20vVGV4dC5jcHA6Cisg
ICAgICAgIChXZWJDb3JlOjpUZXh0Ojp3aG9sZVRleHQpOgorICAgICAgICAqIHBsYXRmb3JtL2F1
ZGlvL0F1ZGlvQXJyYXkuaDoKKyAgICAgICAgKFdlYkNvcmU6OkF1ZGlvQXJyYXk6OmFsbG9jYXRl
KToKKwogMjAxMy0wNy0zMCAgUm9iIEJ1aXMgIDxyd2xidWlzQHdlYmtpdC5vcmc+CiAKICAgICAg
ICAgWE1MU2VyaWFsaXplciBzaG91bGQgcmVzZXQgZGVmYXVsdCBuYW1lc3BhY2Ugd2hlbiBuZWNl
c3NhcnkKZGlmZiAtLWdpdCBhL1NvdXJjZS9XZWJDb3JlL2RvbS9UZXh0LmNwcCBiL1NvdXJjZS9X
ZWJDb3JlL2RvbS9UZXh0LmNwcAppbmRleCBhODkyZGVlYjljZDg4NWNkY2FiNjI1ODA5ZWYyM2U3
ZmNjYzE4MjM1Li5kZWUxNTM4ZWE0ZTBiMzA3NmMxNDY0NTU5ZTVmOTE0NWZhZTY0MWM5IDEwMDY0
NAotLS0gYS9Tb3VyY2UvV2ViQ29yZS9kb20vVGV4dC5jcHAKKysrIGIvU291cmNlL1dlYkNvcmUv
ZG9tL1RleHQuY3BwCkBAIC0zNyw2ICszNyw3IEBACiAKICNpbmNsdWRlICJTdHlsZUluaGVyaXRl
ZERhdGEuaCIKICNpbmNsdWRlICJTdHlsZVJlc29sdmVyLmgiCisjaW5jbHVkZSA8d3RmL0NoZWNr
ZWRBcml0aG1ldGljLmg+CiAjaW5jbHVkZSA8d3RmL3RleHQvQ1N0cmluZy5oPgogI2luY2x1ZGUg
PHd0Zi90ZXh0L1N0cmluZ0J1aWxkZXIuaD4KIApAQCAtMTI2LDI1ICsxMjcsMjMgQEAgU3RyaW5n
IFRleHQ6Ondob2xlVGV4dCgpIGNvbnN0CiAgICAgY29uc3QgVGV4dCogZW5kVGV4dCA9IGxhdGVz
dExvZ2ljYWxseUFkamFjZW50VGV4dE5vZGUodGhpcyk7CiAKICAgICBOb2RlKiBvbmVQYXN0RW5k
VGV4dCA9IGVuZFRleHQtPm5leHRTaWJsaW5nKCk7Ci0gICAgdW5zaWduZWQgcmVzdWx0TGVuZ3Ro
ID0gMDsKKyAgICBDaGVja2VkPHVuc2lnbmVkPiByZXN1bHRMZW5ndGggPSAwOwogICAgIGZvciAo
Y29uc3QgTm9kZSogbiA9IHN0YXJ0VGV4dDsgbiAhPSBvbmVQYXN0RW5kVGV4dDsgbiA9IG4tPm5l
eHRTaWJsaW5nKCkpIHsKICAgICAgICAgaWYgKCFuLT5pc1RleHROb2RlKCkpCiAgICAgICAgICAg
ICBjb250aW51ZTsKICAgICAgICAgY29uc3QgVGV4dCogdCA9IHN0YXRpY19jYXN0PGNvbnN0IFRl
eHQqPihuKTsKICAgICAgICAgY29uc3QgU3RyaW5nJiBkYXRhID0gdC0+ZGF0YSgpOwotICAgICAg
ICBpZiAoc3RkOjpudW1lcmljX2xpbWl0czx1bnNpZ25lZD46Om1heCgpIC0gZGF0YS5sZW5ndGgo
KSA8IHJlc3VsdExlbmd0aCkKLSAgICAgICAgICAgIENSQVNIKCk7CiAgICAgICAgIHJlc3VsdExl
bmd0aCArPSBkYXRhLmxlbmd0aCgpOwogICAgIH0KICAgICBTdHJpbmdCdWlsZGVyIHJlc3VsdDsK
LSAgICByZXN1bHQucmVzZXJ2ZUNhcGFjaXR5KHJlc3VsdExlbmd0aCk7CisgICAgcmVzdWx0LnJl
c2VydmVDYXBhY2l0eShyZXN1bHRMZW5ndGgudW5zYWZlR2V0KCkpOwogICAgIGZvciAoY29uc3Qg
Tm9kZSogbiA9IHN0YXJ0VGV4dDsgbiAhPSBvbmVQYXN0RW5kVGV4dDsgbiA9IG4tPm5leHRTaWJs
aW5nKCkpIHsKICAgICAgICAgaWYgKCFuLT5pc1RleHROb2RlKCkpCiAgICAgICAgICAgICBjb250
aW51ZTsKICAgICAgICAgY29uc3QgVGV4dCogdCA9IHN0YXRpY19jYXN0PGNvbnN0IFRleHQqPihu
KTsKICAgICAgICAgcmVzdWx0LmFwcGVuZCh0LT5kYXRhKCkpOwogICAgIH0KLSAgICBBU1NFUlQo
cmVzdWx0Lmxlbmd0aCgpID09IHJlc3VsdExlbmd0aCk7CisgICAgQVNTRVJUKHJlc3VsdC5sZW5n
dGgoKSA9PSByZXN1bHRMZW5ndGgudW5zYWZlR2V0KCkpOwogCiAgICAgcmV0dXJuIHJlc3VsdC50
b1N0cmluZygpOwogfQpkaWZmIC0tZ2l0IGEvU291cmNlL1dlYkNvcmUvcGxhdGZvcm0vYXVkaW8v
QXVkaW9BcnJheS5oIGIvU291cmNlL1dlYkNvcmUvcGxhdGZvcm0vYXVkaW8vQXVkaW9BcnJheS5o
CmluZGV4IDM5NTkzNjFiNjI3ZjhjOGVmNjkxZWYyMTg3MTMzMjc2YWMzY2ZjMzkuLmIxZmE3YTVm
NGEwMDIyNDM5MjkyYTFjZTVlYzgxMTM3NzU2NDc4YTAgMTAwNjQ0Ci0tLSBhL1NvdXJjZS9XZWJD
b3JlL3BsYXRmb3JtL2F1ZGlvL0F1ZGlvQXJyYXkuaAorKysgYi9Tb3VyY2UvV2ViQ29yZS9wbGF0
Zm9ybS9hdWRpby9BdWRpb0FycmF5LmgKQEAgLTMwLDYgKzMwLDcgQEAKICNkZWZpbmUgQXVkaW9B
cnJheV9oCiAKICNpbmNsdWRlIDxzdHJpbmcuaD4KKyNpbmNsdWRlIDx3dGYvQ2hlY2tlZEFyaXRo
bWV0aWMuaD4KICNpbmNsdWRlIDx3dGYvRmFzdE1hbGxvYy5oPgogI2luY2x1ZGUgPHd0Zi9WZWN0
b3IuaD4KIApAQCAtNTEsMTQgKzUyLDkgQEAgcHVibGljOgogCiAgICAgLy8gSXQncyBPSyB0byBj
YWxsIGFsbG9jYXRlKCkgbXVsdGlwbGUgdGltZXMsIGJ1dCBkYXRhIHdpbGwgKm5vdCogYmUgY29w
aWVkIGZyb20gYW4gaW5pdGlhbCBhbGxvY2F0aW9uCiAgICAgLy8gaWYgcmUtYWxsb2NhdGVkLiBB
bGxvY2F0aW9ucyBhcmUgemVyby1pbml0aWFsaXplZC4KLSAgICB2b2lkIGFsbG9jYXRlKHNpemVf
dCBuKQorICAgIHZvaWQgYWxsb2NhdGUoQ2hlY2tlZDxzaXplX3Q+IG4pCiAgICAgewotICAgICAg
ICAvLyBBbHRob3VnaCBuIGlzIGEgc2l6ZV90LCBpdHMgdHJ1ZSBsaW1pdCBpcyBtYXggdW5zaWdu
ZWQgYmVjYXVzZSB3ZSB1c2UgdW5zaWduZWQgaW4gemVyb1JhbmdlKCkKLSAgICAgICAgLy8gYW5k
IGNvcHlUb1JhbmdlKCkuIEFsc28gY2hlY2sgZm9yIGludGVnZXIgb3ZlcmZsb3cuCi0gICAgICAg
IGlmIChuID4gc3RkOjpudW1lcmljX2xpbWl0czx1bnNpZ25lZD46Om1heCgpIC8gc2l6ZW9mKFQp
KQotICAgICAgICAgICAgQ1JBU0goKTsKLSAgICAgIAotICAgICAgICB1bnNpZ25lZCBpbml0aWFs
U2l6ZSA9IHNpemVvZihUKSAqIG47CisgICAgICAgIENoZWNrZWQ8dW5zaWduZWQ+IGluaXRpYWxT
aXplID0gc2l6ZW9mKFQpICogbjsKIAogI2lmIFVTRShXRUJBVURJT19GRk1QRUcpIHx8IFVTRShX
RUJBVURJT19PUEVOTUFYX0RMX0ZGVCkKICAgICAgICAgY29uc3Qgc2l6ZV90IGFsaWdubWVudCA9
IDMyOwpAQCAtNzYsMTEgKzcyLDcgQEAgcHVibGljOgogICAgICAgICAgICAgLy8gdGhlbiB3ZSds
bCBoYXZlIHRvIHJlYWxsb2NhdGUgYW5kIGZyb20gdGhlbiBvbiBhbGxvY2F0ZSBleHRyYS4KICAg
ICAgICAgICAgIHN0YXRpYyBzaXplX3QgZXh0cmFBbGxvY2F0aW9uQnl0ZXMgPSAwOwogCi0gICAg
ICAgICAgICAvLyBBZ2FpbiwgY2hlY2sgZm9yIGludGVnZXIgb3ZlcmZsb3cuCi0gICAgICAgICAg
ICBpZiAoaW5pdGlhbFNpemUgKyBleHRyYUFsbG9jYXRpb25CeXRlcyA8IGluaXRpYWxTaXplKQot
ICAgICAgICAgICAgICAgIENSQVNIKCk7Ci0KLSAgICAgICAgICAgIFQqIGFsbG9jYXRpb24gPSBz
dGF0aWNfY2FzdDxUKj4oZmFzdE1hbGxvYyhpbml0aWFsU2l6ZSArIGV4dHJhQWxsb2NhdGlvbkJ5
dGVzKSk7CisgICAgICAgICAgICBUKiBhbGxvY2F0aW9uID0gc3RhdGljX2Nhc3Q8VCo+KGZhc3RN
YWxsb2MoKGluaXRpYWxTaXplICsgZXh0cmFBbGxvY2F0aW9uQnl0ZXMpLnVuc2FmZUdldCgpKSk7
CiAgICAgICAgICAgICBpZiAoIWFsbG9jYXRpb24pCiAgICAgICAgICAgICAgICAgQ1JBU0goKTsK
ICAgICAgICAgICAgIFQqIGFsaWduZWREYXRhID0gYWxpZ25lZEFkZHJlc3MoYWxsb2NhdGlvbiwg
YWxpZ25tZW50KTsKQEAgLTg4LDcgKzgwLDcgQEAgcHVibGljOgogICAgICAgICAgICAgaWYgKGFs
aWduZWREYXRhID09IGFsbG9jYXRpb24gfHwgZXh0cmFBbGxvY2F0aW9uQnl0ZXMgPT0gYWxpZ25t
ZW50KSB7CiAgICAgICAgICAgICAgICAgbV9hbGxvY2F0aW9uID0gYWxsb2NhdGlvbjsKICAgICAg
ICAgICAgICAgICBtX2FsaWduZWREYXRhID0gYWxpZ25lZERhdGE7Ci0gICAgICAgICAgICAgICAg
bV9zaXplID0gbjsKKyAgICAgICAgICAgICAgICBtX3NpemUgPSBuLnVuc2FmZUdldCgpOwogICAg
ICAgICAgICAgICAgIGlzQWxsb2NhdGlvbkdvb2QgPSB0cnVlOwogICAgICAgICAgICAgICAgIHpl
cm8oKTsKICAgICAgICAgICAgIH0gZWxzZSB7Cg==
</data>
<flag name="review"
          id="229718"
          type_id="1"
          status="+"
          setter="oliver"
    />
          </attachment>
      

    </bug>

</bugzilla>