<?xml version="1.0" encoding="UTF-8" standalone="yes" ?>
<!DOCTYPE bugzilla SYSTEM "https://bugs.webkit.org/page.cgi?id=bugzilla.dtd">

<bugzilla version="5.0.4.1"
          urlbase="https://bugs.webkit.org/"
          
          maintainer="admin@webkit.org"
>

    <bug>
          <bug_id>119322</bug_id>
          
          <creation_ts>2013-07-30 22:01:56 -0700</creation_ts>
          <short_desc>javascript: urls should always be parsed synchronously</short_desc>
          <delta_ts>2024-12-01 17:25:14 -0800</delta_ts>
          <reporter_accessible>1</reporter_accessible>
          <cclist_accessible>1</cclist_accessible>
          <classification_id>1</classification_id>
          <classification>Unclassified</classification>
          <product>WebKit</product>
          <component>DOM</component>
          <version>528+ (Nightly build)</version>
          <rep_platform>Unspecified</rep_platform>
          <op_sys>Unspecified</op_sys>
          <bug_status>NEW</bug_status>
          <resolution></resolution>
          
          <see_also>https://bugs.webkit.org/show_bug.cgi?id=283747</see_also>
          <bug_file_loc></bug_file_loc>
          <status_whiteboard></status_whiteboard>
          <keywords>BlinkMergeCandidate</keywords>
          <priority>P2</priority>
          <bug_severity>Normal</bug_severity>
          <target_milestone>---</target_milestone>
          
          
          <everconfirmed>1</everconfirmed>
          <reporter name="Ryosuke Niwa">rniwa</reporter>
          <assigned_to name="Nobody">webkit-unassigned</assigned_to>
          <cc>achristensen</cc>
    
    <cc>ahmad.saleem792</cc>
    
    <cc>ap</cc>
    
    <cc>benjamin</cc>
    
    <cc>cdumez</cc>
    
    <cc>eric</cc>
    
    <cc>karlcow</cc>
    
    <cc>kling</cc>
    
    <cc>koivisto</cc>
    
    <cc>syoichi</cc>
          

      

      

      

          <comment_sort_order>oldest_to_newest</comment_sort_order>  
          <long_desc isprivate="0" >
    <commentid>913191</commentid>
    <comment_count>0</comment_count>
    <who name="Ryosuke Niwa">rniwa</who>
    <bug_when>2013-07-30 22:01:56 -0700</bug_when>
    <thetext>Consider merging https://chromium.googlesource.com/chromium/blink/+/cfbec542d3a70df79e9238f15740f7f37ef5eda3

Removing the minimumLayoutDelay() threshold as part of:
https://codereview.chromium.org/20140002/

revealed that we weren&apos;t always parsing javascript: urls
synchronously.  This change is a preventative fix to allow
me to move forward with this change.

In order to trigger this in current webkit, we&apos;d need to parse
a javascript: url which included a script which took more than .5
seconds to execute and then had a second script tag.
We&apos;d (incorrectly) yield between the two script tags while parsing
the html result of the javascript: url.

I also renamed the isLayoutTimer active method on Document to
better reflect what it&apos;s actually used for.

I also added a FIXME to WebViewImpl.</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>1900839</commentid>
    <comment_count>1</comment_count>
    <who name="Ahmad Saleem">ahmad.saleem792</who>
    <bug_when>2022-09-24 02:37:48 -0700</bug_when>
    <thetext>In Webkit -&gt; Renamed isLayoutTimerActive to isLayoutPending:

In Document.cpp:

Just another renamed to bool: https://github.com/WebKit/WebKit/blob/f1bf39d41c844a64adcee49a7d83afe5d174697b/Source/WebCore/dom/Document.cpp#L3349

In Document.h:

Another renamed:

https://github.com/WebKit/WebKit/blob/552bfd33df1642d5d889a7d649cb7b91eafb27b7/Source/WebCore/dom/Document.h#L781

In DocumentParser.h:

Webkit does not have pinToMainThread to add comment.

In HTMLDocumentParser.

Add asset based on &quot;pinToMainThread&quot; or equivalent here including FIXME and other bits:

https://github.com/WebKit/WebKit/blob/03b5974b58684a094f81c69015126e8bcbfa15e7/Source/WebCore/html/parser/HTMLDocumentParser.cpp#L202

Not able to find XSS related anything here.

In HTMLParserScheduler.cpp:

Update here with new FIXME and renamed from above:

https://github.com/WebKit/WebKit/blob/03b5974b58684a094f81c69015126e8bcbfa15e7/Source/WebCore/html/parser/HTMLParserScheduler.cpp#L94

Not able to find paint related change equivalent.

In DocumentLoader.cpp &amp; DocumentWriter.cpp:

nothing changed in Blink patch except comments.

In WebViewImpl.cpp - just new FIXME comment.

______

Is it something worth pursuing this time considering, it would add more FIXME?

Appreciate if someone can add more context and details. Thanks!</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>1902242</commentid>
    <comment_count>2</comment_count>
    <who name="Alexey Proskuryakov">ap</who>
    <bug_when>2022-09-29 18:18:25 -0700</bug_when>
    <thetext>Merging a Blink fix seems impractical, but if the issue still reproduces, it seems substantial enough to track.

But also, testing for this is going to be tricky.</thetext>
  </long_desc>
      
      

    </bug>

</bugzilla>