119298 2013-07-30 18:14:03 -0700 JSOESTextureHalfFloat not generated on Windows 2013-08-01 09:52:40 -0700 1 1 1 Unclassified WebKit WebGL 528+ (Nightly build) Unspecified Unspecified RESOLVED FIXED P2 Normal --- 0 achristensen webkit-unassigned cdumez commit-queue dino esprehn+autocc kondapallykalyan oldest_to_newest 913123 0 achristensen 2013-07-30 18:14:03 -0700 I have spent weeks wondering why OESTextureHalfFloat wasn't working on Windows. JSOESTextureHalfFloat.h and JSOESTextureHalfFloat.cpp were not being generated. After going through every possible difference between OESTextureHalfFloat and OESTextureFloat I found the problem: OESTextureHalfFloat.idl doesn't end with a newline, which was making generate-bindings.pl fail, but only on Windows. 913125 1 207793 achristensen 2013-07-30 18:19:00 -0700 Created attachment 207793 Patch 913193 2 207793 cdumez 2013-07-30 22:24:41 -0700 Comment on attachment 207793 Patch r=me. 913769 3 207793 commit-queue 2013-08-01 09:52:38 -0700 Comment on attachment 207793 Patch Clearing flags on attachment: 207793 Committed r153588: <http://trac.webkit.org/changeset/153588> 913770 4 commit-queue 2013-08-01 09:52:40 -0700 All reviewed patches have been landed. Closing bug. 207793 2013-07-30 18:19:00 -0700 2013-08-01 09:52:38 -0700 Patch bug-119298-20130730181900.patch text/plain 6814 achristensen SW5kZXg6IFNvdXJjZS9XZWJDb3JlL0NoYW5nZUxvZwo9PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09Ci0tLSBTb3VyY2UvV2Vi Q29yZS9DaGFuZ2VMb2cJKHJldmlzaW9uIDE1MzUwNSkKKysrIFNvdXJjZS9XZWJDb3JlL0NoYW5n ZUxvZwkod29ya2luZyBjb3B5KQpAQCAtMSwzICsxLDE3IEBACisyMDEzLTA3LTMwICBBbGV4IENo cmlzdGVuc2VuICA8YWNocmlzdGVuc2VuQGFwcGxlLmNvbT4KKworICAgICAgICBNYWRlIE9FU1Rl eHR1cmVIYWxmRmxvYXQgd29yayBvbiBXaW5kb3dzLgorICAgICAgICBodHRwczovL2J1Z3Mud2Vi a2l0Lm9yZy9zaG93X2J1Zy5jZ2k/aWQ9MTE5Mjk4CisKKyAgICAgICAgUmV2aWV3ZWQgYnkgTk9C T0RZIChPT1BTISkuCisKKyAgICAgICAgKiBEZXJpdmVkU291cmNlcy5jcHA6IEFkZGVkIEpTT0VT VGV4dHVyZUhhbGZGbG9hdC5jcHAgaW5zaWRlIG9mICNpZiBFTkFCTEUoV0VCR0wpLgorICAgICAg ICAqIFdlYkNvcmUudmN4cHJvai9XZWJDb3JlLnZjeHByb2o6CisgICAgICAgICogV2ViQ29yZS52 Y3hwcm9qL1dlYkNvcmUudmN4cHJvai5maWx0ZXJzOgorICAgICAgICBBZGRlZCBKU09FU1RleHR1 cmVIYWxmRmxvYXQuY3BwIGFuZCBKU09FU1RleHR1cmVIYWxmRmxvYXQuaC4KKyAgICAgICAgKiBo dG1sL2NhbnZhcy9PRVNUZXh0dXJlSGFsZkZsb2F0LmlkbDogQWRkZWQgbmV3bGluZSB0byBlbmQg b2YgZmlsZS4KKyAgICAgICAgKiBodG1sL2NhbnZhcy9XZWJHTE9iamVjdC5jcHA6IFJlbW92ZWQg dW51c2VkICNpbmNsdWRlcy4KKwogMjAxMy0wNy0zMCAgQW5keSBFc3RlcyAgPGFlc3Rlc0BhcHBs ZS5jb20+ICAKIAogICAgICAgICBDb250ZW50IGZpbHRlciByZXBsYWNlbWVudCBkYXRhIHVzZXMg dGhlIGVuY29kaW5nIGZyb20gdGhlIGJsb2NrZWQgcGFnZSdzIHJlc3BvbnNlIGhlYWRlcnMKSW5k ZXg6IFNvdXJjZS9XZWJDb3JlL0Rlcml2ZWRTb3VyY2VzLmNwcAo9PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09Ci0tLSBTb3Vy Y2UvV2ViQ29yZS9EZXJpdmVkU291cmNlcy5jcHAJKHJldmlzaW9uIDE1MzUwMikKKysrIFNvdXJj ZS9XZWJDb3JlL0Rlcml2ZWRTb3VyY2VzLmNwcAkod29ya2luZyBjb3B5KQpAQCAtNDQsNiArNDQs NyBAQAogI2luY2x1ZGUgIkpTT0VTRWxlbWVudEluZGV4VWludC5jcHAiCiAjaW5jbHVkZSAiSlNP RVNTdGFuZGFyZERlcml2YXRpdmVzLmNwcCIKICNpbmNsdWRlICJKU09FU1RleHR1cmVGbG9hdC5j cHAiCisjaW5jbHVkZSAiSlNPRVNUZXh0dXJlSGFsZkZsb2F0LmNwcCIKICNpbmNsdWRlICJKU09F U1ZlcnRleEFycmF5T2JqZWN0LmNwcCIKICNpbmNsdWRlICJKU1dlYkdMQWN0aXZlSW5mby5jcHAi CiAjaW5jbHVkZSAiSlNXZWJHTEJ1ZmZlci5jcHAiCkluZGV4OiBTb3VyY2UvV2ViQ29yZS9XZWJD b3JlLnZjeHByb2ovV2ViQ29yZS52Y3hwcm9qCj09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT0KLS0tIFNvdXJjZS9XZWJDb3Jl L1dlYkNvcmUudmN4cHJvai9XZWJDb3JlLnZjeHByb2oJKHJldmlzaW9uIDE1MzUwMikKKysrIFNv dXJjZS9XZWJDb3JlL1dlYkNvcmUudmN4cHJvai9XZWJDb3JlLnZjeHByb2oJKHdvcmtpbmcgY29w eSkKQEAgLTM0MCw2ICszNDAsMjAgQEAKICAgICAgIDxFeGNsdWRlZEZyb21CdWlsZCBDb25kaXRp b249IickKENvbmZpZ3VyYXRpb24pfCQoUGxhdGZvcm0pJz09J1Byb2R1Y3Rpb258V2luMzInIj50 cnVlPC9FeGNsdWRlZEZyb21CdWlsZD4KICAgICAgIDxFeGNsdWRlZEZyb21CdWlsZCBDb25kaXRp b249IickKENvbmZpZ3VyYXRpb24pfCQoUGxhdGZvcm0pJz09J1Byb2R1Y3Rpb258eDY0JyI+dHJ1 ZTwvRXhjbHVkZWRGcm9tQnVpbGQ+CiAgICAgPC9DbENvbXBpbGU+CisgICAgPENsQ29tcGlsZSBJ bmNsdWRlPSIkKENvbmZpZ3VyYXRpb25CdWlsZERpcilcb2JqMzJcV2ViQ29yZVxEZXJpdmVkU291 cmNlc1xKU09FU1RleHR1cmVIYWxmRmxvYXQuY3BwIj4KKyAgICAgIDxFeGNsdWRlZEZyb21CdWls ZCBDb25kaXRpb249IickKENvbmZpZ3VyYXRpb24pfCQoUGxhdGZvcm0pJz09J0RlYnVnfFdpbjMy JyI+dHJ1ZTwvRXhjbHVkZWRGcm9tQnVpbGQ+CisgICAgICA8RXhjbHVkZWRGcm9tQnVpbGQgQ29u ZGl0aW9uPSInJChDb25maWd1cmF0aW9uKXwkKFBsYXRmb3JtKSc9PSdEZWJ1Z3x4NjQnIj50cnVl PC9FeGNsdWRlZEZyb21CdWlsZD4KKyAgICAgIDxFeGNsdWRlZEZyb21CdWlsZCBDb25kaXRpb249 IickKENvbmZpZ3VyYXRpb24pfCQoUGxhdGZvcm0pJz09J0RlYnVnX1dpbkNhaXJvfFdpbjMyJyI+ dHJ1ZTwvRXhjbHVkZWRGcm9tQnVpbGQ+CisgICAgICA8RXhjbHVkZWRGcm9tQnVpbGQgQ29uZGl0 aW9uPSInJChDb25maWd1cmF0aW9uKXwkKFBsYXRmb3JtKSc9PSdEZWJ1Z19XaW5DYWlyb3x4NjQn Ij50cnVlPC9FeGNsdWRlZEZyb21CdWlsZD4KKyAgICAgIDxFeGNsdWRlZEZyb21CdWlsZCBDb25k aXRpb249IickKENvbmZpZ3VyYXRpb24pfCQoUGxhdGZvcm0pJz09J0RlYnVnU3VmZml4fFdpbjMy JyI+dHJ1ZTwvRXhjbHVkZWRGcm9tQnVpbGQ+CisgICAgICA8RXhjbHVkZWRGcm9tQnVpbGQgQ29u ZGl0aW9uPSInJChDb25maWd1cmF0aW9uKXwkKFBsYXRmb3JtKSc9PSdEZWJ1Z1N1ZmZpeHx4NjQn Ij50cnVlPC9FeGNsdWRlZEZyb21CdWlsZD4KKyAgICAgIDxFeGNsdWRlZEZyb21CdWlsZCBDb25k aXRpb249IickKENvbmZpZ3VyYXRpb24pfCQoUGxhdGZvcm0pJz09J1JlbGVhc2V8V2luMzInIj50 cnVlPC9FeGNsdWRlZEZyb21CdWlsZD4KKyAgICAgIDxFeGNsdWRlZEZyb21CdWlsZCBDb25kaXRp b249IickKENvbmZpZ3VyYXRpb24pfCQoUGxhdGZvcm0pJz09J1JlbGVhc2V8eDY0JyI+dHJ1ZTwv RXhjbHVkZWRGcm9tQnVpbGQ+CisgICAgICA8RXhjbHVkZWRGcm9tQnVpbGQgQ29uZGl0aW9uPSIn JChDb25maWd1cmF0aW9uKXwkKFBsYXRmb3JtKSc9PSdSZWxlYXNlX1dpbkNhaXJvfFdpbjMyJyI+ dHJ1ZTwvRXhjbHVkZWRGcm9tQnVpbGQ+CisgICAgICA8RXhjbHVkZWRGcm9tQnVpbGQgQ29uZGl0 aW9uPSInJChDb25maWd1cmF0aW9uKXwkKFBsYXRmb3JtKSc9PSdSZWxlYXNlX1dpbkNhaXJvfHg2 NCciPnRydWU8L0V4Y2x1ZGVkRnJvbUJ1aWxkPgorICAgICAgPEV4Y2x1ZGVkRnJvbUJ1aWxkIENv bmRpdGlvbj0iJyQoQ29uZmlndXJhdGlvbil8JChQbGF0Zm9ybSknPT0nUHJvZHVjdGlvbnxXaW4z MiciPnRydWU8L0V4Y2x1ZGVkRnJvbUJ1aWxkPgorICAgICAgPEV4Y2x1ZGVkRnJvbUJ1aWxkIENv bmRpdGlvbj0iJyQoQ29uZmlndXJhdGlvbil8JChQbGF0Zm9ybSknPT0nUHJvZHVjdGlvbnx4NjQn Ij50cnVlPC9FeGNsdWRlZEZyb21CdWlsZD4KKyAgICA8L0NsQ29tcGlsZT4KICAgICA8Q2xDb21w aWxlIEluY2x1ZGU9IiQoQ29uZmlndXJhdGlvbkJ1aWxkRGlyKVxvYmozMlxXZWJDb3JlXERlcml2 ZWRTb3VyY2VzXEpTT0VTVmVydGV4QXJyYXlPYmplY3QuY3BwIj4KICAgICAgIDxFeGNsdWRlZEZy b21CdWlsZCBDb25kaXRpb249IickKENvbmZpZ3VyYXRpb24pfCQoUGxhdGZvcm0pJz09J0RlYnVn fFdpbjMyJyI+dHJ1ZTwvRXhjbHVkZWRGcm9tQnVpbGQ+CiAgICAgICA8RXhjbHVkZWRGcm9tQnVp bGQgQ29uZGl0aW9uPSInJChDb25maWd1cmF0aW9uKXwkKFBsYXRmb3JtKSc9PSdEZWJ1Z3x4NjQn Ij50cnVlPC9FeGNsdWRlZEZyb21CdWlsZD4KQEAgLTE4NzMxLDYgKzE4NzQ1LDcgQEAKICAgICA8 Q2xJbmNsdWRlIEluY2x1ZGU9IiQoQ29uZmlndXJhdGlvbkJ1aWxkRGlyKVxvYmozMlxXZWJDb3Jl XERlcml2ZWRTb3VyY2VzXEpTT0VTRWxlbWVudEluZGV4VWludC5oIiAvPgogICAgIDxDbEluY2x1 ZGUgSW5jbHVkZT0iJChDb25maWd1cmF0aW9uQnVpbGREaXIpXG9iajMyXFdlYkNvcmVcRGVyaXZl ZFNvdXJjZXNcSlNPRVNTdGFuZGFyZERlcml2YXRpdmVzLmgiIC8+CiAgICAgPENsSW5jbHVkZSBJ bmNsdWRlPSIkKENvbmZpZ3VyYXRpb25CdWlsZERpcilcb2JqMzJcV2ViQ29yZVxEZXJpdmVkU291 cmNlc1xKU09FU1RleHR1cmVGbG9hdC5oIiAvPgorICAgIDxDbEluY2x1ZGUgSW5jbHVkZT0iJChD b25maWd1cmF0aW9uQnVpbGREaXIpXG9iajMyXFdlYkNvcmVcRGVyaXZlZFNvdXJjZXNcSlNPRVNU ZXh0dXJlSGFsZkZsb2F0LmgiIC8+CiAgICAgPENsSW5jbHVkZSBJbmNsdWRlPSIkKENvbmZpZ3Vy YXRpb25CdWlsZERpcilcb2JqMzJcV2ViQ29yZVxEZXJpdmVkU291cmNlc1xKU09FU1ZlcnRleEFy cmF5T2JqZWN0LmgiIC8+CiAgICAgPENsSW5jbHVkZSBJbmNsdWRlPSIkKENvbmZpZ3VyYXRpb25C dWlsZERpcilcb2JqMzJcV2ViQ29yZVxEZXJpdmVkU291cmNlc1xKU1dlYkdMQWN0aXZlSW5mby5o IiAvPgogICAgIDxDbEluY2x1ZGUgSW5jbHVkZT0iJChDb25maWd1cmF0aW9uQnVpbGREaXIpXG9i ajMyXFdlYkNvcmVcRGVyaXZlZFNvdXJjZXNcSlNXZWJHTEJ1ZmZlci5oIiAvPgpJbmRleDogU291 cmNlL1dlYkNvcmUvV2ViQ29yZS52Y3hwcm9qL1dlYkNvcmUudmN4cHJvai5maWx0ZXJzCj09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT0KLS0tIFNvdXJjZS9XZWJDb3JlL1dlYkNvcmUudmN4cHJvai9XZWJDb3JlLnZjeHByb2ou ZmlsdGVycwkocmV2aXNpb24gMTUzNTAyKQorKysgU291cmNlL1dlYkNvcmUvV2ViQ29yZS52Y3hw cm9qL1dlYkNvcmUudmN4cHJvai5maWx0ZXJzCSh3b3JraW5nIGNvcHkpCkBAIC02ODc3LDYgKzY4 NzcsOSBAQAogICAgIDxDbENvbXBpbGUgSW5jbHVkZT0iJChDb25maWd1cmF0aW9uQnVpbGREaXIp XG9iajMyXFdlYkNvcmVcRGVyaXZlZFNvdXJjZXNcSlNPRVNUZXh0dXJlRmxvYXQuY3BwIj4KICAg ICAgIDxGaWx0ZXI+RGVyaXZlZFNvdXJjZXM8L0ZpbHRlcj4KICAgICA8L0NsQ29tcGlsZT4KKyAg ICA8Q2xDb21waWxlIEluY2x1ZGU9IiQoQ29uZmlndXJhdGlvbkJ1aWxkRGlyKVxvYmozMlxXZWJD b3JlXERlcml2ZWRTb3VyY2VzXEpTT0VTVGV4dHVyZUhhbGZGbG9hdC5jcHAiPgorICAgICAgPEZp bHRlcj5EZXJpdmVkU291cmNlczwvRmlsdGVyPgorICAgIDwvQ2xDb21waWxlPgogICAgIDxDbENv bXBpbGUgSW5jbHVkZT0iJChDb25maWd1cmF0aW9uQnVpbGREaXIpXG9iajMyXFdlYkNvcmVcRGVy aXZlZFNvdXJjZXNcSlNPRVNWZXJ0ZXhBcnJheU9iamVjdC5jcHAiPgogICAgICAgPEZpbHRlcj5E ZXJpdmVkU291cmNlczwvRmlsdGVyPgogICAgIDwvQ2xDb21waWxlPgpAQCAtMTQ2NDAsNiArMTQ2 NDMsOSBAQAogICAgIDxDbEluY2x1ZGUgSW5jbHVkZT0iJChDb25maWd1cmF0aW9uQnVpbGREaXIp XG9iajMyXFdlYkNvcmVcRGVyaXZlZFNvdXJjZXNcSlNPRVNUZXh0dXJlRmxvYXQuaCI+CiAgICAg ICA8RmlsdGVyPkRlcml2ZWRTb3VyY2VzPC9GaWx0ZXI+CiAgICAgPC9DbEluY2x1ZGU+CisgICAg PENsSW5jbHVkZSBJbmNsdWRlPSIkKENvbmZpZ3VyYXRpb25CdWlsZERpcilcb2JqMzJcV2ViQ29y ZVxEZXJpdmVkU291cmNlc1xKU09FU1RleHR1cmVIYWxmRmxvYXQuaCI+CisgICAgICA8RmlsdGVy PkRlcml2ZWRTb3VyY2VzPC9GaWx0ZXI+CisgICAgPC9DbEluY2x1ZGU+CiAgICAgPENsSW5jbHVk ZSBJbmNsdWRlPSIkKENvbmZpZ3VyYXRpb25CdWlsZERpcilcb2JqMzJcV2ViQ29yZVxEZXJpdmVk U291cmNlc1xKU09FU1ZlcnRleEFycmF5T2JqZWN0LmgiPgogICAgICAgPEZpbHRlcj5EZXJpdmVk U291cmNlczwvRmlsdGVyPgogICAgIDwvQ2xJbmNsdWRlPgpJbmRleDogU291cmNlL1dlYkNvcmUv aHRtbC9jYW52YXMvT0VTVGV4dHVyZUhhbGZGbG9hdC5pZGwKPT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PQotLS0gU291cmNl L1dlYkNvcmUvaHRtbC9jYW52YXMvT0VTVGV4dHVyZUhhbGZGbG9hdC5pZGwJKHJldmlzaW9uIDE1 MzUwMikKKysrIFNvdXJjZS9XZWJDb3JlL2h0bWwvY2FudmFzL09FU1RleHR1cmVIYWxmRmxvYXQu aWRsCSh3b3JraW5nIGNvcHkpCkBAIC0yOCw0ICsyOCw0IEBACiAgICAgQ29uZGl0aW9uYWw9V0VC R0wsCiAgICAgR2VuZXJhdGVJc1JlYWNoYWJsZT1JbXBsQ29udGV4dCwKIF0gaW50ZXJmYWNlIE9F U1RleHR1cmVIYWxmRmxvYXQgewotfTsKXCBObyBuZXdsaW5lIGF0IGVuZCBvZiBmaWxlCit9OwpJ bmRleDogU291cmNlL1dlYkNvcmUvaHRtbC9jYW52YXMvV2ViR0xPYmplY3QuY3BwCj09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT0KLS0tIFNvdXJjZS9XZWJDb3JlL2h0bWwvY2FudmFzL1dlYkdMT2JqZWN0LmNwcAkocmV2aXNp b24gMTUzNTAyKQorKysgU291cmNlL1dlYkNvcmUvaHRtbC9jYW52YXMvV2ViR0xPYmplY3QuY3Bw CSh3b3JraW5nIGNvcHkpCkBAIC0zMCw5ICszMCw2IEBACiAjaW5jbHVkZSAiV2ViR0xPYmplY3Qu aCIKIAogI2luY2x1ZGUgIkVYVFRleHR1cmVGaWx0ZXJBbmlzb3Ryb3BpYy5oIgotI2luY2x1ZGUg Ik9FU1N0YW5kYXJkRGVyaXZhdGl2ZXMuaCIKLSNpbmNsdWRlICJPRVNUZXh0dXJlRmxvYXQuaCIK LSNpbmNsdWRlICJPRVNWZXJ0ZXhBcnJheU9iamVjdC5oIgogI2luY2x1ZGUgIldlYkdMQ29tcHJl c3NlZFRleHR1cmVTM1RDLmgiCiAjaW5jbHVkZSAiV2ViR0xDb250ZXh0R3JvdXAuaCIKICNpbmNs dWRlICJXZWJHTERlYnVnUmVuZGVyZXJJbmZvLmgiCg==