119279 2013-07-30 14:46:28 -0700 Speculative fix for crash due to string access on multiple threads 2013-07-30 21:14:52 -0700 1 1 1 Unclassified WebKit WebKit2 528+ (Nightly build) Unspecified Unspecified RESOLVED FIXED P2 Normal --- 1 andersca andersca darin oldest_to_newest 913033 0 andersca 2013-07-30 14:46:28 -0700 Speculative fix for crash due to string access on multiple threads 913035 1 207768 andersca 2013-07-30 14:53:47 -0700 Created attachment 207768 Patch 913047 2 andersca 2013-07-30 15:19:14 -0700 Committed r153499: <http://trac.webkit.org/changeset/153499> 913165 3 207768 darin 2013-07-30 21:14:52 -0700 Comment on attachment 207768 Patch View in context: https://bugs.webkit.org/attachment.cgi?id=207768&action=review > Source/WebKit2/UIProcess/Storage/LocalStorageDatabaseTracker.cpp:56 > + RefPtr<StringImpl> copiedLocalStorageDirectory = localStorageDirectory.impl() ? localStorageDirectory.impl()->isolatedCopy() : nullptr; Is this really better than: RefPtr<StringImpl> copiedLocalStorageDirectory = localStorageDirectory.isolatedCopy().impl(); ? Wish I had thought of that before you landed it. 207768 2013-07-30 14:53:47 -0700 2013-07-30 21:14:52 -0700 Patch bug-119279-20130730145346.patch text/plain 3880 andersca U3VidmVyc2lvbiBSZXZpc2lvbjogMTUzNDg4CmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViS2l0Mi9D aGFuZ2VMb2cgYi9Tb3VyY2UvV2ViS2l0Mi9DaGFuZ2VMb2cKaW5kZXggZjMxMjY2N2FlNzhjMjY5 NDYyNjRkOTEzN2E0MTkzYmM0ZjIyMGNiOC4uZGM5MGRhNTgwZDZhYzAzMTA2Mjc3MzE3YmM3MzVj OGUyYzFjMmNmOSAxMDA2NDQKLS0tIGEvU291cmNlL1dlYktpdDIvQ2hhbmdlTG9nCisrKyBiL1Nv dXJjZS9XZWJLaXQyL0NoYW5nZUxvZwpAQCAtMSw1ICsxLDI1IEBACiAyMDEzLTA3LTMwICBBbmRl cnMgQ2FybHNzb24gIDxhbmRlcnNjYUBhcHBsZS5jb20+CiAKKyAgICAgICAgU3BlY3VsYXRpdmUg Zml4IGZvciBjcmFzaCBkdWUgdG8gc3RyaW5nIGFjY2VzcyBvbiBtdWx0aXBsZSB0aHJlYWRzCisg ICAgICAgIGh0dHBzOi8vYnVncy53ZWJraXQub3JnL3Nob3dfYnVnLmNnaT9pZD0xMTkyNzkKKyAg ICAgICAgPHJkYXI6Ly9wcm9ibGVtLzE0MjY3ODMzPgorCisgICAgICAgIFJldmlld2VkIGJ5IE5P Qk9EWSAoT09QUyEpLgorCisgICAgICAgIFdlIGNhbid0IHVzZSBTdHJpbmc6Omlzb2xhdGVkQ29w eSBmb3IgcGFzc2luZyB0aGUgbG9jYWwgc3RvcmFnZSBkaXJlY3RvcnkgdG8gdGhlIHN0b3JhZ2Ug dGhyZWFkIHNpbmNlCisgICAgICAgIHRoYXQgcmV0dXJucyBhIFN0cmluZyB0aGF0J3MgY29waWVk IGFuZCB0aGVuIGRlc3Ryb3llZCBhZnRlciB0aGUgY2FsbCB0byBiaW5kIHJldHVybnMsIGxlYXZp bmcgYSBzbWFsbCB3aW5kb3cKKyAgICAgICAgd2hlcmUgdGhlIHJlZmNvdW50IGNhbiBiZSBhY2Nl c3NlZCBzaW11bHRhbmVvdXNseSBmcm9tIHR3byB0aHJlYWRzLgorCisgICAgICAgIFdvcmsgYXJv dW5kIHRoaXMgYnkgcGFzc2luZyBhIFBhc3NSZWZQdHI8U3RyaW5nSW1wbD4gdG8gYmluZCBpbnN0 ZWFkOyB0aGUgYWN0IG9mIGNvcHlpbmcgdGhlIFBhc3NSZWZQdHIgd2lsbAorICAgICAgICBjbGVh ciBvdXQgdGhlIG9yaWdpbmFsIGFuZCBzbyB3aGVuIHRoZSBvcmlnaW5hbCBpcyBkZXN0cm95ZWQg dGhlIHVuZGVybHlpbmcgU3RyaW5nSW1wbCBwb2ludGVyIHdpbGwgYmUgbnVsbC4KKworICAgICAg ICAqIFVJUHJvY2Vzcy9TdG9yYWdlL0xvY2FsU3RvcmFnZURhdGFiYXNlVHJhY2tlci5jcHA6Cisg ICAgICAgIChXZWJLaXQ6OkxvY2FsU3RvcmFnZURhdGFiYXNlVHJhY2tlcjo6c2V0TG9jYWxTdG9y YWdlRGlyZWN0b3J5KToKKyAgICAgICAgKFdlYktpdDo6TG9jYWxTdG9yYWdlRGF0YWJhc2VUcmFj a2VyOjpzZXRMb2NhbFN0b3JhZ2VEaXJlY3RvcnlJbnRlcm5hbCk6CisgICAgICAgICogVUlQcm9j ZXNzL1N0b3JhZ2UvTG9jYWxTdG9yYWdlRGF0YWJhc2VUcmFja2VyLmg6CisKKzIwMTMtMDctMzAg IEFuZGVycyBDYXJsc3NvbiAgPGFuZGVyc2NhQGFwcGxlLmNvbT4KKwogICAgICAgICBQbHVnLWlu IHByb2Nlc3MgY3Jhc2hlcyBpZiBwbHVnLWluIGlzIGRlc3Ryb3llZCBhcyBhIHJlc3VsdCBvZiBz ZW5kaW5nIE5QT2JqZWN0TWVzc2FnZVJlY2VpdmVyOjpEZWFsbG9jYXRlCiAgICAgICAgIGh0dHBz Oi8vYnVncy53ZWJraXQub3JnL3Nob3dfYnVnLmNnaT9pZD0xMTkyNzAKICAgICAgICAgPHJkYXI6 Ly9wcm9ibGVtLzEzMzY4MjI2PgpkaWZmIC0tZ2l0IGEvU291cmNlL1dlYktpdDIvVUlQcm9jZXNz L1N0b3JhZ2UvTG9jYWxTdG9yYWdlRGF0YWJhc2VUcmFja2VyLmNwcCBiL1NvdXJjZS9XZWJLaXQy L1VJUHJvY2Vzcy9TdG9yYWdlL0xvY2FsU3RvcmFnZURhdGFiYXNlVHJhY2tlci5jcHAKaW5kZXgg MDA0MGE1ZjNhM2I3NDViOTg3YmExMjgzNDk5ZWFiNGIwMDEwNTZlZC4uZjU4ZmU4YTc5MWIyZmYw NmEyZjg5ODk3MTNlZGYxODk3ZGJmMDZjZCAxMDA2NDQKLS0tIGEvU291cmNlL1dlYktpdDIvVUlQ cm9jZXNzL1N0b3JhZ2UvTG9jYWxTdG9yYWdlRGF0YWJhc2VUcmFja2VyLmNwcAorKysgYi9Tb3Vy Y2UvV2ViS2l0Mi9VSVByb2Nlc3MvU3RvcmFnZS9Mb2NhbFN0b3JhZ2VEYXRhYmFzZVRyYWNrZXIu Y3BwCkBAIC01Miw3ICs1MiwxMCBAQCBMb2NhbFN0b3JhZ2VEYXRhYmFzZVRyYWNrZXI6On5Mb2Nh bFN0b3JhZ2VEYXRhYmFzZVRyYWNrZXIoKQogCiB2b2lkIExvY2FsU3RvcmFnZURhdGFiYXNlVHJh Y2tlcjo6c2V0TG9jYWxTdG9yYWdlRGlyZWN0b3J5KGNvbnN0IFN0cmluZyYgbG9jYWxTdG9yYWdl RGlyZWN0b3J5KQogewotICAgIG1fcXVldWUtPmRpc3BhdGNoKGJpbmQoJkxvY2FsU3RvcmFnZURh dGFiYXNlVHJhY2tlcjo6c2V0TG9jYWxTdG9yYWdlRGlyZWN0b3J5SW50ZXJuYWwsIHRoaXMsIGxv Y2FsU3RvcmFnZURpcmVjdG9yeS5pc29sYXRlZENvcHkoKSkpOworICAgIC8vIEZJWE1FOiBXZSBz aG91bGQgY29tZSB1cCB3aXRoIGEgYmV0dGVyIGlkaW9tIGZvciBzYWZlbHkgY29weWluZyBzdHJp bmdzIGFjcm9zcyB0aHJlYWRzLgorICAgIFJlZlB0cjxTdHJpbmdJbXBsPiBjb3BpZWRMb2NhbFN0 b3JhZ2VEaXJlY3RvcnkgPSBsb2NhbFN0b3JhZ2VEaXJlY3RvcnkuaW1wbCgpID8gbG9jYWxTdG9y YWdlRGlyZWN0b3J5LmltcGwoKS0+aXNvbGF0ZWRDb3B5KCkgOiBudWxscHRyOworCisgICAgbV9x dWV1ZS0+ZGlzcGF0Y2goYmluZCgmTG9jYWxTdG9yYWdlRGF0YWJhc2VUcmFja2VyOjpzZXRMb2Nh bFN0b3JhZ2VEaXJlY3RvcnlJbnRlcm5hbCwgdGhpcywgY29waWVkTG9jYWxTdG9yYWdlRGlyZWN0 b3J5LnJlbGVhc2UoKSkpOwogfQogCiBTdHJpbmcgTG9jYWxTdG9yYWdlRGF0YWJhc2VUcmFja2Vy OjpkYXRhYmFzZVBhdGgoU2VjdXJpdHlPcmlnaW4qIHNlY3VyaXR5T3JpZ2luKSBjb25zdApAQCAt MTI5LDcgKzEzMiw3IEBAIFZlY3RvcjxSZWZQdHI8V2ViQ29yZTo6U2VjdXJpdHlPcmlnaW4+PiBM b2NhbFN0b3JhZ2VEYXRhYmFzZVRyYWNrZXI6Om9yaWdpbnMoKSBjCiAgICAgcmV0dXJuIG9yaWdp bnM7CiB9CiAKLXZvaWQgTG9jYWxTdG9yYWdlRGF0YWJhc2VUcmFja2VyOjpzZXRMb2NhbFN0b3Jh Z2VEaXJlY3RvcnlJbnRlcm5hbChjb25zdCBTdHJpbmcmIGxvY2FsU3RvcmFnZURpcmVjdG9yeSkK K3ZvaWQgTG9jYWxTdG9yYWdlRGF0YWJhc2VUcmFja2VyOjpzZXRMb2NhbFN0b3JhZ2VEaXJlY3Rv cnlJbnRlcm5hbChTdHJpbmdJbXBsKiBsb2NhbFN0b3JhZ2VEaXJlY3RvcnkpCiB7CiAgICAgaWYg KG1fZGF0YWJhc2UuaXNPcGVuKCkpCiAgICAgICAgIG1fZGF0YWJhc2UuY2xvc2UoKTsKZGlmZiAt LWdpdCBhL1NvdXJjZS9XZWJLaXQyL1VJUHJvY2Vzcy9TdG9yYWdlL0xvY2FsU3RvcmFnZURhdGFi YXNlVHJhY2tlci5oIGIvU291cmNlL1dlYktpdDIvVUlQcm9jZXNzL1N0b3JhZ2UvTG9jYWxTdG9y YWdlRGF0YWJhc2VUcmFja2VyLmgKaW5kZXggMjI0OTg0M2I4OTg4ODE1ZjY5YjM2ZGVmOTJlZWRi YzQ4ZTVjZjNiYi4uZTE2NDI4OTA3MDU4NWNlYzYxZjQ5MzdlYzQ5MWU3ZjIwMTE1MjNjNiAxMDA2 NDQKLS0tIGEvU291cmNlL1dlYktpdDIvVUlQcm9jZXNzL1N0b3JhZ2UvTG9jYWxTdG9yYWdlRGF0 YWJhc2VUcmFja2VyLmgKKysrIGIvU291cmNlL1dlYktpdDIvVUlQcm9jZXNzL1N0b3JhZ2UvTG9j YWxTdG9yYWdlRGF0YWJhc2VUcmFja2VyLmgKQEAgLTU5LDcgKzU5LDcgQEAgcHVibGljOgogcHJp dmF0ZToKICAgICBleHBsaWNpdCBMb2NhbFN0b3JhZ2VEYXRhYmFzZVRyYWNrZXIoUGFzc1JlZlB0 cjxXb3JrUXVldWU+KTsKIAotICAgIHZvaWQgc2V0TG9jYWxTdG9yYWdlRGlyZWN0b3J5SW50ZXJu YWwoY29uc3QgU3RyaW5nJik7CisgICAgdm9pZCBzZXRMb2NhbFN0b3JhZ2VEaXJlY3RvcnlJbnRl cm5hbChTdHJpbmdJbXBsKik7CiAKICAgICBTdHJpbmcgZGF0YWJhc2VQYXRoKGNvbnN0IFN0cmlu ZyYgZmlsZW5hbWUpIGNvbnN0OwogICAgIFN0cmluZyB0cmFja2VyRGF0YWJhc2VQYXRoKCkgY29u c3Q7Cg==