119275 2013-07-30 14:10:54 -0700 Fix typo in enum name ("SelectionInSnaphot" -> "SelectionInSnapshot") 2013-07-30 14:26:04 -0700 1 1 1 Unclassified WebKit WebCore Misc. 528+ (Nightly build) Unspecified Unspecified RESOLVED FIXED P2 Normal --- 1 thorton thorton bdakin commit-queue simon.fraser oldest_to_newest 913017 0 thorton 2013-07-30 14:10:54 -0700 Just a typo. 913018 1 207765 thorton 2013-07-30 14:13:59 -0700 Created attachment 207765 patch 913019 2 commit-queue 2013-07-30 14:16:37 -0700 Attachment 207765 did not pass style-queue: Failed to run "['Tools/Scripts/check-webkit-style', '--diff-files', u'Source/WebCore/ChangeLog', u'Source/WebCore/WebCore.exp.in', u'Source/WebCore/page/FrameView.cpp', u'Source/WebCore/page/FrameView.h', u'Source/WebKit2/ChangeLog', u'Source/WebKit2/WebProcess/InjectedBundle/DOM/InjectedBundleNodeHandle.cpp', u'Source/WebKit2/WebProcess/WebPage/WebPage.cpp']" exit_code: 1 Source/WebKit2/ChangeLog:1: ChangeLog entry has no bug number [changelog/bugnumber] [5] Source/WebCore/ChangeLog:1: ChangeLog entry has no bug number [changelog/bugnumber] [5] Total errors found: 2 in 7 files If any of these errors are false positives, please file a bug against check-webkit-style. 913023 3 thorton 2013-07-30 14:26:04 -0700 http://trac.webkit.org/changeset/153493 207765 2013-07-30 14:13:59 -0700 2013-07-30 14:17:31 -0700 patch snaphot.diff text/plain 5746 thorton ZGlmZiAtLWdpdCBhL1NvdXJjZS9XZWJDb3JlL0NoYW5nZUxvZyBiL1NvdXJjZS9XZWJDb3JlL0No YW5nZUxvZwppbmRleCBjMTkzZTA1Li5mYjg2OWNlIDEwMDY0NAotLS0gYS9Tb3VyY2UvV2ViQ29y ZS9DaGFuZ2VMb2cKKysrIGIvU291cmNlL1dlYkNvcmUvQ2hhbmdlTG9nCkBAIC0xLDMgKzEsMTUg QEAKKzIwMTMtMDctMjMgIFRpbSBIb3J0b24gIDx0aW1vdGh5X2hvcnRvbkBhcHBsZS5jb20+CisK KyAgICAgICAgRml4IHR5cG8gaW4gZW51bSBuYW1lICgiU2VsZWN0aW9uSW5TbmFwaG90IiAtPiAi U2VsZWN0aW9uSW5TbmFwc2hvdCIpCisKKyAgICAgICAgUmV2aWV3ZWQgYnkgTk9CT0RZIChPT1BT ISkuCisKKyAgICAgICAgKiBXZWJDb3JlLmV4cC5pbjoKKyAgICAgICAgKiBwYWdlL0ZyYW1lVmll dy5jcHA6CisgICAgICAgIChXZWJDb3JlOjpGcmFtZVZpZXc6OnBhaW50Q29udGVudHNGb3JTbmFw c2hvdCk6CisgICAgICAgICogcGFnZS9GcmFtZVZpZXcuaDoKKyAgICAgICAgRml4IHR5cG8uCisK IDIwMTMtMDctMzAgIFBhdHJpY2sgR2Fuc3RlcmVyICA8cGFyb2dhQHdlYmtpdC5vcmc+CiAKICAg ICAgICAgW1dJTl0gUmVtb3ZlIGRlcGVuZGVuY3kgb24gQ29yZUZvdW5kYXRpb24gZnJvbSBEb3du bG9hZEJ1bmRsZQpkaWZmIC0tZ2l0IGEvU291cmNlL1dlYkNvcmUvV2ViQ29yZS5leHAuaW4gYi9T b3VyY2UvV2ViQ29yZS9XZWJDb3JlLmV4cC5pbgppbmRleCBjZjQ5MjQyLi40N2MzMDg3IDEwMDY0 NAotLS0gYS9Tb3VyY2UvV2ViQ29yZS9XZWJDb3JlLmV4cC5pbgorKysgYi9Tb3VyY2UvV2ViQ29y ZS9XZWJDb3JlLmV4cC5pbgpAQCAtMTE3Miw3ICsxMTcyLDcgQEAgX19aTjdXZWJDb3JlOUZyYW1l VmlldzIxcmVzdW1lQW5pbWF0aW5nSW1hZ2VzRXYKIF9fWk43V2ViQ29yZTlGcmFtZVZpZXcyMnNl dEJhc2VCYWNrZ3JvdW5kQ29sb3JFUktOU181Q29sb3JFCiBfX1pON1dlYkNvcmU5RnJhbWVWaWV3 MjN1cGRhdGVDYW5IYXZlU2Nyb2xsYmFyc0V2CiBfX1pON1dlYkNvcmU5RnJhbWVWaWV3MjRmb3Jj ZUxheW91dEZvclBhZ2luYXRpb25FUktOU185RmxvYXRTaXplRVMzX2ZOU18xOUFkanVzdFZpZXdT aXplT3JOb3RFCi1fX1pON1dlYkNvcmU5RnJhbWVWaWV3MjRwYWludENvbnRlbnRzRm9yU25hcHNo b3RFUE5TXzE1R3JhcGhpY3NDb250ZXh0RVJLTlNfN0ludFJlY3RFTlMwXzE4U2VsZWN0aW9uSW5T bmFwaG90RU5TMF8yNkNvb3JkaW5hdGVTcGFjZUZvclNuYXBzaG90RQorX19aTjdXZWJDb3JlOUZy YW1lVmlldzI0cGFpbnRDb250ZW50c0ZvclNuYXBzaG90RVBOU18xNUdyYXBoaWNzQ29udGV4dEVS S05TXzdJbnRSZWN0RU5TMF8xOVNlbGVjdGlvbkluU25hcHNob3RFTlMwXzI2Q29vcmRpbmF0ZVNw YWNlRm9yU25hcHNob3RFCiBfX1pON1dlYkNvcmU5RnJhbWVWaWV3MjRzZXRTY3JvbGxQaW5uaW5n QmVoYXZpb3JFTlNfMjFTY3JvbGxQaW5uaW5nQmVoYXZpb3JFCiBfX1pON1dlYkNvcmU5RnJhbWVW aWV3MjZhZGp1c3RQYWdlSGVpZ2h0RGVwcmVjYXRlZEVQZmZmZgogX19aTjdXZWJDb3JlOUZyYW1l VmlldzI2YWRqdXN0VGlsZWRCYWNraW5nQ292ZXJhZ2VFdgpkaWZmIC0tZ2l0IGEvU291cmNlL1dl YkNvcmUvcGFnZS9GcmFtZVZpZXcuY3BwIGIvU291cmNlL1dlYkNvcmUvcGFnZS9GcmFtZVZpZXcu Y3BwCmluZGV4IDU5OTlkNmIuLmMzZDJmYTUgMTAwNjQ0Ci0tLSBhL1NvdXJjZS9XZWJDb3JlL3Bh Z2UvRnJhbWVWaWV3LmNwcAorKysgYi9Tb3VyY2UvV2ViQ29yZS9wYWdlL0ZyYW1lVmlldy5jcHAK QEAgLTM2NzIsNyArMzY3Miw3IEBAIHZvaWQgRnJhbWVWaWV3OjpzZXROb2RlVG9EcmF3KE5vZGUq IG5vZGUpCiAgICAgbV9ub2RlVG9EcmF3ID0gbm9kZTsKIH0KIAotdm9pZCBGcmFtZVZpZXc6OnBh aW50Q29udGVudHNGb3JTbmFwc2hvdChHcmFwaGljc0NvbnRleHQqIGNvbnRleHQsIGNvbnN0IElu dFJlY3QmIGltYWdlUmVjdCwgU2VsZWN0aW9uSW5TbmFwaG90IHNob3VsZFBhaW50U2VsZWN0aW9u LCBDb29yZGluYXRlU3BhY2VGb3JTbmFwc2hvdCBjb29yZGluYXRlU3BhY2UpCit2b2lkIEZyYW1l Vmlldzo6cGFpbnRDb250ZW50c0ZvclNuYXBzaG90KEdyYXBoaWNzQ29udGV4dCogY29udGV4dCwg Y29uc3QgSW50UmVjdCYgaW1hZ2VSZWN0LCBTZWxlY3Rpb25JblNuYXBzaG90IHNob3VsZFBhaW50 U2VsZWN0aW9uLCBDb29yZGluYXRlU3BhY2VGb3JTbmFwc2hvdCBjb29yZGluYXRlU3BhY2UpCiB7 CiAgICAgdXBkYXRlTGF5b3V0QW5kU3R5bGVJZk5lZWRlZFJlY3Vyc2l2ZSgpOwogCmRpZmYgLS1n aXQgYS9Tb3VyY2UvV2ViQ29yZS9wYWdlL0ZyYW1lVmlldy5oIGIvU291cmNlL1dlYkNvcmUvcGFn ZS9GcmFtZVZpZXcuaAppbmRleCBhNDc5MDM3Li40MzFiMjkzIDEwMDY0NAotLS0gYS9Tb3VyY2Uv V2ViQ29yZS9wYWdlL0ZyYW1lVmlldy5oCisrKyBiL1NvdXJjZS9XZWJDb3JlL3BhZ2UvRnJhbWVW aWV3LmgKQEAgLTI3Nyw5ICsyNzcsOSBAQCBwdWJsaWM6CiAgICAgdm9pZCBzZXRMYXN0UGFpbnRU aW1lKGRvdWJsZSBsYXN0UGFpbnRUaW1lKSB7IG1fbGFzdFBhaW50VGltZSA9IGxhc3RQYWludFRp bWU7IH0KICAgICB2b2lkIHNldE5vZGVUb0RyYXcoTm9kZSopOwogCi0gICAgZW51bSBTZWxlY3Rp b25JblNuYXBob3QgeyBJbmNsdWRlU2VsZWN0aW9uLCBFeGNsdWRlU2VsZWN0aW9uIH07CisgICAg ZW51bSBTZWxlY3Rpb25JblNuYXBzaG90IHsgSW5jbHVkZVNlbGVjdGlvbiwgRXhjbHVkZVNlbGVj dGlvbiB9OwogICAgIGVudW0gQ29vcmRpbmF0ZVNwYWNlRm9yU25hcHNob3QgeyBEb2N1bWVudENv b3JkaW5hdGVzLCBWaWV3Q29vcmRpbmF0ZXMgfTsKLSAgICB2b2lkIHBhaW50Q29udGVudHNGb3JT bmFwc2hvdChHcmFwaGljc0NvbnRleHQqLCBjb25zdCBJbnRSZWN0JiBpbWFnZVJlY3QsIFNlbGVj dGlvbkluU25hcGhvdCBzaG91bGRQYWludFNlbGVjdGlvbiwgQ29vcmRpbmF0ZVNwYWNlRm9yU25h cHNob3QpOworICAgIHZvaWQgcGFpbnRDb250ZW50c0ZvclNuYXBzaG90KEdyYXBoaWNzQ29udGV4 dCosIGNvbnN0IEludFJlY3QmIGltYWdlUmVjdCwgU2VsZWN0aW9uSW5TbmFwc2hvdCBzaG91bGRQ YWludFNlbGVjdGlvbiwgQ29vcmRpbmF0ZVNwYWNlRm9yU25hcHNob3QpOwogCiAgICAgdmlydHVh bCB2b2lkIHBhaW50T3ZlcmhhbmdBcmVhcyhHcmFwaGljc0NvbnRleHQqLCBjb25zdCBJbnRSZWN0 JiBob3Jpem9udGFsT3ZlcmhhbmdBcmVhLCBjb25zdCBJbnRSZWN0JiB2ZXJ0aWNhbE92ZXJoYW5n QXJlYSwgY29uc3QgSW50UmVjdCYgZGlydHlSZWN0KTsKICAgICB2aXJ0dWFsIHZvaWQgcGFpbnRT Y3JvbGxDb3JuZXIoR3JhcGhpY3NDb250ZXh0KiwgY29uc3QgSW50UmVjdCYgY29ybmVyUmVjdCk7 CmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViS2l0Mi9DaGFuZ2VMb2cgYi9Tb3VyY2UvV2ViS2l0Mi9D aGFuZ2VMb2cKaW5kZXggZjMxMjY2Ny4uMDAyYmViYyAxMDA2NDQKLS0tIGEvU291cmNlL1dlYktp dDIvQ2hhbmdlTG9nCisrKyBiL1NvdXJjZS9XZWJLaXQyL0NoYW5nZUxvZwpAQCAtMSwzICsxLDE1 IEBACisyMDEzLTA3LTIzICBUaW0gSG9ydG9uICA8dGltb3RoeV9ob3J0b25AYXBwbGUuY29tPgor CisgICAgICAgIEZpeCB0eXBvIGluIGVudW0gbmFtZSAoIlNlbGVjdGlvbkluU25hcGhvdCIgLT4g IlNlbGVjdGlvbkluU25hcHNob3QiKQorCisgICAgICAgIFJldmlld2VkIGJ5IE5PQk9EWSAoT09Q UyEpLgorCisgICAgICAgICogV2ViUHJvY2Vzcy9JbmplY3RlZEJ1bmRsZS9ET00vSW5qZWN0ZWRC dW5kbGVOb2RlSGFuZGxlLmNwcDoKKyAgICAgICAgKFdlYktpdDo6aW1hZ2VGb3JSZWN0KToKKyAg ICAgICAgKiBXZWJQcm9jZXNzL1dlYlBhZ2UvV2ViUGFnZS5jcHA6CisgICAgICAgIChXZWJLaXQ6 OldlYlBhZ2U6OnNjYWxlZFNuYXBzaG90V2l0aE9wdGlvbnMpOgorICAgICAgICBGaXggdHlwby4K KwogMjAxMy0wNy0zMCAgQW5kZXJzIENhcmxzc29uICA8YW5kZXJzY2FAYXBwbGUuY29tPgogCiAg ICAgICAgIFBsdWctaW4gcHJvY2VzcyBjcmFzaGVzIGlmIHBsdWctaW4gaXMgZGVzdHJveWVkIGFz IGEgcmVzdWx0IG9mIHNlbmRpbmcgTlBPYmplY3RNZXNzYWdlUmVjZWl2ZXI6OkRlYWxsb2NhdGUK ZGlmZiAtLWdpdCBhL1NvdXJjZS9XZWJLaXQyL1dlYlByb2Nlc3MvSW5qZWN0ZWRCdW5kbGUvRE9N L0luamVjdGVkQnVuZGxlTm9kZUhhbmRsZS5jcHAgYi9Tb3VyY2UvV2ViS2l0Mi9XZWJQcm9jZXNz L0luamVjdGVkQnVuZGxlL0RPTS9JbmplY3RlZEJ1bmRsZU5vZGVIYW5kbGUuY3BwCmluZGV4IDUy OWY1MGIuLjdkZmY4MmMgMTAwNjQ0Ci0tLSBhL1NvdXJjZS9XZWJLaXQyL1dlYlByb2Nlc3MvSW5q ZWN0ZWRCdW5kbGUvRE9NL0luamVjdGVkQnVuZGxlTm9kZUhhbmRsZS5jcHAKKysrIGIvU291cmNl L1dlYktpdDIvV2ViUHJvY2Vzcy9JbmplY3RlZEJ1bmRsZS9ET00vSW5qZWN0ZWRCdW5kbGVOb2Rl SGFuZGxlLmNwcApAQCAtMTM5LDcgKzEzOSw3IEBAIHN0YXRpYyBQYXNzUmVmUHRyPFdlYkltYWdl PiBpbWFnZUZvclJlY3QoRnJhbWVWaWV3KiBmcmFtZVZpZXcsIGNvbnN0IEludFJlY3QmIHJlCiAg ICAgZ3JhcGhpY3NDb250ZXh0LT5hcHBseURldmljZVNjYWxlRmFjdG9yKHNjYWxlRmFjdG9yKTsK ICAgICBncmFwaGljc0NvbnRleHQtPnRyYW5zbGF0ZSgtcmVjdC54KCksIC1yZWN0LnkoKSk7CiAK LSAgICBGcmFtZVZpZXc6OlNlbGVjdGlvbkluU25hcGhvdCBzaG91bGRQYWludFNlbGVjdGlvbiA9 IEZyYW1lVmlldzo6SW5jbHVkZVNlbGVjdGlvbjsKKyAgICBGcmFtZVZpZXc6OlNlbGVjdGlvbklu U25hcHNob3Qgc2hvdWxkUGFpbnRTZWxlY3Rpb24gPSBGcmFtZVZpZXc6OkluY2x1ZGVTZWxlY3Rp b247CiAgICAgaWYgKG9wdGlvbnMgJiBTbmFwc2hvdE9wdGlvbnNFeGNsdWRlU2VsZWN0aW9uSGln aGxpZ2h0aW5nKQogICAgICAgICBzaG91bGRQYWludFNlbGVjdGlvbiA9IEZyYW1lVmlldzo6RXhj bHVkZVNlbGVjdGlvbjsKIApkaWZmIC0tZ2l0IGEvU291cmNlL1dlYktpdDIvV2ViUHJvY2Vzcy9X ZWJQYWdlL1dlYlBhZ2UuY3BwIGIvU291cmNlL1dlYktpdDIvV2ViUHJvY2Vzcy9XZWJQYWdlL1dl YlBhZ2UuY3BwCmluZGV4IGQxZWI3MWEuLmI1Mzg1MDQgMTAwNjQ0Ci0tLSBhL1NvdXJjZS9XZWJL aXQyL1dlYlByb2Nlc3MvV2ViUGFnZS9XZWJQYWdlLmNwcAorKysgYi9Tb3VyY2UvV2ViS2l0Mi9X ZWJQcm9jZXNzL1dlYlBhZ2UvV2ViUGFnZS5jcHAKQEAgLTE1MjMsNyArMTUyMyw3IEBAIFBhc3NS ZWZQdHI8V2ViSW1hZ2U+IFdlYlBhZ2U6OnNjYWxlZFNuYXBzaG90V2l0aE9wdGlvbnMoY29uc3Qg SW50UmVjdCYgcmVjdCwgZG91CiAgICAgZ3JhcGhpY3NDb250ZXh0LT5hcHBseURldmljZVNjYWxl RmFjdG9yKGNvbWJpbmVkU2NhbGVGYWN0b3IpOwogICAgIGdyYXBoaWNzQ29udGV4dC0+dHJhbnNs YXRlKC1yZWN0LngoKSwgLXJlY3QueSgpKTsKIAotICAgIEZyYW1lVmlldzo6U2VsZWN0aW9uSW5T bmFwaG90IHNob3VsZFBhaW50U2VsZWN0aW9uID0gRnJhbWVWaWV3OjpJbmNsdWRlU2VsZWN0aW9u OworICAgIEZyYW1lVmlldzo6U2VsZWN0aW9uSW5TbmFwc2hvdCBzaG91bGRQYWludFNlbGVjdGlv biA9IEZyYW1lVmlldzo6SW5jbHVkZVNlbGVjdGlvbjsKICAgICBpZiAob3B0aW9ucyAmIFNuYXBz aG90T3B0aW9uc0V4Y2x1ZGVTZWxlY3Rpb25IaWdobGlnaHRpbmcpCiAgICAgICAgIHNob3VsZFBh aW50U2VsZWN0aW9uID0gRnJhbWVWaWV3OjpFeGNsdWRlU2VsZWN0aW9uOwogCg==