119272 2013-07-30 13:26:37 -0700 Broken build with build-webkit --no-webgl 2013-08-12 11:40:14 -0700 1 1 1 Unclassified WebKit WebGL 528+ (Nightly build) Unspecified Unspecified RESOLVED FIXED P2 Normal --- 1 tonikitoo webkit-unassigned achicu benjamin cmarcelo commit-queue oldest_to_newest 913001 0 tonikitoo 2013-07-30 13:26:37 -0700 It seems code guarded by CSS_SHADER uses Angle, which is not built with --no-webgl. 915263 1 208298 ragner.magalhaes 2013-08-07 13:58:22 -0700 Created attachment 208298 Patch CSS Shaders requires WebGL. Add error message to dependency failure. 915388 2 tonikitoo 2013-08-08 05:19:21 -0700 @achicu: CSS Shaders require ANGLE to build, and this is not available if WEBGL if disabled from say build-webkit. Does it make sense to have a hard dependency on each other, as the patch does? 915391 3 208298 tonikitoo 2013-08-08 05:21:15 -0700 Comment on attachment 208298 Patch please read http://www.webkit.org/coding/contributing.html 916273 4 208539 ragner.magalhaes 2013-08-12 07:32:01 -0700 Created attachment 208539 Patch 916342 5 208539 tonikitoo 2013-08-12 10:52:21 -0700 Comment on attachment 208539 Patch View in context: https://bugs.webkit.org/attachment.cgi?id=208539&action=review > Source/WTF/ChangeLog:8 > + CSS_SHADERS requires WEBGL enabled. Is not it more accurate to say that it requeres ANGLE, which is only available when WebGL is on? 916347 6 208539 achicu 2013-08-12 11:09:39 -0700 Comment on attachment 208539 Patch View in context: https://bugs.webkit.org/attachment.cgi?id=208539&action=review >> Source/WTF/ChangeLog:8 >> + CSS_SHADERS requires WEBGL enabled. > > Is not it more accurate to say that it requeres ANGLE, which is only available when WebGL is on? Custom Filters are implemented on top of WebGL. We are only using ANGLE to validate the shaders, so we need both. 916348 7 208539 tonikitoo 2013-08-12 11:17:21 -0700 Comment on attachment 208539 Patch View in context: https://bugs.webkit.org/attachment.cgi?id=208539&action=review >>> Source/WTF/ChangeLog:8 >>> + CSS_SHADERS requires WEBGL enabled. >> >> Is not it more accurate to say that it requeres ANGLE, which is only available when WebGL is on? > > Custom Filters are implemented on top of WebGL. We are only using ANGLE to validate the shaders, so we need both. ok thanks 916352 8 208539 commit-queue 2013-08-12 11:40:12 -0700 Comment on attachment 208539 Patch Clearing flags on attachment: 208539 Committed r153951: <http://trac.webkit.org/changeset/153951> 916353 9 commit-queue 2013-08-12 11:40:14 -0700 All reviewed patches have been landed. Closing bug. 208298 2013-08-07 13:58:22 -0700 2013-08-12 07:31:50 -0700 Patch 0001-2013-08-07-Ragner-Magalhaes-ranger.n-samsung.com.patch text/plain 929 ragner.magalhaes RnJvbSA5ZWEwMDI1MWY4MGUwOTA0NjhmMDU2ZjZmMWJmMWQ5ZGU0ODU1ODlkIE1vbiBTZXAgMTcg MDA6MDA6MDAgMjAwMQpGcm9tOiBSYWduZXIgTWFnYWxoYWVzIDxyYW5nZXIubkBzYW1zdW5nLmNv bT4KRGF0ZTogV2VkLCA3IEF1ZyAyMDEzIDE2OjMxOjE4IC0wNDAwClN1YmplY3Q6IFtQQVRDSF0g MjAxMy0wOC0wNyAgUmFnbmVyIE1hZ2FsaGFlcyAgPHJhbmdlci5uQHNhbXN1bmcuY29tPgoKICAg ICAgICBDU1MgU2hhZGVycyByZXF1aXJlcyBXZWJHTC4gQWRkIGVycm9yIG1lc3NhZ2UgdG8gZGVw ZW5kZW5jeSBmYWlsdXJlLgogICAgICAgIGh0dHBzOi8vYnVncy53ZWJraXQub3JnL3Nob3dfYnVn LmNnaT9pZD0xMTkyNzIKCiAgICAgICAgUmV2aWV3ZWQgYnkgTk9CT0RZIChPT1BTISkuCgogICAg ICAgICogd3RmL0ZlYXR1cmVEZWZpbmVzLmg6Ci0tLQogU291cmNlL1dURi93dGYvRmVhdHVyZURl ZmluZXMuaCB8IDQgKysrKwogMSBmaWxlIGNoYW5nZWQsIDQgaW5zZXJ0aW9ucygrKQoKZGlmZiAt LWdpdCBhL1NvdXJjZS9XVEYvd3RmL0ZlYXR1cmVEZWZpbmVzLmggYi9Tb3VyY2UvV1RGL3d0Zi9G ZWF0dXJlRGVmaW5lcy5oCmluZGV4IDczMjljOTUuLmEyZTVjODIgMTAwNjQ0Ci0tLSBhL1NvdXJj ZS9XVEYvd3RmL0ZlYXR1cmVEZWZpbmVzLmgKKysrIGIvU291cmNlL1dURi93dGYvRmVhdHVyZURl ZmluZXMuaApAQCAtODM0LDQgKzgzNCw4IEBACiAjZXJyb3IgIkVOQUJMRShWSURFT19UUkFDSykg cmVxdWlyZXMgRU5BQkxFKFZJREVPKSIKICNlbmRpZgogCisjaWYgRU5BQkxFKENTU19TSEFERVJT KSAmJiAhRU5BQkxFKFdFQkdMKQorI2Vycm9yICJFTkFCTEUoQ1NTX1NIQURFUlMpIHJlcXVpcmVz IEVOQUJMRShXRUJHTCkiCisjZW5kaWYKKwogI2VuZGlmIC8qIFdURl9GZWF0dXJlRGVmaW5lc19o ICovCi0tIAoxLjguMS4yCgo= 208539 2013-08-12 07:32:01 -0700 2013-08-12 11:40:12 -0700 Patch bug-119272-20130812103159.patch text/plain 1162 ragner.magalhaes U3VidmVyc2lvbiBSZXZpc2lvbjogMTUzOTQxCmRpZmYgLS1naXQgYS9Tb3VyY2UvV1RGL0NoYW5n ZUxvZyBiL1NvdXJjZS9XVEYvQ2hhbmdlTG9nCmluZGV4IDNiNDM3Nzk4YTg5MmNmZTYxN2VhYzkx YjFmZmE3MDcxYzliZTkzZjYuLjlkNThhZjJkYmQwMjdlM2E2ODU4ZWM2MTg1OTQwNjE1OGYyNTQx MjkgMTAwNjQ0Ci0tLSBhL1NvdXJjZS9XVEYvQ2hhbmdlTG9nCisrKyBiL1NvdXJjZS9XVEYvQ2hh bmdlTG9nCkBAIC0xLDMgKzEsMTUgQEAKKzIwMTMtMDgtMTIgIFJhZ25lciBNYWdhbGhhZXMgIDxy YW5nZXIubkBzYW1zdW5nLmNvbT4KKworICAgICAgICBCcm9rZW4gYnVpbGQgd2l0aCBidWlsZC13 ZWJraXQgLS1uby13ZWJnbAorICAgICAgICBodHRwczovL2J1Z3Mud2Via2l0Lm9yZy9zaG93X2J1 Zy5jZ2k/aWQ9MTE5MjcyCisKKyAgICAgICAgUmV2aWV3ZWQgYnkgTk9CT0RZIChPT1BTISkuCisK KyAgICAgICAgQ1NTX1NIQURFUlMgcmVxdWlyZXMgV0VCR0wgZW5hYmxlZC4KKyAgICAgICAgQWRk IGVycm9yIG1lc3NhZ2UgdG8gZGVwZW5kZW5jeSBmYWlsdXJlLgorCisgICAgICAgICogd3RmL0Zl YXR1cmVEZWZpbmVzLmg6CisKIDIwMTMtMDgtMTEgIENhcmxvcyBHYXJjaWEgQ2FtcG9zICA8Y2dh cmNpYUBpZ2FsaWEuY29tPgogCiAgICAgICAgIFVucmV2aWV3ZWQuIEZpeCBtYWtlIGRpc3RjaGVj ay4KZGlmZiAtLWdpdCBhL1NvdXJjZS9XVEYvd3RmL0ZlYXR1cmVEZWZpbmVzLmggYi9Tb3VyY2Uv V1RGL3d0Zi9GZWF0dXJlRGVmaW5lcy5oCmluZGV4IGY3YTNiOWRhNzA2YjYzMDY3N2Y0ZmVhNDRl MDgzYzlhZWYxYWY3ZTQuLjZjZGFkZTkxNGRkNWQ5YTgxOTU3MWFkMGNmYzQ4ZTk5Yzc1ZTMxOGIg MTAwNjQ0Ci0tLSBhL1NvdXJjZS9XVEYvd3RmL0ZlYXR1cmVEZWZpbmVzLmgKKysrIGIvU291cmNl L1dURi93dGYvRmVhdHVyZURlZmluZXMuaApAQCAtODUwLDQgKzg1MCw4IEBACiAjZXJyb3IgIkVO QUJMRShWSURFT19UUkFDSykgcmVxdWlyZXMgRU5BQkxFKFZJREVPKSIKICNlbmRpZgogCisjaWYg RU5BQkxFKENTU19TSEFERVJTKSAmJiAhRU5BQkxFKFdFQkdMKQorI2Vycm9yICJFTkFCTEUoQ1NT X1NIQURFUlMpIHJlcXVpcmVzIEVOQUJMRShXRUJHTCkiCisjZW5kaWYKKwogI2VuZGlmIC8qIFdU Rl9GZWF0dXJlRGVmaW5lc19oICovCg==