119258 2013-07-30 07:28:26 -0700 [WebKit2] [Gtk] WebKitResponsePolicyDecision URI response property incorrect 2013-07-30 10:29:44 -0700 1 1 1 Unclassified WebKit WebKitGTK 528+ (Nightly build) Unspecified Unspecified RESOLVED FIXED P2 Normal --- 0 brian.holt webkit-unassigned cgarcia commit-queue gustavo mrobinson oldest_to_newest 912834 0 brian.holt 2013-07-30 07:28:26 -0700 g_object_class_install_property(objectClass, PROP_REQUEST, g_param_spec_object("response", _("URI response"), _("The URI response that is associated with this policy decision"), WEBKIT_TYPE_URI_REQUEST, WEBKIT_PARAM_READABLE)); 912837 1 207736 brian.holt 2013-07-30 07:44:34 -0700 Created attachment 207736 Patch 912839 2 commit-queue 2013-07-30 07:47:21 -0700 Thanks for the patch. If this patch contains new public API please make sure it follows the guidelines for new WebKit2 GTK+ API. See http://trac.webkit.org/wiki/WebKitGTK/AddingNewWebKit2API 912840 3 207736 brian.holt 2013-07-30 07:50:37 -0700 Comment on attachment 207736 Patch Cancelling review: in eclipse I couldn't see the _ that preceded the parentheses. Apologies. 912841 4 207737 brian.holt 2013-07-30 07:52:40 -0700 Created attachment 207737 Patch 912843 5 207737 brian.holt 2013-07-30 08:03:49 -0700 Comment on attachment 207737 Patch Thanks for the review! Setting CQ? 912844 6 207737 cgarcia 2013-07-30 08:04:42 -0700 Comment on attachment 207737 Patch What was wrong here? just the coding style? 912845 7 207737 cgarcia 2013-07-30 08:06:47 -0700 Comment on attachment 207737 Patch Ah I see we were using WEBKIT_TYPE_URI_REQUEST instead of WEBKIT_TYPE_URI_RESPONSE, the change was hidden in the conding style "fixes". Please explain what you are fixing in the changelog before landing this. 912846 8 brian.holt 2013-07-30 08:13:28 -0700 (In reply to comment #7) > (From update of attachment 207737 [details]) > Ah I see we were using WEBKIT_TYPE_URI_REQUEST instead of WEBKIT_TYPE_URI_RESPONSE, the change was hidden in the conding style "fixes". Please explain what you are fixing in the changelog before landing this. Sorry Carlos, I though my comment in the changeLog "Corrected the installed URI response property" was sufficient but I'll expand on that a bit more. Its definitely not just a style change :-) 912849 9 207738 brian.holt 2013-07-30 08:18:24 -0700 Created attachment 207738 Updated Patch 912850 10 cgarcia 2013-07-30 08:20:50 -0700 (In reply to comment #8) > (In reply to comment #7) > > (From update of attachment 207737 [details] [details]) > > Ah I see we were using WEBKIT_TYPE_URI_REQUEST instead of WEBKIT_TYPE_URI_RESPONSE, the change was hidden in the conding style "fixes". Please explain what you are fixing in the changelog before landing this. > > Sorry Carlos, I though my comment in the changeLog "Corrected the installed URI response property" was sufficient but I'll expand on that a bit more. Its definitely not just a style change :-) That says there's something wrong, but not what, it took me a while to find what was wrong. Thanks for updating it. 912851 11 cgarcia 2013-07-30 08:22:39 -0700 (In reply to comment #9) > Created an attachment (id=207738) [details] > Updated Patch When submitting an updated patch that has already been r+'ed, you can upload the patch with the reviewer line filled, and only ask for commit-queue. Note that I didn't r- the patch, just cq-. 912852 12 207739 brian.holt 2013-07-30 08:27:38 -0700 Created attachment 207739 Updated Patch 912855 13 207739 cgarcia 2013-07-30 08:35:36 -0700 Comment on attachment 207739 Updated Patch Excellent, thanks! 912858 14 mrobinson 2013-07-30 08:47:18 -0700 Thanks for pointing that out Carlos. It took me a moment to find the actual issue. And thanks Brian for fixing it. :) 912926 15 207739 commit-queue 2013-07-30 10:29:42 -0700 Comment on attachment 207739 Updated Patch Clearing flags on attachment: 207739 Committed r153479: <http://trac.webkit.org/changeset/153479> 912927 16 commit-queue 2013-07-30 10:29:44 -0700 All reviewed patches have been landed. Closing bug. 207736 2013-07-30 07:44:34 -0700 2013-07-30 07:52:33 -0700 Patch bug-119258-20130730154458.patch text/plain 3074 brian.holt U3VidmVyc2lvbiBSZXZpc2lvbjogMTUzNDY4CmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViS2l0Mi9D aGFuZ2VMb2cgYi9Tb3VyY2UvV2ViS2l0Mi9DaGFuZ2VMb2cKaW5kZXggZGE4NzRkYTQyNWNmMTI2 ODVmNWQxYzY3NGU3N2FmZDZlOGNiYzk5NC4uY2M0NGE4NjA3MTEwYzA0OTg0OTJjMzZhMGU0MWU4 Njg2NmFkNGE4YyAxMDA2NDQKLS0tIGEvU291cmNlL1dlYktpdDIvQ2hhbmdlTG9nCisrKyBiL1Nv dXJjZS9XZWJLaXQyL0NoYW5nZUxvZwpAQCAtMSwzICsxLDE1IEBACisyMDEzLTA3LTMwICBCcmlh biBIb2x0ICA8YnJpYW4uaG9sdEBzYW1zdW5nLmNvbT4KKworICAgICAgICBbV2ViS2l0Ml0gW0d0 a10gV2ViS2l0UmVzcG9uc2VQb2xpY3lEZWNpc2lvbiBVUkkgcmVzcG9uc2UgcHJvcGVydHkgaW5j b3JyZWN0CisgICAgICAgIGh0dHBzOi8vYnVncy53ZWJraXQub3JnL3Nob3dfYnVnLmNnaT9pZD0x MTkyNTgKKworICAgICAgICBSZXZpZXdlZCBieSBOT0JPRFkgKE9PUFMhKS4KKworICAgICAgICBD b3JyZWN0ZWQgdGhlIGluc3RhbGxlZCBVUkkgcmVzcG9uc2UgcHJvcGVydHkuCisKKyAgICAgICAg KiBVSVByb2Nlc3MvQVBJL2d0ay9XZWJLaXRSZXNwb25zZVBvbGljeURlY2lzaW9uLmNwcDoKKyAg ICAgICAgKHdlYmtpdF9yZXNwb25zZV9wb2xpY3lfZGVjaXNpb25fY2xhc3NfaW5pdCk6CisKIDIw MTMtMDctMjkgIENhcmxvcyBHYXJjaWEgQ2FtcG9zICA8Y2dhcmNpYUBpZ2FsaWEuY29tPgogCiAg ICAgICAgIFVucmV2aWV3ZWQuIEZpeCBtYWtlIGRpc3RjaGVjay4KZGlmZiAtLWdpdCBhL1NvdXJj ZS9XZWJLaXQyL1VJUHJvY2Vzcy9BUEkvZ3RrL1dlYktpdFJlc3BvbnNlUG9saWN5RGVjaXNpb24u Y3BwIGIvU291cmNlL1dlYktpdDIvVUlQcm9jZXNzL0FQSS9ndGsvV2ViS2l0UmVzcG9uc2VQb2xp Y3lEZWNpc2lvbi5jcHAKaW5kZXggM2E3NWUzOGM5MWUwYTM5YmJhY2QyMWExYThlOTg4ZjIzM2Nh ZTkwMi4uMTFjZTNmOTQ2NGI0ZTIzZWVmNTkwYzQxZDE5M2ZhZGExN2VmZTkyMCAxMDA2NDQKLS0t IGEvU291cmNlL1dlYktpdDIvVUlQcm9jZXNzL0FQSS9ndGsvV2ViS2l0UmVzcG9uc2VQb2xpY3lE ZWNpc2lvbi5jcHAKKysrIGIvU291cmNlL1dlYktpdDIvVUlQcm9jZXNzL0FQSS9ndGsvV2ViS2l0 UmVzcG9uc2VQb2xpY3lEZWNpc2lvbi5jcHAKQEAgLTg2LDEyICs4NiwxMiBAQCBzdGF0aWMgdm9p ZCB3ZWJraXRfcmVzcG9uc2VfcG9saWN5X2RlY2lzaW9uX2NsYXNzX2luaXQoV2ViS2l0UmVzcG9u c2VQb2xpY3lEZWNpcwogICAgICAqIHBvbGljeSBkZWNpc2lvbi4KICAgICAgKi8KICAgICBnX29i amVjdF9jbGFzc19pbnN0YWxsX3Byb3BlcnR5KG9iamVjdENsYXNzLAotICAgICAgICAgICAgICAg ICAgICAgICAgICAgICAgICAgICAgUFJPUF9SRVFVRVNULAotICAgICAgICAgICAgICAgICAgICAg ICAgICAgICAgICAgICAgZ19wYXJhbV9zcGVjX29iamVjdCgicmVxdWVzdCIsCi0gICAgICAgICAg ICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICBfKCJSZXNwb25zZSBV UkkgcmVxdWVzdCIpLAotICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAg ICAgICAgICAgICAgXygiVGhlIFVSSSByZXF1ZXN0IHRoYXQgaXMgYXNzb2NpYXRlZCB3aXRoIHRo aXMgcG9saWN5IGRlY2lzaW9uIiksCi0gICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAg ICAgICAgICAgICAgICAgICAgICBXRUJLSVRfVFlQRV9VUklfUkVRVUVTVCwKLSAgICAgICAgICAg ICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgIFdFQktJVF9QQVJBTV9S RUFEQUJMRSkpOworICAgICAgICBQUk9QX1JFUVVFU1QsCisgICAgICAgIGdfcGFyYW1fc3BlY19v YmplY3QoInJlcXVlc3QiLAorICAgICAgICAgICAgKCJSZXNwb25zZSBVUkkgcmVxdWVzdCIpLAor ICAgICAgICAgICAgKCJUaGUgVVJJIHJlcXVlc3QgdGhhdCBpcyBhc3NvY2lhdGVkIHdpdGggdGhp cyBwb2xpY3kgZGVjaXNpb24iKSwKKyAgICAgICAgICAgIFdFQktJVF9UWVBFX1VSSV9SRVFVRVNU LAorICAgICAgICAgICAgV0VCS0lUX1BBUkFNX1JFQURBQkxFKSk7CiAKICAgICAvKioKICAgICAg KiBXZWJLaXRSZXNwb25zZVBvbGljeURlY2lzaW9uOnJlc3BvbnNlOgpAQCAtMTAwLDEyICsxMDAs MTIgQEAgc3RhdGljIHZvaWQgd2Via2l0X3Jlc3BvbnNlX3BvbGljeV9kZWNpc2lvbl9jbGFzc19p bml0KFdlYktpdFJlc3BvbnNlUG9saWN5RGVjaXMKICAgICAgKiBwb2xpY3kgZGVjaXNpb24uCiAg ICAgICovCiAgICAgZ19vYmplY3RfY2xhc3NfaW5zdGFsbF9wcm9wZXJ0eShvYmplY3RDbGFzcywK LSAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgIFBST1BfUkVRVUVTVCwKLSAgICAg ICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgIGdfcGFyYW1fc3BlY19vYmplY3QoInJlc3Bv bnNlIiwKLSAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAg ICAgIF8oIlVSSSByZXNwb25zZSIpLAotICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAg ICAgICAgICAgICAgICAgICAgICAgXygiVGhlIFVSSSByZXNwb25zZSB0aGF0IGlzIGFzc29jaWF0 ZWQgd2l0aCB0aGlzIHBvbGljeSBkZWNpc2lvbiIpLAotICAgICAgICAgICAgICAgICAgICAgICAg ICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgV0VCS0lUX1RZUEVfVVJJX1JFUVVFU1QsCi0g ICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICBXRUJL SVRfUEFSQU1fUkVBREFCTEUpKTsKKyAgICAgICAgUFJPUF9SRVNQT05TRSwKKyAgICAgICAgZ19w YXJhbV9zcGVjX29iamVjdCgicmVzcG9uc2UiLAorICAgICAgICAgICAgKCJVUkkgcmVzcG9uc2Ui KSwKKyAgICAgICAgICAgICgiVGhlIFVSSSByZXNwb25zZSB0aGF0IGlzIGFzc29jaWF0ZWQgd2l0 aCB0aGlzIHBvbGljeSBkZWNpc2lvbiIpLAorICAgICAgICAgICAgV0VCS0lUX1RZUEVfVVJJX1JF U1BPTlNFLAorICAgICAgICAgICAgV0VCS0lUX1BBUkFNX1JFQURBQkxFKSk7CiAKIH0KIAo= 207737 2013-07-30 07:52:40 -0700 2013-07-30 08:18:18 -0700 Patch bug-119258-20130730155304.patch text/plain 3078 brian.holt U3VidmVyc2lvbiBSZXZpc2lvbjogMTUzNDY4CmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViS2l0Mi9D aGFuZ2VMb2cgYi9Tb3VyY2UvV2ViS2l0Mi9DaGFuZ2VMb2cKaW5kZXggZGE4NzRkYTQyNWNmMTI2 ODVmNWQxYzY3NGU3N2FmZDZlOGNiYzk5NC4uY2M0NGE4NjA3MTEwYzA0OTg0OTJjMzZhMGU0MWU4 Njg2NmFkNGE4YyAxMDA2NDQKLS0tIGEvU291cmNlL1dlYktpdDIvQ2hhbmdlTG9nCisrKyBiL1Nv dXJjZS9XZWJLaXQyL0NoYW5nZUxvZwpAQCAtMSwzICsxLDE1IEBACisyMDEzLTA3LTMwICBCcmlh biBIb2x0ICA8YnJpYW4uaG9sdEBzYW1zdW5nLmNvbT4KKworICAgICAgICBbV2ViS2l0Ml0gW0d0 a10gV2ViS2l0UmVzcG9uc2VQb2xpY3lEZWNpc2lvbiBVUkkgcmVzcG9uc2UgcHJvcGVydHkgaW5j b3JyZWN0CisgICAgICAgIGh0dHBzOi8vYnVncy53ZWJraXQub3JnL3Nob3dfYnVnLmNnaT9pZD0x MTkyNTgKKworICAgICAgICBSZXZpZXdlZCBieSBOT0JPRFkgKE9PUFMhKS4KKworICAgICAgICBD b3JyZWN0ZWQgdGhlIGluc3RhbGxlZCBVUkkgcmVzcG9uc2UgcHJvcGVydHkuCisKKyAgICAgICAg KiBVSVByb2Nlc3MvQVBJL2d0ay9XZWJLaXRSZXNwb25zZVBvbGljeURlY2lzaW9uLmNwcDoKKyAg ICAgICAgKHdlYmtpdF9yZXNwb25zZV9wb2xpY3lfZGVjaXNpb25fY2xhc3NfaW5pdCk6CisKIDIw MTMtMDctMjkgIENhcmxvcyBHYXJjaWEgQ2FtcG9zICA8Y2dhcmNpYUBpZ2FsaWEuY29tPgogCiAg ICAgICAgIFVucmV2aWV3ZWQuIEZpeCBtYWtlIGRpc3RjaGVjay4KZGlmZiAtLWdpdCBhL1NvdXJj ZS9XZWJLaXQyL1VJUHJvY2Vzcy9BUEkvZ3RrL1dlYktpdFJlc3BvbnNlUG9saWN5RGVjaXNpb24u Y3BwIGIvU291cmNlL1dlYktpdDIvVUlQcm9jZXNzL0FQSS9ndGsvV2ViS2l0UmVzcG9uc2VQb2xp Y3lEZWNpc2lvbi5jcHAKaW5kZXggM2E3NWUzOGM5MWUwYTM5YmJhY2QyMWExYThlOTg4ZjIzM2Nh ZTkwMi4uMjI2MTNkYjUxNDg3MmU5NmY4ZGFjNWY2NjY1NDc1ODBhMTlhODdlNiAxMDA2NDQKLS0t IGEvU291cmNlL1dlYktpdDIvVUlQcm9jZXNzL0FQSS9ndGsvV2ViS2l0UmVzcG9uc2VQb2xpY3lE ZWNpc2lvbi5jcHAKKysrIGIvU291cmNlL1dlYktpdDIvVUlQcm9jZXNzL0FQSS9ndGsvV2ViS2l0 UmVzcG9uc2VQb2xpY3lEZWNpc2lvbi5jcHAKQEAgLTg2LDEyICs4NiwxMiBAQCBzdGF0aWMgdm9p ZCB3ZWJraXRfcmVzcG9uc2VfcG9saWN5X2RlY2lzaW9uX2NsYXNzX2luaXQoV2ViS2l0UmVzcG9u c2VQb2xpY3lEZWNpcwogICAgICAqIHBvbGljeSBkZWNpc2lvbi4KICAgICAgKi8KICAgICBnX29i amVjdF9jbGFzc19pbnN0YWxsX3Byb3BlcnR5KG9iamVjdENsYXNzLAotICAgICAgICAgICAgICAg ICAgICAgICAgICAgICAgICAgICAgUFJPUF9SRVFVRVNULAotICAgICAgICAgICAgICAgICAgICAg ICAgICAgICAgICAgICAgZ19wYXJhbV9zcGVjX29iamVjdCgicmVxdWVzdCIsCi0gICAgICAgICAg ICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICBfKCJSZXNwb25zZSBV UkkgcmVxdWVzdCIpLAotICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAg ICAgICAgICAgICAgXygiVGhlIFVSSSByZXF1ZXN0IHRoYXQgaXMgYXNzb2NpYXRlZCB3aXRoIHRo aXMgcG9saWN5IGRlY2lzaW9uIiksCi0gICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAg ICAgICAgICAgICAgICAgICAgICBXRUJLSVRfVFlQRV9VUklfUkVRVUVTVCwKLSAgICAgICAgICAg ICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgIFdFQktJVF9QQVJBTV9S RUFEQUJMRSkpOworICAgICAgICBQUk9QX1JFUVVFU1QsCisgICAgICAgIGdfcGFyYW1fc3BlY19v YmplY3QoInJlcXVlc3QiLAorICAgICAgICAgICAgXygiUmVzcG9uc2UgVVJJIHJlcXVlc3QiKSwK KyAgICAgICAgICAgIF8oIlRoZSBVUkkgcmVxdWVzdCB0aGF0IGlzIGFzc29jaWF0ZWQgd2l0aCB0 aGlzIHBvbGljeSBkZWNpc2lvbiIpLAorICAgICAgICAgICAgV0VCS0lUX1RZUEVfVVJJX1JFUVVF U1QsCisgICAgICAgICAgICBXRUJLSVRfUEFSQU1fUkVBREFCTEUpKTsKIAogICAgIC8qKgogICAg ICAqIFdlYktpdFJlc3BvbnNlUG9saWN5RGVjaXNpb246cmVzcG9uc2U6CkBAIC0xMDAsMTIgKzEw MCwxMiBAQCBzdGF0aWMgdm9pZCB3ZWJraXRfcmVzcG9uc2VfcG9saWN5X2RlY2lzaW9uX2NsYXNz X2luaXQoV2ViS2l0UmVzcG9uc2VQb2xpY3lEZWNpcwogICAgICAqIHBvbGljeSBkZWNpc2lvbi4K ICAgICAgKi8KICAgICBnX29iamVjdF9jbGFzc19pbnN0YWxsX3Byb3BlcnR5KG9iamVjdENsYXNz LAotICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgUFJPUF9SRVFVRVNULAotICAg ICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgZ19wYXJhbV9zcGVjX29iamVjdCgicmVz cG9uc2UiLAotICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAg ICAgICAgXygiVVJJIHJlc3BvbnNlIiksCi0gICAgICAgICAgICAgICAgICAgICAgICAgICAgICAg ICAgICAgICAgICAgICAgICAgICAgICBfKCJUaGUgVVJJIHJlc3BvbnNlIHRoYXQgaXMgYXNzb2Np YXRlZCB3aXRoIHRoaXMgcG9saWN5IGRlY2lzaW9uIiksCi0gICAgICAgICAgICAgICAgICAgICAg ICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICBXRUJLSVRfVFlQRV9VUklfUkVRVUVTVCwK LSAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgIFdF QktJVF9QQVJBTV9SRUFEQUJMRSkpOworICAgICAgICBQUk9QX1JFU1BPTlNFLAorICAgICAgICBn X3BhcmFtX3NwZWNfb2JqZWN0KCJyZXNwb25zZSIsCisgICAgICAgICAgICBfKCJVUkkgcmVzcG9u c2UiKSwKKyAgICAgICAgICAgIF8oIlRoZSBVUkkgcmVzcG9uc2UgdGhhdCBpcyBhc3NvY2lhdGVk IHdpdGggdGhpcyBwb2xpY3kgZGVjaXNpb24iKSwKKyAgICAgICAgICAgIFdFQktJVF9UWVBFX1VS SV9SRVNQT05TRSwKKyAgICAgICAgICAgIFdFQktJVF9QQVJBTV9SRUFEQUJMRSkpOwogCiB9CiAK 207738 2013-07-30 08:18:24 -0700 2013-07-30 08:27:30 -0700 Updated Patch bug-119258-20130730161848.patch text/plain 3197 brian.holt U3VidmVyc2lvbiBSZXZpc2lvbjogMTUzNDY4CmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViS2l0Mi9D aGFuZ2VMb2cgYi9Tb3VyY2UvV2ViS2l0Mi9DaGFuZ2VMb2cKaW5kZXggZGE4NzRkYTQyNWNmMTI2 ODVmNWQxYzY3NGU3N2FmZDZlOGNiYzk5NC4uNGQ3MTcyYWEzYzM0OTA3NWU0NWNkMzBiOGUwNmJh NmMxZjBhYzFhYSAxMDA2NDQKLS0tIGEvU291cmNlL1dlYktpdDIvQ2hhbmdlTG9nCisrKyBiL1Nv dXJjZS9XZWJLaXQyL0NoYW5nZUxvZwpAQCAtMSwzICsxLDE3IEBACisyMDEzLTA3LTMwICBCcmlh biBIb2x0ICA8YnJpYW4uaG9sdEBzYW1zdW5nLmNvbT4KKworICAgICAgICBbV2ViS2l0Ml0gW0d0 a10gV2ViS2l0UmVzcG9uc2VQb2xpY3lEZWNpc2lvbiBVUkkgcmVzcG9uc2UgcHJvcGVydHkgaW5j b3JyZWN0CisgICAgICAgIGh0dHBzOi8vYnVncy53ZWJraXQub3JnL3Nob3dfYnVnLmNnaT9pZD0x MTkyNTgKKworICAgICAgICBSZXZpZXdlZCBieSBOT0JPRFkgKE9PUFMhKS4KKworICAgICAgICBD b3JyZWN0ZWQgdGhlIGluc3RhbGxlZCBVUkkgcmVzcG9uc2UgcHJvcGVydHkgZnJvbSBQUk9QX1JF UVVFU1QgdG8KKyAgICAgICAgUFJPUF9SRVNQT05TRSBhbmQgdHlwZSBmcm9tIFdFQktJVF9UWVBF X1VSSV9SRVFVRVNUIHRvCisgICAgICAgIFdFQktJVF9UWVBFX1VSSV9SRVNQT05TRS4KKworICAg ICAgICAqIFVJUHJvY2Vzcy9BUEkvZ3RrL1dlYktpdFJlc3BvbnNlUG9saWN5RGVjaXNpb24uY3Bw OgorICAgICAgICAod2Via2l0X3Jlc3BvbnNlX3BvbGljeV9kZWNpc2lvbl9jbGFzc19pbml0KToK KwogMjAxMy0wNy0yOSAgQ2FybG9zIEdhcmNpYSBDYW1wb3MgIDxjZ2FyY2lhQGlnYWxpYS5jb20+ CiAKICAgICAgICAgVW5yZXZpZXdlZC4gRml4IG1ha2UgZGlzdGNoZWNrLgpkaWZmIC0tZ2l0IGEv U291cmNlL1dlYktpdDIvVUlQcm9jZXNzL0FQSS9ndGsvV2ViS2l0UmVzcG9uc2VQb2xpY3lEZWNp c2lvbi5jcHAgYi9Tb3VyY2UvV2ViS2l0Mi9VSVByb2Nlc3MvQVBJL2d0ay9XZWJLaXRSZXNwb25z ZVBvbGljeURlY2lzaW9uLmNwcAppbmRleCAzYTc1ZTM4YzkxZTBhMzliYmFjZDIxYTFhOGU5ODhm MjMzY2FlOTAyLi4yMjYxM2RiNTE0ODcyZTk2ZjhkYWM1ZjY2NjU0NzU4MGExOWE4N2U2IDEwMDY0 NAotLS0gYS9Tb3VyY2UvV2ViS2l0Mi9VSVByb2Nlc3MvQVBJL2d0ay9XZWJLaXRSZXNwb25zZVBv bGljeURlY2lzaW9uLmNwcAorKysgYi9Tb3VyY2UvV2ViS2l0Mi9VSVByb2Nlc3MvQVBJL2d0ay9X ZWJLaXRSZXNwb25zZVBvbGljeURlY2lzaW9uLmNwcApAQCAtODYsMTIgKzg2LDEyIEBAIHN0YXRp YyB2b2lkIHdlYmtpdF9yZXNwb25zZV9wb2xpY3lfZGVjaXNpb25fY2xhc3NfaW5pdChXZWJLaXRS ZXNwb25zZVBvbGljeURlY2lzCiAgICAgICogcG9saWN5IGRlY2lzaW9uLgogICAgICAqLwogICAg IGdfb2JqZWN0X2NsYXNzX2luc3RhbGxfcHJvcGVydHkob2JqZWN0Q2xhc3MsCi0gICAgICAgICAg ICAgICAgICAgICAgICAgICAgICAgICAgICBQUk9QX1JFUVVFU1QsCi0gICAgICAgICAgICAgICAg ICAgICAgICAgICAgICAgICAgICBnX3BhcmFtX3NwZWNfb2JqZWN0KCJyZXF1ZXN0IiwKLSAgICAg ICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgIF8oIlJlc3Bv bnNlIFVSSSByZXF1ZXN0IiksCi0gICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAg ICAgICAgICAgICAgICAgICBfKCJUaGUgVVJJIHJlcXVlc3QgdGhhdCBpcyBhc3NvY2lhdGVkIHdp dGggdGhpcyBwb2xpY3kgZGVjaXNpb24iKSwKLSAgICAgICAgICAgICAgICAgICAgICAgICAgICAg ICAgICAgICAgICAgICAgICAgICAgICAgIFdFQktJVF9UWVBFX1VSSV9SRVFVRVNULAotICAgICAg ICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgV0VCS0lUX1BB UkFNX1JFQURBQkxFKSk7CisgICAgICAgIFBST1BfUkVRVUVTVCwKKyAgICAgICAgZ19wYXJhbV9z cGVjX29iamVjdCgicmVxdWVzdCIsCisgICAgICAgICAgICBfKCJSZXNwb25zZSBVUkkgcmVxdWVz dCIpLAorICAgICAgICAgICAgXygiVGhlIFVSSSByZXF1ZXN0IHRoYXQgaXMgYXNzb2NpYXRlZCB3 aXRoIHRoaXMgcG9saWN5IGRlY2lzaW9uIiksCisgICAgICAgICAgICBXRUJLSVRfVFlQRV9VUklf UkVRVUVTVCwKKyAgICAgICAgICAgIFdFQktJVF9QQVJBTV9SRUFEQUJMRSkpOwogCiAgICAgLyoq CiAgICAgICogV2ViS2l0UmVzcG9uc2VQb2xpY3lEZWNpc2lvbjpyZXNwb25zZToKQEAgLTEwMCwx MiArMTAwLDEyIEBAIHN0YXRpYyB2b2lkIHdlYmtpdF9yZXNwb25zZV9wb2xpY3lfZGVjaXNpb25f Y2xhc3NfaW5pdChXZWJLaXRSZXNwb25zZVBvbGljeURlY2lzCiAgICAgICogcG9saWN5IGRlY2lz aW9uLgogICAgICAqLwogICAgIGdfb2JqZWN0X2NsYXNzX2luc3RhbGxfcHJvcGVydHkob2JqZWN0 Q2xhc3MsCi0gICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICBQUk9QX1JFUVVFU1Qs Ci0gICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICBnX3BhcmFtX3NwZWNfb2JqZWN0 KCJyZXNwb25zZSIsCi0gICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAg ICAgICAgICAgICBfKCJVUkkgcmVzcG9uc2UiKSwKLSAgICAgICAgICAgICAgICAgICAgICAgICAg ICAgICAgICAgICAgICAgICAgICAgICAgICAgIF8oIlRoZSBVUkkgcmVzcG9uc2UgdGhhdCBpcyBh c3NvY2lhdGVkIHdpdGggdGhpcyBwb2xpY3kgZGVjaXNpb24iKSwKLSAgICAgICAgICAgICAgICAg ICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgIFdFQktJVF9UWVBFX1VSSV9SRVFV RVNULAotICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAg ICAgV0VCS0lUX1BBUkFNX1JFQURBQkxFKSk7CisgICAgICAgIFBST1BfUkVTUE9OU0UsCisgICAg ICAgIGdfcGFyYW1fc3BlY19vYmplY3QoInJlc3BvbnNlIiwKKyAgICAgICAgICAgIF8oIlVSSSBy ZXNwb25zZSIpLAorICAgICAgICAgICAgXygiVGhlIFVSSSByZXNwb25zZSB0aGF0IGlzIGFzc29j aWF0ZWQgd2l0aCB0aGlzIHBvbGljeSBkZWNpc2lvbiIpLAorICAgICAgICAgICAgV0VCS0lUX1RZ UEVfVVJJX1JFU1BPTlNFLAorICAgICAgICAgICAgV0VCS0lUX1BBUkFNX1JFQURBQkxFKSk7CiAK IH0KIAo= 207739 2013-07-30 08:27:38 -0700 2013-07-30 10:29:42 -0700 Updated Patch bug-119258-20130730162801.patch text/plain 3198 brian.holt U3VidmVyc2lvbiBSZXZpc2lvbjogMTUzNDY4CmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViS2l0Mi9D aGFuZ2VMb2cgYi9Tb3VyY2UvV2ViS2l0Mi9DaGFuZ2VMb2cKaW5kZXggZGE4NzRkYTQyNWNmMTI2 ODVmNWQxYzY3NGU3N2FmZDZlOGNiYzk5NC4uMGQwNzIxM2FiMWRiYzE4NDNkMTg0NDY0ZjBiMDY5 N2FmZmY3ZTU2NiAxMDA2NDQKLS0tIGEvU291cmNlL1dlYktpdDIvQ2hhbmdlTG9nCisrKyBiL1Nv dXJjZS9XZWJLaXQyL0NoYW5nZUxvZwpAQCAtMSwzICsxLDE3IEBACisyMDEzLTA3LTMwICBCcmlh biBIb2x0ICA8YnJpYW4uaG9sdEBzYW1zdW5nLmNvbT4KKworICAgICAgICBbV2ViS2l0Ml0gW0d0 a10gV2ViS2l0UmVzcG9uc2VQb2xpY3lEZWNpc2lvbiBVUkkgcmVzcG9uc2UgcHJvcGVydHkgaW5j b3JyZWN0CisgICAgICAgIGh0dHBzOi8vYnVncy53ZWJraXQub3JnL3Nob3dfYnVnLmNnaT9pZD0x MTkyNTgKKworICAgICAgICBSZXZpZXdlZCBieSBNYXJ0aW4gUm9iaW5zb24uCisKKyAgICAgICAg Q29ycmVjdGVkIHRoZSBpbnN0YWxsZWQgVVJJIHJlc3BvbnNlIHByb3BlcnR5IGZyb20gUFJPUF9S RVFVRVNUIHRvCisgICAgICAgIFBST1BfUkVTUE9OU0UgYW5kIHR5cGUgZnJvbSBXRUJLSVRfVFlQ RV9VUklfUkVRVUVTVCB0bworICAgICAgICBXRUJLSVRfVFlQRV9VUklfUkVTUE9OU0UuCisKKyAg ICAgICAgKiBVSVByb2Nlc3MvQVBJL2d0ay9XZWJLaXRSZXNwb25zZVBvbGljeURlY2lzaW9uLmNw cDoKKyAgICAgICAgKHdlYmtpdF9yZXNwb25zZV9wb2xpY3lfZGVjaXNpb25fY2xhc3NfaW5pdCk6 CisKIDIwMTMtMDctMjkgIENhcmxvcyBHYXJjaWEgQ2FtcG9zICA8Y2dhcmNpYUBpZ2FsaWEuY29t PgogCiAgICAgICAgIFVucmV2aWV3ZWQuIEZpeCBtYWtlIGRpc3RjaGVjay4KZGlmZiAtLWdpdCBh L1NvdXJjZS9XZWJLaXQyL1VJUHJvY2Vzcy9BUEkvZ3RrL1dlYktpdFJlc3BvbnNlUG9saWN5RGVj aXNpb24uY3BwIGIvU291cmNlL1dlYktpdDIvVUlQcm9jZXNzL0FQSS9ndGsvV2ViS2l0UmVzcG9u c2VQb2xpY3lEZWNpc2lvbi5jcHAKaW5kZXggM2E3NWUzOGM5MWUwYTM5YmJhY2QyMWExYThlOTg4 ZjIzM2NhZTkwMi4uMjI2MTNkYjUxNDg3MmU5NmY4ZGFjNWY2NjY1NDc1ODBhMTlhODdlNiAxMDA2 NDQKLS0tIGEvU291cmNlL1dlYktpdDIvVUlQcm9jZXNzL0FQSS9ndGsvV2ViS2l0UmVzcG9uc2VQ b2xpY3lEZWNpc2lvbi5jcHAKKysrIGIvU291cmNlL1dlYktpdDIvVUlQcm9jZXNzL0FQSS9ndGsv V2ViS2l0UmVzcG9uc2VQb2xpY3lEZWNpc2lvbi5jcHAKQEAgLTg2LDEyICs4NiwxMiBAQCBzdGF0 aWMgdm9pZCB3ZWJraXRfcmVzcG9uc2VfcG9saWN5X2RlY2lzaW9uX2NsYXNzX2luaXQoV2ViS2l0 UmVzcG9uc2VQb2xpY3lEZWNpcwogICAgICAqIHBvbGljeSBkZWNpc2lvbi4KICAgICAgKi8KICAg ICBnX29iamVjdF9jbGFzc19pbnN0YWxsX3Byb3BlcnR5KG9iamVjdENsYXNzLAotICAgICAgICAg ICAgICAgICAgICAgICAgICAgICAgICAgICAgUFJPUF9SRVFVRVNULAotICAgICAgICAgICAgICAg ICAgICAgICAgICAgICAgICAgICAgZ19wYXJhbV9zcGVjX29iamVjdCgicmVxdWVzdCIsCi0gICAg ICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICBfKCJSZXNw b25zZSBVUkkgcmVxdWVzdCIpLAotICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAg ICAgICAgICAgICAgICAgICAgXygiVGhlIFVSSSByZXF1ZXN0IHRoYXQgaXMgYXNzb2NpYXRlZCB3 aXRoIHRoaXMgcG9saWN5IGRlY2lzaW9uIiksCi0gICAgICAgICAgICAgICAgICAgICAgICAgICAg ICAgICAgICAgICAgICAgICAgICAgICAgICBXRUJLSVRfVFlQRV9VUklfUkVRVUVTVCwKLSAgICAg ICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgIFdFQktJVF9Q QVJBTV9SRUFEQUJMRSkpOworICAgICAgICBQUk9QX1JFUVVFU1QsCisgICAgICAgIGdfcGFyYW1f c3BlY19vYmplY3QoInJlcXVlc3QiLAorICAgICAgICAgICAgXygiUmVzcG9uc2UgVVJJIHJlcXVl c3QiKSwKKyAgICAgICAgICAgIF8oIlRoZSBVUkkgcmVxdWVzdCB0aGF0IGlzIGFzc29jaWF0ZWQg d2l0aCB0aGlzIHBvbGljeSBkZWNpc2lvbiIpLAorICAgICAgICAgICAgV0VCS0lUX1RZUEVfVVJJ X1JFUVVFU1QsCisgICAgICAgICAgICBXRUJLSVRfUEFSQU1fUkVBREFCTEUpKTsKIAogICAgIC8q KgogICAgICAqIFdlYktpdFJlc3BvbnNlUG9saWN5RGVjaXNpb246cmVzcG9uc2U6CkBAIC0xMDAs MTIgKzEwMCwxMiBAQCBzdGF0aWMgdm9pZCB3ZWJraXRfcmVzcG9uc2VfcG9saWN5X2RlY2lzaW9u X2NsYXNzX2luaXQoV2ViS2l0UmVzcG9uc2VQb2xpY3lEZWNpcwogICAgICAqIHBvbGljeSBkZWNp c2lvbi4KICAgICAgKi8KICAgICBnX29iamVjdF9jbGFzc19pbnN0YWxsX3Byb3BlcnR5KG9iamVj dENsYXNzLAotICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgUFJPUF9SRVFVRVNU LAotICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgZ19wYXJhbV9zcGVjX29iamVj dCgicmVzcG9uc2UiLAotICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAg ICAgICAgICAgICAgXygiVVJJIHJlc3BvbnNlIiksCi0gICAgICAgICAgICAgICAgICAgICAgICAg ICAgICAgICAgICAgICAgICAgICAgICAgICAgICBfKCJUaGUgVVJJIHJlc3BvbnNlIHRoYXQgaXMg YXNzb2NpYXRlZCB3aXRoIHRoaXMgcG9saWN5IGRlY2lzaW9uIiksCi0gICAgICAgICAgICAgICAg ICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICBXRUJLSVRfVFlQRV9VUklfUkVR VUVTVCwKLSAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAg ICAgIFdFQktJVF9QQVJBTV9SRUFEQUJMRSkpOworICAgICAgICBQUk9QX1JFU1BPTlNFLAorICAg ICAgICBnX3BhcmFtX3NwZWNfb2JqZWN0KCJyZXNwb25zZSIsCisgICAgICAgICAgICBfKCJVUkkg cmVzcG9uc2UiKSwKKyAgICAgICAgICAgIF8oIlRoZSBVUkkgcmVzcG9uc2UgdGhhdCBpcyBhc3Nv Y2lhdGVkIHdpdGggdGhpcyBwb2xpY3kgZGVjaXNpb24iKSwKKyAgICAgICAgICAgIFdFQktJVF9U WVBFX1VSSV9SRVNQT05TRSwKKyAgICAgICAgICAgIFdFQktJVF9QQVJBTV9SRUFEQUJMRSkpOwog CiB9CiAK