119252 2013-07-30 06:22:27 -0700 Web Inspector: doesn't use localized user interface at remote inspector 2013-07-30 16:56:04 -0700 1 1 1 Unclassified WebKit Web Inspector 528+ (Nightly build) All All RESOLVED FIXED InRadar P2 Normal --- 118676 1 rtakacs webkit-unassigned commit-queue graouts joepeck seokju timothy webkit-bug-importer oldest_to_newest 912809 0 rtakacs 2013-07-30 06:22:27 -0700 The normal inspector uses InspectorFrontendHost::localizedStringsURL() to get the path/url of localizedStrings. It is undefined at remote inspector: thats why we need to tell the inspector that we wouldn't like to use localizedStrings. 912810 1 webkit-bug-importer 2013-07-30 06:23:03 -0700 <rdar://problem/14589626> 912811 2 207730 rtakacs 2013-07-30 06:24:42 -0700 Created attachment 207730 patch 912826 3 207730 commit-queue 2013-07-30 06:51:04 -0700 Comment on attachment 207730 patch Clearing flags on attachment: 207730 Committed r153471: <http://trac.webkit.org/changeset/153471> 912827 4 commit-queue 2013-07-30 06:51:06 -0700 All reviewed patches have been landed. Closing bug. 912945 5 joepeck 2013-07-30 11:00:40 -0700 (In reply to comment #0) > The normal inspector uses InspectorFrontendHost::localizedStringsURL() to get the path/url of localizedStrings. > It is undefined at remote inspector: thats why we need to tell the inspector that we wouldn't like to use localizedStrings. You should file a follow-up bug to get this working in your case (that is, if you want localization for the remote inspector). Seems like it would be pretty easy to add something like this. 913086 6 seokju 2013-07-30 16:21:33 -0700 Hmm, I wonder that why you don't use it in remote inspector. And Why do you set a default value to true? If you dont use localizedStrings in remote inspector, You should set a value to true when using remote inspector. 913104 7 joepeck 2013-07-30 16:56:04 -0700 (In reply to comment #6) > Hmm, I wonder that why you don't use it in remote inspector. > > And Why do you set a default value to true? > If you dont use localizedStrings in remote inspector, You should set a value to true when using remote inspector. OS X Remote Inspector does have localization. It uses the WebInspectorUI.framework on the host machine which has all the localizations. We have a real InspectorFrontendHost, we aren't using the stub, so we provide a local file:/// path to the localizedStrings.js when asking InspectorFrontendHost.localizedStringsURL(). 207730 2013-07-30 06:24:42 -0700 2013-07-30 06:51:04 -0700 patch 2013_07_30.diff text/plain 2454 rtakacs ZGlmZiAtLWdpdCBhL1NvdXJjZS9XZWJJbnNwZWN0b3JVSS9DaGFuZ2VMb2cgYi9Tb3VyY2UvV2Vi SW5zcGVjdG9yVUkvQ2hhbmdlTG9nCmluZGV4IDk0MDQ2YjcuLjViOTY2MGYgMTAwNjQ0Ci0tLSBh L1NvdXJjZS9XZWJJbnNwZWN0b3JVSS9DaGFuZ2VMb2cKKysrIGIvU291cmNlL1dlYkluc3BlY3Rv clVJL0NoYW5nZUxvZwpAQCAtMSwzICsxLDE3IEBACisyMDEzLTA3LTMwICBSb2xhbmQgVGFrw6Fj cyAgPHJ0YWthY3NAaW5mLnUtc3plZ2VkLmh1PgorCisgICAgICAgIFdlYiBJbnNwZWN0b3I6IGRv ZXNuJ3QgdXNlIGxvY2FsaXplZCB1c2VyIGludGVyZmFjZSBhdCByZW1vdGUgaW5zcGVjdG9yCisg ICAgICAgIGh0dHBzOi8vYnVncy53ZWJraXQub3JnL3Nob3dfYnVnLmNnaT9pZD0xMTkyNTIKKwor ICAgICAgICBSZXZpZXdlZCBieSBOT0JPRFkgKE9PUFMhKS4KKworICAgICAgICBBZGRlZCBhIGZs YWcgaW4gb3JkZXIgdG8gbm90IHVzZSBsb2NhbGl6ZWRTdHJpbmdzIGluIHJlbW90ZSBpbnNwZWN0 b3IuCisKKyAgICAgICAgKiBVc2VySW50ZXJmYWNlL0luc3BlY3RvckZyb250ZW5kSG9zdFN0dWIu anM6CisgICAgICAgICogVXNlckludGVyZmFjZS9Mb2FkTG9jYWxpemVkU3RyaW5ncy5qczoKKyAg ICAgICAgKiBVc2VySW50ZXJmYWNlL01haW4uanM6CisgICAgICAgIChXZWJJbnNwZWN0b3IuVUlT dHJpbmcpOgorCiAyMDEzLTA3LTI0ICBBbnRvaW5lIFF1aW50ICA8Z3Jhb3V0c0BhcHBsZS5jb20+ CiAKICAgICAgICAgV2ViIEluc3BlY3RvcjogY29udHJvbCtjbGlja2luZyBvbiBhIG51bWVyaWMg dG9rZW4gc2hvdWxkIG5vdCBzaG93IHRoZSBjb250ZXh0IG1lbnUKZGlmZiAtLWdpdCBhL1NvdXJj ZS9XZWJJbnNwZWN0b3JVSS9Vc2VySW50ZXJmYWNlL0luc3BlY3RvckZyb250ZW5kSG9zdFN0dWIu anMgYi9Tb3VyY2UvV2ViSW5zcGVjdG9yVUkvVXNlckludGVyZmFjZS9JbnNwZWN0b3JGcm9udGVu ZEhvc3RTdHViLmpzCmluZGV4IDE5YjNmYTIuLmNkZGNkNWQgMTAwNjQ0Ci0tLSBhL1NvdXJjZS9X ZWJJbnNwZWN0b3JVSS9Vc2VySW50ZXJmYWNlL0luc3BlY3RvckZyb250ZW5kSG9zdFN0dWIuanMK KysrIGIvU291cmNlL1dlYkluc3BlY3RvclVJL1VzZXJJbnRlcmZhY2UvSW5zcGVjdG9yRnJvbnRl bmRIb3N0U3R1Yi5qcwpAQCAtMTE4LDUgKzExOCw2IEBAIGlmICghd2luZG93Lkluc3BlY3RvckZy b250ZW5kSG9zdCkgewogICAgIH0KIAogICAgIEluc3BlY3RvckZyb250ZW5kSG9zdCA9IG5ldyBX ZWJJbnNwZWN0b3IuSW5zcGVjdG9yRnJvbnRlbmRIb3N0U3R1YigpOworICAgIFdlYkluc3BlY3Rv ci5kb250TG9jYWxpemVVc2VySW50ZXJmYWNlID0gdHJ1ZTsKIH0KIApkaWZmIC0tZ2l0IGEvU291 cmNlL1dlYkluc3BlY3RvclVJL1VzZXJJbnRlcmZhY2UvTG9hZExvY2FsaXplZFN0cmluZ3MuanMg Yi9Tb3VyY2UvV2ViSW5zcGVjdG9yVUkvVXNlckludGVyZmFjZS9Mb2FkTG9jYWxpemVkU3RyaW5n cy5qcwppbmRleCBiZmI0N2M0Li44NGM2ZTA4IDEwMDY0NAotLS0gYS9Tb3VyY2UvV2ViSW5zcGVj dG9yVUkvVXNlckludGVyZmFjZS9Mb2FkTG9jYWxpemVkU3RyaW5ncy5qcworKysgYi9Tb3VyY2Uv V2ViSW5zcGVjdG9yVUkvVXNlckludGVyZmFjZS9Mb2FkTG9jYWxpemVkU3RyaW5ncy5qcwpAQCAt MjQsNiArMjQsOSBAQAogICovCiAKIChmdW5jdGlvbigpIHsKKyAgICBpZiAoV2ViSW5zcGVjdG9y LmRvbnRMb2NhbGl6ZVVzZXJJbnRlcmZhY2UpCisgICAgICAgIHJldHVybjsKKwogICAgIHZhciBs b2NhbGl6ZWRTdHJpbmdzVVJMID0gSW5zcGVjdG9yRnJvbnRlbmRIb3N0LmxvY2FsaXplZFN0cmlu Z3NVUkwoKTsKICAgICBjb25zb2xlLmFzc2VydChsb2NhbGl6ZWRTdHJpbmdzVVJMKTsKICAgICBp ZiAobG9jYWxpemVkU3RyaW5nc1VSTCkKZGlmZiAtLWdpdCBhL1NvdXJjZS9XZWJJbnNwZWN0b3JV SS9Vc2VySW50ZXJmYWNlL01haW4uanMgYi9Tb3VyY2UvV2ViSW5zcGVjdG9yVUkvVXNlckludGVy ZmFjZS9NYWluLmpzCmluZGV4IGU0M2JjMzguLmYzZjU4NjMgMTAwNjQ0Ci0tLSBhL1NvdXJjZS9X ZWJJbnNwZWN0b3JVSS9Vc2VySW50ZXJmYWNlL01haW4uanMKKysrIGIvU291cmNlL1dlYkluc3Bl Y3RvclVJL1VzZXJJbnRlcmZhY2UvTWFpbi5qcwpAQCAtNjU1LDYgKzY1NSw5IEBAIFdlYkluc3Bl Y3Rvci50b2dnbGVDb25zb2xlVmlldyA9IGZ1bmN0aW9uKCkKIAogV2ViSW5zcGVjdG9yLlVJU3Ry aW5nID0gZnVuY3Rpb24oc3RyaW5nLCB2YXJhcmcpCiB7CisgICAgaWYgKFdlYkluc3BlY3Rvci5k b250TG9jYWxpemVVc2VySW50ZXJmYWNlKQorICAgICAgICByZXR1cm4gc3RyaW5nOworCiAgICAg aWYgKHdpbmRvdy5sb2NhbGl6ZWRTdHJpbmdzICYmIHN0cmluZyBpbiB3aW5kb3cubG9jYWxpemVk U3RyaW5ncykKICAgICAgICAgcmV0dXJuIHdpbmRvdy5sb2NhbGl6ZWRTdHJpbmdzW3N0cmluZ107 CiAK