119249 2013-07-30 05:34:26 -0700 findFirstGrammarDetail doesn't need to be exposed 2013-07-31 00:22:52 -0700 1 1 1 Unclassified WebKit HTML Editing 528+ (Nightly build) Unspecified Unspecified RESOLVED FIXED P2 Normal --- 1 g.czajkowski g.czajkowski rniwa oldest_to_newest 912794 0 g.czajkowski 2013-07-30 05:34:26 -0700 Cleanup. Make TextCheckingHelper::findFirstGrammarDetail private. Remove badGrammarPhraseLength param. It's not used any longer. 912799 1 207728 g.czajkowski 2013-07-30 05:37:53 -0700 Created attachment 207728 proposed patch 913215 2 g.czajkowski 2013-07-31 00:22:52 -0700 Committed r153512: <http://trac.webkit.org/changeset/153512> 207728 2013-07-30 05:37:53 -0700 2013-07-30 12:30:51 -0700 proposed patch 0001-findFirstGrammarDetail-cleanup.patch text/plain 3849 g.czajkowski ZGlmZiAtLWdpdCBhL1NvdXJjZS9XZWJDb3JlL0NoYW5nZUxvZyBiL1NvdXJjZS9XZWJDb3JlL0No YW5nZUxvZwppbmRleCA5YmNiYjI4Li43MjY2ODBkIDEwMDY0NAotLS0gYS9Tb3VyY2UvV2ViQ29y ZS9DaGFuZ2VMb2cKKysrIGIvU291cmNlL1dlYkNvcmUvQ2hhbmdlTG9nCkBAIC0xLDMgKzEsMjAg QEAKKzIwMTMtMDctMjYgIEdyemVnb3J6IEN6YWprb3dza2kgIDxnLmN6YWprb3dza2lAc2Ftc3Vu Zy5jb20+CisKKyAgICAgICAgZmluZEZpcnN0R3JhbW1hckRldGFpbCBkb2Vzbid0IG5lZWQgdG8g YmUgZXhwb3NlZC4KKyAgICAgICAgaHR0cHM6Ly9idWdzLndlYmtpdC5vcmcvc2hvd19idWcuY2dp P2lkPTExOTI0OQorCisgICAgICAgIFJldmlld2VkIGJ5IE5PQk9EWSAoT09QUyEpLgorCisgICAg ICAgIE1ha2UgVGV4dENoZWNraW5nSGVscGVyOjpmaW5kRmlyc3RHcmFtbWFyRGV0YWlsIHByaXZh dGUuCisgICAgICAgIFJlbW92ZSBiYWRHcmFtbWFyUGhyYXNlTGVuZ3RoIHBhcmFtLiBJdCdzIG5v dCB1c2VkIGFueSBsb25nZXIuCisKKyAgICAgICAgTm8gbmV3IHRlc3RzLCBubyBiZWhhdmlvciBj aGFuZ2UuCisKKyAgICAgICAgKiBlZGl0aW5nL1RleHRDaGVja2luZ0hlbHBlci5jcHA6CisgICAg ICAgIChXZWJDb3JlOjpUZXh0Q2hlY2tpbmdIZWxwZXI6OmZpbmRGaXJzdEdyYW1tYXJEZXRhaWwp OgorICAgICAgICAoV2ViQ29yZTo6VGV4dENoZWNraW5nSGVscGVyOjpmaW5kRmlyc3RCYWRHcmFt bWFyKToKKyAgICAgICAgKiBlZGl0aW5nL1RleHRDaGVja2luZ0hlbHBlci5oOgorCiAyMDEzLTA3 LTMwICBTaW1vbiBIYXVzbWFubiAgPHNpbW9uLmhhdXNtYW5uQGRpZ2lhLmNvbT4KIAogICAgICAg ICBbUXRdW1dpbl0gRXh0ZW5kIGRpc2FibGluZyBvZiB3aG9sZS1wcm9ncmFtLW9wdGltaXphdGlv bnMgdG8gTVNWQyAyMDEyCmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViQ29yZS9lZGl0aW5nL1RleHRD aGVja2luZ0hlbHBlci5jcHAgYi9Tb3VyY2UvV2ViQ29yZS9lZGl0aW5nL1RleHRDaGVja2luZ0hl bHBlci5jcHAKaW5kZXggMjdjNDQyYy4uN2Q2NjcwZiAxMDA2NDQKLS0tIGEvU291cmNlL1dlYkNv cmUvZWRpdGluZy9UZXh0Q2hlY2tpbmdIZWxwZXIuY3BwCisrKyBiL1NvdXJjZS9XZWJDb3JlL2Vk aXRpbmcvVGV4dENoZWNraW5nSGVscGVyLmNwcApAQCAtNDE1LDcgKzQxNSw3IEBAIFN0cmluZyBU ZXh0Q2hlY2tpbmdIZWxwZXI6OmZpbmRGaXJzdE1pc3NwZWxsaW5nT3JCYWRHcmFtbWFyKGJvb2wg Y2hlY2tHcmFtbWFyLCBiCiB9CiAKICNpZiBVU0UoR1JBTU1BUl9DSEVDS0lORykKLWludCBUZXh0 Q2hlY2tpbmdIZWxwZXI6OmZpbmRGaXJzdEdyYW1tYXJEZXRhaWwoY29uc3QgVmVjdG9yPEdyYW1t YXJEZXRhaWw+JiBncmFtbWFyRGV0YWlscywgaW50IGJhZEdyYW1tYXJQaHJhc2VMb2NhdGlvbiwg aW50IC8qYmFkR3JhbW1hclBocmFzZUxlbmd0aCovLCBpbnQgc3RhcnRPZmZzZXQsIGludCBlbmRP ZmZzZXQsIGJvb2wgbWFya0FsbCkKK2ludCBUZXh0Q2hlY2tpbmdIZWxwZXI6OmZpbmRGaXJzdEdy YW1tYXJEZXRhaWwoY29uc3QgVmVjdG9yPEdyYW1tYXJEZXRhaWw+JiBncmFtbWFyRGV0YWlscywg aW50IGJhZEdyYW1tYXJQaHJhc2VMb2NhdGlvbiwgaW50IHN0YXJ0T2Zmc2V0LCBpbnQgZW5kT2Zm c2V0LCBib29sIG1hcmtBbGwpCiB7CiAgICAgLy8gRm91bmQgc29tZSBiYWQgZ3JhbW1hci4gRmlu ZCB0aGUgZWFybGllc3QgZGV0YWlsIHJhbmdlIHRoYXQgc3RhcnRzIGluIG91ciBzZWFyY2ggcmFu Z2UgKGlmIGFueSkuCiAgICAgLy8gT3B0aW9uYWxseSBhZGQgYSBEb2N1bWVudE1hcmtlciBmb3Ig ZWFjaCBkZXRhaWwgaW4gdGhlIHJhbmdlLgpAQCAtNDg0LDcgKzQ4NCw3IEBAIFN0cmluZyBUZXh0 Q2hlY2tpbmdIZWxwZXI6OmZpbmRGaXJzdEJhZEdyYW1tYXIoR3JhbW1hckRldGFpbCYgb3V0R3Jh bW1hckRldGFpbCwKIAogICAgICAgICAKICAgICAgICAgLy8gRm91bmQgc29tZSBiYWQgZ3JhbW1h ci4gRmluZCB0aGUgZWFybGllc3QgZGV0YWlsIHJhbmdlIHRoYXQgc3RhcnRzIGluIG91ciBzZWFy Y2ggcmFuZ2UgKGlmIGFueSkuCi0gICAgICAgIGludCBiYWRHcmFtbWFySW5kZXggPSBmaW5kRmly c3RHcmFtbWFyRGV0YWlsKGdyYW1tYXJEZXRhaWxzLCBiYWRHcmFtbWFyUGhyYXNlTG9jYXRpb24s IGJhZEdyYW1tYXJQaHJhc2VMZW5ndGgsIHBhcmFncmFwaC5jaGVja2luZ1N0YXJ0KCksIHBhcmFn cmFwaC5jaGVja2luZ0VuZCgpLCBtYXJrQWxsKTsKKyAgICAgICAgaW50IGJhZEdyYW1tYXJJbmRl eCA9IGZpbmRGaXJzdEdyYW1tYXJEZXRhaWwoZ3JhbW1hckRldGFpbHMsIGJhZEdyYW1tYXJQaHJh c2VMb2NhdGlvbiwgcGFyYWdyYXBoLmNoZWNraW5nU3RhcnQoKSwgcGFyYWdyYXBoLmNoZWNraW5n RW5kKCksIG1hcmtBbGwpOwogICAgICAgICBpZiAoYmFkR3JhbW1hckluZGV4ID49IDApIHsKICAg ICAgICAgICAgIEFTU0VSVChzdGF0aWNfY2FzdDx1bnNpZ25lZD4oYmFkR3JhbW1hckluZGV4KSA8 IGdyYW1tYXJEZXRhaWxzLnNpemUoKSk7CiAgICAgICAgICAgICBvdXRHcmFtbWFyRGV0YWlsID0g Z3JhbW1hckRldGFpbHNbYmFkR3JhbW1hckluZGV4XTsKZGlmZiAtLWdpdCBhL1NvdXJjZS9XZWJD b3JlL2VkaXRpbmcvVGV4dENoZWNraW5nSGVscGVyLmggYi9Tb3VyY2UvV2ViQ29yZS9lZGl0aW5n L1RleHRDaGVja2luZ0hlbHBlci5oCmluZGV4IDQ3MWMxYjcuLjBlMmZkOTggMTAwNjQ0Ci0tLSBh L1NvdXJjZS9XZWJDb3JlL2VkaXRpbmcvVGV4dENoZWNraW5nSGVscGVyLmgKKysrIGIvU291cmNl L1dlYkNvcmUvZWRpdGluZy9UZXh0Q2hlY2tpbmdIZWxwZXIuaApAQCAtODgsMTYgKzg4LDE5IEBA IHB1YmxpYzoKICAgICB2b2lkIG1hcmtBbGxNaXNzcGVsbGluZ3MoUmVmUHRyPFJhbmdlPiYgZmly c3RNaXNzcGVsbGluZ1JhbmdlKTsKICNpZiBVU0UoR1JBTU1BUl9DSEVDS0lORykKICAgICBTdHJp bmcgZmluZEZpcnN0QmFkR3JhbW1hcihHcmFtbWFyRGV0YWlsJiBvdXRHcmFtbWFyRGV0YWlsLCBp bnQmIG91dEdyYW1tYXJQaHJhc2VPZmZzZXQsIGJvb2wgbWFya0FsbCk7Ci0gICAgaW50IGZpbmRG aXJzdEdyYW1tYXJEZXRhaWwoY29uc3QgVmVjdG9yPEdyYW1tYXJEZXRhaWw+JiBncmFtbWFyRGV0 YWlscywgaW50IGJhZEdyYW1tYXJQaHJhc2VMb2NhdGlvbiwgaW50IGJhZEdyYW1tYXJQaHJhc2VM ZW5ndGgsIGludCBzdGFydE9mZnNldCwgaW50IGVuZE9mZnNldCwgYm9vbCBtYXJrQWxsKTsKICAg ICB2b2lkIG1hcmtBbGxCYWRHcmFtbWFyKCk7CiAgICAgYm9vbCBpc1VuZ3JhbW1hdGljYWwoVmVj dG9yPFN0cmluZz4mIGd1ZXNzZXNWZWN0b3IpIGNvbnN0OwogI2VuZGlmCiAgICAgVmVjdG9yPFN0 cmluZz4gZ3Vlc3Nlc0Zvck1pc3NwZWxsZWRPclVuZ3JhbW1hdGljYWxSYW5nZShib29sIGNoZWNr R3JhbW1hciwgYm9vbCYgbWlzc3BlbGxlZCwgYm9vbCYgdW5ncmFtbWF0aWNhbCkgY29uc3Q7CisK IHByaXZhdGU6CiAgICAgRWRpdG9yQ2xpZW50KiBtX2NsaWVudDsKICAgICBSZWZQdHI8UmFuZ2U+ IG1fcmFuZ2U7CiAKICAgICBib29sIHVuaWZpZWRUZXh0Q2hlY2tlckVuYWJsZWQoKSBjb25zdDsK KyNpZiBVU0UoR1JBTU1BUl9DSEVDS0lORykKKyAgICBpbnQgZmluZEZpcnN0R3JhbW1hckRldGFp bChjb25zdCBWZWN0b3I8R3JhbW1hckRldGFpbD4mLCBpbnQgYmFkR3JhbW1hclBocmFzZUxvY2F0 aW9uLCBpbnQgc3RhcnRPZmZzZXQsIGludCBlbmRPZmZzZXQsIGJvb2wgbWFya0FsbCk7CisjZW5k aWYKIH07CiAKIHZvaWQgY2hlY2tUZXh0T2ZQYXJhZ3JhcGgoVGV4dENoZWNrZXJDbGllbnQqLCBj b25zdCBVQ2hhciogdGV4dCwgaW50IGxlbmd0aCwK