119244 2013-07-30 03:54:56 -0700 Unnecessary const_cast<TextCheckingHelper*>(this)->findFirstBadGrammar 2013-07-31 01:06:08 -0700 1 1 1 Unclassified WebKit HTML Editing 528+ (Nightly build) Unspecified Unspecified RESOLVED FIXED P2 Normal --- 1 g.czajkowski g.czajkowski darin ddavidso enrica rniwa oldest_to_newest 912758 0 g.czajkowski 2013-07-30 03:54:56 -0700 Cleanup. findFirstBadGrammar needs const modifier to call it in 'isUngrammatical() const' without const casting. 912759 1 207715 g.czajkowski 2013-07-30 03:57:39 -0700 Created attachment 207715 proposed patch 913223 2 g.czajkowski 2013-07-31 01:06:08 -0700 Committed r153513: <http://trac.webkit.org/changeset/153513> 207715 2013-07-30 03:57:39 -0700 2013-07-30 12:28:14 -0700 proposed patch 0002-findFirstBadGrammar-cleanup.patch text/plain 4295 g.czajkowski ZGlmZiAtLWdpdCBhL1NvdXJjZS9XZWJDb3JlL0NoYW5nZUxvZyBiL1NvdXJjZS9XZWJDb3JlL0No YW5nZUxvZwppbmRleCBhNDc2ZDg2Li44MWFiNWE3IDEwMDY0NAotLS0gYS9Tb3VyY2UvV2ViQ29y ZS9DaGFuZ2VMb2cKKysrIGIvU291cmNlL1dlYkNvcmUvQ2hhbmdlTG9nCkBAIC0xLDMgKzEsMjYg QEAKKzIwMTMtMDctMjYgIEdyemVnb3J6IEN6YWprb3dza2kgIDxnLmN6YWprb3dza2lAc2Ftc3Vu Zy5jb20+CisKKyAgICAgICAgVW5uZWNjZXNhcnkgY29uc3RfY2FzdDxUZXh0Q2hlY2tpbmdIZWxw ZXIqPih0aGlzKS0+ZmluZEZpcnN0QmFkR3JhbW1hcgorICAgICAgICBodHRwczovL2J1Z3Mud2Vi a2l0Lm9yZy9zaG93X2J1Zy5jZ2k/aWQ9MTE5MjQ0CisKKyAgICAgICAgUmV2aWV3ZWQgYnkgTk9C T0RZIChPT1BTISkuCisKKyAgICAgICAgQWRkZWQgbWlzc2luZyBjb25zdCBtb2RpZmllciB0byBm aW5kRmlyc3RCYWRHcmFtbWFyIChhbmQgZmluZEZpcnN0R3JhbW1hckRldGFpbAorICAgICAgICBy ZXNwZWN0aXZlbHkpIHRvIGNhbGwgaXQgaW4gJ2lzVW5ncmFtbWF0aWNhbCgpIGNvbnN0JyB3aXRo b3V0IGNvbnN0IGNhc3RpbmcuCisKKyAgICAgICAgTm8gbmV3IHRlc3RzLCBubyBiZWhhdmlvciBj aGFuZ2UuCisKKyAgICAgICAgKiBlZGl0aW5nL1RleHRDaGVja2luZ0hlbHBlci5jcHA6CisgICAg ICAgIChXZWJDb3JlOjpUZXh0Q2hlY2tpbmdIZWxwZXI6OmZpbmRGaXJzdEdyYW1tYXJEZXRhaWwp OgorICAgICAgICAoV2ViQ29yZTo6VGV4dENoZWNraW5nSGVscGVyOjpmaW5kRmlyc3RCYWRHcmFt bWFyKToKKyAgICAgICAgQWRkZWQgY29uc3QuCisKKyAgICAgICAgKFdlYkNvcmU6OlRleHRDaGVj a2luZ0hlbHBlcjo6aXNVbmdyYW1tYXRpY2FsKToKKyAgICAgICAgKFdlYkNvcmU6OlRleHRDaGVj a2luZ0hlbHBlcjo6aXNVbmdyYW1tYXRpY2FsKToKKyAgICAgICAgTm93IGNvbnN0X2Nhc3QgY2Fu IGJlIHJlbW92ZWQuCisKKyAgICAgICAgKiBlZGl0aW5nL1RleHRDaGVja2luZ0hlbHBlci5oOgor CiAyMDEzLTA3LTI5ICBDYXJsb3MgR2FyY2lhIENhbXBvcyAgPGNnYXJjaWFAaWdhbGlhLmNvbT4K IAogICAgICAgICBVbnJldmlld2VkLiBGaXggbWFrZSBkaXN0Y2hlY2suCmRpZmYgLS1naXQgYS9T b3VyY2UvV2ViQ29yZS9lZGl0aW5nL1RleHRDaGVja2luZ0hlbHBlci5jcHAgYi9Tb3VyY2UvV2Vi Q29yZS9lZGl0aW5nL1RleHRDaGVja2luZ0hlbHBlci5jcHAKaW5kZXggMjdjNDQyYy4uNmNhMDVk YSAxMDA2NDQKLS0tIGEvU291cmNlL1dlYkNvcmUvZWRpdGluZy9UZXh0Q2hlY2tpbmdIZWxwZXIu Y3BwCisrKyBiL1NvdXJjZS9XZWJDb3JlL2VkaXRpbmcvVGV4dENoZWNraW5nSGVscGVyLmNwcApA QCAtNDE1LDcgKzQxNSw3IEBAIFN0cmluZyBUZXh0Q2hlY2tpbmdIZWxwZXI6OmZpbmRGaXJzdE1p c3NwZWxsaW5nT3JCYWRHcmFtbWFyKGJvb2wgY2hlY2tHcmFtbWFyLCBiCiB9CiAKICNpZiBVU0Uo R1JBTU1BUl9DSEVDS0lORykKLWludCBUZXh0Q2hlY2tpbmdIZWxwZXI6OmZpbmRGaXJzdEdyYW1t YXJEZXRhaWwoY29uc3QgVmVjdG9yPEdyYW1tYXJEZXRhaWw+JiBncmFtbWFyRGV0YWlscywgaW50 IGJhZEdyYW1tYXJQaHJhc2VMb2NhdGlvbiwgaW50IC8qYmFkR3JhbW1hclBocmFzZUxlbmd0aCov LCBpbnQgc3RhcnRPZmZzZXQsIGludCBlbmRPZmZzZXQsIGJvb2wgbWFya0FsbCkKK2ludCBUZXh0 Q2hlY2tpbmdIZWxwZXI6OmZpbmRGaXJzdEdyYW1tYXJEZXRhaWwoY29uc3QgVmVjdG9yPEdyYW1t YXJEZXRhaWw+JiBncmFtbWFyRGV0YWlscywgaW50IGJhZEdyYW1tYXJQaHJhc2VMb2NhdGlvbiwg aW50IC8qYmFkR3JhbW1hclBocmFzZUxlbmd0aCovLCBpbnQgc3RhcnRPZmZzZXQsIGludCBlbmRP ZmZzZXQsIGJvb2wgbWFya0FsbCkgY29uc3QKIHsKICAgICAvLyBGb3VuZCBzb21lIGJhZCBncmFt bWFyLiBGaW5kIHRoZSBlYXJsaWVzdCBkZXRhaWwgcmFuZ2UgdGhhdCBzdGFydHMgaW4gb3VyIHNl YXJjaCByYW5nZSAoaWYgYW55KS4KICAgICAvLyBPcHRpb25hbGx5IGFkZCBhIERvY3VtZW50TWFy a2VyIGZvciBlYWNoIGRldGFpbCBpbiB0aGUgcmFuZ2UuCkBAIC00NTAsNyArNDUwLDcgQEAgaW50 IFRleHRDaGVja2luZ0hlbHBlcjo6ZmluZEZpcnN0R3JhbW1hckRldGFpbChjb25zdCBWZWN0b3I8 R3JhbW1hckRldGFpbD4mIGdyYW0KICAgICByZXR1cm4gZWFybGllc3REZXRhaWxJbmRleDsKIH0K IAotU3RyaW5nIFRleHRDaGVja2luZ0hlbHBlcjo6ZmluZEZpcnN0QmFkR3JhbW1hcihHcmFtbWFy RGV0YWlsJiBvdXRHcmFtbWFyRGV0YWlsLCBpbnQmIG91dEdyYW1tYXJQaHJhc2VPZmZzZXQsIGJv b2wgbWFya0FsbCkKK1N0cmluZyBUZXh0Q2hlY2tpbmdIZWxwZXI6OmZpbmRGaXJzdEJhZEdyYW1t YXIoR3JhbW1hckRldGFpbCYgb3V0R3JhbW1hckRldGFpbCwgaW50JiBvdXRHcmFtbWFyUGhyYXNl T2Zmc2V0LCBib29sIG1hcmtBbGwpIGNvbnN0CiB7CiAgICAgLy8gSW5pdGlhbGl6ZSBvdXQgcGFy YW1ldGVyczsgdGhlc2Ugd2lsbCBiZSB1cGRhdGVkIGlmIHdlIGZpbmQgc29tZXRoaW5nIHRvIHJl dHVybi4KICAgICBvdXRHcmFtbWFyRGV0YWlsLmxvY2F0aW9uID0gLTE7CkBAIC01MjUsNyArNTI1 LDcgQEAgYm9vbCBUZXh0Q2hlY2tpbmdIZWxwZXI6OmlzVW5ncmFtbWF0aWNhbChWZWN0b3I8U3Ry aW5nPiYgZ3Vlc3Nlc1ZlY3RvcikgY29uc3QKICAgICBpbnQgZ3JhbW1hclBocmFzZU9mZnNldDsK ICAgICAKICAgICBHcmFtbWFyRGV0YWlsIGdyYW1tYXJEZXRhaWw7Ci0gICAgU3RyaW5nIGJhZEdy YW1tYXJQaHJhc2UgPSBjb25zdF9jYXN0PFRleHRDaGVja2luZ0hlbHBlcio+KHRoaXMpLT5maW5k Rmlyc3RCYWRHcmFtbWFyKGdyYW1tYXJEZXRhaWwsIGdyYW1tYXJQaHJhc2VPZmZzZXQsIGZhbHNl KTsgICAgCisgICAgU3RyaW5nIGJhZEdyYW1tYXJQaHJhc2UgPSBmaW5kRmlyc3RCYWRHcmFtbWFy KGdyYW1tYXJEZXRhaWwsIGdyYW1tYXJQaHJhc2VPZmZzZXQsIGZhbHNlKTsKICAgICAKICAgICAv LyBObyBiYWQgZ3JhbW1hciBpbiB0aGVzZSBwYXJ0cyBhdCBhbGwuCiAgICAgaWYgKGJhZEdyYW1t YXJQaHJhc2UuaXNFbXB0eSgpKQpkaWZmIC0tZ2l0IGEvU291cmNlL1dlYkNvcmUvZWRpdGluZy9U ZXh0Q2hlY2tpbmdIZWxwZXIuaCBiL1NvdXJjZS9XZWJDb3JlL2VkaXRpbmcvVGV4dENoZWNraW5n SGVscGVyLmgKaW5kZXggNDcxYzFiNy4uOGYwMzU2OCAxMDA2NDQKLS0tIGEvU291cmNlL1dlYkNv cmUvZWRpdGluZy9UZXh0Q2hlY2tpbmdIZWxwZXIuaAorKysgYi9Tb3VyY2UvV2ViQ29yZS9lZGl0 aW5nL1RleHRDaGVja2luZ0hlbHBlci5oCkBAIC04Nyw4ICs4Nyw4IEBAIHB1YmxpYzoKICAgICBT dHJpbmcgZmluZEZpcnN0TWlzc3BlbGxpbmdPckJhZEdyYW1tYXIoYm9vbCBjaGVja0dyYW1tYXIs IGJvb2wmIG91dElzU3BlbGxpbmcsIGludCYgb3V0Rmlyc3RGb3VuZE9mZnNldCwgR3JhbW1hckRl dGFpbCYgb3V0R3JhbW1hckRldGFpbCk7CiAgICAgdm9pZCBtYXJrQWxsTWlzc3BlbGxpbmdzKFJl ZlB0cjxSYW5nZT4mIGZpcnN0TWlzc3BlbGxpbmdSYW5nZSk7CiAjaWYgVVNFKEdSQU1NQVJfQ0hF Q0tJTkcpCi0gICAgU3RyaW5nIGZpbmRGaXJzdEJhZEdyYW1tYXIoR3JhbW1hckRldGFpbCYgb3V0 R3JhbW1hckRldGFpbCwgaW50JiBvdXRHcmFtbWFyUGhyYXNlT2Zmc2V0LCBib29sIG1hcmtBbGwp OwotICAgIGludCBmaW5kRmlyc3RHcmFtbWFyRGV0YWlsKGNvbnN0IFZlY3RvcjxHcmFtbWFyRGV0 YWlsPiYgZ3JhbW1hckRldGFpbHMsIGludCBiYWRHcmFtbWFyUGhyYXNlTG9jYXRpb24sIGludCBi YWRHcmFtbWFyUGhyYXNlTGVuZ3RoLCBpbnQgc3RhcnRPZmZzZXQsIGludCBlbmRPZmZzZXQsIGJv b2wgbWFya0FsbCk7CisgICAgU3RyaW5nIGZpbmRGaXJzdEJhZEdyYW1tYXIoR3JhbW1hckRldGFp bCYgb3V0R3JhbW1hckRldGFpbCwgaW50JiBvdXRHcmFtbWFyUGhyYXNlT2Zmc2V0LCBib29sIG1h cmtBbGwpIGNvbnN0OworICAgIGludCBmaW5kRmlyc3RHcmFtbWFyRGV0YWlsKGNvbnN0IFZlY3Rv cjxHcmFtbWFyRGV0YWlsPiYgZ3JhbW1hckRldGFpbHMsIGludCBiYWRHcmFtbWFyUGhyYXNlTG9j YXRpb24sIGludCBiYWRHcmFtbWFyUGhyYXNlTGVuZ3RoLCBpbnQgc3RhcnRPZmZzZXQsIGludCBl bmRPZmZzZXQsIGJvb2wgbWFya0FsbCkgY29uc3Q7CiAgICAgdm9pZCBtYXJrQWxsQmFkR3JhbW1h cigpOwogICAgIGJvb2wgaXNVbmdyYW1tYXRpY2FsKFZlY3RvcjxTdHJpbmc+JiBndWVzc2VzVmVj dG9yKSBjb25zdDsKICNlbmRpZgo=