119240 2013-07-30 02:15:14 -0700 [EFL] REGRESSION after r153439: layout tests do not run. 2013-07-31 04:35:02 -0700 1 1 1 Unclassified WebKit WebKit EFL 528+ (Nightly build) Unspecified Unspecified RESOLVED FIXED P2 Normal --- 0 k.czech webkit-unassigned cdumez commit-queue dpranke glenn lucas.de.marchi rakuco zan oldest_to_newest 912715 0 k.czech 2013-07-30 02:15:14 -0700 Changed attribute name from check_xvfb to check_driver 912717 1 207702 k.czech 2013-07-30 02:15:57 -0700 Created attachment 207702 Patch 912719 2 commit-queue 2013-07-30 02:18:07 -0700 Attachment 207702 did not pass style-queue: Failed to run "['Tools/Scripts/check-webkit-style', '--diff-files', u'Tools/ChangeLog', u'Tools/Scripts/webkitpy/port/efl.py']" exit_code: 1 Tools/ChangeLog:1: ChangeLog entry has no bug number [changelog/bugnumber] [5] Total errors found: 1 in 2 files If any of these errors are false positives, please file a bug against check-webkit-style. 912720 3 207704 k.czech 2013-07-30 02:22:01 -0700 Created attachment 207704 Patch 912735 4 207704 cdumez 2013-07-30 03:09:23 -0700 Comment on attachment 207704 Patch View in context: https://bugs.webkit.org/attachment.cgi?id=207704&action=review > Tools/Scripts/webkitpy/port/efl.py:136 > + return super(EflPort, self).check_sys_deps(needs_http) and XvfbDriver.check_driver(self) Please use self._driver_class().check_driver(self) for consistency with gtk. 912736 5 207708 k.czech 2013-07-30 03:16:52 -0700 Created attachment 207708 Patch 912738 6 207708 cdumez 2013-07-30 03:18:15 -0700 Comment on attachment 207708 Patch Ok, r=me. 912824 7 207708 cdumez 2013-07-30 06:50:38 -0700 Comment on attachment 207708 Patch Clearing flags on attachment: 207708 Committed r153470: <http://trac.webkit.org/changeset/153470> 912825 8 cdumez 2013-07-30 06:50:59 -0700 All reviewed patches have been landed. Closing bug. 913287 9 zan 2013-07-31 04:30:07 -0700 I apologize for the breakage. Immensely stupid on my side not to think of other ports that were affected by the XvfbDriver change. 913292 10 cdumez 2013-07-31 04:35:02 -0700 (In reply to comment #9) > I apologize for the breakage. Immensely stupid on my side not to think of other ports that were affected by the XvfbDriver change. Yes, it was a bit surprising, especially without warning. But no worries, we understand such things happen inadvertently. 207702 2013-07-30 02:15:57 -0700 2013-07-30 02:22:01 -0700 Patch xvfb.patch text/plain 1114 k.czech ZGlmZiAtLWdpdCBhL1Rvb2xzL0NoYW5nZUxvZyBiL1Rvb2xzL0NoYW5nZUxvZwppbmRleCBmOTgx YTMwLi4wMGFlMTI1IDEwMDY0NAotLS0gYS9Ub29scy9DaGFuZ2VMb2cKKysrIGIvVG9vbHMvQ2hh bmdlTG9nCkBAIC0xLDMgKzEsMTUgQEAKKzIwMTMtMDctMzAgIEtyenlzenRvZiBDemVjaCAgPGsu Y3plY2hAc2Ftc3VuZy5jb20+CisKKyAgICAgICAgW0VGTF0gUkVHUkVTU0lPTiBhZnRlciByMTUz NDM5OiBsYXlvdXQgdGVzdHMgZG8gbm90IHJ1bi4KKyAgICAgICAgTmVlZCB0aGUgYnVnIFVSTCAo T09QUyEpLgorCisgICAgICAgIFJldmlld2VkIGJ5IE5PQk9EWSAoT09QUyEpLgorCisgICAgICAg IENoYW5nZWQgYXR0cmlidXRlIG5hbWUgZnJvbSBjaGVja194dmZiIHRvIGNoZWNrX2RyaXZlci4K KworICAgICAgICAqIFNjcmlwdHMvd2Via2l0cHkvcG9ydC9lZmwucHk6CisgICAgICAgIChFZmxQ b3J0LmNoZWNrX3N5c19kZXBzKToKKwogMjAxMy0wNy0yOSAgQ29tbWl0IFF1ZXVlICA8Y29tbWl0 LXF1ZXVlQHdlYmtpdC5vcmc+CiAKICAgICAgICAgVW5yZXZpZXdlZCwgcm9sbGluZyBvdXQgcjE1 Mjg2MC4KZGlmZiAtLWdpdCBhL1Rvb2xzL1NjcmlwdHMvd2Via2l0cHkvcG9ydC9lZmwucHkgYi9U b29scy9TY3JpcHRzL3dlYmtpdHB5L3BvcnQvZWZsLnB5CmluZGV4IDAxYzY2ZWIuLjExZjMxODQg MTAwNjQ0Ci0tLSBhL1Rvb2xzL1NjcmlwdHMvd2Via2l0cHkvcG9ydC9lZmwucHkKKysrIGIvVG9v bHMvU2NyaXB0cy93ZWJraXRweS9wb3J0L2VmbC5weQpAQCAtMTMzLDQgKzEzMyw0IEBAIGNsYXNz IEVmbFBvcnQoUG9ydCk6CiAgICAgICAgIHNlbGYuX3J1bl9zY3JpcHQoInJ1bi1sYXVuY2hlciIs IHJ1bl9sYXVuY2hlcl9hcmdzKQogCiAgICAgZGVmIGNoZWNrX3N5c19kZXBzKHNlbGYsIG5lZWRz X2h0dHApOgotICAgICAgICByZXR1cm4gc3VwZXIoRWZsUG9ydCwgc2VsZikuY2hlY2tfc3lzX2Rl cHMobmVlZHNfaHR0cCkgYW5kIFh2ZmJEcml2ZXIuY2hlY2tfeHZmYihzZWxmKQorICAgICAgICBy ZXR1cm4gc3VwZXIoRWZsUG9ydCwgc2VsZikuY2hlY2tfc3lzX2RlcHMobmVlZHNfaHR0cCkgYW5k IFh2ZmJEcml2ZXIuY2hlY2tfZHJpdmVyKHNlbGYpCg== 207704 2013-07-30 02:22:01 -0700 2013-07-30 03:16:52 -0700 Patch xvfb.patch text/plain 1135 k.czech ZGlmZiAtLWdpdCBhL1Rvb2xzL0NoYW5nZUxvZyBiL1Rvb2xzL0NoYW5nZUxvZwppbmRleCBmOTgx YTMwLi5mMTZmY2M3IDEwMDY0NAotLS0gYS9Ub29scy9DaGFuZ2VMb2cKKysrIGIvVG9vbHMvQ2hh bmdlTG9nCkBAIC0xLDMgKzEsMTUgQEAKKzIwMTMtMDctMzAgIEtyenlzenRvZiBDemVjaCAgPGsu Y3plY2hAc2Ftc3VuZy5jb20+CisKKyAgICAgICAgW0VGTF0gUkVHUkVTU0lPTiBhZnRlciByMTUz NDM5OiBsYXlvdXQgdGVzdHMgZG8gbm90IHJ1bi4KKyAgICAgICAgaHR0cHM6Ly9idWdzLndlYmtp dC5vcmcvc2hvd19idWcuY2dpP2lkPTExOTI0MAorCisgICAgICAgIFJldmlld2VkIGJ5IE5PQk9E WSAoT09QUyEpLgorCisgICAgICAgIENoYW5nZWQgYXR0cmlidXRlIG5hbWUgZnJvbSBjaGVja194 dmZiIHRvIGNoZWNrX2RyaXZlci4KKworICAgICAgICAqIFNjcmlwdHMvd2Via2l0cHkvcG9ydC9l ZmwucHk6CisgICAgICAgIChFZmxQb3J0LmNoZWNrX3N5c19kZXBzKToKKwogMjAxMy0wNy0yOSAg Q29tbWl0IFF1ZXVlICA8Y29tbWl0LXF1ZXVlQHdlYmtpdC5vcmc+CiAKICAgICAgICAgVW5yZXZp ZXdlZCwgcm9sbGluZyBvdXQgcjE1Mjg2MC4KZGlmZiAtLWdpdCBhL1Rvb2xzL1NjcmlwdHMvd2Vi a2l0cHkvcG9ydC9lZmwucHkgYi9Ub29scy9TY3JpcHRzL3dlYmtpdHB5L3BvcnQvZWZsLnB5Cmlu ZGV4IDAxYzY2ZWIuLjExZjMxODQgMTAwNjQ0Ci0tLSBhL1Rvb2xzL1NjcmlwdHMvd2Via2l0cHkv cG9ydC9lZmwucHkKKysrIGIvVG9vbHMvU2NyaXB0cy93ZWJraXRweS9wb3J0L2VmbC5weQpAQCAt MTMzLDQgKzEzMyw0IEBAIGNsYXNzIEVmbFBvcnQoUG9ydCk6CiAgICAgICAgIHNlbGYuX3J1bl9z Y3JpcHQoInJ1bi1sYXVuY2hlciIsIHJ1bl9sYXVuY2hlcl9hcmdzKQogCiAgICAgZGVmIGNoZWNr X3N5c19kZXBzKHNlbGYsIG5lZWRzX2h0dHApOgotICAgICAgICByZXR1cm4gc3VwZXIoRWZsUG9y dCwgc2VsZikuY2hlY2tfc3lzX2RlcHMobmVlZHNfaHR0cCkgYW5kIFh2ZmJEcml2ZXIuY2hlY2tf eHZmYihzZWxmKQorICAgICAgICByZXR1cm4gc3VwZXIoRWZsUG9ydCwgc2VsZikuY2hlY2tfc3lz X2RlcHMobmVlZHNfaHR0cCkgYW5kIFh2ZmJEcml2ZXIuY2hlY2tfZHJpdmVyKHNlbGYpCg== 207708 2013-07-30 03:16:52 -0700 2013-07-30 06:50:37 -0700 Patch xvfb.patch text/plain 1145 k.czech ZGlmZiAtLWdpdCBhL1Rvb2xzL0NoYW5nZUxvZyBiL1Rvb2xzL0NoYW5nZUxvZwppbmRleCBmOTgx YTMwLi5mMTZmY2M3IDEwMDY0NAotLS0gYS9Ub29scy9DaGFuZ2VMb2cKKysrIGIvVG9vbHMvQ2hh bmdlTG9nCkBAIC0xLDMgKzEsMTUgQEAKKzIwMTMtMDctMzAgIEtyenlzenRvZiBDemVjaCAgPGsu Y3plY2hAc2Ftc3VuZy5jb20+CisKKyAgICAgICAgW0VGTF0gUkVHUkVTU0lPTiBhZnRlciByMTUz NDM5OiBsYXlvdXQgdGVzdHMgZG8gbm90IHJ1bi4KKyAgICAgICAgaHR0cHM6Ly9idWdzLndlYmtp dC5vcmcvc2hvd19idWcuY2dpP2lkPTExOTI0MAorCisgICAgICAgIFJldmlld2VkIGJ5IE5PQk9E WSAoT09QUyEpLgorCisgICAgICAgIENoYW5nZWQgYXR0cmlidXRlIG5hbWUgZnJvbSBjaGVja194 dmZiIHRvIGNoZWNrX2RyaXZlci4KKworICAgICAgICAqIFNjcmlwdHMvd2Via2l0cHkvcG9ydC9l ZmwucHk6CisgICAgICAgIChFZmxQb3J0LmNoZWNrX3N5c19kZXBzKToKKwogMjAxMy0wNy0yOSAg Q29tbWl0IFF1ZXVlICA8Y29tbWl0LXF1ZXVlQHdlYmtpdC5vcmc+CiAKICAgICAgICAgVW5yZXZp ZXdlZCwgcm9sbGluZyBvdXQgcjE1Mjg2MC4KZGlmZiAtLWdpdCBhL1Rvb2xzL1NjcmlwdHMvd2Vi a2l0cHkvcG9ydC9lZmwucHkgYi9Ub29scy9TY3JpcHRzL3dlYmtpdHB5L3BvcnQvZWZsLnB5Cmlu ZGV4IDAxYzY2ZWIuLjI3ZDk3YTIgMTAwNjQ0Ci0tLSBhL1Rvb2xzL1NjcmlwdHMvd2Via2l0cHkv cG9ydC9lZmwucHkKKysrIGIvVG9vbHMvU2NyaXB0cy93ZWJraXRweS9wb3J0L2VmbC5weQpAQCAt MTMzLDQgKzEzMyw0IEBAIGNsYXNzIEVmbFBvcnQoUG9ydCk6CiAgICAgICAgIHNlbGYuX3J1bl9z Y3JpcHQoInJ1bi1sYXVuY2hlciIsIHJ1bl9sYXVuY2hlcl9hcmdzKQogCiAgICAgZGVmIGNoZWNr X3N5c19kZXBzKHNlbGYsIG5lZWRzX2h0dHApOgotICAgICAgICByZXR1cm4gc3VwZXIoRWZsUG9y dCwgc2VsZikuY2hlY2tfc3lzX2RlcHMobmVlZHNfaHR0cCkgYW5kIFh2ZmJEcml2ZXIuY2hlY2tf eHZmYihzZWxmKQorICAgICAgICByZXR1cm4gc3VwZXIoRWZsUG9ydCwgc2VsZikuY2hlY2tfc3lz X2RlcHMobmVlZHNfaHR0cCkgYW5kIHNlbGYuX2RyaXZlcl9jbGFzcygpLmNoZWNrX2RyaXZlcihz ZWxmKQo=