119228 2013-07-29 15:55:18 -0700 TextTrackRepresentation captions often disappear then appear again. 2013-07-31 20:22:29 -0700 1 1 1 Unclassified WebKit New Bugs 528+ (Nightly build) Unspecified Unspecified RESOLVED FIXED P2 Normal --- 1 jer.noble jer.noble commit-queue eric.carlson esprehn+autocc glenn simon.fraser oldest_to_newest 912617 0 jer.noble 2013-07-29 15:55:18 -0700 TextTrackRepresentation captions often disappear then appear again. 912618 1 jer.noble 2013-07-29 15:55:47 -0700 <rdar://problem/14550924> 912622 2 207677 jer.noble 2013-07-29 16:12:46 -0700 Created attachment 207677 Patch 912624 3 commit-queue 2013-07-29 16:15:48 -0700 Attachment 207677 did not pass style-queue: Failed to run "['Tools/Scripts/check-webkit-style', '--diff-files', u'Source/WebCore/ChangeLog', u'Source/WebCore/html/HTMLMediaElement.cpp', u'Source/WebCore/html/HTMLMediaElement.h']" exit_code: 1 Source/WebCore/html/HTMLMediaElement.h:295: The parameter name "flags" adds no information, so it should be removed. [readability/parameter_name] [5] Total errors found: 1 in 3 files If any of these errors are false positives, please file a bug against check-webkit-style. 912625 4 207677 simon.fraser 2013-07-29 16:16:25 -0700 Comment on attachment 207677 Patch View in context: https://bugs.webkit.org/attachment.cgi?id=207677&action=review > Source/WebCore/html/HTMLMediaElement.h:294 > + enum ConfigureTextTrackDisplayFlags { DoNotAssumeVisibleTextTracksChanged, AssumeVisibleTextTracksChanged }; "Flags" make me think this is a bitmask, and then the "flags == DoNotAssumeVisibleTextTracksChanged" code seemed iffy. Not sure I like "AssumeVisibleTextTracksChanged" etc; can you change the name to something more descriptive of the impact? 912636 5 jer.noble 2013-07-29 17:14:28 -0700 Committed r153448: <http://trac.webkit.org/changeset/153448> 913621 6 simon.fraser 2013-07-31 20:22:29 -0700 This broke the media/video-controls-captions-trackmenu.html test 207677 2013-07-29 16:12:46 -0700 2013-07-29 16:16:25 -0700 Patch bug-119228-20130729161245.patch text/plain 4351 jer.noble U3VidmVyc2lvbiBSZXZpc2lvbjogMTUyOTcwCmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViQ29yZS9D aGFuZ2VMb2cgYi9Tb3VyY2UvV2ViQ29yZS9DaGFuZ2VMb2cKaW5kZXggNjY1MjE2MDM4MGFlNzkw NzU5NmE5YmUwZTVlN2JkNThmNWFiYzFhMC4uYWE2MDc5MjQ1OWVkMmI4MTI2MTgxNjljZDU4OTIx Njg0NzQ1MGI5ZiAxMDA2NDQKLS0tIGEvU291cmNlL1dlYkNvcmUvQ2hhbmdlTG9nCisrKyBiL1Nv dXJjZS9XZWJDb3JlL0NoYW5nZUxvZwpAQCAtMSwzICsxLDI0IEBACisyMDEzLTA3LTI5ICBKZXIg Tm9ibGUgIDxqZXIubm9ibGVAYXBwbGUuY29tPgorCisgICAgICAgIFRleHRUcmFja1JlcHJlc2Vu dGF0aW9uIGNhcHRpb25zIG9mdGVuIGRpc2FwcGVhciB0aGVuIGFwcGVhciBhZ2Fpbi4KKyAgICAg ICAgaHR0cHM6Ly9idWdzLndlYmtpdC5vcmcvc2hvd19idWcuY2dpP2lkPTExOTIyOAorCisgICAg ICAgIFJldmlld2VkIGJ5IE5PQk9EWSAoT09QUyEpLgorCisgICAgICAgIENhbGxpbmcgdXBkYXRl VGV4dFRyYWNrRGlzcGxheSgpIHdpbGwgY2F1c2UgdGhlIGVudGlyZSBET00gc3VidHJlZSBjb250 YWluaW5nIHRoZSBhY3RpdmUgY3VlcworICAgICAgICB0byBiZSB0b3JuIGRvd24gYW5kIHJlYnVp bHQuIE9ubHkgY2FsbCBpbnRvIHRoaXMgbWV0aG9kIHdoZW4gdGV4dCB0cmFja3MgaGF2ZSBhY3R1 YWxseSBjaGFuZ2VkLgorCisgICAgICAgIEFkZCBhbiBlbnVtIHBhcmFtZXRlciB0byBjb25maWd1 cmVUZXh0VHJhY2tEaXNwbGF5KCkgd2hpY2ggYWxsb3dzIHRoZSBjYWxsZXIgdG8gc3BlY2lmeSB0 aGF0CisgICAgICAgIG1ldGhvZCBzaG91bGQgYXNzdW1lIHRoYXQgdGhlIGxpc3Qgb2YgdmlzaWJs ZSB0ZXh0IHRyYWNrcyBoYXMgY2hhbmdlZCwgZm9yY2luZyBhIGNhbGwgdG8KKyAgICAgICAgdXBk YXRlVGV4dFRyYWNrRGlzcGxheSgpLgorCisgICAgICAgICogaHRtbC9IVE1MTWVkaWFFbGVtZW50 LmNwcDoKKyAgICAgICAgKFdlYkNvcmU6OkhUTUxNZWRpYUVsZW1lbnQ6OnVwZGF0ZUFjdGl2ZVRl eHRUcmFja0N1ZXMpOiBSZW1vdmUgdGhlIHVubmVjZXNzYXJ5IGNhbGwgdG8gdXBkYXRlVGV4dFRy YWNrRGlzcGxheSgpLgorICAgICAgICAoV2ViQ29yZTo6SFRNTE1lZGlhRWxlbWVudDo6dGV4dFRy YWNrTW9kZUNoYW5nZWQpOiBQYXNzIEFzc3VtZVZpc2libGVUZXh0VHJhY2tzQ2hhbmdlZCB0byBj b25maWd1cmVUZXh0VHJhY2tEaXNwbGF5KCkuCisgICAgICAgIChXZWJDb3JlOjpIVE1MTWVkaWFF bGVtZW50Ojpjb25maWd1cmVUZXh0VHJhY2tEaXNwbGF5KTogQ2hlY2sgdGhlIHBhc3NlZCBmbGFn cyBhbmQgZXhpdCBlYXJseSBvbmx5IGlmCisgICAgICAgICAgICBBc3N1bWVWaXNpYmxlVGV4dFRy YWNrc0NoYW5nZWQgaXMgbm90IHNldC4KKyAgICAgICAgKiBodG1sL0hUTUxNZWRpYUVsZW1lbnQu aDoKKwogMjAxMy0wNy0yMiAgRXJpYyBDYXJsc29uICA8ZXJpYy5jYXJsc29uQGFwcGxlLmNvbT4K IAogICAgICAgICBbaU9TXSBjYXB0aW9ucyBzb21ldGltZXMgcG9zaXRpb25lZCBpbmNvcnJlY3Rs eSBhZnRlciBmdWxsc2NyZWVuIHN0YXRlIGNoYW5nZQpkaWZmIC0tZ2l0IGEvU291cmNlL1dlYkNv cmUvaHRtbC9IVE1MTWVkaWFFbGVtZW50LmNwcCBiL1NvdXJjZS9XZWJDb3JlL2h0bWwvSFRNTE1l ZGlhRWxlbWVudC5jcHAKaW5kZXggNmQyYzE3ZDY1NmI3ZDliMmU4MGI2NmUwYTA2NTE3ZTlhNzQ5 OGUzNS4uMzA4NjFmM2E0NDMwY2Q3OTE3M2U2NGZlZmMxMzllN2RhNjVmOWY3ZCAxMDA2NDQKLS0t IGEvU291cmNlL1dlYkNvcmUvaHRtbC9IVE1MTWVkaWFFbGVtZW50LmNwcAorKysgYi9Tb3VyY2Uv V2ViQ29yZS9odG1sL0hUTUxNZWRpYUVsZW1lbnQuY3BwCkBAIC0xMjQyLDE2ICsxMjQyLDggQEAg dm9pZCBIVE1MTWVkaWFFbGVtZW50Ojp1cGRhdGVBY3RpdmVUZXh0VHJhY2tDdWVzKGRvdWJsZSBt b3ZpZVRpbWUpCiAgICAgICAgICAgICBhY3RpdmVTZXRDaGFuZ2VkID0gdHJ1ZTsKICAgICB9CiAK LSAgICBpZiAoIWFjdGl2ZVNldENoYW5nZWQpIHsKLSAgICAgICAgLy8gRXZlbiB0aG91Z2ggdGhl IGFjdGl2ZSBzZXQgaGFzIG5vdCBjaGFuZ2VkLCBpdCBpcyBwb3NzaWJsZSB0aGF0IHRoZQotICAg ICAgICAvLyB0aGUgbW9kZSBvZiBhIHRyYWNrIGhhcyBjaGFuZ2VkIGZyb20gJ2hpZGRlbicgdG8g J3Nob3dpbmcnIGFuZCB0aGUKLSAgICAgICAgLy8gY3VlcyBoYXZlIG5vdCB5ZXQgYmVlbiByZW5k ZXJlZC4KLSAgICAgICAgLy8gTm90ZTogZG9uJ3QgY2FsbCB1cGRhdGVUZXh0VHJhY2tEaXNwbGF5 KCkgdW5sZXNzIHdlIGhhdmUgY29udHJvbHMgYmVjYXVzZSBpdCB3aWxsCi0gICAgICAgIC8vIGNy ZWF0ZSB0aGVtLgotICAgICAgICBpZiAoaGFzTWVkaWFDb250cm9scygpKQotICAgICAgICAgICAg dXBkYXRlVGV4dFRyYWNrRGlzcGxheSgpOworICAgIGlmICghYWN0aXZlU2V0Q2hhbmdlZCkKICAg ICAgICAgcmV0dXJuOwotICAgIH0KIAogICAgIC8vIDcgLSBJZiB0aGUgdGltZSB3YXMgcmVhY2hl ZCB0aHJvdWdoIHRoZSB1c3VhbCBtb25vdG9uaWMgaW5jcmVhc2Ugb2YgdGhlCiAgICAgLy8gY3Vy cmVudCBwbGF5YmFjayBwb3NpdGlvbiBkdXJpbmcgbm9ybWFsIHBsYXliYWNrLCBhbmQgdGhlcmUg YXJlIGN1ZXMgaW4KQEAgLTE0NTksOCArMTQ1MSw3IEBAIHZvaWQgSFRNTE1lZGlhRWxlbWVudDo6 dGV4dFRyYWNrTW9kZUNoYW5nZWQoVGV4dFRyYWNrKiB0cmFjaykKICAgICAgICAgcGxhdGZvcm1U ZXh0VHJhY2tNZW51KCktPnRyYWNrV2FzU2VsZWN0ZWQodHJhY2stPnBsYXRmb3JtVGV4dFRyYWNr KCkpOwogI2VuZGlmCiAgICAgCi0gICAgY29uZmlndXJlVGV4dFRyYWNrRGlzcGxheSgpOwotICAg IHVwZGF0ZUFjdGl2ZVRleHRUcmFja0N1ZXMoY3VycmVudFRpbWUoKSk7CisgICAgY29uZmlndXJl VGV4dFRyYWNrRGlzcGxheShBc3N1bWVWaXNpYmxlVGV4dFRyYWNrc0NoYW5nZWQpOwogfQogCiB2 b2lkIEhUTUxNZWRpYUVsZW1lbnQ6OnZpZGVvVHJhY2tTZWxlY3RlZENoYW5nZWQoVmlkZW9UcmFj ayopCkBAIC00Njg5LDcgKzQ2ODAsNyBAQCB2b2lkIEhUTUxNZWRpYUVsZW1lbnQ6OmNvbmZpZ3Vy ZU1lZGlhQ29udHJvbHMoKQogfQogCiAjaWYgRU5BQkxFKFZJREVPX1RSQUNLKQotdm9pZCBIVE1M TWVkaWFFbGVtZW50Ojpjb25maWd1cmVUZXh0VHJhY2tEaXNwbGF5KCkKK3ZvaWQgSFRNTE1lZGlh RWxlbWVudDo6Y29uZmlndXJlVGV4dFRyYWNrRGlzcGxheShDb25maWd1cmVUZXh0VHJhY2tEaXNw bGF5RmxhZ3MgZmxhZ3MpCiB7CiAgICAgQVNTRVJUKG1fdGV4dFRyYWNrcyk7CiAKQEAgLTQ3MDYs NyArNDY5Nyw3IEBAIHZvaWQgSFRNTE1lZGlhRWxlbWVudDo6Y29uZmlndXJlVGV4dFRyYWNrRGlz cGxheSgpCiAgICAgICAgIH0KICAgICB9CiAKLSAgICBpZiAobV9oYXZlVmlzaWJsZVRleHRUcmFj ayA9PSBoYXZlVmlzaWJsZVRleHRUcmFjaykgeworICAgIGlmIChmbGFncyA9PSBEb05vdEFzc3Vt ZVZpc2libGVUZXh0VHJhY2tzQ2hhbmdlZCAmJiBtX2hhdmVWaXNpYmxlVGV4dFRyYWNrID09IGhh dmVWaXNpYmxlVGV4dFRyYWNrKSB7CiAgICAgICAgIHVwZGF0ZUFjdGl2ZVRleHRUcmFja0N1ZXMo Y3VycmVudFRpbWUoKSk7CiAgICAgICAgIHJldHVybjsKICAgICB9CmRpZmYgLS1naXQgYS9Tb3Vy Y2UvV2ViQ29yZS9odG1sL0hUTUxNZWRpYUVsZW1lbnQuaCBiL1NvdXJjZS9XZWJDb3JlL2h0bWwv SFRNTE1lZGlhRWxlbWVudC5oCmluZGV4IDY2YmQ2MzhiNWQ4Y2EzZmVlNTEzMGUzNmZhZDgyYjI3 M2E4MmEzYzEuLjRiNDRlMzQ3ZjZhMmNlOTgwOTQwM2NkYmIyZGQyNzcyOTg2MjE5Y2UgMTAwNjQ0 Ci0tLSBhL1NvdXJjZS9XZWJDb3JlL2h0bWwvSFRNTE1lZGlhRWxlbWVudC5oCisrKyBiL1NvdXJj ZS9XZWJDb3JlL2h0bWwvSFRNTE1lZGlhRWxlbWVudC5oCkBAIC0yOTEsNyArMjkxLDggQEAgcHVi bGljOgogICAgIHZvaWQgc2V0U2VsZWN0ZWRUZXh0VHJhY2soVGV4dFRyYWNrKik7CiAKICAgICBi b29sIHRleHRUcmFja3NBcmVSZWFkeSgpIGNvbnN0OwotICAgIHZvaWQgY29uZmlndXJlVGV4dFRy YWNrRGlzcGxheSgpOworICAgIGVudW0gQ29uZmlndXJlVGV4dFRyYWNrRGlzcGxheUZsYWdzIHsg RG9Ob3RBc3N1bWVWaXNpYmxlVGV4dFRyYWNrc0NoYW5nZWQsIEFzc3VtZVZpc2libGVUZXh0VHJh Y2tzQ2hhbmdlZCB9OworICAgIHZvaWQgY29uZmlndXJlVGV4dFRyYWNrRGlzcGxheShDb25maWd1 cmVUZXh0VHJhY2tEaXNwbGF5RmxhZ3MgZmxhZ3MgPSBEb05vdEFzc3VtZVZpc2libGVUZXh0VHJh Y2tzQ2hhbmdlZCk7CiAgICAgdm9pZCB1cGRhdGVUZXh0VHJhY2tEaXNwbGF5KCk7CiAKICAgICAv LyBBdWRpb1RyYWNrQ2xpZW50Cg==